Add Fieldbus subsystem + support HMS Profinet card
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v11 Latest7 patches 17 repliesIn review
- v107 patches 26 repliesSuperseded
- v9 posting 2/26 patches 0 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v9 posting 1/2 | 6 patches | 2 replies | Superseded | |
| v8 | 6 patches | 15 replies | Superseded | |
| v7 | 6 patches | 9 replies | Superseded | |
| v6 | 6 patches | 0 replies | Superseded | |
| v5 | 6 patches | 13 replies | Superseded | |
| v4 | 7 patches | 13 replies | Superseded |
Changes in v11 from the cover letter
keep all staging code self-contained within the staging/ directory
Patches in v11 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | fieldbus_dev: add Fieldbus Device subsystem.drivers/ drivers/ drivers/ +6 more | +649 | 0 replies | |
| 2/7 | anybus-s: support HMS Anybus-S busdrivers/ drivers/ drivers/ +4 more | +1627 | 8 replies | |
| 3/7 | anybus-s: support the Arcx anybus controllerdrivers/ drivers/ drivers/ +1 more | +415 | 9 replies | |
| 4/7 | dt-bindings: anybus-controller: document devicetree bindingDocumentation/ | +71 | 0 replies | |
| 5/7 | dt-bindings: Add vendor prefix for arcx / ArchronixDocumentation/ | +1 | 0 replies | |
| 6/7 | fieldbus_dev: support HMS Profinet IRT industrial controllerdrivers/ drivers/ drivers/ | +245 | 0 replies | |
| 7/7 | staging: fieldbus_dev: add TODOdrivers/ | +5 | 0 replies |
Reviews trailers per patch
2 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Rob Herring | Andreas Färber |
|---|---|---|
| 1/7 | ||
| 2/7 | ||
| 3/7 | ||
| 4/7 | R-b | |
| 5/7 | R-b | R-b |
| 6/7 | ||
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v11 0/7] Add Fieldbus subsystem + support HMS Profinet card
This patch:
1. adds a Fieldbus subsystem
2. adds support for the HMS Industrial Networks AB Profinet card.
1. Fieldbus subsystem
---------------------
Fieldbus device (client) adapters allow data exchange with a PLC aka. "Fieldbus Controller" over a fieldbus (Profinet, FLNet, etc.) They are typically used when a Linux device wants to expose itself as an actuator, motor, console light, switch, etc. over the fieldbus. The framework is designed to provide a generic interface to Fieldbus Devices from both the Linux Kernel and the userspace.
2. Add support for HMS Profinet Card
------------------------------------
Profinet is an industry technical standard for data communication over Industrial Ethernet, designed for collecting data from, and controlling, equipment in industrial systems, with a particular strength in delivering data under tight time constraints (on the order of 1ms or less).
The profinet card itself is connected to the system via an industrial bus called 'anybus'.
I have followed the bus driver/client driver pattern, and created an anybus bus driver, plus a client driver for the profinet card.
In case this patch set gets (eventually) accepted, drivers for other anybus client cards may follow: flnet, cc-link, ...
The anybus slot on the host is located on an 'anybus controller', which is custom h/w designed by arcx. It exposes a dual anybus host implementation, plus a power readout unrelated to the anybus.
v11:
keep all staging code self-contained within the staging/ directory
v10:
add a TODO file on how to take this patch set out of staging fix linker errors on defconfigs without HAS_IOMEM or REGULATOR
v9:
Moved everything to staging/ so new userspace ABI can still be tweaked Suggested cross-posting to linux-netdev to widen audience Greg KH: call ida_destroy() on module exits
replace arcx anybus controller's reset spinlock with mutex
(no need for spinlock as never run in atomic context) udelay() can now be replaced with usleep_range()
harmonized email addresses across patchset
various whitespace changes to silence checkpatch.pl --strict
v8:
allow fieldbus core to be built as a module (define as tristate). use IS_ENABLED() in fieldbus_dev.h to conditionally compile dummy functions. anybuss_core.ko uses symbols from fieldbus_dev.ko. Use "top level kbuild
file" method to make this work.
See Documentation/kbuild/modules.txt, section 6.3
Confirm licence choice: GPL-v2 only. no changes.
v7:
use %zu printf formatter to display size_t
v6:
Randy Dunlap:
correctly/consistently indent Kconfig
spelling/punctuation improvements
Greg KH:
suggestion: simplify /sys/class/fieldbus_dev/fieldbus_devX/ -> /sys/class/fieldbus_dev/X/
can't simplify: create_device() also determines the name of the associated char device. simplification would result in a char device named /dev/X ?
applied above suggestion to arcx-controller driver, this works ok as it does not
have associated char device
class name left as-is (fieldbus_dev) to differentiate between
"fieldbus controller" and "fieldbus device" in the future
makefile clean-up
sysfs attributes: snprintf -> sprintf
except card_name, as it's externally provided and could potentially be > PAGE_SIZE
enabled/online sysfs attributes converted to "0/1" values
using kstrtobool()
v5:
Greg KH:
fix licence nit
consistent use of e-mail address
replaced raw sysfs attribute with kobject_uevent() call keep __ATTRIBUTE_GROUPS because we need is_visible field
Rob Herring:
controller devicetree entry now requires multiple address
regions and interrupts
controller child node(s) now mapped to child devices by
slot/host position (using devicetree reg = <>)
architectural overhaul to align closely to existing pci arch:
pci anybus
--------------------------------------------------------------------------------
Common bus code (spec), pci/pci_driver.c anybus/dev_core.c
calls bus_register() no of compatible no of compatible
--------------------------------------------------------------------------------
Device on bus, calls
XXX_client_driver_register() hwmon/k8temp.c fieldbus/hms-profinet.c
--------------------------------------------------------------------------------
Controller, silicon driver pci/pcie-tango.c anybus/arcx-anybus.c
platform_driver calls platform_driver calls
pci_host_probe() anybus_host_common_probe()
v4:
general
create fieldbus_dev subsystem, with standardized 'simple'
userspace interface (sysfs + cdev)
remove redundant __packed keywords
use __be16/32 types wherever values are explicitly big-endian
hms-profinet:
remove configuration code, and uapi headers: not supported (yet)
when registering as a fieldbus_dev.
anybuss-host:
use struct kref to reference-count tasks
replace busy loops with usleep_range() loop after 10 tries use threaded irq so time_before_eq(jiffies, timeout) will
continue to work
allow client devices to be assigned a devicetree node,
in the same way as pci/mmc/...
v3:
devicetree-bindings
adding the vendor prefix is now a separate commit
anybus-bridge:
moved misc driver to drivers/bus/ converted of_gpio_* to gpiod_* abstractions can power readout is now a fixed-voltage regulator
anybuss-host:
converted refcounts from atomic_t to refcount_t fixed potential use-after-free
hms-profinet:
applied minor kernel build robot suggestion
v2:
added architecture overview comments to host driver completely reworked anybus-bridge driver, it becomes a reset controller anybuss-host driver now needs devicetree entry, link to reset controller I will hold off on kernel-doc until the overall architecture gets
more validation / approval
fixed Kconfig, comment-style, document ioctl magic numbers removed redundant pwm dependency
renamed enable-gpios to reset-gpios
stop driving reset-gpio after unloading driver
use interrupt-parent / interrupts method to describe interrupts
in the devicetree
convert references 'i.MX WEIM parallel bus' to 'parallel bus' replace devicetree functions with more generic platform_get_resource()
platform_get_irq()
added device unique data to add_device_randomness()
v1:
first shot
Sven Van Asbroeck (7):
fieldbus_dev: add Fieldbus Device subsystem.
anybus-s: support HMS Anybus-S bus
anybus-s: support the Arcx anybus controller
dt-bindings: anybus-controller: document devicetree binding
dt-bindings: Add vendor prefix for arcx / Archronix
fieldbus_dev: support HMS Profinet IRT industrial controller
staging: fieldbus_dev: add TODO
.../fieldbus/arcx,anybus-controller.txt | 71 + .../devicetree/bindings/vendor-prefixes.txt | 1 + drivers/staging/Kconfig | 2 + drivers/staging/Makefile | 1 + .../Documentation/ABI/fieldbus-dev-cdev | 31 + .../ABI/sysfs-class-fieldbus-dev | 62 + .../fieldbus/Documentation/fieldbus_dev.txt | 66 + drivers/staging/fieldbus/Kconfig | 18 + drivers/staging/fieldbus/Makefile | 7 + drivers/staging/fieldbus/TODO | 5 + drivers/staging/fieldbus/anybuss/Kconfig | 39 + drivers/staging/fieldbus/anybuss/Makefile | 10 + .../staging/fieldbus/anybuss/anybuss-client.h | 102 ++ .../fieldbus/anybuss/anybuss-controller.h | 47 + .../staging/fieldbus/anybuss/arcx-anybus.c | 399 +++++ .../staging/fieldbus/anybuss/hms-profinet.c | 228 +++ drivers/staging/fieldbus/anybuss/host.c | 1460 +++++++++++++++++ drivers/staging/fieldbus/dev_core.c | 351 ++++ drivers/staging/fieldbus/fieldbus_dev.h | 108 ++ 19 files changed, 3008 insertions(+) create mode 100644 Documentation/devicetree/bindings/fieldbus/arcx,anybus-controller.txt create mode 100644 drivers/staging/fieldbus/Documentation/ABI/fieldbus-dev-cdev create mode 100644 drivers/staging/fieldbus/Documentation/ABI/sysfs-class-fieldbus-dev create mode 100644 drivers/staging/fieldbus/Documentation/fieldbus_dev.txt create mode 100644 drivers/staging/fieldbus/Kconfig create mode 100644 drivers/staging/fieldbus/Makefile create mode 100644 drivers/staging/fieldbus/TODO create mode 100644 drivers/staging/fieldbus/anybuss/Kconfig create mode 100644 drivers/staging/fieldbus/anybuss/Makefile create mode 100644 drivers/staging/fieldbus/anybuss/anybuss-client.h create mode 100644 drivers/staging/fieldbus/anybuss/anybuss-controller.h create mode 100644 drivers/staging/fieldbus/anybuss/arcx-anybus.c create mode 100644 drivers/staging/fieldbus/anybuss/hms-profinet.c create mode 100644 drivers/staging/fieldbus/anybuss/host.c create mode 100644 drivers/staging/fieldbus/dev_core.c create mode 100644 drivers/staging/fieldbus/fieldbus_dev.h
Signature · 1 line
2.17.1