Fix espressobin ethernet support on mainline u-boot
Subsystems (2)
cover Fix espressobin ethernet support on mainline u-boot
This patchset fixes ethernet and mv88e6341 switch support on espressobin board when bootloader does not initialize needed registers.
This patchset should be applied along with pinctrl fixes from [1] which have been merged in next branch of linux-pinctrl tree.
[1] https://lkml.org/lkml/2018/12/21/507
Remi Pommarel (2):
arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as
RGMII-ID
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 7 +++++++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 5 +++++ 2 files changed, 12 insertions(+)
Signature · 1 line
2.20.1
PATCH 1/2 arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
In order to be able to communicate with the 88e6341 switch some pins have to be repurposed as RGMII and SMI pins.
This fixes ethernet support on system booted via a bootloader that has not already configured those pins (e.g. mainline u-boot, or vendor u-boot compiled without ethernet support).
--- arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 2 ++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 5 +++++ 2 files changed, 7 insertions(+)
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +2 -0
@@ -196,6 +196,8 @@ }; ð0 { + pinctrl-names = "default"; + pinctrl-0 = <&rgmii_pins>, <&smi_pins>; phy-mode = "rgmii-id"; status = "okay";
arch/arm64/boot/dts/marvell/armada-37xx.dtsi +5 -0
@@ -271,6 +271,11 @@ function = "mii"; }; + smi_pins: smi-pins { + groups = "smi"; + function = "smi"; + }; + sdio_pins: sdio-pins { groups = "sdio_sb"; function = "sdio";
Signature · 1 line
2.20.1
PATCH 2/2 arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as RGMII-ID
In reply to Remi PommarelThe mv88e6341 ethernet switch needs the cpu port control register to be set with TX and RX internal delay in order to work.
This fixes ethernet support on system booted via a bootloader that has not already configured this register (e.g. mainline u-boot, or vendor u-boot compiled without ethernet support).
--- arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +5 -0
@@ -156,6 +156,11 @@ reg = <0>; label = "cpu"; ethernet = <ð0>; + phy-mode = "rgmii-id"; + fixed-link { + speed = <1000>; + full-duplex; + }; }; port@1 {
Signature · 1 line
2.20.1
Re: [PATCH 2/2] arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as RGMII-ID
Quoted 8 lines · Remi Pommarel
The mv88e6341 ethernet switch needs the cpu port control register to be set with TX and RX internal delay in order to work.
This fixes ethernet support on system booted via a bootloader that has not already configured this register (e.g. mainline u-boot, or vendor u-boot compiled without ethernet support).
Signed-off-by Remi Pommarel <[email protected]>
Looks sensible
Andrew
Gregory CLEMENT
maintainerHi Remi,
Quoted 6 lines · Remi Pommarel
This patchset fixes ethernet and mv88e6341 switch support on espressobin board when bootloader does not initialize needed registers.
This patchset should be applied along with pinctrl fixes from [1] which have been merged in next branch of linux-pinctrl tree.
Quoted 7 lines
[1] https://lkml.org/lkml/2018/12/21/507
Remi Pommarel (2):
arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as
RGMII-ID
Both patches applied to mvebu/dt64
Thanks,
Gregory
Quoted 7 lines
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 7 +++++++ arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 5 +++++ 2 files changed, 12 insertions(+)Signature · 1 line
2.20.1
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com