Skip to contentSkip to conversation

Fix espressobin ethernet support on mainline u-boot

PATCH In review Remi Pommarel 3 participants 5 messages Jan 28, 2019 – Feb 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Fix espressobin ethernet support on mainline u-boot

This patchset fixes ethernet and mv88e6341 switch support on espressobin board when bootloader does not initialize needed registers.

This patchset should be applied along with pinctrl fixes from [1] which have been merged in next branch of linux-pinctrl tree.

[1] https://lkml.org/lkml/2018/12/21/507

Remi Pommarel (2):
arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as
RGMII-ID

 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 7 +++++++
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi            | 5 +++++
 2 files changed, 12 insertions(+)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/2 arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins

In order to be able to communicate with the 88e6341 switch some pins have to be repurposed as RGMII and SMI pins.

This fixes ethernet support on system booted via a bootloader that has not already configured those pins (e.g. mainline u-boot, or vendor u-boot compiled without ethernet support).

---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 2 ++
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi            | 5 +++++
 2 files changed, 7 insertions(+)
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +2 -0
index 846003bb480c..b60897edc885 100644
@@ -196,6 +196,8 @@
 };
 
 &eth0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&rgmii_pins>, <&smi_pins>;
 	phy-mode = "rgmii-id";
 	status = "okay";
 
arch/arm64/boot/dts/marvell/armada-37xx.dtsi +5 -0
index e05594ea15fb..f61538910901 100644
@@ -271,6 +271,11 @@
 					function = "mii";
 				};
 
+				smi_pins: smi-pins {
+					groups = "smi";
+					function = "smi";
+				};
+
 				sdio_pins: sdio-pins {
 					groups = "sdio_sb";
 					function = "sdio";
Signature · 1 line
2.20.1
#2 lore raw

PATCH 2/2 arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as RGMII-ID

In reply to Remi Pommarel

The mv88e6341 ethernet switch needs the cpu port control register to be set with TX and RX internal delay in order to work.

This fixes ethernet support on system booted via a bootloader that has not already configured this register (e.g. mainline u-boot, or vendor u-boot compiled without ethernet support).

---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +5 -0
index b60897edc885..86e8a1e3207f 100644
@@ -156,6 +156,11 @@
 				reg = <0>;
 				label = "cpu";
 				ethernet = <&eth0>;
+				phy-mode = "rgmii-id";
+				fixed-link {
+					speed = <1000>;
+					full-duplex;
+				};
 			};
 
 			port@1 {
Signature · 1 line
2.20.1
maintainer Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as RGMII-ID

Quoted 8 lines · Remi Pommarel

The mv88e6341 ethernet switch needs the cpu port control register to be set with TX and RX internal delay in order to work.

This fixes ethernet support on system booted via a bootloader that has not already configured this register (e.g. mainline u-boot, or vendor u-boot compiled without ethernet support).

Looks sensible

Andrew

maintainer
#4 lore raw
In reply to Remi Pommarel

Hi Remi,

Quoted 6 lines · Remi Pommarel

This patchset fixes ethernet and mv88e6341 switch support on espressobin board when bootloader does not initialize needed registers.

This patchset should be applied along with pinctrl fixes from [1] which have been merged in next branch of linux-pinctrl tree.

Quoted 7 lines

[1] https://lkml.org/lkml/2018/12/21/507

Remi Pommarel (2):
arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as
RGMII-ID

Both patches applied to mvebu/dt64

Thanks,

Gregory

Quoted 7 lines
 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 7 +++++++
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi            | 5 +++++
 2 files changed, 12 insertions(+)
Signature · 1 line
2.20.1
Signature · 3 lines
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com