Skip to contentSkip to conversation

Trivial cleanup in hw/acpi

PATCH Superseded Wei Yang 7 participants 28 messages Jan 30, 2019 – Feb 14, 2019

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Wei Yang

author
#0 lore raw

v3 cover Trivial cleanup in hw/acpi

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Wei Yang (3):
hw/i386/pc.c: remove unused function pc_acpi_init() hw/acpi: remove unused function acpi_table_add_builtin() hw/acpi: remove unnecessary variable acpi_table_builtin

 hw/acpi/core.c         | 10 +---------
 hw/i386/pc.c           | 27 ---------------------------
 include/hw/acpi/acpi.h |  1 -
 include/hw/i386/pc.h   |  1 -
 4 files changed, 1 insertion(+), 38 deletions(-)
Signature · 1 line
2.19.1
author
#1 lore raw

PATCH v3 1/3 hw/i386/pc.c: remove unused function pc_acpi_init()

Function pc_acpi_init() is not used anymore.

Remove the definition and declaration.

---
 hw/i386/pc.c         | 27 ---------------------------
 include/hw/i386/pc.h |  1 -
 2 files changed, 28 deletions(-)
hw/i386/pc.c +0 -27
index 5317e08f60..734d3268fa 100644
@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
                                         pci_address_space, -1);
 }
 
-void pc_acpi_init(const char *default_dsdt)
-{
-    char *filename;
-
-    if (acpi_tables != NULL) {
-        /* manually set via -acpitable, leave it alone */
-        return;
-    }
-
-    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
-    if (filename == NULL) {
-        warn_report("failed to find %s", default_dsdt);
-    } else {
-        QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
-                                          &error_abort);
-        Error *err = NULL;
-
-        qemu_opt_set(opts, "file", filename, &error_abort);
-
-        acpi_table_add_builtin(opts, &err);
-        if (err) {
-            warn_reportf_err(err, "failed to load %s: ", filename);
-        }
-        g_free(filename);
-    }
-}
-
 void xen_load_linux(PCMachineState *pcms)
 {
     int i;
include/hw/i386/pc.h +0 -1
index 9d29c4b1df..541124ba6d 100644
@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
 
 void pc_cpus_init(PCMachineState *pcms);
 void pc_hot_add_cpu(const int64_t id, Error **errp);
-void pc_acpi_init(const char *default_dsdt);
 
 void pc_guest_info_init(PCMachineState *pcms);
 
Signature · 1 line
2.19.1
Reviewed-by on v3 1/3
#2 lore raw

Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

Quoted 7 lines · On Wed, 30 Jan 2019 08:06:51 +0800 Wei Yang <[email protected]>…

Function pc_acpi_init() is not used anymore.

Remove the definition and declaration.

Quoted 55 lines
---
 hw/i386/pc.c         | 27 ---------------------------
 include/hw/i386/pc.h |  1 -
 2 files changed, 28 deletions(-)
hw/i386/pc.c +0 -27
index 5317e08f60..734d3268fa 100644
@@ -1280,33 +1280,6 @@ void pc_pci_as_mapping_init(Object *owner, MemoryRegion *system_memory,
                                         pci_address_space, -1);
 }
 
-void pc_acpi_init(const char *default_dsdt)
-{
-    char *filename;
-
-    if (acpi_tables != NULL) {
-        /* manually set via -acpitable, leave it alone */
-        return;
-    }
-
-    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, default_dsdt);
-    if (filename == NULL) {
-        warn_report("failed to find %s", default_dsdt);
-    } else {
-        QemuOpts *opts = qemu_opts_create(qemu_find_opts("acpi"), NULL, 0,
-                                          &error_abort);
-        Error *err = NULL;
-
-        qemu_opt_set(opts, "file", filename, &error_abort);
-
-        acpi_table_add_builtin(opts, &err);
-        if (err) {
-            warn_reportf_err(err, "failed to load %s: ", filename);
-        }
-        g_free(filename);
-    }
-}
-
 void xen_load_linux(PCMachineState *pcms)
 {
     int i;
include/hw/i386/pc.h +0 -1
index 9d29c4b1df..541124ba6d 100644
@@ -187,7 +187,6 @@ void pc_acpi_smi_interrupt(void *opaque, int irq, int level);
 
 void pc_cpus_init(PCMachineState *pcms);
 void pc_hot_add_cpu(const int64_t id, Error **errp);
-void pc_acpi_init(const char *default_dsdt);
 
 void pc_guest_info_init(PCMachineState *pcms);
 
Reviewed-by on v3 1/3
#3 lore raw

Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

In reply to Wei Yang
Quoted 7 lines · Wei Yang

Function pc_acpi_init() is not used anymore.

Remove the definition and declaration.

Hi,

at least in my e-mail client here, it looks like Philippe's last name got mojibaked here. It should be "Daudé", not "Daud茅", as far as I know. Same thing also happened in patch 2 and 3.

Apart from that:

#4 lore raw

Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

Quoted 9 lines · Thomas Huth
Quoted 7 lines · Wei Yang

Function pc_acpi_init() is not used anymore.

Remove the definition and declaration.

Quoted 5 lines

Hi,

at least in my e-mail client here, it looks like Philippe's last name got mojibaked here. It should be "Daudé", not "Daud茅", as far as I know. Same thing also happened in patch 2 and 3.

Thanks!

Quoted 5 lines

Apart from that:

#5 lore raw

Re: [Qemu-devel] [PATCH v3 1/3] hw/i386/pc.c: remove unused function pc_acpi_init()

Quoted 10 lines · Philippe Mathieu-Daudé
Quoted 9 lines · Thomas Huth
Quoted 7 lines · Wei Yang

Function pc_acpi_init() is not used anymore.

Remove the definition and declaration.

Quoted 8 lines
Quoted 5 lines

Hi,

at least in my e-mail client here, it looks like Philippe's last name got mojibaked here. It should be "Daudé", not "Daud茅", as far as I know. Same thing also happened in patch 2 and 3.

Thanks!

Opps, sorry for that.

Not sure which part changes the encoding.

Quoted 5 lines
Quoted 5 lines

Apart from that:

Signature · 2 lines
Wei Yang
Help you, Help me
author
#6 lore raw

PATCH v3 2/3 hw/acpi: remove unused function acpi_table_add_builtin()

In reply to Wei Yang

Function acpi_table_add_builtin() is not used anymore.

Remove the definition and declaration.

---
 hw/acpi/core.c         | 6 ------
 include/hw/acpi/acpi.h | 1 -
 2 files changed, 7 deletions(-)
hw/acpi/core.c +0 -6
index d6f0709691..e9b1a85e54 100644
@@ -305,12 +305,6 @@ out:
 
 static bool acpi_table_builtin = false;
 
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp)
-{
-    acpi_table_builtin = true;
-    acpi_table_add(opts, errp);
-}
-
 unsigned acpi_table_len(void *current)
 {
     struct acpi_table_header *hdr = current - sizeof(hdr->_length);
include/hw/acpi/acpi.h +0 -1
index c20ace0d0b..4a8bbaf1b5 100644
@@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);
 uint8_t *acpi_table_next(uint8_t *current);
 unsigned acpi_table_len(void *current);
 void acpi_table_add(const QemuOpts *opts, Error **errp);
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp);
 
 typedef struct AcpiSlicOem AcpiSlicOem;
 struct AcpiSlicOem {
Signature · 1 line
2.19.1
Reviewed-by on v3 2/3
#7 lore raw

Re: [Qemu-devel] [PATCH v3 2/3] hw/acpi: remove unused function acpi_table_add_builtin()

Quoted 7 lines · On Wed, 30 Jan 2019 08:06:52 +0800 Wei Yang <[email protected]>…

Function acpi_table_add_builtin() is not used anymore.

Remove the definition and declaration.

Quoted 34 lines
---
 hw/acpi/core.c         | 6 ------
 include/hw/acpi/acpi.h | 1 -
 2 files changed, 7 deletions(-)
hw/acpi/core.c +0 -6
index d6f0709691..e9b1a85e54 100644
@@ -305,12 +305,6 @@ out:
 
 static bool acpi_table_builtin = false;
 
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp)
-{
-    acpi_table_builtin = true;
-    acpi_table_add(opts, errp);
-}
-
 unsigned acpi_table_len(void *current)
 {
     struct acpi_table_header *hdr = current - sizeof(hdr->_length);
include/hw/acpi/acpi.h +0 -1
index c20ace0d0b..4a8bbaf1b5 100644
@@ -190,7 +190,6 @@ uint8_t *acpi_table_first(void);
 uint8_t *acpi_table_next(uint8_t *current);
 unsigned acpi_table_len(void *current);
 void acpi_table_add(const QemuOpts *opts, Error **errp);
-void acpi_table_add_builtin(const QemuOpts *opts, Error **errp);
 
 typedef struct AcpiSlicOem AcpiSlicOem;
 struct AcpiSlicOem {
author
#8 lore raw

PATCH v3 3/3 hw/acpi: remove unnecessary variable acpi_table_builtin

In reply to Wei Yang

acpi_table_builtin is now always false, it is not necessary to check it again.

This patch just removes it.

---
 hw/acpi/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
hw/acpi/core.c +1 -3
index e9b1a85e54..f9c96535d1 100644
@@ -303,8 +303,6 @@ out:
     error_propagate(errp, err);
 }
 
-static bool acpi_table_builtin = false;
-
 unsigned acpi_table_len(void *current)
 {
     struct acpi_table_header *hdr = current - sizeof(hdr->_length);
@@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)
 
 uint8_t *acpi_table_first(void)
 {
-    if (acpi_table_builtin || !acpi_tables) {
+    if (!acpi_tables) {
         return NULL;
     }
     return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);
Signature · 1 line
2.19.1
Reviewed-by on v3 3/3
#9 lore raw

Re: [Qemu-devel] [PATCH v3 3/3] hw/acpi: remove unnecessary variable acpi_table_builtin

Quoted 8 lines · On Wed, 30 Jan 2019 08:06:53 +0800 Wei Yang <[email protected]>…

acpi_table_builtin is now always false, it is not necessary to check it again.

This patch just removes it.

Quoted 26 lines
---
 hw/acpi/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
hw/acpi/core.c +1 -3
index e9b1a85e54..f9c96535d1 100644
@@ -303,8 +303,6 @@ out:
     error_propagate(errp, err);
 }
 
-static bool acpi_table_builtin = false;
-
 unsigned acpi_table_len(void *current)
 {
     struct acpi_table_header *hdr = current - sizeof(hdr->_length);
@@ -320,7 +318,7 @@ void *acpi_table_hdr(void *h)
 
 uint8_t *acpi_table_first(void)
 {
-    if (acpi_table_builtin || !acpi_tables) {
+    if (!acpi_tables) {
         return NULL;
     }
     return acpi_table_hdr(acpi_tables + ACPI_TABLE_PFX_SIZE);
author
#10 lore raw
In reply to Wei Yang
Quoted 6 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Quoted 14 lines

Wei Yang (3):
hw/i386/pc.c: remove unused function pc_acpi_init() hw/acpi: remove unused function acpi_table_add_builtin() hw/acpi: remove unnecessary variable acpi_table_builtin

hw/acpi/core.c         | 10 +---------
hw/i386/pc.c           | 27 ---------------------------
include/hw/acpi/acpi.h |  1 -
include/hw/i386/pc.h   |  1 -
4 files changed, 1 insertion(+), 38 deletions(-)
Signature · 1 line
2.19.1
Signature · 2 lines
Wei Yang
Help you, Help me
#11 lore raw
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 18 lines
Quoted 14 lines

Wei Yang (3):
hw/i386/pc.c: remove unused function pc_acpi_init() hw/acpi: remove unused function acpi_table_add_builtin() hw/acpi: remove unnecessary variable acpi_table_builtin

hw/acpi/core.c         | 10 +---------
hw/i386/pc.c           | 27 ---------------------------
include/hw/acpi/acpi.h |  1 -
include/hw/i386/pc.h   |  1 -
4 files changed, 1 insertion(+), 38 deletions(-)
Signature · 1 line
2.19.1
Signature · 2 lines
Wei Yang
Help you, Help me
author
#12 lore raw
Quoted 9 lines · Michael S. Tsirkin
Quoted 8 lines · Wei Yang
Quoted 6 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Quoted 8 lines
Quoted 5 lines

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

I tried to use git-sendemail to send those patches again.

The character 茅 looks good in patch file, while after git-sendemail this is changed.

My encoding property in mail is :

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Looks the same as Philippe's.

Any hint on how to send out a correct character with git-sendemail?

Quoted 19 lines
Quoted 19 lines
Quoted 15 lines

Wei Yang (3):
hw/i386/pc.c: remove unused function pc_acpi_init() hw/acpi: remove unused function acpi_table_add_builtin() hw/acpi: remove unnecessary variable acpi_table_builtin

hw/acpi/core.c         | 10 +---------
hw/i386/pc.c           | 27 ---------------------------
include/hw/acpi/acpi.h |  1 -
include/hw/i386/pc.h   |  1 -
4 files changed, 1 insertion(+), 38 deletions(-)
Signature · 1 line
2.19.1
Signature · 2 lines
Wei Yang
Help you, Help me
Signature · 2 lines
Wei Yang
Help you, Help me
#13 lore raw

Hi Wei,

Quoted 24 lines · Wei Yang
Quoted 9 lines · Michael S. Tsirkin
Quoted 8 lines · Wei Yang
Quoted 6 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Quoted 8 lines
Quoted 5 lines

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

I tried to use git-sendemail to send those patches again.

The character 茅 looks good in patch file, while after git-sendemail this is changed.

Quoted 6 lines

My encoding property in mail is :

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

I'm not sure but you can try:

Content-Transfer-Encoding: base64

Quoted 4 lines

Looks the same as Philippe's.

Any hint on how to send out a correct character with git-sendemail?

If it doesn't work, then use my ASCII-reduced lastname, I can live with that:

"Reviewed-by: Philippe Mathieu-Daude <[email protected]>"

Thanks for trying,

Phil.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

Wei Yang (3):
hw/i386/pc.c: remove unused function pc_acpi_init() hw/acpi: remove unused function acpi_table_add_builtin() hw/acpi: remove unnecessary variable acpi_table_builtin

hw/acpi/core.c         | 10 +---------
hw/i386/pc.c           | 27 ---------------------------
include/hw/acpi/acpi.h |  1 -
include/hw/i386/pc.h   |  1 -
4 files changed, 1 insertion(+), 38 deletions(-)
author
#14 lore raw
Quoted 29 lines · Philippe Mathieu-Daudé

Hi Wei,

Quoted 26 lines · Wei Yang
Quoted 9 lines · Michael S. Tsirkin
Quoted 8 lines · Wei Yang
Quoted 6 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Quoted 8 lines
Quoted 5 lines

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

I tried to use git-sendemail to send those patches again.

The character 茅 looks good in patch file, while after git-sendemail this is changed.

My encoding property in mail is :

Quoted 9 lines
Quoted 4 lines

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

I'm not sure but you can try:

Content-Transfer-Encoding: base64

Looks not work.

git send-email will detect the file's encoding is 8bit, so manually change to base64 doesn't work.

Quoted 11 lines
Quoted 4 lines

Looks the same as Philippe's.

Any hint on how to send out a correct character with git-sendemail?

If it doesn't work, then use my ASCII-reduced lastname, I can live with that:

"Reviewed-by: Philippe Mathieu-Daude <[email protected]>"

Thanks for trying,

Thanks :-)

Let's wait a while to see whether someone else has an idea on that.

Quoted 16 lines

Phil.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

Wei Yang (3):
hw/i386/pc.c: remove unused function pc_acpi_init() hw/acpi: remove unused function acpi_table_add_builtin() hw/acpi: remove unnecessary variable acpi_table_builtin

hw/acpi/core.c         | 10 +---------
hw/i386/pc.c           | 27 ---------------------------
include/hw/acpi/acpi.h |  1 -
include/hw/i386/pc.h   |  1 -
4 files changed, 1 insertion(+), 38 deletions(-)
Signature · 2 lines
Wei Yang
Help you, Help me
#15 lore raw
In reply to Michael S. Tsirkin
Quoted 9 lines · Michael S. Tsirkin
Quoted 8 lines · Wei Yang
Quoted 6 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Quoted 7 lines
Quoted 5 lines

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Or I can take the series through the trivial branch and update manually Philippe's lastname?

Laurent

author
#16 lore raw
Quoted 12 lines · Laurent Vivier
Quoted 11 lines · Michael S. Tsirkin
Quoted 10 lines · Wei Yang
Quoted 6 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Or I can take the series through the trivial branch and update manually Philippe's lastname?

Thanks :-)

Let's see Michael's opinion.

Quoted 1 line

Laurent

Signature · 2 lines
Wei Yang
Help you, Help me
#17 lore raw
In reply to Laurent Vivier

Hi Laurent,

Quoted 12 lines · Laurent Vivier
Quoted 11 lines · Michael S. Tsirkin
Quoted 10 lines · Wei Yang
Quoted 6 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

Another (fair) approach is to forbid non-ASCII chars in all part of patches.

Regards,

Phil.

#18 lore raw
Quoted 21 lines · Philippe Mathieu-Daudé

Hi Laurent,

Quoted 18 lines · Laurent Vivier
Quoted 16 lines · Michael S. Tsirkin
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 9 lines
Quoted 2 lines

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

How you configure your git send-email? or related facility?

Quoted 5 lines

Another (fair) approach is to forbid non-ASCII chars in all part of patches.

Regards,

Phil.

Signature · 2 lines
Wei Yang
Help you, Help me
#19 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 21 lines · Philippe Mathieu-Daudé

Hi Laurent,

Quoted 18 lines · Laurent Vivier
Quoted 16 lines · Michael S. Tsirkin
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 8 lines
Quoted 2 lines

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

I'm wondering if it can be a problem with cut'n'paste rather than with git-sendemail.

I think the following tags should cover Latin and Chinese characters:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Thanks,
Laurent

author
#20 lore raw
Quoted 31 lines · Laurent Vivier
Quoted 21 lines · Philippe Mathieu-Daudé

Hi Laurent,

Quoted 18 lines · Laurent Vivier
Quoted 16 lines · Michael S. Tsirkin
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 8 lines
Quoted 2 lines

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

Quoted 8 lines

I'm wondering if it can be a problem with cut'n'paste rather than with git-sendemail.

I think the following tags should cover Latin and Chinese characters:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Looks not work.

I have tried this and also with

Content-Language: en-US

The character would be modified after git send-email.

Quoted 2 lines

Thanks,
Laurent

Signature · 2 lines
Wei Yang
Help you, Help me
#21 lore raw
Quoted 41 lines · Wei Yang
Quoted 31 lines · Laurent Vivier
Quoted 21 lines · Philippe Mathieu-Daudé

Hi Laurent,

Quoted 18 lines · Laurent Vivier
Quoted 16 lines · Michael S. Tsirkin
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 8 lines
Quoted 2 lines

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

Quoted 8 lines

I'm wondering if it can be a problem with cut'n'paste rather than with git-sendemail.

I think the following tags should cover Latin and Chinese characters:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Quoted 5 lines

Looks not work.

I have tried this and also with

Content-Language: en-US

Could you send me a gzipped version of the 0001-XXX.patch in attachment so I could see the real content before git-send-email?

Thansk,
Laurent

#22 lore raw
Quoted 42 lines · Laurent Vivier
Quoted 41 lines · Wei Yang
Quoted 39 lines · Laurent Vivier
Quoted 21 lines · Philippe Mathieu-Daudé

Hi Laurent,

Quoted 18 lines · Laurent Vivier
Quoted 16 lines · Michael S. Tsirkin
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 8 lines
Quoted 2 lines

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

I'm wondering if it can be a problem with cut'n'paste rather than with git-sendemail.

I think the following tags should cover Latin and Chinese characters:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Quoted 8 lines
Quoted 5 lines

Looks not work.

I have tried this and also with

Content-Language: en-US

Could you send me a gzipped version of the 0001-XXX.patch in attachment so I could see the real content before git-send-email?

OK, I've got it.

What I see is it is already corrupted, thus the problem is not with git-send-email.

So either it is corrupted by git-format-patch (which is very unlikely, we could see that if you push it to a public git repo) or it has been corrupted when you have added it to the commit message.

Thanks,
Laurent

author
#23 lore raw
Quoted 52 lines · Laurent Vivier
Quoted 42 lines · Laurent Vivier
Quoted 41 lines · Wei Yang
Quoted 39 lines · Laurent Vivier
Quoted 21 lines · Philippe Mathieu-Daudé

Hi Laurent,

Quoted 18 lines · Laurent Vivier
Quoted 16 lines · Michael S. Tsirkin
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 8 lines
Quoted 2 lines

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

I'm wondering if it can be a problem with cut'n'paste rather than with git-sendemail.

I think the following tags should cover Latin and Chinese characters:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Quoted 8 lines
Quoted 5 lines

Looks not work.

I have tried this and also with

Content-Language: en-US

Could you send me a gzipped version of the 0001-XXX.patch in attachment so I could see the real content before git-send-email?

Quoted 9 lines

OK, I've got it.

What I see is it is already corrupted, thus the problem is not with git-send-email.

So either it is corrupted by git-format-patch (which is very unlikely, we could see that if you push it to a public git repo) or it has been corrupted when you have added it to the commit message.

Hmm... maybe you are right.

But I found confused how to fix this.

When I use git commit --amend to fix it, the character looks good in my editor. I use vim as my git editor.

But when I use git show, it display an unknown character.

And if I use git format-patch, the patch file looks good in my vim editor. But corrupted if I use another editor.

Do you have any idea on this?

Quoted 3 lines

Thanks,
Laurent

Signature · 2 lines
Wei Yang
Help you, Help me
#24 lore raw
Quoted 70 lines · Wei Yang
Quoted 52 lines · Laurent Vivier
Quoted 42 lines · Laurent Vivier
Quoted 41 lines · Wei Yang
Quoted 39 lines · Laurent Vivier
Quoted 21 lines · Philippe Mathieu-Daudé

Hi Laurent,

Quoted 18 lines · Laurent Vivier
Quoted 16 lines · Michael S. Tsirkin
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 8 lines
Quoted 2 lines

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

I'm wondering if it can be a problem with cut'n'paste rather than with git-sendemail.

I think the following tags should cover Latin and Chinese characters:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Quoted 8 lines
Quoted 5 lines

Looks not work.

I have tried this and also with

Content-Language: en-US

Could you send me a gzipped version of the 0001-XXX.patch in attachment so I could see the real content before git-send-email?

Quoted 9 lines

OK, I've got it.

What I see is it is already corrupted, thus the problem is not with git-send-email.

So either it is corrupted by git-format-patch (which is very unlikely, we could see that if you push it to a public git repo) or it has been corrupted when you have added it to the commit message.

Hmm... maybe you are right.

But I found confused how to fix this.

When I use git commit --amend to fix it, the character looks good in my editor. I use vim as my git editor.

Quoted 6 lines

But when I use git show, it display an unknown character.

And if I use git format-patch, the patch file looks good in my vim editor. But corrupted if I use another editor.

Do you have any idea on this?

What is the result of command "locale" in your terminal? How do you copy the characters to vim?

Thanks,
Laurent

author
#25 lore raw
Quoted 73 lines · Laurent Vivier
Quoted 72 lines · Wei Yang
Quoted 52 lines · Laurent Vivier
Quoted 42 lines · Laurent Vivier
Quoted 41 lines · Wei Yang
Quoted 39 lines · Laurent Vivier
Quoted 21 lines · Philippe Mathieu-Daudé

Hi Laurent,

Quoted 18 lines · Laurent Vivier
Quoted 16 lines · Michael S. Tsirkin
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 8 lines
Quoted 2 lines

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

I'm wondering if it can be a problem with cut'n'paste rather than with git-sendemail.

I think the following tags should cover Latin and Chinese characters:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Quoted 8 lines
Quoted 5 lines

Looks not work.

I have tried this and also with

Content-Language: en-US

Could you send me a gzipped version of the 0001-XXX.patch in attachment so I could see the real content before git-send-email?

Quoted 9 lines

OK, I've got it.

What I see is it is already corrupted, thus the problem is not with git-send-email.

So either it is corrupted by git-format-patch (which is very unlikely, we could see that if you push it to a public git repo) or it has been corrupted when you have added it to the commit message.

Hmm... maybe you are right.

But I found confused how to fix this.

When I use git commit --amend to fix it, the character looks good in my editor. I use vim as my git editor.

But when I use git show, it display an unknown character.

Quoted 8 lines
Quoted 4 lines

And if I use git format-patch, the patch file looks good in my vim editor. But corrupted if I use another editor.

Do you have any idea on this?

What is the result of command "locale" in your terminal? How do you copy the characters to vim?

My locale output:

    $ locale
    LANG=en_US.UTF-8
    LANGUAGE=
    LC_CTYPE="en_US.UTF-8"
    LC_NUMERIC=zh_CN.UTF-8
    LC_TIME=zh_CN.UTF-8
    LC_COLLATE="en_US.UTF-8"
    LC_MONETARY=zh_CN.UTF-8
    LC_MESSAGES="en_US.UTF-8"
    LC_PAPER=zh_CN.UTF-8
    LC_NAME=zh_CN.UTF-8
    LC_ADDRESS=zh_CN.UTF-8
    LC_TELEPHONE=zh_CN.UTF-8
    LC_MEASUREMENT=zh_CN.UTF-8
    LC_IDENTIFICATION=zh_CN.UTF-8
    LC_ALL=

I copy&paste the character from mutt to vim. Let me see if it would work if I save the character from mutt mail itself.

Quoted 2 lines

Thanks,
Laurent

Signature · 2 lines
Wei Yang
Help you, Help me
author
#26 lore raw
In reply to Laurent Vivier
Quoted 73 lines · Laurent Vivier
Quoted 72 lines · Wei Yang
Quoted 52 lines · Laurent Vivier
Quoted 42 lines · Laurent Vivier
Quoted 41 lines · Wei Yang
Quoted 39 lines · Laurent Vivier
Quoted 21 lines · Philippe Mathieu-Daudé

Hi Laurent,

Quoted 18 lines · Laurent Vivier
Quoted 16 lines · Michael S. Tsirkin
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 8 lines
Quoted 2 lines

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

I'm wondering if it can be a problem with cut'n'paste rather than with git-sendemail.

I think the following tags should cover Latin and Chinese characters:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Quoted 8 lines
Quoted 5 lines

Looks not work.

I have tried this and also with

Content-Language: en-US

Could you send me a gzipped version of the 0001-XXX.patch in attachment so I could see the real content before git-send-email?

Quoted 9 lines

OK, I've got it.

What I see is it is already corrupted, thus the problem is not with git-send-email.

So either it is corrupted by git-format-patch (which is very unlikely, we could see that if you push it to a public git repo) or it has been corrupted when you have added it to the commit message.

Hmm... maybe you are right.

But I found confused how to fix this.

When I use git commit --amend to fix it, the character looks good in my editor. I use vim as my git editor.

But when I use git show, it display an unknown character.

Quoted 8 lines
Quoted 4 lines

And if I use git format-patch, the patch file looks good in my vim editor. But corrupted if I use another editor.

Do you have any idea on this?

What is the result of command "locale" in your terminal? How do you copy the characters to vim?

Hi, Laurent

I tried to copied the character directly from Philippe's mail.

This time looks good from my mutt client. Hope it works for you.

Thanks!

Quoted 2 lines

Thanks,
Laurent

Signature · 2 lines
Wei Yang
Help you, Help me
#27 lore raw
Quoted 83 lines · Wei Yang
Quoted 73 lines · Laurent Vivier
Quoted 72 lines · Wei Yang
Quoted 52 lines · Laurent Vivier
Quoted 42 lines · Laurent Vivier
Quoted 41 lines · Wei Yang
Quoted 39 lines · Laurent Vivier
Quoted 21 lines · Philippe Mathieu-Daudé

Hi Laurent,

Quoted 18 lines · Laurent Vivier
Quoted 16 lines · Michael S. Tsirkin
Quoted 5 lines · Wei Yang
Quoted 4 lines · Wei Yang

There are several functions/variable which are not used anymore.

This serials just remove those without functional change.

Quoted 8 lines
Quoted 2 lines

v3: add ack and repost in a new thread
v2: change commit log from "is now used in no place" to "in not used anymore"

Michael,

Looks this serials is not merged yet.

Is there any problem I need to fix?

Yes pls repost with fixed reviewed-by tags.

Quoted 8 lines
Quoted 2 lines

Or I can take the series through the trivial branch and update manually Philippe's lastname?

I appreciate the help with manual update, however Wei is not the only one having this problem (other developpers has non-ASCII in their name, and use such tags).
I'd rather prefer we find a proper configuration setup to help the community.

I'm wondering if it can be a problem with cut'n'paste rather than with git-sendemail.

I think the following tags should cover Latin and Chinese characters:

Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Quoted 8 lines
Quoted 5 lines

Looks not work.

I have tried this and also with

Content-Language: en-US

Could you send me a gzipped version of the 0001-XXX.patch in attachment so I could see the real content before git-send-email?

Quoted 9 lines

OK, I've got it.

What I see is it is already corrupted, thus the problem is not with git-send-email.

So either it is corrupted by git-format-patch (which is very unlikely, we could see that if you push it to a public git repo) or it has been corrupted when you have added it to the commit message.

Hmm... maybe you are right.

But I found confused how to fix this.

When I use git commit --amend to fix it, the character looks good in my editor. I use vim as my git editor.

But when I use git show, it display an unknown character.

Quoted 8 lines
Quoted 4 lines

And if I use git format-patch, the patch file looks good in my vim editor. But corrupted if I use another editor.

Do you have any idea on this?

What is the result of command "locale" in your terminal? How do you copy the characters to vim?

Quoted 5 lines

Hi, Laurent

I tried to copied the character directly from Philippe's mail.

This time looks good from my mutt client. Hope it works for you.

Yes, it's fine.

I let Michael to take the series for the pull request.

Thanks,
Laurent