Skip to contentSkip to conversation

rpi: add Compute Module 3+

PATCH New Jonathan Gray 2 participants 5 messages Jan 30, 2019 Broadcom BCM2711/BCM2835 Arm architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rpi: add Compute Module 3+

Add Raspberry Pi Compute Module 3+ to list of models, the revision code is 0x10 according to the list on raspberrypi.org.

---
 board/raspberrypi/rpi/rpi.c | 5 +++++
 1 file changed, 5 insertions(+)
board/raspberrypi/rpi/rpi.c +5 -0
index 153a1fdcb7..c118250740 100644
@@ -143,6 +143,11 @@ static const struct rpi_model rpi_models_new_scheme[] = {
 		DTB_DIR "bcm2837-rpi-3-a-plus.dtb",
 		false,
 	},
+	[0x10] = {
+		"Compute Module 3+",
+		DTB_DIR "bcm2837-rpi-cm3-plus.dtb",
+		false,
+	},
 };
 
 static const struct rpi_model rpi_models_old_scheme[] = {
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 rpi: add Compute Module 3+

Hi Jonathan,

Quoted 13 lines · Jonathan Gray

Add Raspberry Pi Compute Module 3+ to list of models, the revision code is 0x10 according to the list on raspberrypi.org.

---
 board/raspberrypi/rpi/rpi.c | 5 +++++
 1 file changed, 5 insertions(+)
board/raspberrypi/rpi/rpi.c +0 -0
index 153a1fdcb7..c118250740 100644

board/raspberrypi/rpi/rpi.c static const struct rpi_model rpi_models_new_scheme[] = { · line 148

Quoted 6 lines
board/raspberrypi/rpi/rpi.c +3 -0
@@ -143,6 +143,11 @@ static const struct rpi_model rpi_models_new_scheme[] = {
 		DTB_DIR "bcm2837-rpi-3-a-plus.dtb",
 		false,
 	},
+	[0x10] = {
+		"Compute Module 3+",
+		DTB_DIR "bcm2837-rpi-cm3-plus.dtb",

Is the dtb name already committed to? I haven't seen patches on the rpi kernel ML.

Alex

Quoted 6 lines
board/raspberrypi/rpi/rpi.c +2 -0
+		false,
+	},
 };
 
 static const struct rpi_model rpi_models_old_scheme[] = {
#2 lore raw

PATCH 1/1 rpi: add Compute Module 3+

Quoted 11 lines · Alexander Graf

Hi Jonathan,

Quoted 8 lines · Jonathan Gray

Add Raspberry Pi Compute Module 3+ to list of models, the revision code is 0x10 according to the list on raspberrypi.org.

---
 board/raspberrypi/rpi/rpi.c | 5 +++++
 1 file changed, 5 insertions(+)
Quoted 14 lines

board/raspberrypi/rpi/rpi.c static const struct rpi_model rpi_models_new_scheme[] = { · line 148

Quoted 11 lines
board/raspberrypi/rpi/rpi.c +3 -0
index 153a1fdcb7..c118250740 100644
@@ -143,6 +143,11 @@ static const struct rpi_model rpi_models_new_scheme[] = {
 		DTB_DIR "bcm2837-rpi-3-a-plus.dtb",
 		false,
 	},
+	[0x10] = {
+		"Compute Module 3+",
+		DTB_DIR "bcm2837-rpi-cm3-plus.dtb",

Is the dtb name already committed to? I haven't seen patches on the rpi kernel ML.

I didn't see an existing name in various linux trees.

There is currently no new dtb provided with the firmware either, though
https://raw.githubusercontent.com/raspberrypi/documentation/master/hardware/computemodule/datasheets/rpi_DATA_CM3plus_1p0.pdf
states

"CM3+ modules require a software/firmware image dated November 2018 or newer to function correctly."

So the firmware likely patches bcm2710-rpi-cm3.dtb before passing it on.

#3 lore raw

PATCH 1/1 rpi: add Compute Module 3+

Quoted 33 lines

Am 30.01.2019 um 22:38 schrieb Jonathan Gray <[email protected]>:

Quoted 12 lines · Alexander Graf

Hi Jonathan,

Quoted 9 lines · Jonathan Gray

Add Raspberry Pi Compute Module 3+ to list of models, the revision code is 0x10 according to the list on raspberrypi.org.

---
board/raspberrypi/rpi/rpi.c | 5 +++++

1 file changed, 5 insertions(+)
Quoted 14 lines

board/raspberrypi/rpi/rpi.c static const struct rpi_model rpi_models_new_scheme[] = { · line 148

Quoted 11 lines
board/raspberrypi/rpi/rpi.c +3 -0
index 153a1fdcb7..c118250740 100644
@@ -143,6 +143,11 @@ static const struct rpi_model rpi_models_new_scheme[] = {
       DTB_DIR "bcm2837-rpi-3-a-plus.dtb",
       false,
   },
+    [0x10] = {
+        "Compute Module 3+",
+        DTB_DIR "bcm2837-rpi-cm3-plus.dtb",

Is the dtb name already committed to? I haven't seen patches on the rpi kernel ML.

I didn't see an existing name in various linux trees.

Quoted 8 lines

There is currently no new dtb provided with the firmware either, though
https://raw.githubusercontent.com/raspberrypi/documentation/master/hardware/computemodule/datasheets/rpi_DATA_CM3plus_1p0.pdf
states

"CM3+ modules require a software/firmware image dated November 2018 or newer to function correctly."

So the firmware likely patches bcm2710-rpi-cm3.dtb before passing it on.

Or maybe it's identical to the CM3? It's supposed to be a drop in replacement after all - and the other differences (wifi chip, usb hub) of the 3+ should not apply to a CM.

So I guess either you send a patch to Linux that adds the cm3plus and only changes the compatible/model properties over cm3 or we make the dtb name in this patch the cm3 one.

Alex

#4 lore raw

PATCH 1/1 rpi: add Compute Module 3+

Quoted 40 lines · Alexander Graf
Quoted 40 lines

Am 30.01.2019 um 22:38 schrieb Jonathan Gray <[email protected]>:

Quoted 12 lines · Alexander Graf

Hi Jonathan,

Quoted 9 lines · Jonathan Gray

Add Raspberry Pi Compute Module 3+ to list of models, the revision code is 0x10 according to the list on raspberrypi.org.

---
board/raspberrypi/rpi/rpi.c | 5 +++++

1 file changed, 5 insertions(+)
Quoted 14 lines

board/raspberrypi/rpi/rpi.c static const struct rpi_model rpi_models_new_scheme[] = { · line 148

Quoted 11 lines
board/raspberrypi/rpi/rpi.c +3 -0
index 153a1fdcb7..c118250740 100644
@@ -143,6 +143,11 @@ static const struct rpi_model rpi_models_new_scheme[] = {
       DTB_DIR "bcm2837-rpi-3-a-plus.dtb",
       false,
   },
+    [0x10] = {
+        "Compute Module 3+",
+        DTB_DIR "bcm2837-rpi-cm3-plus.dtb",

Is the dtb name already committed to? I haven't seen patches on the rpi kernel ML.

I didn't see an existing name in various linux trees.

There is currently no new dtb provided with the firmware either, though
https://raw.githubusercontent.com/raspberrypi/documentation/master/hardware/computemodule/datasheets/rpi_DATA_CM3plus_1p0.pdf
states

"CM3+ modules require a software/firmware image dated November 2018 or newer to function correctly."

Quoted 7 lines
Quoted 1 line

So the firmware likely patches bcm2710-rpi-cm3.dtb before passing it on.

Or maybe it's identical to the CM3? It's supposed to be a drop in replacement after all - and the other differences (wifi chip, usb hub) of the 3+ should not apply to a CM.

So I guess either you send a patch to Linux that adds the cm3plus and only changes the compatible/model properties over cm3 or we make the dtb name in this patch the cm3 one.

Alex

Ok, I'll send a v2 with "bcm2837-rpi-cm3.dtb".