spi: atmel-quadspi: introduce sam9x60 qspi controller
Subsystems (4)
v4 cover spi: atmel-quadspi: introduce sam9x60 qspi controller
From: Tudor Ambarus <[email protected]>
Patches from 1 to 11 are minor fixes or cosmetics. Patches 12 and 13 introduce the sam9x60 qspi controller.
sam9x60 qspi controller tested with sst26vf064b jedec,spi-nor flash. Backward compatibility test done on sama5d2 qspi controller and mx25l25635e jedec,spi-nor flash.
The patches are generated on top of for-next branch.
v4:
- s/smm/mr, init controller in serial memory mode by default
- drop local variables that kept aq->regs and &pdev->dev, the compiler should be smart enough to store them in a register
- introduce QSPI_IFR_TFRTYP_MEM
- add comment saying QSPI_IFR_APBTFRTYP_READ is defined in sam9x60
- s/sama5d2_qspi_modes/atmel_qspi_modes, modes are the same both controllers
- fix kernel doc header
- move comment in function body
- collect R-b tags
v3:
- update smm value when different.
- treat just regular spi transfers when introducing sam9x60 qspi IP. Mem transfers will be added together with dirmap support.
- reorganize the code and change ops functions pointers to avoid code duplication.
- rename aq->clk to aq->pclk to indicate that it's a peripheral clock.
- drop unused and NOP transfer macros.
- add Suggested-by tags, reword some commits.
v2:
- cache MR value,
- drop iomem wrappers,
- make "pclk" clock-name mandatory even for sama5d2,
- rework clock handling,
- reorder setting of register values in set_cfg() calls,
- collect R-b tags.
Tudor Ambarus (13):
spi: atmel-quadspi: cache MR value to avoid a write access
spi: atmel-quadspi: order header files inclusion alphabetically
spi: atmel-quadspi: drop wrappers for iomem accesses
spi: atmel-quadspi: fix naming scheme
spi: atmel-quadspi: remove unnecessary cast
spi: atmel-quadspi: return appropriate error code
spi: atmel-quadspi: switch to SPDX license identifiers
spi: atmel-quadspi: rework transfer macros
dt-bindings: spi: atmel-quadspi: update example to new clock binding
dt-bindings: spi: atmel-quadspi: make "pclk" mandatory
spi: atmel-quadspi: add support for named peripheral clock
dt-bindings: spi: atmel-quadspi: QuadSPI driver for Microchip SAM9X60
spi: atmel-quadspi: add support for sam9x60 qspi controller
.../devicetree/bindings/spi/atmel-quadspi.txt | 12 +- drivers/spi/atmel-quadspi.c | 389 +++++++++++++++------ 2 files changed, 284 insertions(+), 117 deletions(-)
Signature · 1 line
2.9.5
PATCH v4 1/13 spi: atmel-quadspi: cache MR value to avoid a write access
From: Tudor Ambarus <[email protected]>
Set the controller by default in Serial Memory Mode (SMM) at probe. Cache Mode Register (MR) value to avoid write access when setting the controller in serial memory mode at exec_op().
---
v4: s/smm/mr, init controller in serial memory mode by default
v3: update smm value when different. rename mr/smm
v2: cache MR value instead of moving the write access at probe
drivers/spi/atmel-quadspi.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
drivers/spi/atmel-quadspi.c +13 -1
@@ -155,6 +155,7 @@ struct atmel_qspi {struct clk *clk;struct platform_device *pdev;u32 pending; +u32 mr;struct completion cmd_completion; };
@@ -238,7 +239,14 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) icr =QSPI_ICR_INST (op->cmd.opcode); ifr =QSPI_IFR_INSTEN ; -qspi_writel (aq,QSPI_MR ,QSPI_MR_SMM ); +/* +* If the QSPI controller is set in regular SPI mode, set it in +* Serial Memory Mode (SMM). +*/ +if (aq->mr !=QSPI_MR_SMM ) { +qspi_writel (aq,QSPI_MR ,QSPI_MR_SMM ); + aq->mr =QSPI_MR_SMM ; + } mode =find_mode (op);if (mode <0 )
@@ -381,6 +389,10 @@ static int atmel_qspi_init(struct atmel_qspi *aq)/* Reset the QSPI controller */ qspi_writel (aq,QSPI_CR ,QSPI_CR_SWRST ); +/* Set the QSPI controller by default in Serial Memory Mode */ +qspi_writel (aq,QSPI_MR ,QSPI_MR_SMM ); + aq->mr =QSPI_MR_SMM ; +/* Enable the QSPI controller */ qspi_writel (aq,QSPI_CR ,QSPI_CR_QSPIEN );
Signature · 1 line
2.9.5
Re: [PATCH v4 01/13] spi: atmel-quadspi: cache MR value to avoid a write access
Quoted 7 lines · On Mon, 4 Feb 2019 10:09:22 +0000 <[email protected]> wrote:
From: Tudor Ambarus <[email protected]>
Set the controller by default in Serial Memory Mode (SMM) at probe. Cache Mode Register (MR) value to avoid write access when setting the controller in serial memory mode at
exec_op().Signed-off-by Tudor Ambarus <[email protected]>
Quoted 47 lines
---
v4: s/smm/mr, init controller in serial memory mode by default
v3: update smm value when different. rename mr/smm
v2: cache MR value instead of moving the write access at probedrivers/spi/atmel-quadspi.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)drivers/spi/atmel-quadspi.c +13
-1@@ -155,6 +155,7 @@ struct atmel_qspi {struct clk *clk;struct platform_device *pdev;u32 pending; +u32 mr;struct completion cmd_completion; };@@ -238,7 +239,14 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) icr =QSPI_ICR_INST (op->cmd.opcode); ifr =QSPI_IFR_INSTEN ; -qspi_writel (aq,QSPI_MR ,QSPI_MR_SMM ); +/* +* If the QSPI controller is set in regular SPI mode, set it in +* Serial Memory Mode (SMM). +*/ +if (aq->mr !=QSPI_MR_SMM ) { +qspi_writel (aq,QSPI_MR ,QSPI_MR_SMM ); + aq->mr =QSPI_MR_SMM ; + } mode =find_mode (op);if (mode <0 )@@ -381,6 +389,10 @@ static int atmel_qspi_init(struct atmel_qspi *aq)/* Reset the QSPI controller */ qspi_writel (aq,QSPI_CR ,QSPI_CR_SWRST ); +/* Set the QSPI controller by default in Serial Memory Mode */ +qspi_writel (aq,QSPI_MR ,QSPI_MR_SMM ); + aq->mr =QSPI_MR_SMM ; +/* Enable the QSPI controller */ qspi_writel (aq,QSPI_CR ,QSPI_CR_QSPIEN );
PATCH v4 2/13 spi: atmel-quadspi: order header files inclusion alphabetically
In reply to [email protected]From: Tudor Ambarus <[email protected]>
Cosmetic change, no functional change.
---
v4: no change
v3: no change
v2: collect R-b
drivers/spi/atmel-quadspi.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/spi/atmel-quadspi.c +4 -5
@@ -22,16 +22,15 @@* This driver is based on drivers/mtd/spi-nor/fsl-quadspi.c from Freescale. */ -#include <linux/kernel.h> #include <linux/clk.h> -#include <linux/module.h> -#include <linux/platform_device.h> #include <linux/delay.h> #include <linux/err.h> #include <linux/interrupt.h> -#include <linux/of.h> -#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> #include <linux/spi/spi-mem.h> /* QSPI register offsets */
Signature · 1 line
2.9.5
PATCH v4 3/13 spi: atmel-quadspi: drop wrappers for iomem accesses
In reply to [email protected]From: Tudor Ambarus <[email protected]>
The wrappers hid that the accesses are relaxed. Drop them.
---
v4:
- drop local variable that kept aq->regs, the compiler should be smart enough to store it in a register
- collect R-b
v3: no change
v2: new patch
drivers/spi/atmel-quadspi.c | 45 +++++++++++++++++---------------------------- 1 file changed, 17 insertions(+), 28 deletions(-)
drivers/spi/atmel-quadspi.c +17 -28
@@ -175,17 +175,6 @@ static const struct qspi_mode sama5d2_qspi_modes[] = { { 4, 4, 4, QSPI_IFR_WIDTH_QUAD_CMD }, }; -/* Register access functions */ -static inline u32 qspi_readl (struct atmel_qspi *aq,u32 reg) -{ -return readl_relaxed (aq->regs + reg); -} - -static inline void qspi_writel (struct atmel_qspi *aq,u32 reg,u32 value) -{ -writel_relaxed (value, aq->regs + reg); -} -static inline bool is_compatible (const struct spi_mem_op *op,const struct qspi_mode *mode) {
@@ -243,7 +232,7 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)* Serial Memory Mode (SMM). */ if (aq->mr !=QSPI_MR_SMM ) { -qspi_writel (aq,QSPI_MR ,QSPI_MR_SMM ); +writel_relaxed (QSPI_MR_SMM , aq->regs +QSPI_MR ); aq->mr =QSPI_MR_SMM ; }
@@ -303,17 +292,17 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) ifr |=QSPI_IFR_TFRTYP_TRSFR_WRITE ;/* Clear pending interrupts */ - (void )qspi_readl (aq,QSPI_SR ); + (void )readl_relaxed (aq->regs +QSPI_SR );/* Set QSPI Instruction Frame registers */ -qspi_writel (aq,QSPI_IAR , iar); -qspi_writel (aq,QSPI_ICR , icr); -qspi_writel (aq,QSPI_IFR , ifr); +writel_relaxed (iar, aq->regs +QSPI_IAR ); +writel_relaxed (icr, aq->regs +QSPI_ICR ); +writel_relaxed (ifr, aq->regs +QSPI_IFR );/* Skip to the final steps if there is no data */ if (op->data.nbytes) {/* Dummy read of QSPI_IFR to synchronize APB and AHB accesses */ - (void )qspi_readl (aq,QSPI_IFR ); + (void )readl_relaxed (aq->regs +QSPI_IFR );/* Send/Receive data */ if (op->data.dir ==SPI_MEM_DATA_IN )
@@ -324,22 +313,22 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) op->data.buf.out, op->data.nbytes);/* Release the chip-select */ -qspi_writel (aq,QSPI_CR ,QSPI_CR_LASTXFER ); +writel_relaxed (QSPI_CR_LASTXFER , aq->regs +QSPI_CR ); }/* Poll INSTRuction End status */ - sr =qspi_readl (aq,QSPI_SR ); + sr =readl_relaxed (aq->regs +QSPI_SR );if ((sr &QSPI_SR_CMD_COMPLETED ) ==QSPI_SR_CMD_COMPLETED )return err;/* Wait for INSTRuction End interrupt */ reinit_completion (&aq->cmd_completion); aq->pending = sr &QSPI_SR_CMD_COMPLETED ; -qspi_writel (aq,QSPI_IER ,QSPI_SR_CMD_COMPLETED ); +writel_relaxed (QSPI_SR_CMD_COMPLETED , aq->regs +QSPI_IER );if (!wait_for_completion_timeout (&aq->cmd_completion,msecs_to_jiffies (1000 ))) err = -ETIMEDOUT ; -qspi_writel (aq,QSPI_IDR ,QSPI_SR_CMD_COMPLETED ); +writel_relaxed (QSPI_SR_CMD_COMPLETED , aq->regs +QSPI_IDR );return err; }
@@ -378,7 +367,7 @@ static int atmel_qspi_setup(struct spi_device *spi) scbr--; scr =QSPI_SCR_SCBR (scbr); -qspi_writel (aq,QSPI_SCR , scr); +writel_relaxed (scr, aq->regs +QSPI_SCR );return 0 ; }
@@ -386,14 +375,14 @@ static int atmel_qspi_setup(struct spi_device *spi)static int atmel_qspi_init (struct atmel_qspi *aq) {/* Reset the QSPI controller */ -qspi_writel (aq,QSPI_CR ,QSPI_CR_SWRST ); +writel_relaxed (QSPI_CR_SWRST , aq->regs +QSPI_CR );/* Set the QSPI controller by default in Serial Memory Mode */ -qspi_writel (aq,QSPI_MR ,QSPI_MR_SMM ); +writel_relaxed (QSPI_MR_SMM , aq->regs +QSPI_MR ); aq->mr =QSPI_MR_SMM ;/* Enable the QSPI controller */ -qspi_writel (aq,QSPI_CR ,QSPI_CR_QSPIEN ); +writel_relaxed (QSPI_CR_QSPIEN , aq->regs +QSPI_CR );return 0 ; }
@@ -403,8 +392,8 @@ static irqreturn_t atmel_qspi_interrupt(int irq, void *dev_id)struct atmel_qspi *aq = (struct atmel_qspi *)dev_id;u32 status, mask, pending; - status =qspi_readl (aq,QSPI_SR ); - mask =qspi_readl (aq,QSPI_IMR ); + status =readl_relaxed (aq->regs +QSPI_SR ); + mask =readl_relaxed (aq->regs +QSPI_IMR ); pending = status & mask;if (!pending)
@@ -510,7 +499,7 @@ static int atmel_qspi_remove(struct platform_device *pdev)struct atmel_qspi *aq =spi_controller_get_devdata (ctrl);spi_unregister_controller (ctrl); -qspi_writel (aq,QSPI_CR ,QSPI_CR_QSPIDIS ); +writel_relaxed (QSPI_CR_QSPIDIS , aq->regs +QSPI_CR );clk_disable_unprepare (aq->clk);return 0 ; }
Signature · 1 line
2.9.5
PATCH v4 4/13 spi: atmel-quadspi: fix naming scheme
In reply to [email protected]From: Tudor Ambarus <[email protected]>
Let general names to core drivers.
---
v4: collect R-b
v3: no change
v2: update after the removing of iomem access wrappers
drivers/spi/atmel-quadspi.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/spi/atmel-quadspi.c +8 -8
@@ -158,14 +158,14 @@ struct atmel_qspi {struct completion cmd_completion; }; -struct qspi_mode { +struct atmel_qspi_mode {u8 cmd_buswidth;u8 addr_buswidth;u8 data_buswidth;u32 config; }; -static const struct qspi_mode sama5d2_qspi_modes[] = { +static const struct atmel_qspi_mode sama5d2_qspi_modes[] = { {1 ,1 ,1 ,QSPI_IFR_WIDTH_SINGLE_BIT_SPI }, {1 ,1 ,2 ,QSPI_IFR_WIDTH_DUAL_OUTPUT }, {1 ,1 ,4 ,QSPI_IFR_WIDTH_QUAD_OUTPUT },
@@ -175,8 +175,8 @@ static const struct qspi_mode sama5d2_qspi_modes[] = { { 4, 4, 4, QSPI_IFR_WIDTH_QUAD_CMD }, }; -static inline bool is_compatible (const struct spi_mem_op *op, -const struct qspi_mode *mode) +static inline bool atmel_qspi_is_compatible (const struct spi_mem_op *op, +const struct atmel_qspi_mode *mode) {if (op->cmd.buswidth != mode->cmd_buswidth)return false;
@@ -190,12 +190,12 @@ static inline bool is_compatible(const struct spi_mem_op *op,return true; } -static int find_mode (const struct spi_mem_op *op) +static int atmel_qspi_find_mode (const struct spi_mem_op *op) {u32 i;for (i =0 ; i <ARRAY_SIZE (sama5d2_qspi_modes); i++) -if (is_compatible (op, &sama5d2_qspi_modes[i])) +if (atmel_qspi_is_compatible (op, &sama5d2_qspi_modes[i]))return i;return -1 ;
@@ -204,7 +204,7 @@ static int find_mode(const struct spi_mem_op *op)static bool atmel_qspi_supports_op (struct spi_mem *mem,const struct spi_mem_op *op) { -if (find_mode (op) <0 ) +if (atmel_qspi_find_mode (op) <0 )return false;/* special case not supported by hardware */
@@ -236,7 +236,7 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) aq->mr =QSPI_MR_SMM ; } - mode =find_mode (op); + mode =atmel_qspi_find_mode (op);if (mode <0 )return -ENOTSUPP ;
Signature · 1 line
2.9.5
PATCH v4 5/13 spi: atmel-quadspi: remove unnecessary cast
In reply to [email protected]From: Tudor Ambarus <[email protected]>
The cast is done implicitly.
---
v4: no change
v3: no change
v2: collect R-b
drivers/spi/atmel-quadspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/atmel-quadspi.c +1 -1
@@ -389,7 +389,7 @@ static int atmel_qspi_init(struct atmel_qspi *aq)static irqreturn_t atmel_qspi_interrupt (int irq,void *dev_id) { -struct atmel_qspi *aq = (struct atmel_qspi *)dev_id; +struct atmel_qspi *aq = dev_id;u32 status, mask, pending; status =readl_relaxed (aq->regs +QSPI_SR );
Signature · 1 line
2.9.5
PATCH v4 6/13 spi: atmel-quadspi: return appropriate error code
In reply to [email protected]From: Tudor Ambarus <[email protected]>
Return -ENOTSUPP when atmel_qspi_find_mode() fails. Propagate the error in atmel_qspi_exec_op().
---
v4: no change
v3: no change
v2: collect R-b
drivers/spi/atmel-quadspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/atmel-quadspi.c +2 -2
@@ -198,7 +198,7 @@ static int atmel_qspi_find_mode(const struct spi_mem_op *op)if (atmel_qspi_is_compatible (op, &sama5d2_qspi_modes[i]))return i; -return -1 ; +return -ENOTSUPP ; } static bool atmel_qspi_supports_op(struct spi_mem *mem,
@@ -238,7 +238,7 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) mode =atmel_qspi_find_mode (op);if (mode <0 ) -return -ENOTSUPP ; +return mode; ifr |= sama5d2_qspi_modes[mode].config;
Signature · 1 line
2.9.5
PATCH v4 7/13 spi: atmel-quadspi: switch to SPDX license identifiers
In reply to [email protected]From: Tudor Ambarus <[email protected]>
Adopt the SPDX license identifiers to ease license compliance management.
---
v4: no change
v3: no change
v2: collect R-b
drivers/spi/atmel-quadspi.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)
drivers/spi/atmel-quadspi.c +1 -12
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * Driver for Atmel QSPI Controller *
@@ -7,18 +8,6 @@* Author: Cyrille Pitchen <[email protected]> * Author: Piotr Bugalski <[email protected]> * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -* -* This program is distributed in the hope that it will be useful, but WITHOUT -* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or -* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for -* more details. -* -* You should have received a copy of the GNU General Public License along with -* this program. If not, see <http://www.gnu.org/licenses/>. -* * This driver is based on drivers/mtd/spi-nor/fsl-quadspi.c from Freescale. */
Signature · 1 line
2.9.5
PATCH v4 8/13 spi: atmel-quadspi: rework transfer macros
In reply to [email protected]From: Tudor Ambarus <[email protected]>
Split the TFRTYP_TRSFR_ bitfields in 2: one bit encoding the mem/reg transfer type and one bit encoding the direction of the transfer (read/write).
Remove NOP when setting read transfer type. Remove useless setting of write transfer type whenop->data.dir == SPI_MEM_DATA_IN && !op->data.nbytes.
QSPI_IFR_TFRTYP_TRSFR_WRITE is specific just to sama5d2 qspi, rename it to QSPI_IFR_SAMA5D2_WRITE_TRSFR.
---
v4: introduce QSPI_IFR_TFRTYP_MEM, reword commit
v3: new patch
drivers/spi/atmel-quadspi.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)
drivers/spi/atmel-quadspi.c +4 -9
@@ -113,11 +113,8 @@#define QSPI_IFR_OPTL_4BIT (2 << 8)#define QSPI_IFR_OPTL_8BIT (3 << 8)#define QSPI_IFR_ADDRL BIT(10) -#define QSPI_IFR_TFRTYP_MASK GENMASK(13, 12) -#define QSPI_IFR_TFRTYP_TRSFR_READ (0 << 12) -#define QSPI_IFR_TFRTYP_TRSFR_READ_MEM (1 << 12) -#define QSPI_IFR_TFRTYP_TRSFR_WRITE (2 << 12) -#define QSPI_IFR_TFRTYP_TRSFR_WRITE_MEM (3 << 13) +#define QSPI_IFR_TFRTYP_MEM BIT(12) +#define QSPI_IFR_SAMA5D2_WRITE_TRSFR BIT(13)#define QSPI_IFR_CRM BIT(14)#define QSPI_IFR_NBDUM_MASK GENMASK(20, 16)#define QSPI_IFR_NBDUM (n) (((n) << 16) & QSPI_IFR_NBDUM_MASK)
@@ -275,10 +272,8 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)if (op->data.nbytes) ifr |=QSPI_IFR_DATAEN ; -if (op->data.dir ==SPI_MEM_DATA_IN && op->data.nbytes) - ifr |=QSPI_IFR_TFRTYP_TRSFR_READ ; -else - ifr |=QSPI_IFR_TFRTYP_TRSFR_WRITE ; +if (op->data.dir ==SPI_MEM_DATA_OUT ) + ifr |=QSPI_IFR_SAMA5D2_WRITE_TRSFR ;/* Clear pending interrupts */ (void )readl_relaxed (aq->regs +QSPI_SR );
Signature · 1 line
2.9.5
Re: [PATCH v4 08/13] spi: atmel-quadspi: rework transfer macros
Quoted 10 lines · On Mon, 4 Feb 2019 10:09:53 +0000 <[email protected]> wrote:
From: Tudor Ambarus <[email protected]>
Split the
TFRTYP_TRSFR_bitfields in 2: one bit encoding the mem/reg transfer type and one bit encoding the direction of the transfer (read/write).Remove NOP when setting read transfer type. Remove useless setting of write transfer type when
op->data.dir==SPI_MEM_DATA_IN&& !op->data.nbytes.
Quoted 5 lines
QSPI_IFR_TFRTYP_TRSFR_WRITEis specific just to sama5d2 qspi, rename it toQSPI_IFR_SAMA5D2_WRITE_TRSFR.Suggested-by Boris Brezillon <[email protected]>Signed-off-by Tudor Ambarus <[email protected]>
Quoted 38 lines
---
v4: introduceQSPI_IFR_TFRTYP_MEM, reword commit
v3: new patchdrivers/spi/atmel-quadspi.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)drivers/spi/atmel-quadspi.c +4
-9@@ -113,11 +113,8 @@#define QSPI_IFR_OPTL_4BIT (2 << 8)#define QSPI_IFR_OPTL_8BIT (3 << 8)#define QSPI_IFR_ADDRL BIT(10) -#define QSPI_IFR_TFRTYP_MASK GENMASK(13, 12) -#define QSPI_IFR_TFRTYP_TRSFR_READ (0 << 12) -#define QSPI_IFR_TFRTYP_TRSFR_READ_MEM (1 << 12) -#define QSPI_IFR_TFRTYP_TRSFR_WRITE (2 << 12) -#define QSPI_IFR_TFRTYP_TRSFR_WRITE_MEM (3 << 13) +#define QSPI_IFR_TFRTYP_MEM BIT(12) +#define QSPI_IFR_SAMA5D2_WRITE_TRSFR BIT(13)#define QSPI_IFR_CRM BIT(14)#define QSPI_IFR_NBDUM_MASK GENMASK(20, 16)#define QSPI_IFR_NBDUM (n) (((n) << 16) & QSPI_IFR_NBDUM_MASK)@@ -275,10 +272,8 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)if (op->data.nbytes) ifr |=QSPI_IFR_DATAEN ; -if (op->data.dir ==SPI_MEM_DATA_IN && op->data.nbytes) - ifr |=QSPI_IFR_TFRTYP_TRSFR_READ ; -else - ifr |=QSPI_IFR_TFRTYP_TRSFR_WRITE ; +if (op->data.dir ==SPI_MEM_DATA_OUT ) + ifr |=QSPI_IFR_SAMA5D2_WRITE_TRSFR ;/* Clear pending interrupts */ (void )readl_relaxed (aq->regs +QSPI_SR );
PATCH v4 9/13 dt-bindings: spi: atmel-quadspi: update example to new clock binding
In reply to [email protected]From: Tudor Ambarus <[email protected]>
Introduced in:
commit b60557876849 ("ARM: dts: at91: sama5d2: switch to new clock binding")
---
v4: no change
v3: new patch
Documentation/devicetree/bindings/spi/atmel-quadspi.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/spi/atmel-quadspi.txt +1 -1
@@ -19,7 +19,7 @@ spi@f0020000 { reg = <0xf0020000 0x100>, <0xd0000000 0x8000000>; reg-names = "qspi_base", "qspi_mmap"; interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>; - clocks = <&spi0_clk>; + clocks = <&pmc PMC_TYPE_PERIPHERAL 52>; #address-cells = <1>; #size-cells = <0>; pinctrl-names = "default";
Signature · 1 line
2.9.5
PATCH v4 10/13 dt-bindings: spi: atmel-quadspi: make "pclk" mandatory
In reply to [email protected]From: Tudor Ambarus <[email protected]>
Naming clocks is a good practice. Make "pclk" madatory even if we support unnamed clock in the driver, to be backward compatible with old DTs.
---
v4: add missing semicolon, collect R-b
v3: new patch
Documentation/devicetree/bindings/spi/atmel-quadspi.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/spi/atmel-quadspi.txt +2 -0
@@ -9,6 +9,7 @@ Required properties: - qspi_mmap: memory mapped address space - interrupts: Should contain the interrupt for the device. - clocks: The phandle of the clock needed by the QSPI controller. +- clock-names: Should contain "pclk" for the peripheral clock. - #address-cells: Should be <1>. - #size-cells: Should be <0>.
@@ -20,6 +21,7 @@ spi@f0020000 { reg-names = "qspi_base", "qspi_mmap"; interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&pmc PMC_TYPE_PERIPHERAL 52>; + clock-names = "pclk"; #address-cells = <1>; #size-cells = <0>; pinctrl-names = "default";
Signature · 1 line
2.9.5
PATCH v4 11/13 spi: atmel-quadspi: add support for named peripheral clock
In reply to [email protected]From: Tudor Ambarus <[email protected]>
Naming clocks is a good practice. Keep supporting unnamed peripheral clock, to be backward compatible with old DTs. While here, rename clk to pclk, to indicate that it is a peripheral clock.
---
v4: collect R-b
v3: new patch
drivers/spi/atmel-quadspi.c | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-)
drivers/spi/atmel-quadspi.c +18 -15
@@ -137,7 +137,7 @@struct atmel_qspi {void __iomem *regs;void __iomem *mem; -struct clk *clk; +struct clk *pclk;struct platform_device *pdev;u32 pending;u32 mr;
@@ -341,7 +341,7 @@ static int atmel_qspi_setup(struct spi_device *spi)if (!spi->max_speed_hz)return -EINVAL ; - src_rate =clk_get_rate (aq->clk); + src_rate =clk_get_rate (aq->pclk);if (!src_rate)return -EINVAL ;
@@ -433,15 +433,18 @@ static int atmel_qspi_probe(struct platform_device *pdev) }/* Get the peripheral clock */ - aq->clk =devm_clk_get (&pdev->dev,NULL ); -if (IS_ERR (aq->clk)) { + aq->pclk =devm_clk_get (&pdev->dev,"pclk" ); +if (IS_ERR (aq->pclk)) + aq->pclk =devm_clk_get (&pdev->dev,NULL ); + +if (IS_ERR (aq->pclk)) {dev_err (&pdev->dev,"missing peripheral clock\n" ); - err =PTR_ERR (aq->clk); + err =PTR_ERR (aq->pclk); goto exit; }/* Enable the peripheral clock */ - err =clk_prepare_enable (aq->clk); + err =clk_prepare_enable (aq->pclk);if (err) {dev_err (&pdev->dev,"failed to enable the peripheral clock\n" ); goto exit;
@@ -452,25 +455,25 @@ static int atmel_qspi_probe(struct platform_device *pdev)if (irq <0 ) {dev_err (&pdev->dev,"missing IRQ\n" ); err = irq; - goto disable_clk; + goto disable_pclk; } err =devm_request_irq (&pdev->dev, irq, atmel_qspi_interrupt,0 ,dev_name (&pdev->dev), aq);if (err) - goto disable_clk; + goto disable_pclk; err =atmel_qspi_init (aq);if (err) - goto disable_clk; + goto disable_pclk; err =spi_register_controller (ctrl);if (err) - goto disable_clk; + goto disable_pclk;return 0 ; -disable_clk: -clk_disable_unprepare (aq->clk); +disable_pclk: +clk_disable_unprepare (aq->pclk); exit:spi_controller_put (ctrl);
@@ -484,7 +487,7 @@ static int atmel_qspi_remove(struct platform_device *pdev)spi_unregister_controller (ctrl);writel_relaxed (QSPI_CR_QSPIDIS , aq->regs +QSPI_CR ); -clk_disable_unprepare (aq->clk); +clk_disable_unprepare (aq->pclk);return 0 ; }
@@ -492,7 +495,7 @@ static int __maybe_unused atmel_qspi_suspend(struct device *dev) {struct atmel_qspi *aq =dev_get_drvdata (dev); -clk_disable_unprepare (aq->clk); +clk_disable_unprepare (aq->pclk);return 0 ; }
@@ -501,7 +504,7 @@ static int __maybe_unused atmel_qspi_resume(struct device *dev) {struct atmel_qspi *aq =dev_get_drvdata (dev); -clk_prepare_enable (aq->clk); +clk_prepare_enable (aq->pclk);return atmel_qspi_init (aq); }
Signature · 1 line
2.9.5
PATCH v4 12/13 dt-bindings: spi: atmel-quadspi: QuadSPI driver for Microchip SAM9X60
In reply to [email protected]From: Tudor Ambarus <[email protected]>
The sam9x60 qspi controller uses 2 clocks, one for the peripheral register access, the other for the qspi core and phy. Both are mandatory.
---
v4: collect R-b
v3: "pclk" was made mandatory in previous patch. Reword clock descriptions.
v2:
- make "pclk" mandatory even for sama5d2. Unnamed clk will be supported in the driver.
- drop unneeded example
Documentation/devicetree/bindings/spi/atmel-quadspi.txt | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/spi/atmel-quadspi.txt +7 -3
@@ -1,15 +1,19 @@ * Atmel Quad Serial Peripheral Interface (QSPI) Required properties: -- compatible: Should be "atmel,sama5d2-qspi". +- compatible: Should be one of the following: + - "atmel,sama5d2-qspi" + - "microchip,sam9x60-qspi" - reg: Should contain the locations and lengths of the base registers and the mapped memory. - reg-names: Should contain the resource reg names: - qspi_base: configuration register address space - qspi_mmap: memory mapped address space - interrupts: Should contain the interrupt for the device. -- clocks: The phandle of the clock needed by the QSPI controller. -- clock-names: Should contain "pclk" for the peripheral clock. +- clocks: Should reference the peripheral clock and the QSPI system + clock if available. +- clock-names: Should contain "pclk" for the peripheral clock and "qspick" + for the system clock when available. - #address-cells: Should be <1>. - #size-cells: Should be <0>.
Signature · 1 line
2.9.5
PATCH v4 13/13 spi: atmel-quadspi: add support for sam9x60 qspi controller
In reply to [email protected]From: Tudor Ambarus <[email protected]>
The sam9x60 qspi controller uses 2 clocks, one for the peripheral register access, the other for the qspi core and phy. Both are mandatory. It uses different transfer type bits in IFR register. It has dedicated registers to specify a read or a write instruction: Read Instruction Code Register (RICR) and Write Instruction Code Register (WICR). ICR/RICR/WICR have identical fields.
Tested with sst26vf064b jedec,spi-nor flash. Backward compatibility test done on sama5d2 qspi controller and mx25l25635e jedec,spi-nor flash.
---
v4:
- drop local variables that kept aq->regs and &pdev->dev, the compiler should be smart enough to store them in a register
- add comment saying QSPI_IFR_APBTFRTYP_READ is defined in sam9x60
- s/sama5d2_qspi_modes/atmel_qspi_modes, modes are the same both controllers
- fix kernel doc header
- move comment in function body
v3:
- reorganize the code and change ops functions pointers to avoid code duplication. From the IP perspective, the transfer type bits are different, and what registers are written: ricr/wicr instead of icr.
- treat just regular spi transfers. Mem transfers will be added together with dirmap support.
v2:
- rework clock handling
- reorder setting of register values in set_cfg() calls -> move functions that can fail in the upper part of the function body.
drivers/spi/atmel-quadspi.c | 282 +++++++++++++++++++++++++++++++++++--------- 1 file changed, 228 insertions(+), 54 deletions(-)
drivers/spi/atmel-quadspi.c +228 -54
@@ -19,6 +19,7 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/of_platform.h> #include <linux/platform_device.h> #include <linux/spi/spi-mem.h>
@@ -35,7 +36,9 @@#define QSPI_IAR 0x0030/* Instruction Address Register */ #define QSPI_ICR 0x0034/* Instruction Code Register */ +#define QSPI_WICR 0x0034/* Write Instruction Code Register */ #define QSPI_IFR 0x0038/* Instruction Frame Register */ +#define QSPI_RICR 0x003C/* Read Instruction Code Register */ #define QSPI_SMR 0x0040/* Scrambling Mode Register */ #define QSPI_SKR 0x0044/* Scrambling Key Register */
@@ -88,7 +91,7 @@#define QSPI_SCR_DLYBS_MASK GENMASK(23, 16)#define QSPI_SCR_DLYBS (n) (((n) << 16) & QSPI_SCR_DLYBS_MASK) -/* Bitfields in QSPI_ICR (Instruction Code Register) */ +/* Bitfields in QSPI_ICR (Read/Write Instruction Code Register) */ #define QSPI_ICR_INST_MASK GENMASK(7, 0)#define QSPI_ICR_INST (inst) (((inst) << 0) & QSPI_ICR_INST_MASK)#define QSPI_ICR_OPT_MASK GENMASK(23, 16)
@@ -118,6 +121,7 @@#define QSPI_IFR_CRM BIT(14)#define QSPI_IFR_NBDUM_MASK GENMASK(20, 16)#define QSPI_IFR_NBDUM (n) (((n) << 16) & QSPI_IFR_NBDUM_MASK) +#define QSPI_IFR_APBTFRTYP_READ BIT(24)/* Defined in SAM9X60 */ /* Bitfields in QSPI_SMR (Scrambling Mode Register) */ #define QSPI_SMR_SCREN BIT(0)
@@ -134,16 +138,40 @@#define QSPI_WPSR_WPVSRC (src) (((src) << 8) & QSPI_WPSR_WPVSRC) +/* Describes register values. */ +struct atmel_qspi_cfg { +u32 icr; +u32 iar; +u32 ifr; +}; + +struct atmel_qspi_caps ; +struct atmel_qspi {void __iomem *regs;void __iomem *mem;struct clk *pclk; +struct clk *qspick;struct platform_device *pdev; +const struct atmel_qspi_caps *caps;u32 pending;u32 mr;struct completion cmd_completion; }; +struct atmel_qspi_ops { +void (*set_tfrtyp)(const struct spi_mem_op *op, +struct atmel_qspi_cfg *cfg); +void (*write_regs)(const struct atmel_qspi *aq, +const struct spi_mem_op *op, +const struct atmel_qspi_cfg *cfg); +}; + +struct atmel_qspi_caps { +const struct atmel_qspi_ops *ops; +bool has_qspick; +}; +struct atmel_qspi_mode {u8 cmd_buswidth;u8 addr_buswidth;
@@ -151,7 +179,7 @@ struct atmel_qspi_mode {u32 config; }; -static const struct atmel_qspi_mode sama5d2_qspi_modes[] = { +static const struct atmel_qspi_mode atmel_qspi_modes[] = { {1 ,1 ,1 ,QSPI_IFR_WIDTH_SINGLE_BIT_SPI }, {1 ,1 ,2 ,QSPI_IFR_WIDTH_DUAL_OUTPUT }, {1 ,1 ,4 ,QSPI_IFR_WIDTH_QUAD_OUTPUT },
@@ -180,8 +208,8 @@ static int atmel_qspi_find_mode(const struct spi_mem_op *op) {u32 i; -for (i =0 ; i <ARRAY_SIZE (sama5d2_qspi_modes); i++) -if (atmel_qspi_is_compatible (op, &sama5d2_qspi_modes[i])) +for (i =0 ; i <ARRAY_SIZE (atmel_qspi_modes); i++) +if (atmel_qspi_is_compatible (op, &atmel_qspi_modes[i]))return i;return -ENOTSUPP ;
@@ -201,63 +229,69 @@ static bool atmel_qspi_supports_op(struct spi_mem *mem,return true; } -static int atmel_qspi_exec_op (struct spi_mem *mem,const struct spi_mem_op *op) +static int atmel_qspi_set_mode (struct atmel_qspi_cfg *cfg, +const struct spi_mem_op *op) { -struct atmel_qspi *aq =spi_controller_get_devdata (mem->spi->master); -int mode; -u32 dummy_cycles =0 ; -u32 iar, icr, ifr, sr; -int err =0 ; - - iar =0 ; - icr =QSPI_ICR_INST (op->cmd.opcode); - ifr =QSPI_IFR_INSTEN ; - -/* -* If the QSPI controller is set in regular SPI mode, set it in -* Serial Memory Mode (SMM). -*/ -if (aq->mr !=QSPI_MR_SMM ) { -writel_relaxed (QSPI_MR_SMM , aq->regs +QSPI_MR ); - aq->mr =QSPI_MR_SMM ; - } +int mode =atmel_qspi_find_mode (op); - mode =atmel_qspi_find_mode (op);if (mode <0 )return mode; + cfg->ifr = atmel_qspi_modes[mode].config; +return 0 ; +} - ifr |= sama5d2_qspi_modes[mode].config; +/** +* atmel_qspi_set_address_mode() - set address mode. +* @cfg: contains register values +* @op: describes a SPI memory operation +*/ +static int atmel_qspi_set_address_mode (struct atmel_qspi_cfg *cfg, +const struct spi_mem_op *op) +{ +u32 dummy_cycles =0 ;if (op->dummy.buswidth && op->dummy.nbytes) dummy_cycles = op->dummy.nbytes *8 / op->dummy.buswidth; +/* +* The controller allows 24 and 32-bit addressing while NAND-flash +* requires 16-bit long. Handling 8-bit long addresses is done using +* the option field. For the 16-bit addresses, the workaround depends +* of the number of requested dummy bits. If there are 8 or more dummy +* cycles, the address is shifted and sent with the first dummy byte. +* Otherwise opcode is disabled and the first byte of the address +* contains the command opcode (works only if the opcode and address +* use the same buswidth). The limitation is when the 16-bit address is +* used without enough dummy cycles and the opcode is using a different +* buswidth than the address. +*/ if (op->addr.buswidth) {switch (op->addr.nbytes) {case 0 :break ;case 1 : - ifr |=QSPI_IFR_OPTEN |QSPI_IFR_OPTL_8BIT ; - icr |=QSPI_ICR_OPT (op->addr.val &0xff ); + cfg->ifr |=QSPI_IFR_OPTEN |QSPI_IFR_OPTL_8BIT ; + cfg->icr =QSPI_ICR_OPT (op->addr.val &0xff );break ;case 2 :if (dummy_cycles <8 / op->addr.buswidth) { - ifr &= ~QSPI_IFR_INSTEN ; - ifr |=QSPI_IFR_ADDREN ; - iar = (op->cmd.opcode <<16 ) | - (op->addr.val &0xffff ); + cfg->ifr &= ~QSPI_IFR_INSTEN ; + cfg->ifr |=QSPI_IFR_ADDREN ; + cfg->iar = (op->cmd.opcode <<16 ) | + (op->addr.val &0xffff ); }else { - ifr |=QSPI_IFR_ADDREN ; - iar = (op->addr.val <<8 ) &0xffffff ; + cfg->ifr |=QSPI_IFR_ADDREN ; + cfg->iar = (op->addr.val <<8 ) &0xffffff ; dummy_cycles -=8 / op->addr.buswidth; }break ;case 3 : - ifr |=QSPI_IFR_ADDREN ; - iar = op->addr.val &0xffffff ; + cfg->ifr |=QSPI_IFR_ADDREN ; + cfg->iar = op->addr.val &0xffffff ;break ;case 4 : - ifr |=QSPI_IFR_ADDREN |QSPI_IFR_ADDRL ; - iar = op->addr.val &0x7ffffff ; + cfg->ifr |=QSPI_IFR_ADDREN |QSPI_IFR_ADDRL ; + cfg->iar = op->addr.val &0x7ffffff ;break ;default :return -ENOTSUPP ;
@@ -266,22 +300,100 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)/* Set number of dummy cycles */ if (dummy_cycles) - ifr |=QSPI_IFR_NBDUM (dummy_cycles); + cfg->ifr |=QSPI_IFR_NBDUM (dummy_cycles); -/* Set data enable */ -if (op->data.nbytes) - ifr |=QSPI_IFR_DATAEN ; +return 0 ; +} +static void atmel_qspi_sama5d2_set_tfrtyp (const struct spi_mem_op *op, +struct atmel_qspi_cfg *cfg) +{if (op->data.dir ==SPI_MEM_DATA_OUT ) - ifr |=QSPI_IFR_SAMA5D2_WRITE_TRSFR ; + cfg->ifr |=QSPI_IFR_SAMA5D2_WRITE_TRSFR ; +} +static void atmel_qspi_sama5d2_write_regs (const struct atmel_qspi *aq, +const struct spi_mem_op *op, +const struct atmel_qspi_cfg *cfg) +{/* Clear pending interrupts */ (void )readl_relaxed (aq->regs +QSPI_SR );/* Set QSPI Instruction Frame registers */ -writel_relaxed (iar, aq->regs +QSPI_IAR ); -writel_relaxed (icr, aq->regs +QSPI_ICR ); -writel_relaxed (ifr, aq->regs +QSPI_IFR ); +writel_relaxed (cfg->iar, aq->regs +QSPI_IAR ); +writel_relaxed (cfg->icr, aq->regs +QSPI_ICR ); +writel_relaxed (cfg->ifr, aq->regs +QSPI_IFR ); +} + +static void atmel_qspi_sam9x60_set_tfrtyp (const struct spi_mem_op *op, +struct atmel_qspi_cfg *cfg) +{ +if (!op->addr.nbytes && op->data.dir ==SPI_MEM_DATA_IN ) + cfg->ifr |=QSPI_IFR_APBTFRTYP_READ ; +} + +static void atmel_qspi_sam9x60_write_regs (const struct atmel_qspi *aq, +const struct spi_mem_op *op, +const struct atmel_qspi_cfg *cfg) +{ +/* Clear pending interrupts */ + (void )readl_relaxed (aq->regs +QSPI_SR ); + +/* Set QSPI Instruction Frame registers */ +writel_relaxed (cfg->iar, aq->regs +QSPI_IAR ); +if (op->data.dir ==SPI_MEM_DATA_IN ) +writel_relaxed (cfg->icr, aq->regs +QSPI_RICR ); +else +writel_relaxed (cfg->icr, aq->regs +QSPI_ICR ); +writel_relaxed (cfg->ifr, aq->regs +QSPI_IFR ); +} + +static int atmel_qspi_set_cfg (struct atmel_qspi *aq, +const struct spi_mem_op *op, +struct atmel_qspi_cfg *cfg) +{ +int ret; + +/* +* If the QSPI controller is set in regular SPI mode, set it in +* Serial Memory Mode (SMM). +*/ +if (aq->mr !=QSPI_MR_SMM ) { +writel_relaxed (QSPI_MR_SMM , aq->regs +QSPI_MR ); + aq->mr =QSPI_MR_SMM ; + } + + ret =atmel_qspi_set_mode (cfg, op); +if (ret) +return ret; + + ret =atmel_qspi_set_address_mode (cfg, op); +if (ret) +return ret; + + cfg->ifr |=QSPI_IFR_INSTEN ; + cfg->icr |=QSPI_ICR_INST (op->cmd.opcode); + +/* Set data enable */ +if (op->data.nbytes) + cfg->ifr |=QSPI_IFR_DATAEN ; + + aq->caps->ops->set_tfrtyp (op, cfg); + aq->caps->ops->write_regs (aq, op, cfg); + +return 0 ; +} + +static int atmel_qspi_exec_op (struct spi_mem *mem,const struct spi_mem_op *op) +{ +struct atmel_qspi *aq =spi_controller_get_devdata (mem->spi->master); +struct atmel_qspi_cfg cfg = {0 }; +u32 sr; +int err; + + err =atmel_qspi_set_cfg (aq, op, &cfg); +if (err) +return err;/* Skip to the final steps if there is no data */ if (op->data.nbytes) {
@@ -290,11 +402,11 @@ static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op)/* Send/Receive data */ if (op->data.dir ==SPI_MEM_DATA_IN ) -_memcpy_fromio (op->data.buf.in, - aq->mem + iar, op->data.nbytes); +_memcpy_fromio (op->data.buf.in, aq->mem + cfg.iar, + op->data.nbytes);else -_memcpy_toio (aq->mem + iar, - op->data.buf.out, op->data.nbytes); +_memcpy_toio (aq->mem + cfg.iar, op->data.buf.out, + op->data.nbytes);/* Release the chip-select */ writel_relaxed (QSPI_CR_LASTXFER , aq->regs +QSPI_CR );
@@ -395,8 +507,20 @@ static int atmel_qspi_probe(struct platform_device *pdev)struct spi_controller *ctrl;struct atmel_qspi *aq;struct resource *res; +const struct atmel_qspi_caps *caps;int irq, err =0 ; + caps =of_device_get_match_data (&pdev->dev); +if (!caps) { +dev_err (&pdev->dev,"Could not retrieve QSPI caps\n" ); +return -EINVAL ; + } + +if (!caps->ops->set_tfrtyp || !caps->ops->write_regs) { +dev_err (&pdev->dev,"Could not retrieve QSPI ops\n" ); +return -EINVAL ; + } + ctrl =spi_alloc_master (&pdev->dev,sizeof (*aq));if (!ctrl)return -ENOMEM ;
@@ -413,6 +537,7 @@ static int atmel_qspi_probe(struct platform_device *pdev)init_completion (&aq->cmd_completion); aq->pdev = pdev; + aq->caps = caps;/* Map the registers */ res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"qspi_base" );
@@ -450,28 +575,48 @@ static int atmel_qspi_probe(struct platform_device *pdev) goto exit; } +if (caps->has_qspick) { +/* Get the QSPI system clock */ + aq->qspick =devm_clk_get (&pdev->dev,"qspick" ); +if (IS_ERR (aq->qspick)) { +dev_err (&pdev->dev,"missing system clock\n" ); + err =PTR_ERR (aq->qspick); + goto disable_pclk; + } + +/* Enable the QSPI system clock */ + err =clk_prepare_enable (aq->qspick); +if (err) { +dev_err (&pdev->dev, +"failed to enable the QSPI system clock\n" ); + goto disable_pclk; + } + } +/* Request the IRQ */ irq =platform_get_irq (pdev,0 );if (irq <0 ) {dev_err (&pdev->dev,"missing IRQ\n" ); err = irq; - goto disable_pclk; + goto disable_qspick; } err =devm_request_irq (&pdev->dev, irq, atmel_qspi_interrupt,0 ,dev_name (&pdev->dev), aq);if (err) - goto disable_pclk; + goto disable_qspick; err =atmel_qspi_init (aq);if (err) - goto disable_pclk; + goto disable_qspick; err =spi_register_controller (ctrl);if (err) - goto disable_pclk; + goto disable_qspick;return 0 ; +disable_qspick: +clk_disable_unprepare (aq->qspick); disable_pclk:clk_disable_unprepare (aq->pclk); exit:
@@ -487,6 +632,7 @@ static int atmel_qspi_remove(struct platform_device *pdev)spi_unregister_controller (ctrl);writel_relaxed (QSPI_CR_QSPIDIS , aq->regs +QSPI_CR ); +clk_disable_unprepare (aq->qspick);clk_disable_unprepare (aq->pclk);return 0 ; }
@@ -495,6 +641,7 @@ static int __maybe_unused atmel_qspi_suspend(struct device *dev) {struct atmel_qspi *aq =dev_get_drvdata (dev); +clk_disable_unprepare (aq->qspick);clk_disable_unprepare (aq->pclk);return 0 ;
@@ -505,6 +652,7 @@ static int __maybe_unused atmel_qspi_resume(struct device *dev)struct atmel_qspi *aq =dev_get_drvdata (dev);clk_prepare_enable (aq->pclk); +clk_prepare_enable (aq->qspick);return atmel_qspi_init (aq); }
@@ -512,8 +660,34 @@ static int __maybe_unused atmel_qspi_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(atmel_qspi_pm_ops, atmel_qspi_suspend, atmel_qspi_resume); +static const struct atmel_qspi_ops atmel_sama5d2_qspi_ops = { + .set_tfrtyp = atmel_qspi_sama5d2_set_tfrtyp, + .write_regs = atmel_qspi_sama5d2_write_regs, +}; + +static const struct atmel_qspi_caps atmel_sama5d2_qspi_caps = { + .ops = &atmel_sama5d2_qspi_ops, +}; + +static const struct atmel_qspi_ops atmel_sam9x60_qspi_ops = { + .set_tfrtyp = atmel_qspi_sam9x60_set_tfrtyp, + .write_regs = atmel_qspi_sam9x60_write_regs, +}; + +static const struct atmel_qspi_caps atmel_sam9x60_qspi_caps = { + .ops = &atmel_sam9x60_qspi_ops, + .has_qspick = true, +}; +static const struct of_device_id atmel_qspi_dt_ids[] = { - { .compatible ="atmel,sama5d2-qspi" }, + { + .compatible ="atmel,sama5d2-qspi" , + .data = &atmel_sama5d2_qspi_caps, + }, + { + .compatible ="microchip,sam9x60-qspi" , + .data = &atmel_sam9x60_qspi_caps, + }, {/* sentinel */ } };
Signature · 1 line
2.9.5
Re: [PATCH v4 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller
Quoted 4 lines · On Mon, 4 Feb 2019 10:10:21 +0000 <[email protected]> wrote:
drivers/spi/atmel-quadspi.c +4
-0+ +static void atmel_qspi_sam9x60_write_regs (const struct atmel_qspi *aq, +const struct spi_mem_op *op, +const struct atmel_qspi_cfg *cfg)
drivers/spi/atmel-quadspi.c static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) · line 347
Quoted 10 lines
drivers/spi/atmel-quadspi.c +10
-0+{ +/* Clear pending interrupts */ + (void )readl_relaxed (aq->regs +QSPI_SR ); + +/* Set QSPI Instruction Frame registers */ +writel_relaxed (cfg->iar, aq->regs +QSPI_IAR ); +if (op->data.dir ==SPI_MEM_DATA_IN ) +writel_relaxed (cfg->icr, aq->regs +QSPI_RICR ); +else +writel_relaxed (cfg->icr, aq->regs +QSPI_ICR );
Can you use WICR here (even if ICR == WICR)?
Review
Quoted 2 lines
(quoted diff) +2
-0+ writel_relaxed(cfg->ifr, aq->regs + QSPI_IFR); +}
Hm, so the only difference we have is the RICR vs ICR reg and the APBTFRTYP_READ vs SAMA5D2_WRITE_TRSFR bit. Not sure it deserves creating 2 hooks for that. Can we have something like ->has_ricr in the caps and then have an if/else block directly in atmel_qspi_set_cfg()?
Re: [PATCH v4 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller
Quoted 19 lines · Boris Brezillon
Quoted 4 lines · On Mon, 4 Feb 2019 10:10:21 +0000 <[email protected]> wrote:
drivers/spi/atmel-quadspi.c +4
-0+ +static void atmel_qspi_sam9x60_write_regs (const struct atmel_qspi *aq, +const struct spi_mem_op *op, +const struct atmel_qspi_cfg *cfg)drivers/spi/atmel-quadspi.c static int atmel_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) · line 347
Quoted 10 lines
drivers/spi/atmel-quadspi.c +10
-0+{ +/* Clear pending interrupts */ + (void )readl_relaxed (aq->regs +QSPI_SR ); + +/* Set QSPI Instruction Frame registers */ +writel_relaxed (cfg->iar, aq->regs +QSPI_IAR ); +if (op->data.dir ==SPI_MEM_DATA_IN ) +writel_relaxed (cfg->icr, aq->regs +QSPI_RICR ); +else +writel_relaxed (cfg->icr, aq->regs +QSPI_ICR );Can you use WICR here (even if ICR == WICR)?
yes, good catch.
Quoted 10 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+ writel_relaxed(cfg->ifr, aq->regs + QSPI_IFR); +}Hm, so the only difference we have is the RICR vs ICR reg and the
APBTFRTYP_READvsSAMA5D2_WRITE_TRSFRbit. Not sure it deserves creating 2 hooks for that. Can we have something like ->has_ricr in the caps and then have an if/else block directly inatmel_qspi_set_cfg()?
Correct. It is a cost of an extra if, I tried to avoid it. I like it better with these two hooks, but if you have a strong opinion I'll do it, just confirm it again.
Thanks,
ta
Re: [PATCH v4 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller
Quoted 11 lines · On Mon, 4 Feb 2019 14:28:27 +0000 <[email protected]> wrote:
Quoted 10 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+ writel_relaxed(cfg->ifr, aq->regs + QSPI_IFR); +}Hm, so the only difference we have is the RICR vs ICR reg and the
APBTFRTYP_READvsSAMA5D2_WRITE_TRSFRbit. Not sure it deserves creating 2 hooks for that. Can we have something like ->has_ricr in the caps and then have an if/else block directly inatmel_qspi_set_cfg()?
Quoted 2 lines
Correct. It is a cost of an extra if, I tried to avoid it. I like it better with these two hooks, but if you have a strong opinion I'll do it, just confirm it again.
The cost of an indirect call is actually higher than an extra if/else block. I'm not against paying this extra cost when implementations are completely different, but that does not seem to be the case here. Moreover, if you get rid of these hooks, you can also get rid of the cfg struct.