Skip to content

spi: atmel-quadspi: introduce sam9x60 qspi controller

[email protected] linux-arm-kernel linux-devicetree linux-mtd linux-spi lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest13 patches 5 repliesIn review
  2. v513 patches 1 replySuperseded
  3. v413 patches 5 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v313 patches17 repliesSuperseded
v210 patches8 repliesSuperseded
v19 patches17 repliesSuperseded

v5 from the cover letter

- use WICR for sam9x60
- remove ops hooks and introduce caps->has_ricr
- get rid of the cfg struct
- group IO accesses together in atmel_qspi_set_cfg()

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13spi: atmel-quadspi: cache MR value to avoid a write accessdrivers/spi/atmel-quadspi.c+13 -13 replies
2/13spi: atmel-quadspi: order header files inclusion alphabeticallydrivers/spi/atmel-quadspi.c+4 -50 replies
3/13spi: atmel-quadspi: drop wrappers for iomem accessesdrivers/spi/atmel-quadspi.c+17 -280 replies
4/13spi: atmel-quadspi: fix naming schemedrivers/spi/atmel-quadspi.c+8 -80 replies
5/13spi: atmel-quadspi: remove unnecessary castdrivers/spi/atmel-quadspi.c+1 -10 replies
6/13spi: atmel-quadspi: return appropriate error codedrivers/spi/atmel-quadspi.c+2 -20 replies
7/13spi: atmel-quadspi: switch to SPDX license identifiersdrivers/spi/atmel-quadspi.c+1 -120 replies
8/13spi: atmel-quadspi: rework transfer macrosdrivers/spi/atmel-quadspi.c+4 -90 replies
9/13dt-bindings: spi: atmel-quadspi: update example to new clock bindingDocumentation/devicetree/bindings/spi/atmel-quadspi.txt+1 -10 replies
10/13dt-bindings: spi: atmel-quadspi: make "pclk" mandatoryDocumentation/devicetree/bindings/spi/atmel-quadspi.txt+2 -00 replies
11/13spi: atmel-quadspi: add support for named peripheral clockdrivers/spi/atmel-quadspi.c+18 -150 replies
12/13dt-bindings: spi: atmel-quadspi: QuadSPI driver for Microchip SAM9X60Documentation/devicetree/bindings/spi/atmel-quadspi.txt+7 -30 replies
13/13spi: atmel-quadspi: add support for sam9x60 qspi controllerdrivers/spi/atmel-quadspi.c+128 -352 replies

Reviews trailers per patch

12 of 13 patches have a Reviewed-by or Acked-by.

PatchBoris Brezillon
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/13] spi: atmel-quadspi: introduce sam9x60 qspi controller

From: Tudor Ambarus <[email protected]>

Patches from 1 to 11 are minor fixes or cosmetics. Patches 12 and 13 introduce the sam9x60 qspi controller.

sam9x60 qspi controller tested with sst26vf064b jedec,spi-nor flash. Backward compatibility test done on sama5d2 qspi controller and mx25l25635e jedec,spi-nor flash.

v6: patch 13/13: add a caps instance to the sama5d2 entry instead of allowing caps to be NULL

v5:
- use WICR for sam9x60
- remove ops hooks and introduce caps->has_ricr
- get rid of the cfg struct
- group IO accesses together in atmel_qspi_set_cfg()

v4:
- s/smm/mr, init controller in serial memory mode by default
- drop local variables that kept aq->regs and &pdev->dev, the compiler should be smart enough to store them in a register
- introduce QSPI_IFR_TFRTYP_MEM
- add comment saying QSPI_IFR_APBTFRTYP_READ is defined in sam9x60
- s/sama5d2_qspi_modes/atmel_qspi_modes, modes are the same both controllers
- fix kernel doc header
- move comment in function body
- collect R-b tags

v3:
- update smm value when different.
- treat just regular spi transfers when introducing sam9x60 qspi IP. Mem transfers will be added together with dirmap support.
- reorganize the code and change ops functions pointers to avoid code duplication.
- rename aq->clk to aq->pclk to indicate that it's a peripheral clock.
- drop unused and NOP transfer macros.
- add Suggested-by tags, reword some commits.

v2:
- cache MR value,
- drop iomem wrappers,
- make "pclk" clock-name mandatory even for sama5d2,
- rework clock handling,
- reorder setting of register values in set_cfg() calls,
- collect R-b tags.

Tudor Ambarus (13):
spi: atmel-quadspi: cache MR value to avoid a write access
spi: atmel-quadspi: order header files inclusion alphabetically
spi: atmel-quadspi: drop wrappers for iomem accesses
spi: atmel-quadspi: fix naming scheme
spi: atmel-quadspi: remove unnecessary cast
spi: atmel-quadspi: return appropriate error code
spi: atmel-quadspi: switch to SPDX license identifiers
spi: atmel-quadspi: rework transfer macros
dt-bindings: spi: atmel-quadspi: update example to new clock binding
dt-bindings: spi: atmel-quadspi: make "pclk" mandatory
spi: atmel-quadspi: add support for named peripheral clock
dt-bindings: spi: atmel-quadspi: QuadSPI driver for Microchip SAM9X60
spi: atmel-quadspi: add support for sam9x60 qspi controller

 .../devicetree/bindings/spi/atmel-quadspi.txt      |  12 +-
 drivers/spi/atmel-quadspi.c                        | 270 +++++++++++++--------
 2 files changed, 184 insertions(+), 98 deletions(-)
Signature · 1 line
2.9.5