arm: exynos: Fix reboot on Odroid HC1
Subsystems (2)
Krzysztof Kozlowski
maintainerv2 cover arm: exynos: Fix reboot on Odroid HC1
Hi,
Changes since v1
================
1. Move fixes to beginning of patchset.
2. Patch 3: Rework the idea - split revision detection to be executed later.
3. Patch 4: New patch.
4. Patch 6: Apply Simon's comments.
5. Patch 6: Do not delay when changing voltage if regulator is disabled.
6. Patch 6: Do not delay when disabling the regulator.
Description
===========
Odroid HC1 does not reboot properly (at least from SD card but I do not expect difference on eMMC), if LDO4/VDD_ADC was turned off by Linux kernel. This condition happens so far always, because Linux kernel did not enable ADC on Odroid HC1, therefore the VDD_ADC regulator was turned off as unused.
The issue is in detection of revision which later is used to load proper DTB.
The revision is obtained by ADC read of a voltage depending on VDD_ADC. Therefore:
1. VDD_ADC has to be turned on (but board detection happens before power is initialized),
2. Turning VDD_ADC should wait with ramp delay,
3. Reading the value from ADC should wait for it to stabilize.
Tested on Odroid XU3-Lite and Odroid HC1.
Commends and testing are welcomed.
Best regards,
Krzysztof
Krzysztof Kozlowski (9):
adc: exynos-adc: Fix wrong bit operation used to stop the ADC
power: regulator: s2mps11: Fix step for LDO27 and LDO35
arm: exynos: Detect revision later, when all resources are ready
arm: exynos: odroid-xu3: Display info late to have proper type
arm: exynos: Wait till ADC stabilizes before checking Odroid HC1
revision
regulator: Add support for ramp delay
power: regulator: s2mps11: Add enable delay
arm: dts: exynos: Add supply for ADC block to Odroid XU3 family
arm: dts: exynos: Add ramp delay property to LDO regulators to Odroid
XU3 family
arch/arm/dts/exynos5422-odroidxu3.dts | 20 +++++++ board/samsung/common/board.c | 15 ++++- board/samsung/common/exynos5-dt-types.c | 58 +++++++++++++++++-- board/samsung/odroid/odroid.c | 8 +++ configs/odroid-xu3_defconfig | 2 + .../regulator/regulator.txt | 2 + drivers/adc/exynos-adc.c | 2 +- drivers/power/regulator/regulator-uclass.c | 47 ++++++++++++++- drivers/power/regulator/s2mps11_regulator.c | 13 ++++- include/power/regulator.h | 2 + include/samsung/misc.h | 1 + 11 files changed, 160 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH v2 1/9 adc: exynos-adc: Fix wrong bit operation used to stop the ADC
When stopping the ADC_V2_CON1_STC_EN should be cleared.
--- drivers/adc/exynos-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/adc/exynos-adc.c +1 -1
@@ -62,7 +62,7 @@ int exynos_adc_stop(struct udevice *dev)/* Stop conversion */ cfg =readl (®s->con1); - cfg |= ~ADC_V2_CON1_STC_EN ; + cfg &= ~ADC_V2_CON1_STC_EN ;writel (cfg, ®s->con1);
Signature · 1 line
2.17.1
PATCH v2 1/9 adc: exynos-adc: Fix wrong bit operation used to stop the ADC
Quoted 12 lines · On Wed, 13 Feb 2019 17:46:40 +0100 Krzysztof Kozlowski <[email protected]> wrote:
When stopping the
ADC_V2_CON1_STC_ENshould be cleared.Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/adc/exynos-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/adc/exynos-adc.c +0
-0
drivers/adc/exynos-adc.c int exynos_adc_stop(struct udevice *dev) · line 68
Quoted 8 lines
drivers/adc/exynos-adc.c +1
-1@@ -62,7 +62,7 @@ int exynos_adc_stop(struct udevice *dev)/* Stop conversion */ cfg =readl (®s->con1); - cfg |= ~ADC_V2_CON1_STC_EN ; + cfg &= ~ADC_V2_CON1_STC_EN ;writel (cfg, ®s->con1);
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190215/8afc7bde/attachment.sig>
Krzysztof Kozlowski
maintainerPATCH v2 2/9 power: regulator: s2mps11: Fix step for LDO27 and LDO35
In reply to Krzysztof KozlowskiLDO27 and LDO35 have 25 mV step, not 50 mV.
--- drivers/power/regulator/s2mps11_regulator.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/power/regulator/s2mps11_regulator.c +4 -0
@@ -346,6 +346,8 @@ static int s2mps11_ldo_hex2volt(int ldo, int hex)case 11 :case 22 :case 23 : +case 27 : +case 35 : uV = hex *S2MPS11_LDO_STEP +S2MPS11_LDO_UV_MIN ;break ;default :
@@ -366,6 +368,8 @@ static int s2mps11_ldo_volt2hex(int ldo, int uV)case 11 :case 22 :case 23 : +case 27 : +case 35 : hex = (uV -S2MPS11_LDO_UV_MIN ) /S2MPS11_LDO_STEP ;break ;default :
Signature · 1 line
2.17.1
PATCH v2 2/9 power: regulator: s2mps11: Fix step for LDO27 and LDO35
Quoted 21 lines · On Wed, 13 Feb 2019 17:46:41 +0100 Krzysztof Kozlowski <[email protected]> wrote:
LDO27 and LDO35 have 25 mV step, not 50 mV.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/power/regulator/s2mps11_regulator.c | 4 ++++ 1 file changed, 4 insertions(+)(quoted diff) +0
-0
b/drivers/power/regulator/s2mps11_regulator.cindexced504eb1476..723d27f67c9a100644 ---a/drivers/power/regulator/s2mps11_regulator.c+++b/drivers/power/regulator/s2mps11_regulator.c@@ -346,6 +346,8 @@ static ints2mps11_ldo_hex2volt(int ldo, int hex)case 11:drivers/power/regulator/s2mps11_regulator.c +2
-0case 22 :case 23 : +case 27 : +case 35 : uV = hex *S2MPS11_LDO_STEP +S2MPS11_LDO_UV_MIN ;break ;default :
drivers/power/regulator/s2mps11_regulator.c static int s2mps11_ldo_volt2hex(int ldo, int uV) · line 375
Quoted 8 lines
drivers/power/regulator/s2mps11_regulator.c +2
-0@@ -366,6 +368,8 @@ static int s2mps11_ldo_volt2hex(int ldo, int uV)case 11 :case 22 :case 23 : +case 27 : +case 35 : hex = (uV -S2MPS11_LDO_UV_MIN ) /S2MPS11_LDO_STEP ;break ;default :
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190215/f93ebed3/attachment.sig>
Krzysztof Kozlowski
maintainerPATCH v2 3/9 arm: exynos: Detect revision later, when all resources are ready
In reply to Krzysztof KozlowskiDetection of board revision is done early - before power setup. In case of Odroid XU3/XU4/HC1 family, the detection is done using ADC which is supplied by LDO4/VDD_ADC regulator. This regulator could be turned off (e.g. by kernel before reboot). If ADC is used early, the regulators are not yet available and the detection won't work.
Split the revision detection out of set_board_type() into separate function called later - either when displaying board info or during misc_init_r (whatever succeeds first). The idea is that set_board_type() will be called early so its method of detection are limited to flattened device tree (exynos5-dt-types.c for Exynos5) or GPIO (odroid.c for Exynos4412). The newly added set_board_revision() can be called only later, when resources like regulator are available.
This is necessary to fix the detection of Odroid HC1 after reboot, if kernel turned off the LDO4 regulator.
--- board/samsung/common/board.c | 13 ++++++++++++- board/samsung/common/exynos5-dt-types.c | 20 +++++++++++++++++--- board/samsung/odroid/odroid.c | 8 ++++++++ include/samsung/misc.h | 1 + 4 files changed, 38 insertions(+), 4 deletions(-)
board/samsung/common/board.c +12 -1
@@ -253,7 +253,12 @@ int board_eth_init(bd_t *bis)int checkboard (void ) {if (IS_ENABLED (CONFIG_BOARD_TYPES )) { -const char *board_info =get_board_type (); +const char *board_info; + +/* Printing type requires having revision */ +set_board_revision (); + + board_info =get_board_type ();if (board_info)printf ("Type: %s\n" , board_info);
@@ -287,6 +292,12 @@ int board_late_init(void)#ifdef CONFIG_MISC_INIT_R int misc_init_r (void ) { +/* +* At this point regulators should be available so do full +* revision detection +*/ +set_board_revision (); +#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG set_board_info ();#endif
board/samsung/common/exynos5-dt-types.c +17 -3
@@ -192,8 +192,11 @@ const char *get_board_type(void)/** * set_board_type() - set board type in gd->board_type. -* As default type set EXYNOS5_BOARD_GENERIC, if detect Odroid, -* then set its proper type. +* As default type set EXYNOS5_BOARD_GENERIC. If Odroid is detected, +* set its proper type based on device tree. +* +* This might be called early when some more specific ways to detect revision +* are not yet available. */ void set_board_type (void ) {
@@ -211,8 +214,19 @@ void set_board_type(void) gd->board_type = of_match->data;break ; } +} + +/** +* set_board_revision() - set detailed board type in gd->board_type. +* Should be called when resources (e.g. regulators) are available +* so ADC can be used to detect the specific revision of a board. +*/ +void set_board_revision (void ) +{ +/* Do not detect revision twice */ +if (gd->board_type ==EXYNOS5_BOARD_GENERIC ) +return ; -/* If Odroid, then check its revision */ if (board_is_odroidxu3 ()) gd->board_type =odroid_get_board_type (); }
board/samsung/odroid/odroid.c +8 -0
@@ -54,6 +54,14 @@ void set_board_type(void) gd->board_type =ODROID_TYPE_U3 ; } +void set_board_revision (void ) +{ +/* +* Revision already set by set_board_type() because it can be +* executed early. +*/ +} +const char *get_board_type (void ) {const char *board_type[] = {"u3" ,"x2" };
include/samsung/misc.h +1 -0
@@ -33,6 +33,7 @@ char *get_dfu_alt_system(char *interface, char *devstr);char *get_dfu_alt_boot (char *interface,char *devstr);#endif void set_board_type (void ); +void set_board_revision (void );const char *get_board_type (void );#endif /* __SAMSUNG_MISC_COMMON_H__ */
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH v2 4/9 arm: exynos: odroid-xu3: Display info late to have proper type
In reply to Krzysztof KozlowskiFrom: Krzysztof Kozlowski <[email protected]>
Printing the "Type" of board requires proper detection of revision which can happen only late because regulators are needed.
--- board/samsung/common/board.c | 2 +- configs/odroid-xu3_defconfig | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)
board/samsung/common/board.c +1 -1
@@ -249,7 +249,7 @@ int board_eth_init(bd_t *bis)return 0 ; } -#ifdef CONFIG_DISPLAY_BOARDINFO +#if defined(CONFIG_DISPLAY_BOARDINFO ) || defined(CONFIG_DISPLAY_BOARDINFO_LATE )int checkboard (void ) {if (IS_ENABLED (CONFIG_BOARD_TYPES )) {
configs/odroid-xu3_defconfig +2 -0
@@ -11,6 +11,8 @@ CONFIG_FIT=y CONFIG_FIT_BEST_MATCH=y CONFIG_SILENT_CONSOLE=y CONFIG_CONSOLE_MUX=y +# CONFIG_DISPLAY_BOARDINFO is not set +CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_MISC_INIT_R=y CONFIG_SYS_PROMPT="ODROID-XU3 # " CONFIG_CMD_THOR_DOWNLOAD=y
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH v2 4/9 arm: exynos: odroid-xu3: Display info late to have proper type
Quoted 7 lines · Krzysztof Kozlowski
From: Krzysztof Kozlowski <[email protected]>
Printing the "Type" of board requires proper detection of revision which can happen only late because regulators are needed.
Signed-off-by Krzysztof Kozlowski <[email protected]>
I should sent it from my @kernel.org account. I'll fix it in v3 but let me wait for some more comments/review.
Best regards,
Krzysztof
Quoted 38 lines
--- board/samsung/common/board.c | 2 +- configs/odroid-xu3_defconfig | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)board/samsung/common/board.c +1
-1@@ -249,7 +249,7 @@ int board_eth_init(bd_t *bis)return 0 ; } -#ifdef CONFIG_DISPLAY_BOARDINFO +#if defined(CONFIG_DISPLAY_BOARDINFO ) || defined(CONFIG_DISPLAY_BOARDINFO_LATE )int checkboard (void ) {if (IS_ENABLED (CONFIG_BOARD_TYPES )) {configs/odroid-xu3_defconfig +2
-1@@ -11,6 +11,8 @@ CONFIG_FIT=y CONFIG_FIT_BEST_MATCH=y CONFIG_SILENT_CONSOLE=y CONFIG_CONSOLE_MUX=y +# CONFIG_DISPLAY_BOARDINFO is not set +CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_MISC_INIT_R=y CONFIG_SYS_PROMPT="ODROID-XU3 # " CONFIG_CMD_THOR_DOWNLOAD=y --2.17.1
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Krzysztof Kozlowski
maintainerPATCH v2 5/9 arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revision
In reply to Krzysztof KozlowskiFix detection of Odroid HC1 (Exynos5422) after reboot if kernel disabled the LDO4/VDD_ADC regulator.
The LDO4 supplies both ADC block and the ADC input AIN9. Voltage on AIN9 will rise slowly, so be patient and wait for it to stabilize.
First reads on Odroid HC1 return 305, 1207, 1297 and finally 1308 (reference value is 1309).
--- board/samsung/common/exynos5-dt-types.c | 38 ++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)
board/samsung/common/exynos5-dt-types.c +37 -1
@@ -57,12 +57,48 @@ static unsigned int odroid_get_rev(void)return 0 ; } +/* +* Read ADC at least twice and check the resuls. If regulator providing voltage +* on to measured point was just turned on, first reads might require time +* to stabilize. +*/ +static int odroid_get_adc_val (unsigned int *adcval) +{ +unsigned int adcval_prev =0 ; +int ret, retries =20 ; + + ret =adc_channel_single_shot ("adc" ,CONFIG_ODROID_REV_AIN , + &adcval_prev); +if (ret) +return ret; + +while (retries--) { +mdelay (5 ); + + ret =adc_channel_single_shot ("adc" ,CONFIG_ODROID_REV_AIN , + adcval); +if (ret) +return ret; + +/* +* If difference between ADC reads is less than 3%, +* accept the result +*/ +if ((100 *abs (*adcval - adcval_prev) / adcval_prev) <3 ) +return ret; + + adcval_prev = *adcval; + } + +return ret; +} +static int odroid_get_board_type (void ) {unsigned int adcval;int ret, i; - ret =adc_channel_single_shot ("adc" ,CONFIG_ODROID_REV_AIN , &adcval); + ret =odroid_get_adc_val (&adcval);if (ret) goto rev_default;
Signature · 1 line
2.17.1
PATCH v2 5/9 arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revision
Quoted 55 lines · On Wed, 13 Feb 2019 17:46:44 +0100 Krzysztof Kozlowski <[email protected]> wrote:
Fix detection of Odroid HC1 (Exynos5422) after reboot if kernel disabled the LDO4/VDD_ADC regulator.
The LDO4 supplies both ADC block and the ADC input AIN9. Voltage on AIN9 will rise slowly, so be patient and wait for it to stabilize.
First reads on Odroid HC1 return 305, 1207, 1297 and finally 1308 (reference value is 1309).
Signed-off-by Krzysztof Kozlowski <[email protected]>--- board/samsung/common/exynos5-dt-types.c | 38++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)
(quoted diff) +0
-0
b/board/samsung/common/exynos5-dt-types.cindexaf711e727a78..8aed64183837100644 ---a/board/samsung/common/exynos5-dt-types.c+++b/board/samsung/common/exynos5-dt-types.c@@ -57,12 +57,48 @@ static unsigned intodroid_get_rev(void)return 0;
}+/*
+ * Read ADC at least twice and check the resuls. If regulator providing voltage
+ * on to measured point was just turned on, first reads might require time
+ * to stabilize.
+ */board/samsung/common/exynos5-dt-types.c +14
-0+static int odroid_get_adc_val (unsigned int *adcval) +{ +unsigned int adcval_prev =0 ; +int ret, retries =20 ; + + ret =adc_channel_single_shot ("adc" ,CONFIG_ODROID_REV_AIN , + &adcval_prev); +if (ret) +return ret; + +while (retries--) { +mdelay (5 ); + + ret = adc_channel_single_shot("adc",
CONFIG_ODROID_REV_AIN,board/samsung/common/exynos5-dt-types.c +9
-0+ adcval); +if (ret) +return ret; + +/* +* If difference between ADC reads is less than 3%, +* accept the result +*/ + if ((100 * abs(*adcval - adcval_prev) / adcval_prev)< 3)
board/samsung/common/exynos5-dt-types.c static unsigned int odroid_get_rev(void) · line 91
Quoted 4 lines
board/samsung/common/exynos5-dt-types.c +4
-0+return ret; + + adcval_prev = *adcval; + }
Is there in the documentation any required time to wait before reading the ADC value?
If yes then maybe get_timer() based approach shall be used (if get_timer() is available in this context)?
Please see for example drivers/net/fec_mxc.c for how timeouts are handled there.
I will test this patch series on XU3 during the weekend. Thanks for this fix :-)
Quoted 12 lines
board/samsung/common/exynos5-dt-types.c +4
-1+ +return ret; +} +static int odroid_get_board_type (void ) {unsigned int adcval;int ret, i; - ret = adc_channel_single_shot("adc", CONFIG_ODROID_REV_AIN,&adcval);
board/samsung/common/exynos5-dt-types.c static unsigned int odroid_get_rev(void) · line 103
Quoted 3 lines
board/samsung/common/exynos5-dt-types.c +1
-0+ ret =odroid_get_adc_val (&adcval);if (ret) goto rev_default;
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190215/892d52ac/attachment.sig>
Krzysztof Kozlowski
maintainerPATCH v2 5/9 arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revision
Quoted 58 lines · Lukasz Majewski
Quoted 54 lines · On Wed, 13 Feb 2019 17:46:44 +0100 Krzysztof Kozlowski <[email protected]> wrote:
Fix detection of Odroid HC1 (Exynos5422) after reboot if kernel disabled the LDO4/VDD_ADC regulator.
The LDO4 supplies both ADC block and the ADC input AIN9. Voltage on AIN9 will rise slowly, so be patient and wait for it to stabilize.
First reads on Odroid HC1 return 305, 1207, 1297 and finally 1308 (reference value is 1309).
Signed-off-by Krzysztof Kozlowski <[email protected]>--- board/samsung/common/exynos5-dt-types.c | 38++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)
(quoted diff) +0
-0
b/board/samsung/common/exynos5-dt-types.cindexaf711e727a78..8aed64183837100644 ---a/board/samsung/common/exynos5-dt-types.c+++b/board/samsung/common/exynos5-dt-types.c@@ -57,12 +57,48 @@ static unsigned intodroid_get_rev(void)return 0;
}+/*
+ * Read ADC at least twice and check the resuls. If regulator providing voltage
+ * on to measured point was just turned on, first reads might require time
+ * to stabilize.
+ */board/samsung/common/exynos5-dt-types.c +14
-0+static int odroid_get_adc_val (unsigned int *adcval) +{ +unsigned int adcval_prev =0 ; +int ret, retries =20 ; + + ret =adc_channel_single_shot ("adc" ,CONFIG_ODROID_REV_AIN , + &adcval_prev); +if (ret) +return ret; + +while (retries--) { +mdelay (5 ); + + ret = adc_channel_single_shot("adc",
CONFIG_ODROID_REV_AIN,board/samsung/common/exynos5-dt-types.c +9
-0+ adcval); +if (ret) +return ret; + +/* +* If difference between ADC reads is less than 3%, +* accept the result +*/ + if ((100 * abs(*adcval - adcval_prev) / adcval_prev)
Quoted 8 lines
board/samsung/common/exynos5-dt-types.c static unsigned int odroid_get_rev(void) · line 91
Quoted 5 lines
< 3)
board/samsung/common/exynos5-dt-types.c +4
-0+return ret; + + adcval_prev = *adcval; + }Is there in the documentation any required time to wait before reading the ADC value?
No, I think this delay is not SoC specific. The ADC already has proper delay/conversion rounds. The only thing it misses is to wait for 25 cycles of ADC PCLK after SWRESET but I found that adding it does not affect anything. To my understanding this is delay is purely some charging or slow ramp rate (although measuring point is on simple voltage divider...).
Quoted 5 lines
If yes then maybe
get_timer()based approach shall be used (ifget_timer()is available in this context)?Please see for example
drivers/net/fec_mxc.cfor how timeouts are handled there.
I can take a look. First read of ADC might be very early so maybe before times... but I will check if these could be used.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerPATCH v2 5/9 arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revision
In reply to Lukasz MajewskiQuoted 66 lines · Lukasz Majewski
Quoted 55 lines · On Wed, 13 Feb 2019 17:46:44 +0100 Krzysztof Kozlowski <[email protected]> wrote:
Fix detection of Odroid HC1 (Exynos5422) after reboot if kernel disabled the LDO4/VDD_ADC regulator.
The LDO4 supplies both ADC block and the ADC input AIN9. Voltage on AIN9 will rise slowly, so be patient and wait for it to stabilize.
First reads on Odroid HC1 return 305, 1207, 1297 and finally 1308 (reference value is 1309).
Signed-off-by Krzysztof Kozlowski <[email protected]>--- board/samsung/common/exynos5-dt-types.c | 38++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)
(quoted diff) +0
-0
b/board/samsung/common/exynos5-dt-types.cindexaf711e727a78..8aed64183837100644 ---a/board/samsung/common/exynos5-dt-types.c+++b/board/samsung/common/exynos5-dt-types.c@@ -57,12 +57,48 @@ static unsigned intodroid_get_rev(void)return 0;
}+/*
+ * Read ADC at least twice and check the resuls. If regulator providing voltage
+ * on to measured point was just turned on, first reads might require time
+ * to stabilize.
+ */board/samsung/common/exynos5-dt-types.c +14
-0+static int odroid_get_adc_val (unsigned int *adcval) +{ +unsigned int adcval_prev =0 ; +int ret, retries =20 ; + + ret =adc_channel_single_shot ("adc" ,CONFIG_ODROID_REV_AIN , + &adcval_prev); +if (ret) +return ret; + +while (retries--) { +mdelay (5 ); + + ret = adc_channel_single_shot("adc",
CONFIG_ODROID_REV_AIN,board/samsung/common/exynos5-dt-types.c +9
-0+ adcval); +if (ret) +return ret; + +/* +* If difference between ADC reads is less than 3%, +* accept the result +*/ + if ((100 * abs(*adcval - adcval_prev) / adcval_prev)< 3)
board/samsung/common/exynos5-dt-types.c static unsigned int odroid_get_rev(void) · line 91
Quoted 4 lines
board/samsung/common/exynos5-dt-types.c +4
-0+return ret; + + adcval_prev = *adcval; + }Is there in the documentation any required time to wait before reading the ADC value?
Quoted 5 lines
If yes then maybe
get_timer()based approach shall be used (ifget_timer()is available in this context)?Please see for example
drivers/net/fec_mxc.cfor how timeouts are handled there.
I must admit that I do not see benefit of timers...
1. Make code slightly more complicated (instead of simple retries and mdelay()).
2. Introduce no delay by itself so the ADC reads happen one after another. Probing ADC value fast does not work with my approach of waiting till the values get closer to each other...
With timer-based approach, without delay I got:
ADC = 660
ADC = 887
ADC = 1031
ADC = 1125
ADC = 1186
ADC = 1226
ADC = 1253
return - because the difference is too small (<3 %).
I could narrow my threshold to 1%... but then:
ADC = 651
ADC = 881
ADC = 1027
ADC = 1122
ADC = 1184
ADC = 1225
ADC = 1253
ADC = 1271
ADC = 1284
ADC = 1292
I prefer simpler method with delay.
Best regards,
Krzysztof
PATCH v2 5/9 arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revision
Hi Krzysztof,
Quoted 105 lines · Lukasz Majewski
Quoted 69 lines
Quoted 58 lines · On Wed, 13 Feb 2019 17:46:44 +0100 Krzysztof Kozlowski <[email protected]> wrote:
Fix detection of Odroid HC1 (Exynos5422) after reboot if kernel disabled the LDO4/VDD_ADC regulator.
The LDO4 supplies both ADC block and the ADC input AIN9. Voltage on AIN9 will rise slowly, so be patient and wait for it to stabilize.
First reads on Odroid HC1 return 305, 1207, 1297 and finally 1308 (reference value is 1309).
Signed-off-by Krzysztof Kozlowski <[email protected]>--- board/samsung/common/exynos5-dt-types.c | 38++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)
(quoted diff) +0
-0
b/board/samsung/common/exynos5-dt-types.cindexaf711e727a78..8aed64183837100644 ---a/board/samsung/common/exynos5-dt-types.c+++b/board/samsung/common/exynos5-dt-types.c@@ -57,12 +57,48 @@ static unsigned intodroid_get_rev(void)return 0;
}+/*
+ * Read ADC at least twice and check the resuls. If regulator providing voltage
+ * on to measured point was just turned on, first reads might require time
+ * to stabilize.
+ */board/samsung/common/exynos5-dt-types.c +6
-0+static int odroid_get_adc_val (unsigned int *adcval) +{ +unsigned int adcval_prev =0 ; +int ret, retries =20 ; + + ret = adc_channel_single_shot("adc",
CONFIG_ODROID_REV_AIN,board/samsung/common/exynos5-dt-types.c +8
-0+ &adcval_prev); +if (ret) +return ret; + +while (retries--) { +mdelay (5 ); + + ret = adc_channel_single_shot("adc",
CONFIG_ODROID_REV_AIN,board/samsung/common/exynos5-dt-types.c +6
-0+ adcval); +if (ret) +return ret; + +/* +* If difference between ADC reads is less than 3%,
board/samsung/common/exynos5-dt-types.c +3
-0+* accept the result +*/ + if ((100 * abs(*adcval - adcval_prev) /
adcval_prev) < 3)board/samsung/common/exynos5-dt-types.c static unsigned int odroid_get_rev(void) · line 91
Quoted 4 lines
board/samsung/common/exynos5-dt-types.c +4
-0+return ret; + + adcval_prev = *adcval; + }Is there in the documentation any required time to wait before reading the ADC value?
Quoted 5 lines
If yes then maybe
get_timer()based approach shall be used (ifget_timer()is available in this context)?Please see for example
drivers/net/fec_mxc.cfor how timeouts are handled there.I must admit that I do not see benefit of timers...
1. Make code slightly more complicated (instead of simple retries andmdelay()).
2. Introduce no delay by itself so the ADC reads happen one after another. Probing ADC value fast does not work with my approach of waiting till the values get closer to each other...With timer-based approach, without delay I got:
ADC = 660
ADC = 887
ADC = 1031
ADC = 1125
ADC = 1186
ADC = 1226
ADC = 1253
return - because the difference is too small (<3 %).I could narrow my threshold to 1%... but then:
ADC = 651
ADC = 881
ADC = 1027
ADC = 1122
ADC = 1184
ADC = 1225
ADC = 1253
ADC = 1271
ADC = 1284
ADC = 1292
Quoted 1 line
I prefer simpler method with delay.
Ok. I see.
Just please add proper comment /or patch description.
Thanks for your effort :-)
Quoted 4 lines
Best regards,
Krzysztof
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190217/75ba1805/attachment.sig>
Krzysztof Kozlowski
maintainerPATCH v2 6/9 regulator: Add support for ramp delay
In reply to Krzysztof KozlowskiChanging voltage and enabling regulator might require delays so the regulator stabilizes at expected level.
Add support for "regulator-ramp-delay" binding which can introduce required time to both enabling the regulator and to changing the voltage.
--- .../regulator/regulator.txt | 2 + drivers/power/regulator/regulator-uclass.c | 47 ++++++++++++++++++- include/power/regulator.h | 2 + 3 files changed, 49 insertions(+), 2 deletions(-)
doc/device-tree-bindings/regulator/regulator.txt +2 -0
@@ -35,6 +35,7 @@ Optional properties: - regulator-max-microamp: a maximum allowed Current value - regulator-always-on: regulator should never be disabled - regulator-boot-on: enabled by bootloader/firmware +- regulator-ramp-delay: ramp delay for regulator (in uV/us) Note The "regulator-name" constraint is used for setting the device's uclass
@@ -60,4 +61,5 @@ ldo0 { regulator-max-microamp = <100000>; regulator-always-on; regulator-boot-on; + regulator-ramp-delay = <12000>; };
drivers/power/regulator/regulator-uclass.c +45 -2
81 lines not on this page · raw message
include/power/regulator.h +2 -0
@@ -150,6 +150,7 @@ enum regulator_flag {* @always_on* - bool type, true or false * @boot_on* - bool type, true or false * TODO(sjg at chromium.org): Consider putting the above two into @flags +* @ramp_delay - Time to settle down after voltage change (unit: uV/us) * @flags: - flags value (see REGULATOR_FLAG_...) * @name** - fdt regulator name - should be taken from the device tree * ctrl_reg: - Control register offset used to enable/disable regulator
@@ -169,6 +170,7 @@ struct dm_regulator_uclass_platdata {int max_uV;int min_uA;int max_uA; +unsigned int ramp_delay;bool always_on;bool boot_on;const char *name;
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH v2 7/9 power: regulator: s2mps11: Add enable delay
In reply to Krzysztof KozlowskiAccording to datasheet, the output on LDO regulators will start appearing after 10-15 us.
--- drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/power/regulator/s2mps11_regulator.c +8 -1
@@ -551,7 +551,14 @@ static int ldo_get_enable(struct udevice *dev)static int ldo_set_enable (struct udevice *dev,bool enable) { -return s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable); +int ret; + + ret =s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable); + +/* Wait the "enable delay" for voltage to start to rise */ +udelay (15 ); + +return ret; }static int ldo_get_mode (struct udevice *dev)
Signature · 1 line
2.17.1
PATCH v2 7/9 power: regulator: s2mps11: Add enable delay
Quoted 16 lines · On Wed, 13 Feb 2019 17:46:46 +0100 Krzysztof Kozlowski <[email protected]> wrote:
According to datasheet, the output on LDO regulators will start appearing after 10-15 us.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/power/regulator/s2mps11_regulator.cindex723d27f67c9a..1f1581852ee2100644 ---a/drivers/power/regulator/s2mps11_regulator.c+++b/drivers/power/regulator/s2mps11_regulator.c@@ -551,7 +551,14 @@ static intldo_get_enable(struct udevice *dev)
static intldo_set_enable(struct udevice *dev, bool enable){
drivers/power/regulator/s2mps11_regulator.c static int ldo_get_enable(struct udevice *dev) · line 559
Quoted 7 lines
drivers/power/regulator/s2mps11_regulator.c +6
-1-return s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable); +int ret; + + ret =s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable); + +/* Wait the "enable delay" for voltage to start to rise */ +udelay (15 );
Isn't the enable delay provided/read from dts?
Or is it too early to have dtb parsed?
The udelay(15) seems a bit "magic" value (or is it specified in the PMIC manual?).
drivers/power/regulator/s2mps11_regulator.c static int ldo_get_enable(struct udevice *dev) · line 564
Quoted 5 lines
drivers/power/regulator/s2mps11_regulator.c +2
-0+ +return ret; }static int ldo_get_mode (struct udevice *dev)
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190215/03795187/attachment.sig>
Krzysztof Kozlowski
maintainerPATCH v2 7/9 power: regulator: s2mps11: Add enable delay
Quoted 22 lines · Lukasz Majewski
Quoted 18 lines · On Wed, 13 Feb 2019 17:46:46 +0100 Krzysztof Kozlowski <[email protected]> wrote:
According to datasheet, the output on LDO regulators will start appearing after 10-15 us.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/power/regulator/s2mps11_regulator.cindex723d27f67c9a..1f1581852ee2100644 ---a/drivers/power/regulator/s2mps11_regulator.c+++b/drivers/power/regulator/s2mps11_regulator.c@@ -551,7 +551,14 @@ static intldo_get_enable(struct udevice *dev)
static intldo_set_enable(struct udevice *dev, bool enable){drivers/power/regulator/s2mps11_regulator.c +1
-1-return s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable); +int ret;
Quoted 8 lines
drivers/power/regulator/s2mps11_regulator.c static int ldo_get_enable(struct udevice *dev) · line 559
Quoted 5 lines
drivers/power/regulator/s2mps11_regulator.c +5
-0+ + ret =s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable); + +/* Wait the "enable delay" for voltage to start to rise */ +udelay (15 );Isn't the enable delay provided/read from dts?
Or is it too early to have dtb parsed?
We could read it from DTB... but I would need to add new property just for that. I can... just more commits for simple stuff :)
Quoted 2 lines
The udelay(15) seems a bit "magic" value (or is it specified in the PMIC manual?).
Yeah, it is magic value mentioned in PMIC manual (actually - 10-15 us). It is the same as ramp delay - PMIC specific value.
Best regards,
Krzysztof
PATCH v2 7/9 power: regulator: s2mps11: Add enable delay
Hi Krzysztof,
Quoted 32 lines · Lukasz Majewski
Quoted 22 lines
Quoted 18 lines · On Wed, 13 Feb 2019 17:46:46 +0100 Krzysztof Kozlowski <[email protected]> wrote:
According to datasheet, the output on LDO regulators will start appearing after 10-15 us.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/power/regulator/s2mps11_regulator.cindex723d27f67c9a..1f1581852ee2100644 ---a/drivers/power/regulator/s2mps11_regulator.c+++b/drivers/power/regulator/s2mps11_regulator.c@@ -551,7 +551,14 @@ static intldo_get_enable(struct udevice *dev)
static intldo_set_enable(struct udevice *dev, bool enable){drivers/power/regulator/s2mps11_regulator.c +1
-1-return s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable); +int ret;Quoted 8 lines
drivers/power/regulator/s2mps11_regulator.c static int ldo_get_enable(struct udevice *dev) · line 559
Quoted 5 lines
drivers/power/regulator/s2mps11_regulator.c +5
-0+ + ret =s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable); + +/* Wait the "enable delay" for voltage to start to rise */ +udelay (15 );Isn't the enable delay provided/read from dts?
Or is it too early to have dtb parsed?
Quoted 2 lines
We could read it from DTB... but I would need to add new property just for that. I can... just more commits for simple stuff :)
No, lets keep simple things simple :-). No need for extra DTB property.
Quoted 6 lines
Quoted 3 lines
The udelay(15) seems a bit "magic" value (or is it specified in the PMIC manual?).
Yeah, it is magic value mentioned in PMIC manual (actually - 10-15 us). It is the same as ramp delay - PMIC specific value.
Ok, If it is in the manual then we shall stick to it (and vendor just stated - delay for 15ms).
Quoted 3 lines
Best regards,
Krzysztof
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190215/dbe847a0/attachment.sig>
PATCH v2 7/9 power: regulator: s2mps11: Add enable delay
In reply to Krzysztof KozlowskiHi Krzysztof,
Quoted 14 lines · Krzysztof Kozlowski
According to datasheet, the output on LDO regulators will start appearing after 10-15 us.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)drivers/power/regulator/s2mps11_regulator.c +0
-0
drivers/power/regulator/s2mps11_regulator.c static int ldo_get_enable(struct udevice *dev) · line 556
Quoted 7 lines
drivers/power/regulator/s2mps11_regulator.c +3
-1@@ -551,7 +551,14 @@ static int ldo_get_enable(struct udevice *dev)static int ldo_set_enable (struct udevice *dev,bool enable) { -return s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable); +int ret; + + ret =s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable);
How about:
if (ret)
return ret;
drivers/power/regulator/s2mps11_regulator.c static int ldo_get_enable(struct udevice *dev) · line 561
Quoted 5 lines
drivers/power/regulator/s2mps11_regulator.c +5
-0+ +/* Wait the "enable delay" for voltage to start to rise */ +udelay (15 ); + +return ret;
return 0;
Quoted 6 lines
drivers/power/regulator/s2mps11_regulator.c +0
-1}static int ldo_get_mode (struct udevice *dev) --2.17.1
Regards,
Simon
Krzysztof Kozlowski
maintainerPATCH v2 7/9 power: regulator: s2mps11: Add enable delay
Quoted 27 lines · Simon Glass
Hi Krzysztof,
Quoted 14 lines · Krzysztof Kozlowski
According to datasheet, the output on LDO regulators will start appearing after 10-15 us.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)drivers/power/regulator/s2mps11_regulator.c +0
-0drivers/power/regulator/s2mps11_regulator.c static int ldo_get_enable(struct udevice *dev) · line 556
Quoted 7 lines
drivers/power/regulator/s2mps11_regulator.c +3
-1@@ -551,7 +551,14 @@ static int ldo_get_enable(struct udevice *dev)static int ldo_set_enable (struct udevice *dev,bool enable) { -return s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable); +int ret; + + ret =s2mps11_ldo_enable (dev,PMIC_OP_SET , &enable);How about:
Quoted 3 lines
if (ret)
return ret;
Sure, good idea, thanks!
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerPATCH v2 8/9 arm: dts: exynos: Add supply for ADC block to Odroid XU3 family
In reply to Krzysztof KozlowskiThe ADC block requires VDD supply to be on so provide one.
--- arch/arm/dts/exynos5422-odroidxu3.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm/dts/exynos5422-odroidxu3.dts +1 -0
@@ -32,6 +32,7 @@ adc at 12D10000 { u-boot,dm-pre-reloc; + vdd-supply = <&ldo4_reg>; status = "okay"; };
Signature · 1 line
2.17.1
PATCH v2 8/9 arm: dts: exynos: Add supply for ADC block to Odroid XU3 family
Quoted 14 lines · On Wed, 13 Feb 2019 17:46:47 +0100 Krzysztof Kozlowski <[email protected]> wrote:
The ADC block requires VDD supply to be on so provide one.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/dts/exynos5422-odroidxu3.dts | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/arch/arm/dts/exynos5422-odroidxu3.dtsindexe859dd1b981a..9dfae90667cf100644 ---a/arch/arm/dts/exynos5422-odroidxu3.dts+++b/arch/arm/dts/exynos5422-odroidxu3.dts@@ -32,6 +32,7 @@
arch/arm/dts/exynos5422-odroidxu3.dts line 37
Quoted 5 lines
arch/arm/dts/exynos5422-odroidxu3.dts +1
-0adc at 12D10000 { u-boot,dm-pre-reloc; + vdd-supply = <&ldo4_reg>; status = "okay"; };
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190215/5b2c6c32/attachment.sig>
Krzysztof Kozlowski
maintainerPATCH v2 9/9 arm: dts: exynos: Add ramp delay property to LDO regulators to Odroid XU3 family
In reply to Krzysztof KozlowskiAdd startup time to LDO regulators of S2MPS11 PMIC on Odroid XU3/XU4/HC1 family of boards to be sure the voltage is proper before relying on the regulator.
The datasheet for all the S2MPS1x family is inconsistent here and does not specify unambiguously the value of ramp delay for LDO. It mentions 30 mV/us in one timing diagram but then omits it completely in LDO regulator characteristics table (it is specified for bucks).
However the vendor kernels for Galaxy S5 and Odroid XU3 use values of 12 mV/us or 24 mV/us.
Without the ramp delay value the consumers do not wait for voltage settle after changing it. Although the proper value of ramp delay for LDOs is unknown, it seems safer to use at least some value from reference kernel than to leave it unset.
--- arch/arm/dts/exynos5422-odroidxu3.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
arch/arm/dts/exynos5422-odroidxu3.dts +19 -0
@@ -45,6 +45,7 @@ regulator-name = "vdd_ldo1"; regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -52,18 +53,21 @@ regulator-name = "vddq_mmc0"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; }; ldo4_reg: LDO4 { regulator-name = "vdd_adc"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; }; ldo5_reg: LDO5 { regulator-name = "vdd_ldo5"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -71,6 +75,7 @@ regulator-name = "vdd_ldo6"; regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -78,6 +83,7 @@ regulator-name = "vdd_ldo7"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -85,6 +91,7 @@ regulator-name = "vdd_ldo8"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -92,6 +99,7 @@ regulator-name = "vdd_ldo9"; regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -99,6 +107,7 @@ regulator-name = "vdd_ldo10"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -106,6 +115,7 @@ regulator-name = "vdd_ldo11"; regulator-min-microvolt = <1000000>; regulator-max-microvolt = <1000000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -113,6 +123,7 @@ regulator-name = "vdd_ldo12"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -120,12 +131,14 @@ regulator-name = "vddq_mmc2"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; + regulator-ramp-delay = <12000>; }; ldo15_reg: LDO15 { regulator-name = "vdd_ldo15"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -133,6 +146,7 @@ regulator-name = "vdd_ldo16"; regulator-min-microvolt = <2200000>; regulator-max-microvolt = <2200000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -140,6 +154,7 @@ regulator-name = "vdd_ldo17"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -147,18 +162,21 @@ regulator-name = "vdd_emmc_1V8"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; + regulator-ramp-delay = <12000>; }; ldo19_reg: LDO19 { regulator-name = "vdd_sd"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; + regulator-ramp-delay = <12000>; }; ldo24_reg: LDO24 { regulator-name = "tsp_io"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
@@ -166,6 +184,7 @@ regulator-name = "vdd_ldo26"; regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; + regulator-ramp-delay = <12000>; regulator-always-on; };
Signature · 1 line
2.17.1