arm: exynos: Fix reboot on Odroid HC1
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest9 patches 0 repliesNew
- v4 posting 2/20 of 9 patches 0 repliesSuperseded
- v4 posting 1/29 patches 0 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 posting 2/2 | 0 of 9 patches | 0 replies | Superseded | |
| v3 posting 1/2 | 9 patches | 0 replies | Superseded | |
| v2 | 9 patches | 0 replies | Superseded | |
| v1 | 8 patches | 0 replies | Superseded |
Changes in v5 from the cover letter
================
1. Patch 3: Fix build of trats/trats2 and other by hiding new call behind check for CONFIG_BOARD_TYPES.
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | adc: exynos-adc: Fix wrong bit operation used to stop the ADCdrivers/ | +1 | 0 replies | |
| 2/9 | power: regulator: s2mps11: Fix step for LDO27 and LDO35drivers/ | +4 | 0 replies | |
| 3/9 | arm: exynos: Detect revision later, when all resources are readyboard/ board/ board/ +1 more | +44 | 0 replies | |
| 4/9 | arm: exynos: odroid-xu3: Display info late to have proper typeboard/ configs/ | +3 | 0 replies | |
| 5/9 | arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revisionboard/ | +37 | 0 replies | |
| 6/9 | regulator: Add support for ramp delaydoc/ drivers/ include/ | +49 | 0 replies | |
| 7/9 | power: regulator: s2mps11: Add enable delaydrivers/ | +10 | 0 replies | |
| 8/9 | arm: dts: exynos: Add supply for ADC block to Odroid XU3 familyarch/ | +1 | 0 replies | |
| 9/9 | arm: dts: exynos: Add ramp delay property to LDO regulators to Odroid XU3 familyarch/ | +19 | 0 replies |
Reviews trailers per patch
5 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Lukasz Majewski | Anand Moon |
|---|---|---|
| 1/9 | R-b | T-b |
| 2/9 | R-b | T-b |
| 3/9 | R-b | T-b |
| 4/9 | T-b | |
| 5/9 | T-b | |
| 6/9 | T-b | |
| 7/9 | T-b | |
| 8/9 | R-b | T-b |
| 9/9 | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [PATCH v5 0/9] arm: exynos: Fix reboot on Odroid HC1
Hi,
Changes since v4
================
1. Patch 3: Fix build of trats/trats2 and other by hiding new call behind check for CONFIG_BOARD_TYPES.
Changes since v3
================
1. Add accumulated review and test tags.
2. Patch 6: Add "ramp" keyword to new function (as discussed with Torsten Duwe).
3. Rebased on v2019.04-rc3.
Changes since v2
================
1. Add Lukasz review tags.
2. Patch 7: Return on error, as suggested by Simon.
2. Patch 3: Use IS_ENABLED() to run revision detection only once - either during late display board or misc_init_r.
Changes since v1
================
1. Move fixes to beginning of patchset.
2. Patch 3: Rework the idea - split revision detection to be executed later.
3. Patch 4: New patch.
4. Patch 6: Apply Simon's comments.
5. Patch 6: Do not delay when changing voltage if regulator is disabled.
6. Patch 6: Do not delay when disabling the regulator.
Description
===========
Odroid HC1 does not reboot properly (at least from SD card but I do not expect difference on eMMC), if LDO4/VDD_ADC was turned off by Linux kernel. This condition happens so far always, because Linux kernel did not enable ADC on Odroid HC1, therefore the VDD_ADC regulator was turned off as unused.
The issue is in detection of revision which later is used to load proper DTB.
The revision is obtained by ADC read of a voltage depending on VDD_ADC. Therefore:
1. VDD_ADC has to be turned on (but board detection happens before power is initialized),
2. Turning VDD_ADC should wait with ramp delay,
3. Reading the value from ADC should wait for it to stabilize.
Tested on Odroid XU3-Lite and Odroid HC1.
Comments and testing are welcomed.
Best regards,
Krzysztof
Krzysztof Kozlowski (9):
adc: exynos-adc: Fix wrong bit operation used to stop the ADC
power: regulator: s2mps11: Fix step for LDO27 and LDO35
arm: exynos: Detect revision later, when all resources are ready
arm: exynos: odroid-xu3: Display info late to have proper type
arm: exynos: Wait till ADC stabilizes before checking Odroid HC1
revision
regulator: Add support for ramp delay
power: regulator: s2mps11: Add enable delay
arm: dts: exynos: Add supply for ADC block to Odroid XU3 family
arm: dts: exynos: Add ramp delay property to LDO regulators to Odroid
XU3 family
arch/arm/dts/exynos5422-odroidxu3.dts | 20 +++++++ board/samsung/common/board.c | 25 ++++++++- board/samsung/common/exynos5-dt-types.c | 54 +++++++++++++++++-- board/samsung/odroid/odroid.c | 8 +++ configs/odroid-xu3_defconfig | 2 + .../regulator/regulator.txt | 2 + drivers/adc/exynos-adc.c | 2 +- drivers/power/regulator/regulator-uclass.c | 47 +++++++++++++++- drivers/power/regulator/s2mps11_regulator.c | 15 +++++- include/power/regulator.h | 2 + include/samsung/misc.h | 1 + 11 files changed, 168 insertions(+), 10 deletions(-)
Signature · 1 line
2.17.1