Skip to contentSkip to conversation

MAINTAINERS: Add various missing entries

PATCH In review Philippe Mathieu-Daudé 9 participants 29 messages Dec 18, 2018 – Feb 15, 2019

lore
Share & tools
lore
#0 lore raw

v2 cover MAINTAINERS: Add various missing entries

Hi,

This cleanup effort is inspired by Markus "Full list of unmaintained files" from the "MAINTAINERS leaves too many files uncovered" thread:
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04270.html

v1: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04994.html

Regards,

Phil.

Philippe Mathieu-Daudé (12):
MAINTAINERS: Add missing entries to the X86 section (AMD SEV)
MAINTAINERS: Add missing entries for the sun4u machines
MAINTAINERS: Add missing entries for the PC machines
MAINTAINERS: Add missing entries to VFIO and NVMe
MAINTAINERS: Add missing entries for the QObject section
MAINTAINERS: Add missing test entries to the Cryptography section
MAINTAINERS: Add an entry for the Dino machine
MAINTAINERS: Add maintainers to the Linux subsystem
MAINTAINERS: Add maintainer to the POSIX subsystem
MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem
MAINTAINERS: Orphanize the 'GDB stub' subsystem
MAINTAINERS: Add maintainer to the TCG/i386 subsystem

 MAINTAINERS | 55 ++++++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 44 insertions(+), 11 deletions(-)
Signature · 1 line
2.17.2
#1 lore raw

PATCH v2 1/12 MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

---
v2: Moved from TCG to KVM section

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index 83c127f0d6..771b1c7b94 100644
@@ -392,7 +392,9 @@ M: Marcelo Tosatti <[email protected]>
 L: [email protected]
 S: Supported
 F: target/i386/kvm.c
+F: include/sysemu/sev.h
 F: scripts/kvm/vmxcap
+F: docs/amd-memory-encryption.txt
 
 Guest CPU Cores (Xen):
 ----------------------
Signature · 1 line
2.17.2
#2 lore raw

Re: [Qemu-devel] [PATCH v2 01/12] MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

Quoted 12 lines · Philippe Mathieu-Daudé

---
v2: Moved from TCG to KVM section

---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +0 -0
index 83c127f0d6..771b1c7b94 100644

MAINTAINERS M: Marcelo Tosatti <[email protected]> · line 395

Quoted 4 lines
MAINTAINERS +1 -0
@@ -392,7 +392,9 @@ M: Marcelo Tosatti <[email protected]>
 L: [email protected]
 S: Supported
 F: target/i386/kvm.c
+F: include/sysemu/sev.h

Shouldn't this then include target/i386/sev.c, too?

MAINTAINERS M: Marcelo Tosatti <[email protected]> · line 397

Quoted 2 lines
MAINTAINERS +1 -0
 F: scripts/kvm/vmxcap
+F: docs/amd-memory-encryption.txt

Thomas

#3 lore raw

PATCH v2 2/12 MAINTAINERS: Add missing entries for the sun4u machines

In reply to Philippe Mathieu-Daudé

---
v2: Added simba

---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
MAINTAINERS +5 -1
index 771b1c7b94..dac394d125 100644
@@ -1056,9 +1056,13 @@ Sun4u
 M: Mark Cave-Ayland <[email protected]>
 S: Maintained
 F: hw/sparc64/sun4u.c
-F: pc-bios/openbios-sparc64
+F: hw/sparc64/sun4u_iommu.c
+F: include/hw/sparc/sun4u_iommu.h
 F: hw/pci-host/sabre.c
 F: include/hw/pci-host/sabre.h
+F: hw/pci-bridge/simba.c
+F: include/hw/pci-bridge/simba.h
+F: pc-bios/openbios-sparc64
 
 Sun4v
 M: Artyom Tarasenko <[email protected]>
Signature · 1 line
2.17.2
#4 lore raw

PATCH v2 3/12 MAINTAINERS: Add missing entries for the PC machines

In reply to Philippe Mathieu-Daudé
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
MAINTAINERS +4 -0
index dac394d125..f3305a65b6 100644
@@ -1141,6 +1141,10 @@ F: hw/acpi/ich9.c
 F: include/hw/acpi/ich9.h
 F: include/hw/acpi/piix4.h
 F: hw/misc/sga.c
+F: hw/isa/apm.c
+F: include/hw/isa/apm.h
+F: tests/test-x86-cpuid.c
+F: tests/test-x86-cpuid-compat.c
 
 PC Chipset
 M: Michael S. Tsirkin <[email protected]>
Signature · 1 line
2.17.2
Reviewed-by on v2 3/12
#5 lore raw

Re: [Qemu-devel] [PATCH v2 03/12] MAINTAINERS: Add missing entries for the PC machines

Quoted 1 line · Philippe Mathieu-Daudé
Quoted 21 lines
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)
MAINTAINERS +4 -0
index dac394d125..f3305a65b6 100644
@@ -1141,6 +1141,10 @@ F: hw/acpi/ich9.c
 F: include/hw/acpi/ich9.h
 F: include/hw/acpi/piix4.h
 F: hw/misc/sga.c
+F: hw/isa/apm.c
+F: include/hw/isa/apm.h
+F: tests/test-x86-cpuid.c
+F: tests/test-x86-cpuid-compat.c
 
 PC Chipset
 M: Michael S. Tsirkin <[email protected]>
Signature · 1 line
2.17.2
#6 lore raw

PATCH v2 4/12 MAINTAINERS: Add missing entries to VFIO and NVMe

In reply to Philippe Mathieu-Daudé

The VFIO helpers are used by the NVMe block driver, add the entries to both sections.

---
v2: add util/vfio-helpers.c, add entries to NVMe section

---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)
MAINTAINERS +5 -0
index f3305a65b6..7a94b0dab3 100644
@@ -1365,7 +1365,10 @@ VFIO
 M: Alex Williamson <[email protected]>
 S: Supported
 F: hw/vfio/*
+F: util/vfio-helpers.c
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h
+F: docs/igd-assign.txt
 
 vfio-ccw
 M: Cornelia Huck <[email protected]>
@@ -2290,6 +2293,8 @@ M: Fam Zheng <[email protected]>
 L: [email protected]
 S: Supported
 F: block/nvme*
+F: util/vfio-helpers.c
+F: include/qemu/vfio-helpers.h
 
 Bootdevice
 M: Gonglei <[email protected]>
Signature · 1 line
2.17.2
#7 lore raw

Re: [Qemu-devel] [PATCH v2 04/12] MAINTAINERS: Add missing entries to VFIO and NVMe

Quoted 27 lines · Philippe Mathieu-Daudé

The VFIO helpers are used by the NVMe block driver, add the entries to both sections.

---
v2: add util/vfio-helpers.c, add entries to NVMe section

---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)
MAINTAINERS +3 -0
index f3305a65b6..7a94b0dab3 100644
@@ -1365,7 +1365,10 @@ VFIO
 M: Alex Williamson <[email protected]>
 S: Supported
 F: hw/vfio/*
+F: util/vfio-helpers.c
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h
+F: docs/igd-assign.txt
 
 vfio-ccw
 M: Cornelia Huck <[email protected]>

MAINTAINERS M: Fam Zheng <[email protected]> · line 2300

Quoted 8 lines
MAINTAINERS +2 -0
@@ -2290,6 +2293,8 @@ M: Fam Zheng <[email protected]>
 L: [email protected]
 S: Supported
 F: block/nvme*
+F: util/vfio-helpers.c
+F: include/qemu/vfio-helpers.h
 
 Bootdevice
 M: Gonglei <[email protected]>

Cornelia? Alex? ... Ack? NAck?

Thomas

#8 lore raw

Re: [Qemu-devel] [PATCH v2 04/12] MAINTAINERS: Add missing entries to VFIO and NVMe

Quoted 33 lines · On Fri, 15 Feb 2019 18:29:19 +0100 Thomas Huth <[email protected]> wrote:
Quoted 32 lines · Philippe Mathieu-Daudé

The VFIO helpers are used by the NVMe block driver, add the entries to both sections.

---
v2: add util/vfio-helpers.c, add entries to NVMe section

---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)
MAINTAINERS +5 -0
index f3305a65b6..7a94b0dab3 100644
@@ -1365,7 +1365,10 @@ VFIO
 M: Alex Williamson <[email protected]>
 S: Supported
 F: hw/vfio/*
+F: util/vfio-helpers.c
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h
+F: docs/igd-assign.txt
 
 vfio-ccw
 M: Cornelia Huck <[email protected]>
@@ -2290,6 +2293,8 @@ M: Fam Zheng <[email protected]>
 L: [email protected]
 S: Supported
 F: block/nvme*
+F: util/vfio-helpers.c
+F: include/qemu/vfio-helpers.h
 
Quoted 5 lines

MAINTAINERS M: Fam Zheng <[email protected]> · line 2300

Quoted 3 lines
MAINTAINERS +0 -0
 Bootdevice
 M: Gonglei <[email protected]>

Cornelia? Alex? ... Ack? NAck?

vfio-helpers consumes vfio but that's really the only tie to me having any remote authority over it. I think it makes more sense to tie it with the direct consumer, which is nvme, and developer, Fam. Thanks,

Alex

#9 lore raw

PATCH v2 5/12 MAINTAINERS: Add missing entries for the QObject section

In reply to Philippe Mathieu-Daudé

---
v2: Removed qdist

---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
MAINTAINERS +5 -1
index 7a94b0dab3..a381882c27 100644
@@ -1900,10 +1900,14 @@ F: include/qapi/qmp/
 X: include/qapi/qmp/dispatch.h
 F: scripts/coccinelle/qobject.cocci
 F: tests/check-qdict.c
-F: tests/check-qnum.c
 F: tests/check-qjson.c
 F: tests/check-qlist.c
+F: tests/check-qlit.c
+F: tests/check-qnull.c
+F: tests/check-qnum.c
+F: tests/check-qobject.c
 F: tests/check-qstring.c
+F: qdict-test-data.txt
 T: git https://repo.or.cz/qemu/armbru.git qapi-next
 
 QEMU Guest Agent
Signature · 1 line
2.17.2
Reviewed-by on v2 5/12
#10 lore raw

Re: [Qemu-devel] [PATCH v2 05/12] MAINTAINERS: Add missing entries for the QObject section

Quoted 15 lines · Philippe Mathieu-Daudé

---
v2: Removed qdist

---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index 7a94b0dab3..a381882c27 100644
@@ -1900,10 +1900,14 @@ F: include/qapi/qmp/
 X: include/qapi/qmp/dispatch.h
 F: scripts/coccinelle/qobject.cocci
 F: tests/check-qdict.c

MAINTAINERS F: include/qapi/qmp/ · line 1911

Quoted 10 lines
MAINTAINERS +5 -1
-F: tests/check-qnum.c
 F: tests/check-qjson.c
 F: tests/check-qlist.c
+F: tests/check-qlit.c
+F: tests/check-qnull.c
+F: tests/check-qnum.c
+F: tests/check-qobject.c
 F: tests/check-qstring.c
+F: qdict-test-data.txt
 T: git https://repo.or.cz/qemu/armbru.git qapi-next
Reviewed-by on v2 5/12
#11 lore raw

Re: [Qemu-devel] [PATCH v2 05/12] MAINTAINERS: Add missing entries for the QObject section

In reply to Philippe Mathieu-Daudé
Quoted 17 lines · Philippe Mathieu-Daudé

---
v2: Removed qdist

---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
MAINTAINERS +0 -1
index 7a94b0dab3..a381882c27 100644
@@ -1900,10 +1900,14 @@ F: include/qapi/qmp/
 X: include/qapi/qmp/dispatch.h
 F: scripts/coccinelle/qobject.cocci
 F: tests/check-qdict.c
-F: tests/check-qnum.c
 F: tests/check-qjson.c

MAINTAINERS F: include/qapi/qmp/ · line 1913

Quoted 10 lines
MAINTAINERS +5 -0
 F: tests/check-qlist.c
+F: tests/check-qlit.c
+F: tests/check-qnull.c
+F: tests/check-qnum.c
+F: tests/check-qobject.c
 F: tests/check-qstring.c
+F: qdict-test-data.txt
 T: git https://repo.or.cz/qemu/armbru.git qapi-next
 
 QEMU Guest Agent
#12 lore raw

PATCH v2 6/12 MAINTAINERS: Add missing test entries to the Cryptography section

In reply to Philippe Mathieu-Daudé
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)
MAINTAINERS +2 -0
index a381882c27..bdf3534478 100644
@@ -2028,6 +2028,8 @@ F: crypto/
 F: include/crypto/
 F: tests/test-crypto-*
 F: tests/benchmark-crypto-*
+F: tests/crypto-tls-*
+F: tests/pkix_asn1_tab.c
 F: qemu.sasl
 
 Coroutines
Signature · 1 line
2.17.2
#13 lore raw

PATCH v2 7/12 MAINTAINERS: Add an entry for the Dino machine

In reply to Philippe Mathieu-Daudé

Add Richard as maintainer, and Helge as reviewer.

---
v2: downgrade to 'Odd fixes', add Helge

---
 MAINTAINERS | 10 ++++++++++
 1 file changed, 10 insertions(+)
MAINTAINERS +10 -0
index bdf3534478..f0fb2c74d7 100644
@@ -912,6 +912,16 @@ F: hw/mips/boston.c
 F: hw/pci-host/xilinx-pcie.c
 F: include/hw/pci-host/xilinx-pcie.h
 
+HP-PARISC Machines
+------------------
+
+Dino
+M: Richard Henderson <[email protected]>
+R: Helge Deller <[email protected]>
+S: Odd Fixes
+F: hw/hppa/
+F: pc-bios/hppa-firmware.img
+
 OpenRISC Machines
 -----------------
 or1k-sim
Signature · 1 line
2.17.2
#14 lore raw

PATCH v2 8/12 MAINTAINERS: Add maintainers to the Linux subsystem

In reply to Philippe Mathieu-Daudé

Add Michael, Cornelia and Paolo as maintainers of the Linux subsystem.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
MAINTAINERS +3 -2
index f0fb2c74d7..5f39fa4b80 100644
@@ -420,9 +420,10 @@ Hosts:
 ------
 
 LINUX
-L: [email protected]
+M: Michael S. Tsirkin <[email protected]>
+M: Cornelia Huck <[email protected]>
+M: Paolo Bonzini <[email protected]>
 S: Maintained
-F: linux-*
 F: linux-headers/
 
 POSIX
Signature · 1 line
2.17.2
Acked-by on v2 8/12
#15 lore raw

Re: [Qemu-devel] [PATCH v2 08/12] MAINTAINERS: Add maintainers to the Linux subsystem

Quoted 18 lines · On Tue, 18 Dec 2018 12:56:11 +0100 Philippe Mathieu-Daudé <[email protected]>…

Add Michael, Cornelia and Paolo as maintainers of the Linux subsystem.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
MAINTAINERS +0 -0
index f0fb2c74d7..5f39fa4b80 100644
@@ -420,9 +420,10 @@ Hosts:
 ------
 

MAINTAINERS Hosts: · line 429

Quoted 10 lines
MAINTAINERS +3 -2
 LINUX
-L: [email protected]
+M: Michael S. Tsirkin <[email protected]>
+M: Cornelia Huck <[email protected]>
+M: Paolo Bonzini <[email protected]>
 S: Maintained
-F: linux-*
 F: linux-headers/
 
 POSIX

As this now basically an entry for linux-headers, should this now also include the headers update script?

#16 lore raw

PATCH v2 9/12 MAINTAINERS: Add maintainer to the POSIX subsystem

In reply to Philippe Mathieu-Daudé

Add Paolo as maintainer of the POSIX subsystem.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
MAINTAINERS +5 -2
index 5f39fa4b80..e50f8c6b97 100644
@@ -427,9 +427,12 @@ S: Maintained
 F: linux-headers/
 
 POSIX
-L: [email protected]
+M: Paolo Bonzini <[email protected]>
 S: Maintained
-F: *posix*
+F: os-posix.c
+F: include/sysemu/os-posix.h
+F: util/*posix*.c
+F: include/qemu/*posix*.h
 
 NETBSD
 L: [email protected]
Signature · 1 line
2.17.2
#17 lore raw

PATCH v2 10/12 MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

In reply to Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +1 -2
index e50f8c6b97..e6a73820f1 100644
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
 CPU
-L: [email protected]
-S: Supported
+S: Orphan
 F: qom/cpu.c
 F: include/qom/cpu.h
 
Signature · 1 line
2.17.2
#18 lore raw

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

Quoted 17 lines · Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index e50f8c6b97..e6a73820f1 100644

MAINTAINERS S: Supported · line 1751

Quoted 9 lines
MAINTAINERS +1 -2
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
 CPU
-L: [email protected]
-S: Supported
+S: Orphan
 F: qom/cpu.c
 F: include/qom/cpu.h
 

I don't think that's accurate. Simply there's not much going on. If patches are sent, get-maintainers's git fallback will do something (probably sending the patch to Eduardo, Igor or me).

Paolo

#19 lore raw

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

Quoted 19 lines · Paolo Bonzini
Quoted 18 lines · Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index e50f8c6b97..e6a73820f1 100644
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
Quoted 12 lines

MAINTAINERS S: Supported · line 1751

Quoted 8 lines
MAINTAINERS +1 -2
 CPU
-L: [email protected]
-S: Supported
+S: Orphan
 F: qom/cpu.c
 F: include/qom/cpu.h
 

I don't think that's accurate. Simply there's not much going on. If patches are sent, get-maintainers's git fallback will do something (probably sending the patch to Eduardo, Igor or me).

Should we add our names to that section, or is it OK to leave it as "S: Supported" even if it doesn't have any official maintainers?

Signature · 1 line
Eduardo
#20 lore raw

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

Hi Paolo, Eduardo,

Quoted 20 lines · Eduardo Habkost
Quoted 19 lines · Paolo Bonzini
Quoted 18 lines · Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index e50f8c6b97..e6a73820f1 100644
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
MAINTAINERS +1 -2
 CPU
-L: [email protected]
-S: Supported
+S: Orphan
Quoted 8 lines

MAINTAINERS S: Supported · line 1751

Quoted 4 lines
MAINTAINERS +0 -0
 F: qom/cpu.c
 F: include/qom/cpu.h
 

I don't think that's accurate. Simply there's not much going on. If patches are sent, get-maintainers's git fallback will do something (probably sending the patch to Eduardo, Igor or me).

I followed Markus suggestion from
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:

If we take the definition of S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.

Quoted 4 lines

Should we add our names to that section, or is it OK to leave it as "S: Supported" even if it doesn't have any official maintainers?

#21 lore raw

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

Quoted 36 lines · Philippe Mathieu-Daudé

Hi Paolo, Eduardo,

Quoted 20 lines · Eduardo Habkost
Quoted 19 lines · Paolo Bonzini
Quoted 18 lines · Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index e50f8c6b97..e6a73820f1 100644
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
MAINTAINERS +1 -2
 CPU
-L: [email protected]
-S: Supported
+S: Orphan
Quoted 8 lines

MAINTAINERS S: Supported · line 1751

Quoted 4 lines
MAINTAINERS +0 -0
 F: qom/cpu.c
 F: include/qom/cpu.h
 

I don't think that's accurate. Simply there's not much going on. If patches are sent, get-maintainers's git fallback will do something (probably sending the patch to Eduardo, Igor or me).

Quoted 6 lines

I followed Markus suggestion from
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:

If we take the definition of S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.

I agree with Markus and Philippe. Having "S: Supported" but no names available is just confusing. So either put a maintainer name in here, or downgrade to "Orphan".

Thomas

#22 lore raw

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

Quoted 40 lines · Thomas Huth
Quoted 39 lines · Philippe Mathieu-Daudé

Hi Paolo, Eduardo,

Quoted 20 lines · Eduardo Habkost
Quoted 19 lines · Paolo Bonzini
Quoted 18 lines · Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index e50f8c6b97..e6a73820f1 100644
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
MAINTAINERS +1 -2
 CPU
-L: [email protected]
-S: Supported
+S: Orphan
Quoted 8 lines

MAINTAINERS S: Supported · line 1751

Quoted 4 lines
MAINTAINERS +0 -0
 F: qom/cpu.c
 F: include/qom/cpu.h
 

I don't think that's accurate. Simply there's not much going on. If patches are sent, get-maintainers's git fallback will do something (probably sending the patch to Eduardo, Igor or me).

I followed Markus suggestion from
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:

Quoted 7 lines
Quoted 3 lines

If we take the definition of S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.

I agree with Markus and Philippe. Having "S: Supported" but no names available is just confusing. So either put a maintainer name in here, or downgrade to "Orphan".

I volunteer to maintain it, but I don't want to be the only maintainer. Any other volunteer?

Signature · 1 line
Eduardo
#23 lore raw

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

Quoted 45 lines · Eduardo Habkost
Quoted 44 lines · Thomas Huth
Quoted 42 lines · Philippe Mathieu-Daudé

Hi Paolo, Eduardo,

Quoted 20 lines · Eduardo Habkost
Quoted 19 lines · Paolo Bonzini
Quoted 18 lines · Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index e50f8c6b97..e6a73820f1 100644
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
MAINTAINERS +1 -2
 CPU
-L: [email protected]
-S: Supported
+S: Orphan
Quoted 8 lines

MAINTAINERS S: Supported · line 1751

Quoted 4 lines
MAINTAINERS +0 -0
 F: qom/cpu.c
 F: include/qom/cpu.h
 

I don't think that's accurate. Simply there's not much going on. If patches are sent, get-maintainers's git fallback will do something (probably sending the patch to Eduardo, Igor or me).

I followed Markus suggestion from
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:

If we take the definition of S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.

Quoted 6 lines
Quoted 3 lines

I agree with Markus and Philippe. Having "S: Supported" but no names available is just confusing. So either put a maintainer name in here, or downgrade to "Orphan".

I volunteer to maintain it, but I don't want to be the only maintainer. Any other volunteer?

I can volunteer since I'd take the patches anyway. We can also mark it as Odd Fixes, and also make it a single thing with all of qom/ and include/qom/.

Paolo

#24 lore raw

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

Quoted 50 lines · Paolo Bonzini
Quoted 49 lines · Eduardo Habkost
Quoted 47 lines · Thomas Huth
Quoted 36 lines · Philippe Mathieu-Daudé

Hi Paolo, Eduardo,

Quoted 20 lines · Eduardo Habkost
Quoted 19 lines · Paolo Bonzini
Quoted 18 lines · Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index e50f8c6b97..e6a73820f1 100644
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
MAINTAINERS +1 -2
 CPU
-L: [email protected]
-S: Supported
+S: Orphan
Quoted 8 lines

MAINTAINERS S: Supported · line 1751

Quoted 4 lines
MAINTAINERS +0 -0
 F: qom/cpu.c
 F: include/qom/cpu.h
 

I don't think that's accurate. Simply there's not much going on. If patches are sent, get-maintainers's git fallback will do something (probably sending the patch to Eduardo, Igor or me).

Quoted 6 lines

I followed Markus suggestion from
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:

If we take the definition of S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.

I agree with Markus and Philippe. Having "S: Supported" but no names available is just confusing. So either put a maintainer name in here, or downgrade to "Orphan".

Quoted 6 lines
Quoted 2 lines

I volunteer to maintain it, but I don't want to be the only maintainer. Any other volunteer?

I can volunteer since I'd take the patches anyway. We can also mark it as Odd Fixes, and also make it a single thing with all of qom/ and include/qom/.

Actually, I consider qom/cpu.c distinct from QOM core, and I was planning to move it to hw/cpu, and add hw/cpu/core.c to the same section.

Anyway, I guess this means you're also volunteering to be listed as QOM maintainer?

Signature · 1 line
Eduardo
#25 lore raw

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

Quoted 58 lines · Eduardo Habkost
Quoted 50 lines · Paolo Bonzini
Quoted 49 lines · Eduardo Habkost
Quoted 47 lines · Thomas Huth
Quoted 36 lines · Philippe Mathieu-Daudé

Hi Paolo, Eduardo,

Quoted 20 lines · Eduardo Habkost
Quoted 19 lines · Paolo Bonzini
Quoted 18 lines · Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index e50f8c6b97..e6a73820f1 100644
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
MAINTAINERS +1 -2
 CPU
-L: [email protected]
-S: Supported
+S: Orphan
Quoted 8 lines

MAINTAINERS S: Supported · line 1751

Quoted 4 lines
MAINTAINERS +0 -0
 F: qom/cpu.c
 F: include/qom/cpu.h
 

I don't think that's accurate. Simply there's not much going on. If patches are sent, get-maintainers's git fallback will do something (probably sending the patch to Eduardo, Igor or me).

Quoted 6 lines

I followed Markus suggestion from
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:

If we take the definition of S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.

I agree with Markus and Philippe. Having "S: Supported" but no names available is just confusing. So either put a maintainer name in here, or downgrade to "Orphan".

Quoted 6 lines
Quoted 2 lines

I volunteer to maintain it, but I don't want to be the only maintainer. Any other volunteer?

I can volunteer since I'd take the patches anyway. We can also mark it as Odd Fixes, and also make it a single thing with all of qom/ and include/qom/.

Quoted 6 lines

Actually, I consider qom/cpu.c distinct from QOM core, and I was planning to move it to hw/cpu, and add hw/cpu/core.c to the same section.

Anyway, I guess this means you're also volunteering to be listed as QOM maintainer?

Igor and Daniel, would you co-maintain or review it?

Paolo

#26 lore raw

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

Quoted 59 lines · Paolo Bonzini
Quoted 58 lines · Eduardo Habkost
Quoted 56 lines · Paolo Bonzini
Quoted 45 lines · Eduardo Habkost
Quoted 44 lines · Thomas Huth
Quoted 42 lines · Philippe Mathieu-Daudé

Hi Paolo, Eduardo,

Quoted 20 lines · Eduardo Habkost
Quoted 19 lines · Paolo Bonzini
Quoted 18 lines · Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +0 -0
index e50f8c6b97..e6a73820f1 100644
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
MAINTAINERS +1 -2
 CPU
-L: [email protected]
-S: Supported
+S: Orphan
Quoted 8 lines

MAINTAINERS S: Supported · line 1751

Quoted 4 lines
MAINTAINERS +0 -0
 F: qom/cpu.c
 F: include/qom/cpu.h
 

I don't think that's accurate. Simply there's not much going on. If patches are sent, get-maintainers's git fallback will do something (probably sending the patch to Eduardo, Igor or me).

I followed Markus suggestion from
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:

If we take the definition of S: in MAINTAINERS seriously, we need to appoint a maintainer (a person, not a mailing list), or downgrade to S: Orphan.

Quoted 6 lines
Quoted 3 lines

I agree with Markus and Philippe. Having "S: Supported" but no names available is just confusing. So either put a maintainer name in here, or downgrade to "Orphan".

I volunteer to maintain it, but I don't want to be the only maintainer. Any other volunteer?

I can volunteer since I'd take the patches anyway. We can also mark it as Odd Fixes, and also make it a single thing with all of qom/ and include/qom/.

Quoted 8 lines
Quoted 6 lines

Actually, I consider qom/cpu.c distinct from QOM core, and I was planning to move it to hw/cpu, and add hw/cpu/core.c to the same section.

Anyway, I guess this means you're also volunteering to be listed as QOM maintainer?

Igor and Daniel, would you co-maintain or review it?

I'm fine being listed as a manitainer for qom/, agree with moving qom/cpu.c to hw/cpu, as I was going to suggest that myself :-)

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#27 lore raw

PATCH v2 11/12 MAINTAINERS: Orphanize the 'GDB stub' subsystem

In reply to Philippe Mathieu-Daudé

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
Luc: interested in stepping in? :)

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +1 -2
index e6a73820f1..49f8f2fa37 100644
@@ -1776,8 +1776,7 @@ F: util/error.c
 F: util/qemu-error.c
 
 GDB stub
-L: [email protected]
-S: Odd Fixes
+S: Orphan
 F: gdbstub*
 F: gdb-xml/
 
Signature · 1 line
2.17.2
#28 lore raw

PATCH v2 12/12 MAINTAINERS: Add maintainer to the TCG/i386 subsystem

In reply to Philippe Mathieu-Daudé

Richard obviously maintains this subdirectory, make this official :)

Remove the [email protected] entry because the list is always selected by the 'All patches CC here' section.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 49f8f2fa37..a879ddfc53 100644
@@ -2175,7 +2175,7 @@ F: tcg/arm/
 F: disas/arm.c
 
 i386 target
-L: [email protected]
+M: Richard Henderson <[email protected]>
 S: Maintained
 F: tcg/i386/
 F: disas/i386.c
Signature · 1 line
2.17.2