staging: erofs: match alignment with open parentheses
PATCH v2 1/1 staging: erofs: match alignment with open parentheses
Align code with open parantheses to improve the readability. Issue found using checkpatch.pl
---
v2: -modified log message
-corrected spelling in subject line
drivers/staging/erofs/dir.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/erofs/dir.c +4 -4
@@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = { };static int erofs_fill_dentries (struct dir_context *ctx, -void *dentry_blk,unsigned int *ofs, -unsigned int nameoff,unsigned int maxsize) +void *dentry_blk,unsigned int *ofs, +unsigned int nameoff,unsigned int maxsize) {struct erofs_dirent *de = dentry_blk;const struct erofs_dirent *end = dentry_blk + nameoff;
@@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx) nameoff =le16_to_cpu (de->nameoff);if (unlikely (nameoff <sizeof (struct erofs_dirent ) || - nameoff >=PAGE_SIZE )) { + nameoff >=PAGE_SIZE )) {errln ("%s, invalid de[0].nameoff %u" , - __func__, nameoff); + __func__, nameoff); err = -EIO ; goto skip_this;
Signature · 1 line
2.17.1
Quoted 2 lines · Bhanusree Pola
Align code with open parantheses to improve the readability. Issue found using checkpatch.pl
The subject line and loge message look better now, but I wonder why you still have [Outreachy kernel] twice?
julia
Quoted 47 lines
Signed-off-by Bhanusree Pola <[email protected]>---
v2: -modified log message
-corrected spelling in subject line
drivers/staging/erofs/dir.c| 8 ++++----1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/erofs/dir.c +4
-5@@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = { };static int erofs_fill_dentries (struct dir_context *ctx, -void *dentry_blk,unsigned int *ofs, -unsigned int nameoff,unsigned int maxsize) +void *dentry_blk,unsigned int *ofs, +unsigned int nameoff,unsigned int maxsize) {struct erofs_dirent *de = dentry_blk;const struct erofs_dirent *end = dentry_blk + nameoff;@@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx) nameoff =le16_to_cpu (de->nameoff);if (unlikely (nameoff <sizeof (struct erofs_dirent ) || - nameoff >=PAGE_SIZE )) { + nameoff >=PAGE_SIZE )) {errln ("%s, invalid de[0].nameoff %u" , - __func__, nameoff); + __func__, nameoff); err = -EIO ; goto skip_this; --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190219092525.GA4474%40bhanusree-MacBookAir.
For more options, visit https://groups.google.com/d/optout.
Greg Kroah-Hartman
maintainerQuoted 9 lines · Julia Lawall
Quoted 2 lines · Bhanusree Pola
Align code with open parantheses to improve the readability. Issue found using checkpatch.pl
The subject line and loge message look better now, but I wonder why you still have [Outreachy kernel] twice?
It looks like it was added by both the poster, and the mailing list :(
The one I got only had one copy, so I can take it as-is.
thanks,
greg k-h
PATCH v2 1/1 staging: erofs: match alignment with open parentheses
In reply to Bhanusree Pola[+cc linux-erofs and staging mailing list]
Quoted 4 lines · Bhanusree Pola
Align code with open parantheses to improve the readability. Issue found using checkpatch.pl
Signed-off-by Bhanusree Pola <bhanusreemahesh at gmail.com>
Thanks,
Gao Xiang
Quoted 36 lines
---
v2: -modified log message
-corrected spelling in subject line
drivers/staging/erofs/dir.c| 8 ++++----1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/erofs/dir.c +4
-4@@ -24,8 +24,8 @@ static const unsigned char erofs_filetype_table[EROFS_FT_MAX] = { };static int erofs_fill_dentries (struct dir_context *ctx, -void *dentry_blk,unsigned int *ofs, -unsigned int nameoff,unsigned int maxsize) +void *dentry_blk,unsigned int *ofs, +unsigned int nameoff,unsigned int maxsize) {struct erofs_dirent *de = dentry_blk;const struct erofs_dirent *end = dentry_blk + nameoff;@@ -104,9 +104,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx) nameoff =le16_to_cpu (de->nameoff);if (unlikely (nameoff <sizeof (struct erofs_dirent ) || - nameoff >=PAGE_SIZE )) { + nameoff >=PAGE_SIZE )) {errln ("%s, invalid de[0].nameoff %u" , - __func__, nameoff); + __func__, nameoff); err = -EIO ; goto skip_this;
PATCH v2 1/1 staging: erofs: match alignment with open parentheses
Quoted 7 lines · Gao Xiang
[+cc linux-erofs and staging mailing list]
Quoted 4 lines · Bhanusree Pola
Align code with open parantheses to improve the readability. Issue found using checkpatch.pl
Signed-off-by Bhanusree Pola <bhanusreemahesh at gmail.com>
Thanks,