snip my name and email
cover snip my name and email
the occurrence of my name and email on the files below may have led to some confusion in the reporting of a few recent bugs.
i have therefore choosen to snip it.
David Kiarie (1):
hw/i386: snip my name and email
hw/i386/amd_iommu.c | 1 - hw/i386/amd_iommu.h | 1 - 2 files changed, 2 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/1 hw/i386: snip my name and email
--- hw/i386/amd_iommu.c | 1 - hw/i386/amd_iommu.h | 1 - 2 files changed, 2 deletions(-)
hw/i386/amd_iommu.c +0 -1
@@ -2,7 +2,6 @@* QEMU emulation of AMD IOMMU (AMD-Vi) * * Copyright (C) 2011 Eduard - Gabriel Munteanu -* Copyright (C) 2015 David Kiarie, <[email protected]> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
hw/i386/amd_iommu.h +0 -1
@@ -2,7 +2,6 @@* QEMU emulation of an AMD IOMMU (AMD-Vi) * * Copyright (C) 2011 Eduard - Gabriel Munteanu -* Copyright (C) 2015 David Kiarie, <[email protected]> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
Signature · 1 line
2.20.1
Re: [Qemu-devel] [PATCH 1/1] hw/i386: snip my name and email
On Thu, Feb 21, 2019 at 06:53:59PM +0300, David Kiarie wrote:
Note, patches to QEMU are required to have a signed-off-by line in the commit message with name + email address to indicate your contribution follows the submission rules
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [Qemu-devel] [PATCH 1/1] hw/i386: snip my name and email
Quoted 11 lines · Daniel P. Berrangé
On Thu, Feb 21, 2019 at 06:53:59PM +0300, David Kiarie wrote:
Note, patches to QEMU are required to have a signed-off-by line in the commit message with name + email address to indicate your contribution follows the submission rules
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
noted.
thanks.
Quoted 4 lines
Regards,
Daniel
Quoted 4 lines · David Kiarie
the occurrence of my name and email on the files below may have led to some confusion in the reporting of a few recent bugs.
i have therefore choosen to snip it.
Dropping an email from the copyright line makes sense; dropping the Copyright declaration altogether is a bit odd (the GPL works only in tandem with a copyright assertion) - but as you are the author of the line and copyright holder of your contributions, I am not in a position to say you are wrong in removing it, only that it looks odd.
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Quoted 4 lines · Eric Blake
Quoted 3 lines · David Kiarie
the occurrence of my name and email on the files below may have led to some confusion in the reporting of a few recent bugs.
Quoted 8 lines
Quoted 1 line
i have therefore choosen to snip it.
Dropping an email from the copyright line makes sense; dropping the Copyright declaration altogether is a bit odd (the GPL works only in tandem with a copyright assertion) - but as you are the author of the line and copyright holder of your contributions, I am not in a position to say you are wrong in removing it, only that it looks odd.
Yeah, indeed.
David, also note that you probably have been addressed because scripts/get_maintainer.pl will look into the git history of files that some patch addresses and pick up significant and/or recent contributors from there. There should be some opt-out statement from that, but I don't recall how.
Jan
Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
Quoted 14 lines · Jan Kiszka
Quoted 4 lines · Eric Blake
Quoted 3 lines · David Kiarie
the occurrence of my name and email on the files below may have led to some confusion in the reporting of a few recent bugs.
Quoted 8 lines
Quoted 1 line
i have therefore choosen to snip it.
Dropping an email from the copyright line makes sense; dropping the Copyright declaration altogether is a bit odd (the GPL works only in tandem with a copyright assertion) - but as you are the author of the line and copyright holder of your contributions, I am not in a position to say you are wrong in removing it, only that it looks odd.
Quoted 6 lines
Yeah, indeed.
David, also note that you probably have been addressed because
scripts/get_maintainer.plwill look into the git history of files that some patch addresses and pick up significant and/or recent contributors from there.
MAINTAINERS covers these files, so the most common use of get_maintainer.pl won't list anyone not listed there:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch]
Paolo Bonzini <[email protected]> (maintainer:X86)
Richard Henderson <[email protected]> (maintainer:X86)
Eduardo Habkost <[email protected]> (maintainer:X86)
"Michael S. Tsirkin" <[email protected]> (supporter:PC)
Marcel Apfelbaum <[email protected]> (supporter:PC)
[email protected] (open list:All patches CC here)David's contributions have aged out of --git:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git
"Michael S. Tsirkin" <[email protected]> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%)
Marcel Apfelbaum <[email protected]> (supporter:PC)
Paolo Bonzini <[email protected]> (maintainer:X86)
Richard Henderson <[email protected]> (maintainer:X86,commit_signer:1/7=14%)
Eduardo Habkost <[email protected]> (maintainer:X86)
Peter Xu <[email protected]> (commit_signer:6/7=86%,commit_signer:4/5=80%)
Brijesh Singh <[email protected]> (commit_signer:5/7=71%,commit_signer:4/5=80%)
"Alex Bennée" <[email protected]> (commit_signer:1/7=14%)
Jan Kiszka <[email protected]> (commit_signer:1/5=20%)
[email protected] (open list:All patches CC here)However, --git-blame still lists him:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame
Paolo Bonzini <[email protected]> (maintainer:X86,commits:7/24=29%)
Richard Henderson <[email protected]> (maintainer:X86)
Eduardo Habkost <[email protected]> (maintainer:X86,commits:7/24=29%)
"Michael S. Tsirkin" <[email protected]> (supporter:PC,commits:26/24=100%,commits:14/8=100%)
Marcel Apfelbaum <[email protected]> (supporter:PC)
David Kiarie <[email protected]> (authored lines:1176/1645=71%,authored lines:274/373=73%)
Brijesh Singh <[email protected]> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%)
Peter Xu <[email protected]> (commits:10/24=42%,commits:4/8=50%)
David Gibson <[email protected]> (commits:7/24=29%)
Jan Kiszka <[email protected]> (commits:1/8=12%)
Prasad J Pandit <[email protected]> (commits:1/8=12%)
[email protected] (open list:All patches CC here)--help admonishes:
Using "--git-blame" is slow and may add old committers and authors
that are no longer active maintainers to the output.
Quoted 2 lines
There should be some opt-out statement from
that, but I don't recall how.
I don't think get_maintainer.pl supports a blacklist of people who don't want to be pestered anymore.
Quoted 66 lines · Markus Armbruster
Quoted 14 lines · Jan Kiszka
Quoted 4 lines · Eric Blake
Quoted 3 lines · David Kiarie
the occurrence of my name and email on the files below may have led to some confusion in the reporting of a few recent bugs.
Quoted 8 lines
Quoted 1 line
i have therefore choosen to snip it.
Dropping an email from the copyright line makes sense; dropping the Copyright declaration altogether is a bit odd (the GPL works only in tandem with a copyright assertion) - but as you are the author of the line and copyright holder of your contributions, I am not in a position to say you are wrong in removing it, only that it looks odd.
Quoted 6 lines
Yeah, indeed.
David, also note that you probably have been addressed because
scripts/get_maintainer.plwill look into the git history of files that some patch addresses and pick up significant and/or recent contributors from there.
MAINTAINERScovers these files, so the most common use of get_maintainer.pl won't list anyone not listed there:$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] Paolo Bonzini <[email protected]> (maintainer:X86) Richard Henderson <[email protected]> (maintainer:X86) Eduardo Habkost <[email protected]> (maintainer:X86) "Michael S. Tsirkin" <[email protected]> (supporter:PC) Marcel Apfelbaum <[email protected]> (supporter:PC) [email protected] (open list:All patches CC here)David's contributions have aged out of --git:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git "Michael S. Tsirkin" <[email protected]> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%) Marcel Apfelbaum <[email protected]> (supporter:PC) Paolo Bonzini <[email protected]> (maintainer:X86) Richard Henderson <[email protected]> (maintainer:X86,commit_signer:1/7=14%) Eduardo Habkost <[email protected]> (maintainer:X86) Peter Xu <[email protected]> (commit_signer:6/7=86%,commit_signer:4/5=80%) Brijesh Singh <[email protected]> (commit_signer:5/7=71%,commit_signer:4/5=80%) "Alex Bennée" <[email protected]> (commit_signer:1/7=14%) Jan Kiszka <[email protected]> (commit_signer:1/5=20%) [email protected] (open list:All patches CC here)However, --git-blame still lists him:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame Paolo Bonzini <[email protected]> (maintainer:X86,commits:7/24=29%) Richard Henderson <[email protected]> (maintainer:X86) Eduardo Habkost <[email protected]> (maintainer:X86,commits:7/24=29%) "Michael S. Tsirkin" <[email protected]> (supporter:PC,commits:26/24=100%,commits:14/8=100%) Marcel Apfelbaum <[email protected]> (supporter:PC) David Kiarie <[email protected]> (authored lines:1176/1645=71%,authored lines:274/373=73%) Brijesh Singh <[email protected]> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%) Peter Xu <[email protected]> (commits:10/24=42%,commits:4/8=50%) David Gibson <[email protected]> (commits:7/24=29%) Jan Kiszka <[email protected]> (commits:1/8=12%) Prasad J Pandit <[email protected]> (commits:1/8=12%) [email protected] (open list:All patches CC here)--help admonishes:
Quoted 9 lines
Using "--git-blame" is slow and may add old committers and authors
that are no longer active maintainers to the output.Quoted 2 lines
There should be some opt-out statement from
that, but I don't recall how.I don't think get_maintainer.pl supports a blacklist of people who don't want to be pestered anymore.
# cat linux/.get_maintainer.ignore Christoph Hellwig <[email protected]>
That's why I remembered it vaguely.
Jan
Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
i will just drop the email.
thanks.
Quoted 73 lines · Jan Kiszka
Quoted 72 lines · Markus Armbruster
Quoted 14 lines · Jan Kiszka
Quoted 4 lines · Eric Blake
Quoted 3 lines · David Kiarie
the occurrence of my name and email on the files below may have led to some confusion in the reporting of a few recent bugs.
Quoted 8 lines
Quoted 1 line
i have therefore choosen to snip it.
Dropping an email from the copyright line makes sense; dropping the Copyright declaration altogether is a bit odd (the GPL works only in tandem with a copyright assertion) - but as you are the author of the line and copyright holder of your contributions, I am not in a position to say you are wrong in removing it, only that it looks odd.
Quoted 6 lines
Yeah, indeed.
David, also note that you probably have been addressed because
scripts/get_maintainer.plwill look into the git history of files that some patch addresses and pick up significant and/or recent contributors from there.
MAINTAINERScovers these files, so the most common use of get_maintainer.pl won't list anyone not listed there:$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] Paolo Bonzini <[email protected]> (maintainer:X86) Richard Henderson <[email protected]> (maintainer:X86) Eduardo Habkost <[email protected]> (maintainer:X86) "Michael S. Tsirkin" <[email protected]> (supporter:PC) Marcel Apfelbaum <[email protected]> (supporter:PC) [email protected] (open list:All patches CC here)David's contributions have aged out of --git:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git "Michael S. Tsirkin" <[email protected]> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%) Marcel Apfelbaum <[email protected]> (supporter:PC) Paolo Bonzini <[email protected]> (maintainer:X86) Richard Henderson <[email protected]> (maintainer:X86,commit_signer:1/7=14%) Eduardo Habkost <[email protected]> (maintainer:X86) Peter Xu <[email protected]> (commit_signer:6/7=86%,commit_signer:4/5=80%) Brijesh Singh <[email protected]> (commit_signer:5/7=71%,commit_signer:4/5=80%) "Alex Bennée" <[email protected]> (commit_signer:1/7=14%) Jan Kiszka <[email protected]> (commit_signer:1/5=20%) [email protected] (open list:All patches CC here)However, --git-blame still lists him:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame Paolo Bonzini <[email protected]> (maintainer:X86,commits:7/24=29%) Richard Henderson <[email protected]> (maintainer:X86) Eduardo Habkost <[email protected]> (maintainer:X86,commits:7/24=29%) "Michael S. Tsirkin" <[email protected]> (supporter:PC,commits:26/24=100%,commits:14/8=100%) Marcel Apfelbaum <[email protected]> (supporter:PC) David Kiarie <[email protected]> (authored lines:1176/1645=71%,authored lines:274/373=73%) Brijesh Singh <[email protected]> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%) Peter Xu <[email protected]> (commits:10/24=42%,commits:4/8=50%) David Gibson <[email protected]> (commits:7/24=29%) Jan Kiszka <[email protected]> (commits:1/8=12%) Prasad J Pandit <[email protected]> (commits:1/8=12%) [email protected] (open list:All patches CC here)--help admonishes:
Using "--git-blame" is slow and may add old committers and authors
that are no longer active maintainers to the output.Quoted 2 lines
There should be some opt-out statement from
that, but I don't recall how.
Quoted 8 lines
Quoted 3 lines
I don't think get_maintainer.pl supports a blacklist of people who don't want to be pestered anymore.
# cat linux/.get_maintainer.ignore Christoph Hellwig <[email protected]>That's why I remembered it vaguely.
Ah!
commit 435de0782b658c993350049e853ea9a8795df4e2
Author: Joe Perches <[email protected]> Date: Thu Jun 25 15:01:50 2015 -0700
get_maintainer.pl: add .get_maintainer.ignore file capability
Some people prefer not to be cc'd on patches. Add an ability to have a file (.get_maintainer.ignore) with names and email addresses that are excluded from being listed except when specifically listed as a maintainer in a section.
Can we resync with the kernel's script to get this feature? Or should we cherry-pick it?
Quoted 97 lines · Markus Armbruster
Quoted 73 lines · Jan Kiszka
Quoted 72 lines · Markus Armbruster
Quoted 14 lines · Jan Kiszka
Quoted 4 lines · Eric Blake
Quoted 3 lines · David Kiarie
the occurrence of my name and email on the files below may have led to some confusion in the reporting of a few recent bugs.
Quoted 8 lines
Quoted 1 line
i have therefore choosen to snip it.
Dropping an email from the copyright line makes sense; dropping the Copyright declaration altogether is a bit odd (the GPL works only in tandem with a copyright assertion) - but as you are the author of the line and copyright holder of your contributions, I am not in a position to say you are wrong in removing it, only that it looks odd.
Quoted 6 lines
Yeah, indeed.
David, also note that you probably have been addressed because
scripts/get_maintainer.plwill look into the git history of files that some patch addresses and pick up significant and/or recent contributors from there.
MAINTAINERScovers these files, so the most common use of get_maintainer.pl won't list anyone not listed there:$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] Paolo Bonzini <[email protected]> (maintainer:X86) Richard Henderson <[email protected]> (maintainer:X86) Eduardo Habkost <[email protected]> (maintainer:X86) "Michael S. Tsirkin" <[email protected]> (supporter:PC) Marcel Apfelbaum <[email protected]> (supporter:PC) [email protected] (open list:All patches CC here)David's contributions have aged out of --git:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git "Michael S. Tsirkin" <[email protected]> (supporter:PC,commit_signer:12/7=100%,commit_signer:10/5=100%) Marcel Apfelbaum <[email protected]> (supporter:PC) Paolo Bonzini <[email protected]> (maintainer:X86) Richard Henderson <[email protected]> (maintainer:X86,commit_signer:1/7=14%) Eduardo Habkost <[email protected]> (maintainer:X86) Peter Xu <[email protected]> (commit_signer:6/7=86%,commit_signer:4/5=80%) Brijesh Singh <[email protected]> (commit_signer:5/7=71%,commit_signer:4/5=80%) "Alex Bennée" <[email protected]> (commit_signer:1/7=14%) Jan Kiszka <[email protected]> (commit_signer:1/5=20%) [email protected] (open list:All patches CC here)However, --git-blame still lists him:
$ scripts/get_maintainer.pl -f hw/i386/amd_iommu.[ch] --git-blame Paolo Bonzini <[email protected]> (maintainer:X86,commits:7/24=29%) Richard Henderson <[email protected]> (maintainer:X86) Eduardo Habkost <[email protected]> (maintainer:X86,commits:7/24=29%) "Michael S. Tsirkin" <[email protected]> (supporter:PC,commits:26/24=100%,commits:14/8=100%) Marcel Apfelbaum <[email protected]> (supporter:PC) David Kiarie <[email protected]> (authored lines:1176/1645=71%,authored lines:274/373=73%) Brijesh Singh <[email protected]> (authored lines:403/1645=24%,authored lines:93/373=25%,commits:4/8=50%) Peter Xu <[email protected]> (commits:10/24=42%,commits:4/8=50%) David Gibson <[email protected]> (commits:7/24=29%) Jan Kiszka <[email protected]> (commits:1/8=12%) Prasad J Pandit <[email protected]> (commits:1/8=12%) [email protected] (open list:All patches CC here)--help admonishes:
Using "--git-blame" is slow and may add old committers and authors
that are no longer active maintainers to the output.Quoted 2 lines
There should be some opt-out statement from
that, but I don't recall how.Quoted 8 lines
Quoted 3 lines
I don't think get_maintainer.pl supports a blacklist of people who don't want to be pestered anymore.
# cat linux/.get_maintainer.ignore Christoph Hellwig <[email protected]>That's why I remembered it vaguely.
Ah!
commit
435de0782b658c993350049e853ea9a8795df4e2Author: Joe Perches <[email protected]> Date: Thu Jun 25 15:01:50 2015 -0700get_maintainer.pl: add .get_maintainer.ignore file capability
Some people prefer not to be cc'd on patches. Add an ability to have a file (.get_maintainer.ignore) with names and email addresses that are excluded from being listed except when specifically listed as a maintainer in a section.
Quoted 6 lines
Signed-off-by Joe Perches <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Linus Torvalds <[email protected]>Can we resync with the kernel's script to get this feature? Or should we cherry-pick it?
I think we are out-of-sync and only cherry-picking.
Quoted 8 lines · Philippe Mathieu-Daudé
Quoted 3 lines · Markus Armbruster
Can we resync with the kernel's script to get this feature? Or should we cherry-pick it?
I think we are out-of-sync and only cherry-picking.
you can do this if you so wish but i am personally okay with the follow up patch i sent.
Quoted 14 lines · Jan Kiszka
Quoted 4 lines · Eric Blake
Quoted 3 lines · David Kiarie
the occurrence of my name and email on the files below may have led to some confusion in the reporting of a few recent bugs.
Quoted 8 lines
Quoted 1 line
i have therefore choosen to snip it.
Dropping an email from the copyright line makes sense; dropping the Copyright declaration altogether is a bit odd (the GPL works only in tandem with a copyright assertion) - but as you are the author of the line and copyright holder of your contributions, I am not in a position to say you are wrong in removing it, only that it looks odd.
Quoted 10 lines
Yeah, indeed.
David, also note that you probably have been addressed because
scripts/get_maintainer.plwill look into the git history of files that some
patch addresses and pick up significant and/or recent contributors from there.
There should be some opt-out statement from that, but I don't recall how.
Jan, Eblake, i respect your opinion but i still think my original patch would have been best fit for the simple me.
Quoted 6 lines
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux
Patchew URL: https://patchew.org/QEMU/[email protected]/
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series seems to have some coding style problems. See output below for more information:
Message-id: [email protected]
Subject: [Qemu-devel] [PATCH 0/1] snip my name and email
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3840647010 hw/i386: snip my name and email
=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 14 lines checked
Commit 384064701074 (hw/i386: snip my name and email) has style problems, please review. If any of these errors are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to [email protected]