Skip to contentSkip to conversation

generic/294: skip on NFS

PATCH In review Murphy Zhou 2 participants 5 messages Mar 4, 2019 – Apr 16, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/294: skip on NFS

Because NFS handles this differently, returning different values. Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294

---
 tests/generic/294 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/294 +1 -0
index b74579ac..f7e763a3 100755
@@ -27,6 +27,7 @@ _cleanup()
 . ./common/filter
 
 # real QA test starts here
+[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
 
 # Modify as appropriate.
 _supported_fs generic
Signature · 1 line
2.21.0
#1 lore raw
Quoted 3 lines · Murphy Zhou

Because NFS handles this differently, returning different values. Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294

Any comments are helpful, :)

Thanks
M

Quoted 21 lines
---
 tests/generic/294 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/294 +1 -0
index b74579ac..f7e763a3 100755
@@ -27,6 +27,7 @@ _cleanup()
 . ./common/filter
 
 # real QA test starts here
+[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
 
 # Modify as appropriate.
 _supported_fs generic
Signature · 1 line
2.21.0
#2 lore raw
In reply to Murphy Zhou
Quoted 5 lines · Xiong Zhou

Because NFS handles this differently, returning different values. Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294

Sorry for the so long delay..

tests/generic/294 _cleanup() · line 30

Quoted 13 lines
---
 tests/generic/294 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/294 +1 -0
index b74579ac..f7e763a3 100755
@@ -27,6 +27,7 @@ _cleanup()
 . ./common/filter
 
 # real QA test starts here
+[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"

I think it's better to filter the output of NFS to follow the golden output, so when NFS changes behavior, filter fails and we could know that from test failure.

Thanks,
Eryu

Quoted 6 lines
tests/generic/294 +0 -0
 # Modify as appropriate.
 _supported_fs generic
Signature · 1 line
2.21.0
#3 lore raw
Quoted 8 lines · Eryu Guan
Quoted 5 lines · Xiong Zhou

Because NFS handles this differently, returning different values. Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294

Sorry for the so long delay..

Not at all, :)

Sending v2.

Thanks,
Xiong

Quoted 27 lines

tests/generic/294 _cleanup() · line 30

Quoted 13 lines
---
 tests/generic/294 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/294 +1 -0
index b74579ac..f7e763a3 100755
@@ -27,6 +27,7 @@ _cleanup()
 . ./common/filter
 
 # real QA test starts here
+[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"

I think it's better to filter the output of NFS to follow the golden output, so when NFS changes behavior, filter fails and we could know that from test failure.

Thanks,
Eryu

Quoted 6 lines
tests/generic/294 +0 -0
 # Modify as appropriate.
 _supported_fs generic
Signature · 1 line
2.21.0
#4 lore raw

PATCH v2 1/1 generic/294: add golden output for nfs

In reply to Eryu Guan

Because NFS handles this differently, returning different values. Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294

---

v2:
add a new golden output for nfs instead of _notrun.

 tests/generic/294         | 7 +++++++
 tests/generic/294.out.nfs | 5 +++++
 2 files changed, 12 insertions(+)
 create mode 100644 tests/generic/294.out.nfs
tests/generic/294 +7 -0
index b74579ac..a355c612 100755
@@ -7,6 +7,7 @@
 # Tests for EEXIST (not EROFS) for inode creations, if
 # we ask to create an already-existing entity on an RO filesystem
 #
+seqfull=$0
 seq=`basename $0`
 seqres=$RESULT_DIR/$seq
 echo "QA output created by $seq"
@@ -27,6 +28,12 @@ _cleanup()
 . ./common/filter
 
 # real QA test starts here
+# link correct .out file
+if [ $FSTYP == "nfs" ]; then
+	rm -f $seqfull.out
+	ln -sf $seq.out.nfs $seqfull.out
+fi
+
 
 # Modify as appropriate.
 _supported_fs generic
tests/generic/294.out.nfs new file +5 -0
new file mode 100644
index 00000000..71ebeecd
@@ -0,0 +1,5 @@
+QA output created by 294
+mknod: 'SCRATCH_MNT/294.test/testnode': Read-only file system
+mkdir: cannot create directory 'SCRATCH_MNT/294.test/testdir': Read-only file system
+touch: cannot touch 'SCRATCH_MNT/294.test/testtarget': Read-only file system
+ln: creating symbolic link 'SCRATCH_MNT/294.test/testlink': File exists
Signature · 1 line
2.21.0