generic/294: skip on NFS
PATCH 1/1 generic/294: skip on NFS
Because NFS handles this differently, returning different values. Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
--- tests/generic/294 | 1 + 1 file changed, 1 insertion(+)
tests/generic/294 +1 -0
@@ -27,6 +27,7 @@ _cleanup() . ./common/filter # real QA test starts here +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output" # Modify as appropriate. _supported_fs generic
Signature · 1 line
2.21.0
Quoted 3 lines · Murphy Zhou
Because NFS handles this differently, returning different values. Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
Any comments are helpful, :)
Thanks
M
Quoted 21 lines
Signed-off-by Murphy Zhou <[email protected]>--- tests/generic/294 | 1 + 1 file changed, 1 insertion(+)tests/generic/294 +1
-0@@ -27,6 +27,7 @@ _cleanup() . ./common/filter # real QA test starts here +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output" # Modify as appropriate. _supported_fs genericSignature · 1 line
2.21.0
Quoted 5 lines · Xiong Zhou
Because NFS handles this differently, returning different values. Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294Signed-off-by Murphy Zhou <[email protected]>
Sorry for the so long delay..
tests/generic/294 _cleanup() · line 30
Quoted 13 lines
--- tests/generic/294 | 1 + 1 file changed, 1 insertion(+)tests/generic/294 +1
-0@@ -27,6 +27,7 @@ _cleanup() . ./common/filter # real QA test starts here +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"
I think it's better to filter the output of NFS to follow the golden output, so when NFS changes behavior, filter fails and we could know that from test failure.
Thanks,
Eryu
Quoted 6 lines
tests/generic/294 +0
-0# Modify as appropriate. _supported_fs genericSignature · 1 line
2.21.0
Quoted 8 lines · Eryu Guan
Quoted 5 lines · Xiong Zhou
Because NFS handles this differently, returning different values. Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294Signed-off-by Murphy Zhou <[email protected]>Sorry for the so long delay..
Not at all, :)
Sending v2.
Thanks,
Xiong
Quoted 27 lines
tests/generic/294 _cleanup() · line 30
Quoted 13 lines
--- tests/generic/294 | 1 + 1 file changed, 1 insertion(+)tests/generic/294 +1
-0@@ -27,6 +27,7 @@ _cleanup() . ./common/filter # real QA test starts here +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output"I think it's better to filter the output of NFS to follow the golden output, so when NFS changes behavior, filter fails and we could know that from test failure.
Thanks,
EryuQuoted 6 lines
tests/generic/294 +0
-0# Modify as appropriate. _supported_fs genericSignature · 1 line
2.21.0
PATCH v2 1/1 generic/294: add golden output for nfs
In reply to Eryu GuanBecause NFS handles this differently, returning different values. Details:
http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294
---
v2:
add a new golden output for nfs instead of _notrun.
tests/generic/294 | 7 +++++++ tests/generic/294.out.nfs | 5 +++++ 2 files changed, 12 insertions(+) create mode 100644 tests/generic/294.out.nfs
tests/generic/294 +7 -0
@@ -7,6 +7,7 @@ # Tests for EEXIST (not EROFS) for inode creations, if # we ask to create an already-existing entity on an RO filesystem # +seqfull=$0 seq=`basename $0` seqres=$RESULT_DIR/$seq echo "QA output created by $seq"
@@ -27,6 +28,12 @@ _cleanup() . ./common/filter # real QA test starts here +# link correct .out file +if [ $FSTYP == "nfs" ]; then + rm -f $seqfull.out + ln -sf $seq.out.nfs $seqfull.out +fi + # Modify as appropriate. _supported_fs generic
tests/generic/294.out.nfs new file +5 -0
@@ -0,0 +1,5 @@ +QA output created by 294 +mknod: 'SCRATCH_MNT/294.test/testnode': Read-only file system +mkdir: cannot create directory 'SCRATCH_MNT/294.test/testdir': Read-only file system +touch: cannot touch 'SCRATCH_MNT/294.test/testtarget': Read-only file system +ln: creating symbolic link 'SCRATCH_MNT/294.test/testlink': File exists
Signature · 1 line
2.21.0