Skip to contentSkip to conversation

Fix for a small typo

PATCH In review Milan P. Gandhi 3 participants 5 messages Mar 12, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix for a small typo

---
 drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_bsg.c +1 -1
index 17d42658ad9a..f2b95f11a71c 100644
@@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
 
 	if (rval) {
 		ql_log(ql_log_warn, vha, 0x704c,
-		    "iIDMA cmd failed for %8phN -- "
+		    "iiDMA cmd failed for %8phN -- "
 		    "%04x %x %04x %04x.\n", fcport->port_name,
 		    rval, fcport->fp_speed, mb[0], mb[1]);
 		rval = (DID_ERROR << 16);
#1 lore raw

On Tue, 12 Mar 2019, Milan P. Gandhi wrote:

The patch should have a log message. For example, you could point out where the type is so the reader doesn't have to search for it.

The subject line should also give a hint about what file is affected, so that the right person will pay attention to it. You can see what subject lines others have used on this file by:

git log --oneline drivers/scsi/qla2xxx/qla_bsg.c

julia

Quoted 19 lines
---
 drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_bsg.c +1 -1
index 17d42658ad9a..f2b95f11a71c 100644
@@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
 
 	if (rval) {
 		ql_log(ql_log_warn, vha, 0x704c,
-		    "iIDMA cmd failed for %8phN -- "
+		    "iiDMA cmd failed for %8phN -- "
 		    "%04x %x %04x %04x.\n", fcport->port_name,
 		    rval, fcport->fp_speed, mb[0], mb[1]);
 		rval = (DID_ERROR << 16);
#3 lore raw
In reply to Milan P. Gandhi
Quoted 4 lines · Dan Carpenter

1) Subject
2) No patch description. (What type did you fix?)
3) CC list.

Hi Dan, Julia,

Thanks for pointing it out.
Let me fix it quickly.

regards,
Milan.

#4 lore raw
In reply to Milan P. Gandhi
Quoted 10 lines · Milan P. Gandhi
Quoted 4 lines · Dan Carpenter

1) Subject
2) No patch description. (What type did you fix?)
3) CC list.

Hi Dan, Julia,

Thanks for pointing it out.
Let me fix it quickly.

There is absolutely no need to rush. Please go slowly.

regards,
dan carpenter