Fix for a small typo
Subsystems (3)
PATCH 1/1 Fix for a small typo
--- drivers/scsi/qla2xxx/qla_bsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_bsg.c +1 -1
@@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)if (rval) {ql_log (ql_log_warn, vha,0x704c , -"iIDMA cmd failed for %8phN -- " +"iiDMA cmd failed for %8phN -- " "%04x %x %04x %04x.\n" , fcport->port_name, rval, fcport->fp_speed, mb[0 ], mb[1 ]); rval = (DID_ERROR <<16 );
On Tue, 12 Mar 2019, Milan P. Gandhi wrote:
The patch should have a log message. For example, you could point out where the type is so the reader doesn't have to search for it.
The subject line should also give a hint about what file is affected, so that the right person will pay attention to it. You can see what subject lines others have used on this file by:
git log --oneline drivers/scsi/qla2xxx/qla_bsg.c
julia
Quoted 19 lines
Signed-off-by Milan P. Gandhi <[email protected]>--- drivers/scsi/qla2xxx/qla_bsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/scsi/qla2xxx/qla_bsg.c +1
-1@@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)if (rval) {ql_log (ql_log_warn, vha,0x704c , -"iIDMA cmd failed for %8phN -- " +"iiDMA cmd failed for %8phN -- " "%04x %x %04x %04x.\n" , fcport->port_name, rval, fcport->fp_speed, mb[0 ], mb[1 ]); rval = (DID_ERROR <<16 );
1) Subject
2) No patch description. (What type did you fix?)
3) CC list.
regards,
dan carpenter
Quoted 4 lines · Dan Carpenter
1) Subject
2) No patch description. (What type did you fix?)
3) CC list.
Hi Dan, Julia,
Thanks for pointing it out.
Let me fix it quickly.
regards,
Milan.
Quoted 10 lines · Milan P. Gandhi
Quoted 4 lines · Dan Carpenter
1) Subject
2) No patch description. (What type did you fix?)
3) CC list.Hi Dan, Julia,
Thanks for pointing it out.
Let me fix it quickly.
There is absolutely no need to rush. Please go slowly.
regards,
dan carpenter