net/vdev_netvsc: check for required related drivers
RFC 1/1 net/vdev_netvsc: check for required related drivers
The vdev_netvsc virtual driver that is used to do initialization on Hyper-V/Azure won't work without failsafe and tap device. If the related devices aren't present, it causes confusing errors later in initialization when it crafts devargs and attempts to send them to a device driver that isn't there.
Unfortunately, this is common with VPP where the TAP and FAILSAFE PMD's are both optional. The suggestion here is to detect this in the startup phase earlier.
Alternative would be to use RTE_BUILD_BUG_ON(!defined(...)) but that would break people doing normal VPP build.
--- drivers/net/vdev_netvsc/vdev_netvsc.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/net/vdev_netvsc/vdev_netvsc.c +14 -0
@@ -812,6 +812,20 @@ vdev_netvsc_scan_callback(__rte_unused void *arg)struct rte_devargs *devargs;struct rte_bus *vbus =rte_bus_find_by_name ("vdev" ); + dev = vbus->find_device (NULL , vdev_netvsc_cmp_rte_device, +"net_failsafe" ); +if (!dev) { +DRV_LOG (ERR ,"failsafe network device not present" ); +return ; + } + + dev = vbus->find_device (NULL , vdev_netvsc_cmp_rte_device, +"net_tap" ); +if (!dev) { +DRV_LOG (ERR ,"tap network device driver not present" ); +return ; + } +RTE_EAL_DEVARGS_FOREACH ("vdev" , devargs) if (!strncmp(devargs->name, VDEV_NETVSC_DRIVER_NAME,VDEV_NETVSC_DRIVER_NAME_LEN ))
Signature · 1 line
2.17.1
Hi
From: Stephen Hemminger
Quoted 6 lines
The
vdev_netvscvirtual driver that is used to do initialization on Hyper- V/Azure won't work without failsafe and tap device.
If the related devices aren't present, it causes confusing errors later in initialization when it crafts devargs and attempts to send them to a device driver that isn't there.
Quoted 7 lines
Unfortunately, this is common with VPP where the TAP and FAILSAFE PMD's are both optional. The suggestion here is to detect this in the startup phase earlier.
Alternative would be to use RTE_BUILD_BUG_ON(!defined(...)) but that would break people doing normal VPP build.
The failsafe and tap devices are created by the vdev_netvsc PMD, so it is not expected to find them in the scan time. If the VM doesn't want vdev_netvsc driver to run, it have 2 options:
1. assign IP to the netvsc netdevs.
2. run --vdev="vdev_netvsc0,ignore=1" - see documentation for more info.
Quoted 34 lines
Signed-off-by Stephen Hemminger <[email protected]>--- drivers/net/vdev_netvsc/vdev_netvsc.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)drivers/net/vdev_netvsc/vdev_netvsc.c +14
-0@@ -812,6 +812,20 @@ vdev_netvsc_scan_callback(__rte_unused void *arg)struct rte_devargs *devargs;struct rte_bus *vbus =rte_bus_find_by_name ("vdev" ); + dev = vbus->find_device (NULL , vdev_netvsc_cmp_rte_device, +"net_failsafe" ); +if (!dev) { +DRV_LOG (ERR ,"failsafe network device not present" ); +return ; + } + + dev = vbus->find_device (NULL , vdev_netvsc_cmp_rte_device, +"net_tap" ); +if (!dev) { +DRV_LOG (ERR ,"tap network device driver not present" ); +return ; + } +RTE_EAL_DEVARGS_FOREACH ("vdev" , devargs) if (!strncmp(devargs->name, VDEV_NETVSC_DRIVER_NAME,
VDEV_NETVSC_DRIVER_NAME_LEN))
--
2.17.1
Quoted 13 lines · On Thu, 14 Mar 2019 11:26:05 +0000 Matan Azrad <[email protected]> wrote:
Hi
From: Stephen Hemminger
Quoted 10 lines
The
vdev_netvscvirtual driver that is used to do initialization on Hyper- V/Azure won't work without failsafe and tap device.
If the related devices aren't present, it causes confusing errors later in initialization when it crafts devargs and attempts to send them to a device driver that isn't there.Unfortunately, this is common with VPP where the TAP and FAILSAFE PMD's are both optional. The suggestion here is to detect this in the startup phase earlier.
Quoted 9 lines
Quoted 3 lines
Alternative would be to use RTE_BUILD_BUG_ON(!defined(...)) but that would break people doing normal VPP build.
The failsafe and tap devices are created by the
vdev_netvscPMD, so it is not expected to find them in the scan time. If the VM doesn't wantvdev_netvscdriver to run, it have 2 options:
1. assign IP to the netvsc netdevs.
2. run --vdev="vdev_netvsc0,ignore=1" - see documentation for more info.
How do we improve the error reporting for configurations that have run Hyper-V/Azure but forget to build failsafe, tap or mlx5 device drivers. Right now the error messages are confusing, misleading and waste significant amount of developer time.
What solution do you propose? The DPDK build system is not as smart as kernel Kconfig, there is no way to force dependencies.
Hi
From: Stephen Hemminger
Quoted 27 lines
Quoted 13 lines · wrote:
Hi
From: Stephen Hemminger
Quoted 10 lines
The
vdev_netvscvirtual driver that is used to do initialization on Hyper- V/Azure won't work without failsafe and tap device. If the related devices aren't present, it causes confusing errors later in initialization when it crafts devargs and attempts to send them to a device driver that isn't there.Unfortunately, this is common with VPP where the TAP and FAILSAFE PMD's are both optional. The suggestion here is to detect this in the startup phase earlier.
Quoted 5 lines
Quoted 3 lines
Alternative would be to use RTE_BUILD_BUG_ON(!defined(...)) but that would break people doing normal VPP build.
The failsafe and tap devices are created by the
vdev_netvscPMD, so it isnot expected to find them in the scan time.
Quoted 4 lines
If the VM doesn't want
vdev_netvscdriver to run, it have 2 options:
1. assign IP to the netvsc netdevs.
2. run --vdev="vdev_netvsc0,ignore=1" - see documentation for more info.
Quoted 7 lines
How do we improve the error reporting for configurations that have run Hyper-V/Azure but forget to build failsafe, tap or mlx5 device drivers. Right now the error messages are confusing, misleading and waste significant amount of developer time.
What solution do you propose? The DPDK build system is not as smart as kernel
Kconfig, there is no way to force dependencies.
Why?
Can't you condition the vdev_netvsc compilation in failsafe and tap compilation?
1 more option:
To condition the vdev_netvsc automated probing (in vdev_netvsc_custom_scan_add) by "ifdef" statement in failsafe and tap compilation existence.
Moreover, you can add clearer massage for this case if vdev_netvsc is running (vdev_netvsc_vdev_probe).
Matan.
Quoted 38 lines · On Sun, 17 Mar 2019 06:53:02 +0000 Matan Azrad <[email protected]> wrote:
Hi
From: Stephen Hemminger
Quoted 27 lines
Quoted 13 lines · wrote:
Hi
From: Stephen Hemminger
Quoted 10 lines
The
vdev_netvscvirtual driver that is used to do initialization on Hyper- V/Azure won't work without failsafe and tap device. If the related devices aren't present, it causes confusing errors later in initialization when it crafts devargs and attempts to send them to a device driver that isn't there.Unfortunately, this is common with VPP where the TAP and FAILSAFE PMD's are both optional. The suggestion here is to detect this in the startup phase earlier.
Quoted 5 lines
Quoted 3 lines
Alternative would be to use RTE_BUILD_BUG_ON(!defined(...)) but that would break people doing normal VPP build.
The failsafe and tap devices are created by the
vdev_netvscPMD, so it isnot expected to find them in the scan time.
Quoted 4 lines
If the VM doesn't want
vdev_netvscdriver to run, it have 2 options:
1. assign IP to the netvsc netdevs.
2. run --vdev="vdev_netvsc0,ignore=1" - see documentation for more info.Quoted 7 lines
How do we improve the error reporting for configurations that have run Hyper-V/Azure but forget to build failsafe, tap or mlx5 device drivers. Right now the error messages are confusing, misleading and waste significant amount of developer time.
What solution do you propose? The DPDK build system is not as smart as kernel
Kconfig, there is no way to force dependencies.
Quoted 7 lines
Why?
Can't you condition thevdev_netvsccompilation in failsafe and tap compilation?1 more option:
To condition thevdev_netvscautomated probing (invdev_netvsc_custom_scan_add) by "ifdef" statement in failsafe and tap compilation existence.Moreover, you can add clearer massage for this case if
vdev_netvscis running (vdev_netvsc_vdev_probe).
Right now FAILSAFE, TAP and MLX5 are all optional in how VPP builds.
If FAILSAFE or TAP is not configured then vdev_netvsc will try and configure them anyway and fail obscurely.
My current preference would be:
RTE_BUILD_BUG_ON(!defined(CONFIG_RTE_LIBRTE_PMD_FAILSAFE));