thunderbolt: fix a missing check of kmemdup
PATCH 1/1 thunderbolt: fix a missing check of kmemdup
kmemdup may fail and return NULL. The fix adds a check and returns NULL in case it fails to avoid NULL pointer dereferecen.
Signed-off-by Kangjie Lu <[email protected]>
--- drivers/thunderbolt/property.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/thunderbolt/property.c +4 -0
@@ -176,6 +176,10 @@ static struct tb_property_dir *__tb_property_parse_dir(const u32 *block, }else { dir->uuid =kmemdup (&block[dir_offset],sizeof (*dir->uuid),GFP_KERNEL ); +if (!dir->uuid) { +tb_property_free_dir (dir); +return NULL ; + } content_offset = dir_offset +4 ; content_len = dir_len -4 ;/* Length includes UUID */ }
Signature · 1 line
2.17.1
Mika Westerberg
AppliedQuoted 4 lines · Kangjie Lu
kmemdup may fail and return NULL. The fix adds a check and returns NULL in case it fails to avoid NULL pointer dereferecen.
Signed-off-by Kangjie Lu <[email protected]>
Applied, thanks!