Skip to contentSkip to conversation

thunderbolt: fix a missing check of kmemdup

PATCH Applied Kangjie Lu 2 participants 2 messages Mar 14, 2019 – Mar 15, 2019 Thunderbolt driver

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore

Kangjie Lu

author
#0 lore raw

PATCH 1/1 thunderbolt: fix a missing check of kmemdup

kmemdup may fail and return NULL. The fix adds a check and returns NULL in case it fails to avoid NULL pointer dereferecen.

---
 drivers/thunderbolt/property.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/thunderbolt/property.c +4 -0
index ee76449524a3..841314deb446 100644
@@ -176,6 +176,10 @@ static struct tb_property_dir *__tb_property_parse_dir(const u32 *block,
 	} else {
 		dir->uuid = kmemdup(&block[dir_offset], sizeof(*dir->uuid),
 				    GFP_KERNEL);
+		if (!dir->uuid) {
+			tb_property_free_dir(dir);
+			return NULL;
+		}
 		content_offset = dir_offset + 4;
 		content_len = dir_len - 4; /* Length includes UUID */
 	}
Signature · 1 line
2.17.1