Skip to contentSkip to conversation

thunderbolt: property: fix a missing check of kzalloc

PATCH Applied Kangjie Lu 2 participants 2 messages Mar 25, 2019 – Mar 28, 2019 1 message not in the archive Thunderbolt driver

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Kangjie Lu

author
#1 lore raw

PATCH v2 1/1 thunderbolt: property: fix a missing check of kzalloc

No check is enforced for the return value of kzalloc, which may lead to NULL-pointer dereference.

The patch fixes this issue.

---
V2: no overflow issue, as pointed out by
Mika Westerberg <[email protected]>

---
 drivers/thunderbolt/property.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/thunderbolt/property.c +6 -1
index 841314deb446..d5b0cdb8f0b1 100644
@@ -587,7 +587,12 @@ int tb_property_add_text(struct tb_property_dir *parent, const char *key,
 		return -ENOMEM;
 
 	property->length = size / 4;
-	property->value.data = kzalloc(size, GFP_KERNEL);
+	property->value.text = kzalloc(size, GFP_KERNEL);
+	if (!property->value.text) {
+		kfree(property);
+		return -ENOMEM;
+	}
+
 	strcpy(property->value.text, text);
 
 	list_add_tail(&property->list, &parent->properties);
Signature · 1 line
2.17.1