thunderbolt: property: fix a missing check of kzalloc
PATCH v2 1/1 thunderbolt: property: fix a missing check of kzalloc
In reply to a message not in the archiveNo check is enforced for the return value of kzalloc, which may lead to NULL-pointer dereference.
The patch fixes this issue.
Signed-off-by Kangjie Lu <[email protected]>
Reviewed-by Mukesh Ojha <[email protected]>
---
V2: no overflow issue, as pointed out by
Mika Westerberg <[email protected]>
--- drivers/thunderbolt/property.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/thunderbolt/property.c +6 -1
@@ -587,7 +587,12 @@ int tb_property_add_text(struct tb_property_dir *parent, const char *key,return -ENOMEM ; property->length = size /4 ; - property->value.data =kzalloc (size,GFP_KERNEL ); + property->value.text =kzalloc (size,GFP_KERNEL ); +if (!property->value.text) { +kfree (property); +return -ENOMEM ; + } +strcpy (property->value.text, text);list_add_tail (&property->list, &parent->properties);
Signature · 1 line
2.17.1
Mika Westerberg
AppliedQuoted 7 lines · Kangjie Lu
No check is enforced for the return value of kzalloc, which may lead to NULL-pointer dereference.
The patch fixes this issue.
Signed-off-by Kangjie Lu <[email protected]>Reviewed-by Mukesh Ojha <[email protected]>
Applied, thanks!