toolchain-external: add OpenMP support
cover toolchain-external: add OpenMP support
This patchset adds OpenMP support to toolchain-external. The first patch adds a new 'BR2_TOOLCHAIN_HAS_OPENMP' option which causes libgomp.so.* to be added to TOOLCHAIN_EXTERNAL_LIBS, and the second patch enables BR2_TOOLCHAIN_HAS_OPENMP for all supporting external toolchains.
Ed Blake (2):
toolchain-external: add option for OpenMP support
toolchain-external: enable OpenMP for supporting toolchains
toolchain/Config.in | 3 +++ toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++++ .../toolchain-external-arm-aarch64-be/Config.in | 1 + .../toolchain-external-arm-aarch64/Config.in | 1 + .../toolchain-external/toolchain-external-arm-arm/Config.in | 1 + .../toolchain-external-codescape-img-mips/Config.in | 1 + .../toolchain-external-codescape-mti-mips/Config.in | 1 + .../toolchain-external-codesourcery-amd64/Config.in | 1 + .../toolchain-external-codesourcery-mips/Config.in | 1 + .../toolchain-external-linaro-aarch64-be/Config.in | 1 + .../toolchain-external-linaro-aarch64/Config.in | 1 + .../toolchain-external-linaro-arm/Config.in | 1 + .../toolchain-external-linaro-armeb/Config.in | 1 + 13 files changed, 18 insertions(+)
Signature · 1 line
2.17.1
PATCH 1/2 toolchain-external: add option for OpenMP support
Add new BR2_TOOLCHAIN_HAS_OPENMP option for toolchains with OpenMP support.
--- toolchain/Config.in | 3 +++ toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++++ 2 files changed, 7 insertions(+)
toolchain/Config.in +3 -0
@@ -168,6 +168,9 @@ config BR2_TOOLCHAIN_HAS_SSP config BR2_TOOLCHAIN_HAS_UCONTEXT bool +config BR2_TOOLCHAIN_HAS_OPENMP + bool + config BR2_TOOLCHAIN_SUPPORTS_PIE bool
toolchain/toolchain-external/pkg-toolchain-external.mk +4 -0
@@ -144,6 +144,10 @@ TOOLCHAIN_EXTERNAL_LIBS += libquadmath.so* endif endif +ifeq ($(BR2_TOOLCHAIN_HAS_OPENMP),y) +TOOLCHAIN_EXTERNAL_LIBS += libgomp.so.* +endif + TOOLCHAIN_EXTERNAL_LIBS += $(call qstrip,$(BR2_TOOLCHAIN_EXTRA_EXTERNAL_LIBS))
Signature · 1 line
2.17.1
PATCH 1/2 toolchain-external: add option for OpenMP support
Ed, All,
On 2019-03-22 16:59 +0000, Ed Blake spake thusly:
Quoted 2 lines
Add new
BR2_TOOLCHAIN_HAS_OPENMPoption for toolchains with OpenMP support.
With your series, there is no user of libgomp in Buildroot, so I suppose this is for your own local packages, right?
Actually, if we have packages in Buildroot that may use OpenMP, then it is only optional for them, then. Do you know of such a package? The goal being to actually add a runtime-test that gomp works.
Quoted 1 line
Signed-off-by Ed Blake <[email protected]>
Regards,
Yann E. MORIN.
Quoted 41 lines
--- toolchain/Config.in | 3 +++ toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++++ 2 files changed, 7 insertions(+)toolchain/Config.in +3
-0@@ -168,6 +168,9 @@ config BR2_TOOLCHAIN_HAS_SSP config BR2_TOOLCHAIN_HAS_UCONTEXT bool +config BR2_TOOLCHAIN_HAS_OPENMP + bool + config BR2_TOOLCHAIN_SUPPORTS_PIE booltoolchain/toolchain-external/pkg-toolchain-external.mk +4
-0@@ -144,6 +144,10 @@ TOOLCHAIN_EXTERNAL_LIBS += libquadmath.so* endif endif +ifeq ($(BR2_TOOLCHAIN_HAS_OPENMP),y) +TOOLCHAIN_EXTERNAL_LIBS += libgomp.so.* +endif + TOOLCHAIN_EXTERNAL_LIBS += $(call qstrip,$(BR2_TOOLCHAIN_EXTRA_EXTERNAL_LIBS))Signature · 6 lines
2.17.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/2 toolchain-external: add option for OpenMP support
Hi Yann,
Quoted 8 lines · On Fri, 22 Mar 2019 22:15:34 +0100 "Yann E. MORIN" <[email protected]>…
Ed, All,
On 2019-03-22 16:59 +0000, Ed Blake spake thusly:
Quoted 2 lines
Add new
BR2_TOOLCHAIN_HAS_OPENMPoption for toolchains with OpenMP support.With your series, there is no user of libgomp in Buildroot, so I suppose this is for your own local packages, right?
Yes, it's for a local package.
Quoted 3 lines
Actually, if we have packages in Buildroot that may use OpenMP, then it is only optional for them, then. Do you know of such a package? The goal being to actually add a runtime-test that gomp works.
The following packages *could* use OpenMP, but currently disable it:
imagemagick
beecrypt
libraw
gettext
And the following package uses OpenMP if BR2_GCC_ENABLE_OPENMP is enabled:
fftw
I wonder if BR2_GCC_ENABLE_OPENMP should select BR2_TOOLCHAIN_HAS_OPENMP, in the same way that BR2_TOOLCHAIN_BUILDROOT_FORTRAN selects BR2_TOOLCHAIN_HAS_FORTRAN.
Then BR2_TOOLCHAIN_HAS_OPENMP would be checked in the fftw makefile instead of BR2_GCC_ENABLE_OPENMP.
Regards,
Ed.
Quoted 49 lines
Quoted 1 line
Signed-off-by Ed Blake <[email protected]>Reviewed-by "Yann E. MORIN" <[email protected]>Regards,
Yann E. MORIN.Quoted 41 lines
--- toolchain/Config.in | 3 +++ toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++++ 2 files changed, 7 insertions(+)toolchain/Config.in +3
-0@@ -168,6 +168,9 @@ config BR2_TOOLCHAIN_HAS_SSP config BR2_TOOLCHAIN_HAS_UCONTEXT bool +config BR2_TOOLCHAIN_HAS_OPENMP + bool + config BR2_TOOLCHAIN_SUPPORTS_PIE booltoolchain/toolchain-external/pkg-toolchain-external.mk +4
-0@@ -144,6 +144,10 @@ TOOLCHAIN_EXTERNAL_LIBS += libquadmath.so* endif endif +ifeq ($(BR2_TOOLCHAIN_HAS_OPENMP),y) +TOOLCHAIN_EXTERNAL_LIBS += libgomp.so.* +endif + TOOLCHAIN_EXTERNAL_LIBS += $(call qstrip,$(BR2_TOOLCHAIN_EXTRA_EXTERNAL_LIBS))Signature · 6 lines
2.17.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/2 toolchain-external: add option for OpenMP support
On 2019-03-25 11:27 +0000, Ed Blake spake thusly:
Quoted 27 lines
Hi Yann,
Quoted 8 lines · On Fri, 22 Mar 2019 22:15:34 +0100 "Yann E. MORIN" <[email protected]>…
Ed, All,
On 2019-03-22 16:59 +0000, Ed Blake spake thusly:
Quoted 2 lines
Add new
BR2_TOOLCHAIN_HAS_OPENMPoption for toolchains with OpenMP support.With your series, there is no user of libgomp in Buildroot, so I suppose this is for your own local packages, right?
Yes, it's for a local package.
Quoted 3 lines
Actually, if we have packages in Buildroot that may use OpenMP, then it is only optional for them, then. Do you know of such a package? The goal being to actually add a runtime-test that gomp works.
The following packages *could* use OpenMP, but currently disable it:
imagemagick
beecrypt
libraw
gettext
Quoted 6 lines
And the following package uses OpenMP if
BR2_GCC_ENABLE_OPENMPis enabled:fftw
I wonder if
BR2_GCC_ENABLE_OPENMPshould selectBR2_TOOLCHAIN_HAS_OPENMP, in the same way thatBR2_TOOLCHAIN_BUILDROOT_FORTRANselectsBR2_TOOLCHAIN_HAS_FORTRAN.
Ah, yes, that would indeed be good.
Quoted 2 lines
Then
BR2_TOOLCHAIN_HAS_OPENMPwould be checked in the fftw makefile instead ofBR2_GCC_ENABLE_OPENMP.
Then yes, it would be nice if your series would do:
1. introduce BR2_TOOLCHAIN_HAS_OPENMP
2. BR2_GCC_ENABLE_OPENMP select BR2_TOOLCHAIN_HAS_OPENMP
3. external toolchain select BR2_TOOLCHAIN_HAS_OPENMP
4. fftw switches to using BR2_TOOLCHAIN_HAS_OPENMP
Care to have a look and respin your series, please?
Regards,
Yann E. MORIN.
Quoted 54 lines
Regards,
Ed.
Quoted 49 lines
Quoted 1 line
Signed-off-by Ed Blake <[email protected]>Reviewed-by "Yann E. MORIN" <[email protected]>Regards,
Yann E. MORIN.Quoted 41 lines
--- toolchain/Config.in | 3 +++ toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++++ 2 files changed, 7 insertions(+)toolchain/Config.in +3
-0@@ -168,6 +168,9 @@ config BR2_TOOLCHAIN_HAS_SSP config BR2_TOOLCHAIN_HAS_UCONTEXT bool +config BR2_TOOLCHAIN_HAS_OPENMP + bool + config BR2_TOOLCHAIN_SUPPORTS_PIE booltoolchain/toolchain-external/pkg-toolchain-external.mk +4
-0@@ -144,6 +144,10 @@ TOOLCHAIN_EXTERNAL_LIBS += libquadmath.so* endif endif +ifeq ($(BR2_TOOLCHAIN_HAS_OPENMP),y) +TOOLCHAIN_EXTERNAL_LIBS += libgomp.so.* +endif + TOOLCHAIN_EXTERNAL_LIBS += $(call qstrip,$(BR2_TOOLCHAIN_EXTRA_EXTERNAL_LIBS))Signature · 6 lines
2.17.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/2 toolchain-external: add option for OpenMP support
Quoted 40 lines · On Mon, 25 Mar 2019 17:57:27 +0100 "Yann E. MORIN" <[email protected]>…
On 2019-03-25 11:27 +0000, Ed Blake spake thusly:
Quoted 27 lines
Hi Yann,
Quoted 8 lines · On Fri, 22 Mar 2019 22:15:34 +0100 "Yann E. MORIN" <[email protected]>…
Ed, All,
On 2019-03-22 16:59 +0000, Ed Blake spake thusly:
Quoted 2 lines
Add new
BR2_TOOLCHAIN_HAS_OPENMPoption for toolchains with OpenMP support.With your series, there is no user of libgomp in Buildroot, so I suppose this is for your own local packages, right?
Yes, it's for a local package.
Quoted 3 lines
Actually, if we have packages in Buildroot that may use OpenMP, then it is only optional for them, then. Do you know of such a package? The goal being to actually add a runtime-test that gomp works.
The following packages *could* use OpenMP, but currently disable it:
imagemagick
beecrypt
libraw
gettextQuoted 6 lines
And the following package uses OpenMP if
BR2_GCC_ENABLE_OPENMPis enabled:fftw
I wonder if
BR2_GCC_ENABLE_OPENMPshould selectBR2_TOOLCHAIN_HAS_OPENMP, in the same way thatBR2_TOOLCHAIN_BUILDROOT_FORTRANselectsBR2_TOOLCHAIN_HAS_FORTRAN.Ah, yes, that would indeed be good.
Quoted 2 lines
Then
BR2_TOOLCHAIN_HAS_OPENMPwould be checked in the fftw makefile instead ofBR2_GCC_ENABLE_OPENMP.
Quoted 8 lines
Then yes, it would be nice if your series would do:
1. introduce
BR2_TOOLCHAIN_HAS_OPENMP
2.BR2_GCC_ENABLE_OPENMPselectBR2_TOOLCHAIN_HAS_OPENMP
3. external toolchain selectBR2_TOOLCHAIN_HAS_OPENMP
4. fftw switches to usingBR2_TOOLCHAIN_HAS_OPENMPCare to have a look and respin your series, please?
Will do. I just noticed opencv3 and flann also reference BR2_GCC_ENABLE_OPENMP, so I will change those as well in patch 4.
Ed.
Quoted 59 lines
Regards,
Yann E. MORIN.Quoted 54 lines
Regards,
Ed.
Quoted 49 lines
Quoted 1 line
Signed-off-by Ed Blake <[email protected]>Reviewed-by "Yann E. MORIN" <[email protected]>Regards,
Yann E. MORIN.Quoted 41 lines
--- toolchain/Config.in | 3 +++ toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ++++ 2 files changed, 7 insertions(+)toolchain/Config.in +3
-0@@ -168,6 +168,9 @@ config BR2_TOOLCHAIN_HAS_SSP config BR2_TOOLCHAIN_HAS_UCONTEXT bool +config BR2_TOOLCHAIN_HAS_OPENMP + bool + config BR2_TOOLCHAIN_SUPPORTS_PIE booltoolchain/toolchain-external/pkg-toolchain-external.mk +4
-0@@ -144,6 +144,10 @@ TOOLCHAIN_EXTERNAL_LIBS += libquadmath.so* endif endif +ifeq ($(BR2_TOOLCHAIN_HAS_OPENMP),y) +TOOLCHAIN_EXTERNAL_LIBS += libgomp.so.* +endif + TOOLCHAIN_EXTERNAL_LIBS += $(call qstrip,$(BR2_TOOLCHAIN_EXTRA_EXTERNAL_LIBS))Signature · 6 lines
2.17.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 2/2 toolchain-external: enable OpenMP for supporting toolchains
In reply to Ed BlakeEnable OpenMP support in the following external toolchains:
toolchain-external-arm-aarch64-be
toolchain-external-arm-aarch64
toolchain-external-arm-arm
toolchain-external-codescape-img-mips
toolchain-external-codescape-mti-mips
toolchain-external-codesourcery-amd64
toolchain-external-codesourcery-mips
toolchain-external-linaro-aarch64-be
toolchain-external-linaro-aarch64
toolchain-external-linaro-arm
toolchain-external-linaro-armeb
--- .../toolchain-external-arm-aarch64-be/Config.in | 1 + .../toolchain-external/toolchain-external-arm-aarch64/Config.in | 1 + .../toolchain-external/toolchain-external-arm-arm/Config.in | 1 + .../toolchain-external-codescape-img-mips/Config.in | 1 + .../toolchain-external-codescape-mti-mips/Config.in | 1 + .../toolchain-external-codesourcery-amd64/Config.in | 1 + .../toolchain-external-codesourcery-mips/Config.in | 1 + .../toolchain-external-linaro-aarch64-be/Config.in | 1 + .../toolchain-external-linaro-aarch64/Config.in | 1 + .../toolchain-external/toolchain-external-linaro-arm/Config.in | 1 + .../toolchain-external/toolchain-external-linaro-armeb/Config.in | 1 + 11 files changed, 11 insertions(+)
toolchain/toolchain-external/toolchain-external-arm-aarch64-be/Config.in +1 -0
@@ -10,6 +10,7 @@ config BR2_TOOLCHAIN_EXTERNAL_ARM_AARCH64_BE select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_20 select BR2_TOOLCHAIN_GCC_AT_LEAST_8 select BR2_TOOLCHAIN_HAS_FORTRAN + select BR2_TOOLCHAIN_HAS_OPENMP help Arm toolchain for the AArch64 Big Endian architecture.
toolchain/toolchain-external/toolchain-external-arm-aarch64/Config.in +1 -0
@@ -10,6 +10,7 @@ config BR2_TOOLCHAIN_EXTERNAL_ARM_AARCH64 select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_20 select BR2_TOOLCHAIN_GCC_AT_LEAST_8 select BR2_TOOLCHAIN_HAS_FORTRAN + select BR2_TOOLCHAIN_HAS_OPENMP help Arm toolchain for the AArch64 architecture.
toolchain/toolchain-external/toolchain-external-arm-arm/Config.in +1 -0
@@ -17,6 +17,7 @@ config BR2_TOOLCHAIN_EXTERNAL_ARM_ARM select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_20 select BR2_TOOLCHAIN_GCC_AT_LEAST_8 select BR2_TOOLCHAIN_HAS_FORTRAN + select BR2_TOOLCHAIN_HAS_OPENMP help Arm toolchain for the ARM architecture. It uses GCC 8.2.1, GDB 8.1.1, glibc 2.28, Binutils 2.30. It generates code that
toolchain/toolchain-external/toolchain-external-codescape-img-mips/Config.in +1 -0
@@ -9,6 +9,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_IMG_MIPS select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_7 select BR2_TOOLCHAIN_GCC_AT_LEAST_6 select BR2_TOOLCHAIN_HAS_FORTRAN + select BR2_TOOLCHAIN_HAS_OPENMP help Codescape IMG GNU Linux Toolchain 2018.09 for the MIPS architecture, from MIPS Tech LLC. It uses gcc 6.3.0,
toolchain/toolchain-external/toolchain-external-codescape-mti-mips/Config.in +1 -0
@@ -10,6 +10,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESCAPE_MTI_MIPS select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_7 select BR2_TOOLCHAIN_GCC_AT_LEAST_6 select BR2_TOOLCHAIN_HAS_FORTRAN + select BR2_TOOLCHAIN_HAS_OPENMP help Codescape MTI GNU Linux Toolchain 2018.09 for the MIPS architecture, from MIPS Tech LLC. It uses gcc 6.3.0,
toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Config.in +1 -0
@@ -8,6 +8,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_AMD64 select BR2_TOOLCHAIN_EXTERNAL_GLIBC select BR2_TOOLCHAIN_HAS_SSP select BR2_TOOLCHAIN_HAS_NATIVE_RPC + select BR2_TOOLCHAIN_HAS_OPENMP select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_7
toolchain/toolchain-external/toolchain-external-codesourcery-mips/Config.in +1 -0
@@ -11,6 +11,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS select BR2_TOOLCHAIN_EXTERNAL_GLIBC select BR2_TOOLCHAIN_HAS_SSP select BR2_TOOLCHAIN_HAS_NATIVE_RPC + select BR2_TOOLCHAIN_HAS_OPENMP select BR2_INSTALL_LIBSTDCPP select BR2_HOSTARCH_NEEDS_IA32_LIBS select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_4
toolchain/toolchain-external/toolchain-external-linaro-aarch64-be/Config.in +1 -0
@@ -10,6 +10,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_BE select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_10 select BR2_TOOLCHAIN_GCC_AT_LEAST_7 select BR2_TOOLCHAIN_HAS_FORTRAN + select BR2_TOOLCHAIN_HAS_OPENMP help Toolchain for the AArch64 Big Endian architecture, from http://www.linaro.org/engineering/armv8/
toolchain/toolchain-external/toolchain-external-linaro-aarch64/Config.in +1 -0
@@ -10,6 +10,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64 select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_10 select BR2_TOOLCHAIN_GCC_AT_LEAST_7 select BR2_TOOLCHAIN_HAS_FORTRAN + select BR2_TOOLCHAIN_HAS_OPENMP help Toolchain for the AArch64 architecture, from http://www.linaro.org/engineering/armv8/
toolchain/toolchain-external/toolchain-external-linaro-arm/Config.in +1 -0
@@ -17,6 +17,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_10 select BR2_TOOLCHAIN_GCC_AT_LEAST_7 select BR2_TOOLCHAIN_HAS_FORTRAN + select BR2_TOOLCHAIN_HAS_OPENMP help Linaro toolchain for the ARM architecture. It uses Linaro GCC 2018.05 (based on gcc 7.3.1), Linaro GDB 2018.05 (based on
toolchain/toolchain-external/toolchain-external-linaro-armeb/Config.in +1 -0
@@ -13,6 +13,7 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_ARMEB select BR2_TOOLCHAIN_EXTERNAL_GLIBC select BR2_TOOLCHAIN_HAS_SSP select BR2_TOOLCHAIN_HAS_NATIVE_RPC + select BR2_TOOLCHAIN_HAS_OPENMP select BR2_INSTALL_LIBSTDCPP select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_10 select BR2_TOOLCHAIN_GCC_AT_LEAST_7
Signature · 1 line
2.17.1