sunxi: Use clrsetbits_le32 instead of multiple instruction
Subsystems (3)
PATCH v5 3/3 sunxi: Use clrsetbits_le32 instead of multiple instruction
From: Michael Trimarchi <[email protected]>
This will improve code readabilty
Signed-off-by Michael Trimarchi <[email protected]>
Signed-off-by Shyam Saini <[email protected]>
---
Changelogs:
V1->V2: none
V2->V3: Fix use of clrsetbits_le32 and setbits_le32 functions
V3->V4: Rebase to original series's patch 2 and 3
v4->V5 Use correct clear bit function
---
arch/arm/mach-sunxi/dram_sun8i_a33.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)arch/arm/mach-sunxi/dram_sun8i_a33.c +2 -5
@@ -145,11 +145,8 @@ static void auto_set_timing_para(struct dram_para *para) reg_val = (tcksrx <<24 ) | (tcksre <<16 ) | (tckesr <<8 ) | (tcke <<0 );writel (reg_val, &mctl_ctl->dramtmg5);/* Set two rank timing and exit self-refresh timing */ - reg_val =readl (&mctl_ctl->dramtmg8); - reg_val &= ~(0xff <<8 ); - reg_val &= ~(0xff <<0 ); - reg_val |= (0x33 <<8 ); - reg_val |= (0x10 <<0 ); +clrbits_le32 (&mctl_ctl->dramtmg8, (0xff <<8 ) | (0xff <<0 )); +setbits_le32 (&mctl_ctl->dramtmg8, (0x33 <<8 ) | (0x10 <<0 ));writel (reg_val, &mctl_ctl->dramtmg8);/* Set phy interface time */ reg_val = (0x2 <<24 ) | (t_rdata_en <<16 ) | (0x1 <<8 )
Signature · 1 line
2.11.0