Staging: rtl8192u: ieee80211: Remove custom macro IEEE80211_DEBUG
PATCH v2 1/1 Staging: rtl8192u: ieee80211: Remove custom macro IEEE80211_DEBUG
Remove the custom macro IEEE80211_DEBUG for printing message in dev_alloc_skb in order to maintain Linux kernel coding style based on which kernel does not print failure warning.
Issue suggested by Coccinelle
Signed-off-by Madhumitha Prabakaran <[email protected]>
---
Changes in v2:
- Removed the unnecessary braces
--- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c +2 -6
@@ -118,10 +118,8 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, sreturn NULL ; } skb =dev_alloc_skb (len +sizeof (struct rtl_80211_hdr_3addr ));//need to add something others? FIXME -if (!skb) { -IEEE80211_DEBUG (IEEE80211_DL_ERR ,"can't alloc skb for ADDBA_REQ\n" ); +if (!skb)return NULL ; - }memset (skb->data,0 ,sizeof (struct rtl_80211_hdr_3addr ));//I wonder whether it's necessary. Apparently kernel will not do it when alloc a skb. skb_reserve (skb, ieee->tx_headroom);
@@ -205,10 +203,8 @@ static struct sk_buff *ieee80211_DELBA( DelbaParamSet.field.tid = pBA->param_set.field.tid; skb =dev_alloc_skb (len +sizeof (struct rtl_80211_hdr_3addr ));//need to add something others? FIXME -if (!skb) { -IEEE80211_DEBUG (IEEE80211_DL_ERR ,"can't alloc skb for ADDBA_REQ\n" ); +if (!skb)return NULL ; - }// memset(skb->data, 0, len+sizeof( struct rtl_80211_hdr_3addr)); skb_reserve (skb, ieee->tx_headroom);
Signature · 1 line
2.17.1