Skip to contentSkip to conversation

Staging: rtl8192u: ieee80211: Remove custom macro IEEE80211_DEBUG

PATCH Superseded Madhumitha Prabakaran 2 participants 2 messages Mar 28, 2019 – Mar 29, 2019 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8192u: ieee80211: Remove custom macro IEEE80211_DEBUG

Remove the custom macro IEEE80211_DEBUG for printing message in dev_alloc_skb in order to maintain Linux kernel coding style based on which kernel does not print failure warning.

Issue suggested by Coccinelle.

---
 drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c +0 -2
index 109445407cec..085309aace94 100644
@@ -119,7 +119,6 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, s
 	}
 	skb = dev_alloc_skb(len + sizeof(struct rtl_80211_hdr_3addr)); //need to add something others? FIXME
 	if (!skb) {
-		IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc skb for ADDBA_REQ\n");
 		return NULL;
 	}
 
@@ -206,7 +205,6 @@ static struct sk_buff *ieee80211_DELBA(
 
 	skb = dev_alloc_skb(len + sizeof(struct rtl_80211_hdr_3addr)); //need to add something others? FIXME
 	if (!skb) {
-		IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc skb for ADDBA_REQ\n");
 		return NULL;
 	}
 //	memset(skb->data, 0, len+sizeof( struct rtl_80211_hdr_3addr));
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 16 lines · Madhumitha Prabakaran

Remove the custom macro IEEE80211_DEBUG for printing message in dev_alloc_skb in order to maintain Linux kernel coding style based on which kernel does not print failure warning.

Issue suggested by Coccinelle.

---
 drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c +0 -0
index 109445407cec..085309aace94 100644

drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, s · line 123

Quoted 6 lines
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c +0 -1
@@ -119,7 +119,6 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, s
 	}
 	skb = dev_alloc_skb(len + sizeof(struct rtl_80211_hdr_3addr)); //need to add something others? FIXME
 	if (!skb) {
-		IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc skb for ADDBA_REQ\n");
 		return NULL;
 	}

When you do this, the extra { } should also be removed.

Same for the rest of the patch.

thanks,

greg k-h