Skip to contentSkip to conversation

dt-bindings: vendor-prefixes: add AZW

PATCH In review Clément Péron 2 participants 4 messages Apr 4, 2019 – Apr 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: vendor-prefixes: add AZW

Shenzhen AZW Technology Co. Ltd. is a manufacturer specialized in Android smart TV boxes, Intel mini PCs and home cloud TV boxes with NAS.

Add the vendor prefix for AZW.

---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index 8b4ae37629b2..8313edbaf52e 100644
@@ -54,6 +54,7 @@ avic	Shanghai AVIC Optoelectronics Co., Ltd.
 avnet	Avnet, Inc.
 axentia	Axentia Technologies AB
 axis	Axis Communications AB
+azw     Shenzhen AZW Technology Co., Ltd.
 bananapi BIPAI KEJI LIMITED
 bhf	Beckhoff Automation GmbH & Co. KG
 bitmain	Bitmain Technologies
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 ARM: dts: sun50i: h6: Introduce Beelink GS1 board

Beelink GS1 is an Allwinner H6 based TV box,
which support:
- Allwinner H6 Quad-core 64-bit ARM Cortex-A53
- GPU Mali-T720
- 2GB LPDDR3 RAM
- AXP805 PMIC
- 1Gbps GMAC via RTL8211E
- FN-Link 6222B-SRB Wifi/BT
- 1x USB 2.0 Host and 1x USB 3.0 Host
- HDMI port
- S/PDIF Tx
- IR receiver
- 5V/2A DC power supply

---

Thanks to Jagan and Icenowy, most of this devicetree is taken from their works on the OrangePi One Plus and Pine H64.

 arch/arm64/boot/dts/allwinner/Makefile        |   1 +
 .../dts/allwinner/sun50i-h6-beelink-gs1.dts   | 252 ++++++++++++++++++
 2 files changed, 253 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index e4dce2f6fa3a..2dd806a3d5c9 100644
@@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-pc2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-prime.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus2.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-beelink-gs1.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts new file +252 -0

252 lines not on this page · raw message

Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH 2/2] ARM: dts: sun50i: h6: Introduce Beelink GS1 board

Hi,

Quoted 47 lines · Clément Péron

Beelink GS1 is an Allwinner H6 based TV box,
which support:
- Allwinner H6 Quad-core 64-bit ARM Cortex-A53
- GPU Mali-T720
- 2GB LPDDR3 RAM
- AXP805 PMIC
- 1Gbps GMAC via RTL8211E
- FN-Link 6222B-SRB Wifi/BT
- 1x USB 2.0 Host and 1x USB 3.0 Host
- HDMI port
- S/PDIF Tx
- IR receiver
- 5V/2A DC power supply

---

Thanks to Jagan and Icenowy, most of this devicetree is taken from their works on the OrangePi One Plus and Pine H64.

 arch/arm64/boot/dts/allwinner/Makefile        |   1 +
 .../dts/allwinner/sun50i-h6-beelink-gs1.dts   | 252 ++++++++++++++++++
 2 files changed, 253 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index e4dce2f6fa3a..2dd806a3d5c9 100644
@@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-pc2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-prime.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus2.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-beelink-gs1.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts new file +4 -0
new file mode 100644
index 000000000000..d927e7d33bf3
@@ -0,0 +1,252 @@
+// SPDX-License-Identifier: (GPL-2.0+ or MIT)
+/*
+ * Copyright (C) 2019 Clément Péron <[email protected]>
+ */

arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts line 14

Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts new file +10 -0
+
+/dts-v1/;
+
+#include "sun50i-h6.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+
+/ {
+	model = "Beelink GS1";
+	compatible = "azw,beelink-gs1", "allwinner,sun50i-h6";

Please add that board to Documentation/devicetree/bindings/arm/sunxi.yaml, it's new and in linux-next.

arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts line 103

Quoted 12 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts new file +12 -0
+&mmc0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc0_pins>;
+	vmmc-supply = <&reg_cldo1>;
+	cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
+	bus-width = <4>;
+	status = "okay";
+};
+
+&mmc2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc2_pins>;

If those (mmc0 and mmc2_pins) are the only muxing options as their names suggests, it should be set in the DTSI.

If not, the name of the pin group should be changed.

arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts line 202

Quoted 13 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts new file +13 -0
+			reg_cldo2: cldo2 {
+				regulator-always-on;
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-name = "vcc-wifi-1";
+			};
+
+			reg_cldo3: cldo3 {
+				regulator-always-on;
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-name = "vcc-wifi-2";
+			};

I don't see any SDIO bus declared, why do you need those regulators on?

Can you also declare the PIO regulators?

Thanks!
Maxmie

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#3 lore raw

Re: [PATCH 2/2] ARM: dts: sun50i: h6: Introduce Beelink GS1 board

Hi,

Quoted 57 lines · Maxime Ripard

Hi,

Quoted 53 lines · Clément Péron

Beelink GS1 is an Allwinner H6 based TV box,
which support:
- Allwinner H6 Quad-core 64-bit ARM Cortex-A53
- GPU Mali-T720
- 2GB LPDDR3 RAM
- AXP805 PMIC
- 1Gbps GMAC via RTL8211E
- FN-Link 6222B-SRB Wifi/BT
- 1x USB 2.0 Host and 1x USB 3.0 Host
- HDMI port
- S/PDIF Tx
- IR receiver
- 5V/2A DC power supply

---

Thanks to Jagan and Icenowy, most of this devicetree is taken from their works on the OrangePi One Plus and Pine H64.

 arch/arm64/boot/dts/allwinner/Makefile        |   1 +
 .../dts/allwinner/sun50i-h6-beelink-gs1.dts   | 252 ++++++++++++++++++
 2 files changed, 253 insertions(+)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
arch/arm64/boot/dts/allwinner/Makefile +1 -0
index e4dce2f6fa3a..2dd806a3d5c9 100644
@@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-pc2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-prime.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus2.dtb
+dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-beelink-gs1.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb
 dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts new file +10 -0
new file mode 100644
index 000000000000..d927e7d33bf3
@@ -0,0 +1,252 @@
+// SPDX-License-Identifier: (GPL-2.0+ or MIT)
+/*
+ * Copyright (C) 2019 Clément Péron <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "sun50i-h6.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
Quoted 8 lines

arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts line 14

Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts new file +4 -0
+
+/ {
+     model = "Beelink GS1";
+     compatible = "azw,beelink-gs1", "allwinner,sun50i-h6";

Please add that board to Documentation/devicetree/bindings/arm/sunxi.yaml, it's new and in linux-next.

OK didn't know about that will do it.

Quoted 16 lines

arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts line 103

Quoted 13 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts new file +12 -0
+&mmc0 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&mmc0_pins>;
+     vmmc-supply = <&reg_cldo1>;
+     cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>;
+     bus-width = <4>;
+     status = "okay";
+};
+
+&mmc2 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&mmc2_pins>;

If those (mmc0 and mmc2_pins) are the only muxing options as their names suggests, it should be set in the DTSI.

Yes, it's the only muxing. I will add a patch to move these in the SOC dtsi.

Quoted 17 lines

If not, the name of the pin group should be changed.

arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts line 202

Quoted 13 lines
arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts new file +13 -0
+                     reg_cldo2: cldo2 {
+                             regulator-always-on;
+                             regulator-min-microvolt = <3300000>;
+                             regulator-max-microvolt = <3300000>;
+                             regulator-name = "vcc-wifi-1";
+                     };
+
+                     reg_cldo3: cldo3 {
+                             regulator-always-on;
+                             regulator-min-microvolt = <3300000>;
+                             regulator-max-microvolt = <3300000>;
+                             regulator-name = "vcc-wifi-2";
+                     };
Quoted 1 line

I don't see any SDIO bus declared, why do you need those regulators on?

You're right forget to remove. Will do.

Quoted 2 lines

Can you also declare the PIO regulators?

Ok,

Thanks for the review.

Quoted 8 lines

Thanks!
Maxmie

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com