Skip to contentSkip to conversation

CIFS: display noacl in the mount options

PATCH In review XiaoLi Feng 2 participants 5 messages Apr 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 CIFS: display noacl in the mount options

From: "[email protected]" <[email protected]>

The mount option noacl aren't shown in /proc/mounts even if they are mounted successfully. And smb2.0+ don't support ACL. Display noacl acquiescently if ACL is unsupported.

---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)
fs/cifs/cifsfs.c +2 -0
index f9b71c12cc9f..80ee4fbcd25b 100644
@@ -535,6 +535,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
 		seq_puts(s, ",dynperm");
 	if (root->d_sb->s_flags & SB_POSIXACL)
 		seq_puts(s, ",acl");
+	else
+		seq_puts(s, ",noacl");
 	if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MF_SYMLINKS)
 		seq_puts(s, ",mfsymlinks");
 	if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE)
Signature · 1 line
2.18.1
#1 lore raw

Could this get users confused who mount with "cifsacl" and see "noacl" as well?

Also this is really saying no support for "POSIX (draft standard) ACL support" not no support for SMB3 ACL (or similarly "RichACL" or NFS ACL or ... NTFS ACL or ... which are somewhat similar and common).

Could get confusing

Quoted 29 lines · XiaoLi Feng

From: "[email protected]" <[email protected]>

The mount option noacl aren't shown in /proc/mounts even if they are mounted successfully. And smb2.0+ don't support ACL. Display noacl acquiescently if ACL is unsupported.

---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)
fs/cifs/cifsfs.c +2 -1
index f9b71c12cc9f..80ee4fbcd25b 100644
@@ -535,6 +535,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)
                seq_puts(s, ",dynperm");
        if (root->d_sb->s_flags & SB_POSIXACL)
                seq_puts(s, ",acl");
+       else
+               seq_puts(s, ",noacl");
        if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MF_SYMLINKS)
                seq_puts(s, ",mfsymlinks");
        if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE)
--

2.18.1

Signature · 3 lines
Thanks,

Steve
#2 lore raw

Yes, could get users confused. But from the Man page:

noacl Do not allow POSIX ACL operations even if server would support them.
The CIFS client can get and set POSIX ACLs (getfacl, setfacl) to Samba servers version 3.0.10 and later. Setting POSIX ACLs requires enabling both CIFS_XATTR and then CIFS_POSIX support in the CIFS configuration options when building the cifs module. POSIX ACL support can be disabled on a per mount basis by specifying noacl on mount.

cifsacl
This option is used to map CIFS/NTFS ACLs to/from Linux permission bits, map SIDs to/from UIDs and GIDs, and get and set Security Descriptors. See section on CIFS/NTFS ACL, SID/UID/GID MAPPING, SECURITY DESCRIPTORS for more information.

These two options are for different ACL. There is still a option "acl". It also can be mounted with cifsacl together for SMB1.0. There are some errors in my commit log. Should say "smb2.0+ don't support POSIX ACL". What do you think about this patch? It also makes sense if doesn't display "noacl".

----- Original Message -----

Quoted 53 lines

From: "Steve French" <[email protected]>
To: "XiaoLi Feng" <[email protected]>
Cc: "CIFS" <[email protected]>, "[email protected]" <[email protected]>
Sent: Wednesday, April 10, 2019 10:56:19 AM
Subject: Re: [PATCH v2] CIFS: display noacl in the mount options

Could this get users confused who mount with "cifsacl" and see "noacl" as well?

Also this is really saying no support for "POSIX (draft standard) ACL support" not no support for SMB3 ACL (or similarly "RichACL" or NFS ACL or ... NTFS ACL or ... which are somewhat similar and common).

Could get confusing

Quoted 27 lines · XiaoLi Feng

From: "[email protected]" <[email protected]>

The mount option noacl aren't shown in /proc/mounts even if they are mounted successfully. And smb2.0+ don't support ACL. Display noacl acquiescently if ACL is unsupported.

---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)
fs/cifs/cifsfs.c +2 -0
index f9b71c12cc9f..80ee4fbcd25b 100644
@@ -535,6 +535,8 @@ cifs_show_options(struct seq_file *s, struct dentry
 *root)
                seq_puts(s, ",dynperm");
        if (root->d_sb->s_flags & SB_POSIXACL)
                seq_puts(s, ",acl");
+       else
+               seq_puts(s, ",noacl");
        if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MF_SYMLINKS)
                seq_puts(s, ",mfsymlinks");
        if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE)
Quoted 3 lines

--
2.18.1

--
Thanks,

Steve

#3 lore raw

Maybe we should change the option "acl|noacl" to "posixacl|noposixacl".

----- Original Message -----

Quoted 86 lines

From: "Xiaoli Feng" <[email protected]>
To: "Steve French" <[email protected]>
Cc: "CIFS" <[email protected]>, "[email protected]" <[email protected]>
Sent: Wednesday, April 10, 2019 11:40:16 AM
Subject: Re: [PATCH v2] CIFS: display noacl in the mount options

Yes, could get users confused. But from the Man page:

noacl Do not allow POSIX ACL operations even if server would support them.
The CIFS client can get and set POSIX ACLs (getfacl, setfacl) to Samba servers version 3.0.10 and later. Setting POSIX ACLs requires enabling both CIFS_XATTR and then CIFS_POSIX support in the CIFS configuration options when building the cifs module. POSIX ACL support can be disabled on a per mount basis by specifying noacl on mount.

cifsacl
This option is used to map CIFS/NTFS ACLs to/from Linux permission bits, map SIDs to/from UIDs and GIDs, and get and set Security Descriptors.
See section on CIFS/NTFS ACL, SID/UID/GID MAPPING, SECURITY DESCRIPTORS for more information.

These two options are for different ACL. There is still a option "acl". It also can be mounted with cifsacl together for SMB1.0.
There are some errors in my commit log. Should say "smb2.0+ don't support POSIX ACL". What do you think about this patch? It also
makes sense if doesn't display "noacl".

----- Original Message -----

Quoted 54 lines

From: "Steve French" <[email protected]>
To: "XiaoLi Feng" <[email protected]>
Cc: "CIFS" <[email protected]>, "[email protected]" <[email protected]>
Sent: Wednesday, April 10, 2019 10:56:19 AM
Subject: Re: [PATCH v2] CIFS: display noacl in the mount options

Could this get users confused who mount with "cifsacl" and see "noacl" as well?

Also this is really saying no support for "POSIX (draft standard) ACL support" not no support for SMB3 ACL (or similarly "RichACL" or NFS ACL or ... NTFS ACL or ... which are somewhat similar and common).

Could get confusing

Quoted 27 lines · XiaoLi Feng

From: "[email protected]" <[email protected]>

The mount option noacl aren't shown in /proc/mounts even if they are mounted successfully. And smb2.0+ don't support ACL. Display noacl acquiescently if ACL is unsupported.

---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)
fs/cifs/cifsfs.c +2 -0
index f9b71c12cc9f..80ee4fbcd25b 100644
@@ -535,6 +535,8 @@ cifs_show_options(struct seq_file *s, struct dentry
 *root)
                seq_puts(s, ",dynperm");
        if (root->d_sb->s_flags & SB_POSIXACL)
                seq_puts(s, ",acl");
+       else
+               seq_puts(s, ",noacl");
        if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MF_SYMLINKS)
                seq_puts(s, ",mfsymlinks");
        if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE)
Quoted 3 lines

--
2.18.1

--
Thanks,

Steve

#4 lore raw
Quoted 3 lines · Xiaoli Feng

Maybe we should change the option "acl|noacl" to "posixacl|noposixacl".

That could be better although I lean toward waiting until we experiment a little more with the SMB3.1.1 POSIX Extensions and any additional mount options for them.

Quoted 87 lines

----- Original Message -----

Quoted 86 lines

From: "Xiaoli Feng" <[email protected]>
To: "Steve French" <[email protected]>
Cc: "CIFS" <[email protected]>, "[email protected]" <[email protected]>
Sent: Wednesday, April 10, 2019 11:40:16 AM
Subject: Re: [PATCH v2] CIFS: display noacl in the mount options

Yes, could get users confused. But from the Man page:

noacl Do not allow POSIX ACL operations even if server would support them.
The CIFS client can get and set POSIX ACLs (getfacl, setfacl) to Samba servers version 3.0.10 and later. Setting POSIX ACLs requires enabling both CIFS_XATTR and then CIFS_POSIX support in the CIFS configuration options when building the cifs module. POSIX ACL support can be disabled on a per mount basis by specifying noacl on mount.

cifsacl
This option is used to map CIFS/NTFS ACLs to/from Linux permission bits, map SIDs to/from UIDs and GIDs, and get and set Security Descriptors.
See section on CIFS/NTFS ACL, SID/UID/GID MAPPING, SECURITY DESCRIPTORS for more information.

These two options are for different ACL. There is still a option "acl". It also can be mounted with cifsacl together for SMB1.0.
There are some errors in my commit log. Should say "smb2.0+ don't support POSIX ACL". What do you think about this patch? It also
makes sense if doesn't display "noacl".

----- Original Message -----

Quoted 54 lines

From: "Steve French" <[email protected]>
To: "XiaoLi Feng" <[email protected]>
Cc: "CIFS" <[email protected]>, "[email protected]" <[email protected]>
Sent: Wednesday, April 10, 2019 10:56:19 AM
Subject: Re: [PATCH v2] CIFS: display noacl in the mount options

Could this get users confused who mount with "cifsacl" and see "noacl" as well?

Also this is really saying no support for "POSIX (draft standard) ACL support" not no support for SMB3 ACL (or similarly "RichACL" or NFS ACL or ... NTFS ACL or ... which are somewhat similar and common).

Could get confusing

Quoted 27 lines · XiaoLi Feng

From: "[email protected]" <[email protected]>

The mount option noacl aren't shown in /proc/mounts even if they are mounted successfully. And smb2.0+ don't support ACL. Display noacl acquiescently if ACL is unsupported.

---
 fs/cifs/cifsfs.c | 2 ++
 1 file changed, 2 insertions(+)
fs/cifs/cifsfs.c +2 -0
index f9b71c12cc9f..80ee4fbcd25b 100644
@@ -535,6 +535,8 @@ cifs_show_options(struct seq_file *s, struct dentry
 *root)
                seq_puts(s, ",dynperm");
        if (root->d_sb->s_flags & SB_POSIXACL)
                seq_puts(s, ",acl");
+       else
+               seq_puts(s, ",noacl");
        if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MF_SYMLINKS)
                seq_puts(s, ",mfsymlinks");
        if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE)
Quoted 3 lines

--
2.18.1

--
Thanks,

Steve

Signature · 3 lines
Thanks,

Steve