CIFS: display noacl and locallease in the mount options
Subsystems (2)
PATCH 1/1 CIFS: display noacl and locallease in the mount options
From: "[email protected]" <[email protected]>
The mount option noacl and locallease aren't shown in /proc/mounts even if they are mounted successfully. Now display them.
--- fs/cifs/cifsfs.c | 4 ++++ 1 file changed, 4 insertions(+)
fs/cifs/cifsfs.c +4 -0
@@ -503,6 +503,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)seq_puts (s,",unix" ); else seq_puts(s, ",nounix"); +if (tcon->local_lease) +seq_puts (s,",locallease" );if (cifs_sb->mnt_cifs_flags &CIFS_MOUNT_NO_DFS )seq_puts (s,",nodfs" );if (cifs_sb->mnt_cifs_flags &CIFS_MOUNT_POSIX_PATHS )
@@ -535,6 +537,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)seq_puts (s,",dynperm" );if (root->d_sb->s_flags &SB_POSIXACL )seq_puts (s,",acl" ); +else +seq_puts (s,",noacl" );if (cifs_sb->mnt_cifs_flags &CIFS_MOUNT_MF_SYMLINKS )seq_puts (s,",mfsymlinks" );if (cifs_sb->mnt_cifs_flags &CIFS_MOUNT_FSCACHE )
Signature · 1 line
2.18.1
We already have locallease patch in for next.
https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=1d4fcc75b71f8a9f9807a000da53d9885546e2f3
Can you resend this patch only for noacl?
Quoted 36 lines · XiaoLi Feng
From: "[email protected]" <[email protected]>
The mount option noacl and locallease aren't shown in
/proc/mountseven if they are mounted successfully. Now display them.Signed-off-by [email protected] <[email protected]>--- fs/cifs/cifsfs.c | 4 ++++ 1 file changed, 4 insertions(+)fs/cifs/cifsfs.c +4
-1@@ -503,6 +503,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)seq_puts (s,",unix" ); else seq_puts(s, ",nounix"); +if (tcon->local_lease) +seq_puts (s,",locallease" );if (cifs_sb->mnt_cifs_flags &CIFS_MOUNT_NO_DFS )seq_puts (s,",nodfs" );if (cifs_sb->mnt_cifs_flags &CIFS_MOUNT_POSIX_PATHS )@@ -535,6 +537,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)seq_puts (s,",dynperm" );if (root->d_sb->s_flags &SB_POSIXACL )seq_puts (s,",acl" ); +else +seq_puts (s,",noacl" );if (cifs_sb->mnt_cifs_flags &CIFS_MOUNT_MF_SYMLINKS )seq_puts (s,",mfsymlinks" );if (cifs_sb->mnt_cifs_flags &CIFS_MOUNT_FSCACHE ) --2.18.1
Hi Kenneth,
Now re-sended it. By the way, suddenly I have an idea. Such as for your this patch, I suppose you see the bug
https://bugzilla.redhat.com/show_bug.cgi?id=1662406
Bug 1662406 - [RHEL8 cifs]: the option locallease isn't shown in /proc/mounts
and then send this patch. I think it's better that add the bugzilla info in the commit log. Just my opinion. But if you didn't see this bugzilla, ignore what I said.
Thanks.
----- Original Message -----
Quoted 50 lines
From: "Kenneth Dsouza" <[email protected]>
To: "XiaoLi Feng" <[email protected]>
Cc: "CIFS" <[email protected]>, "[email protected]" <[email protected]>
Sent: Tuesday, April 9, 2019 9:59:39 PM
Subject: Re: [PATCH v1] CIFS: display noacl and locallease in the mount optionsWe already have locallease patch in for next.
https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=1d4fcc75b71f8a9f9807a000da53d9885546e2f3
Can you resend this patch only for noacl?Quoted 38 lines · XiaoLi Feng
From: "[email protected]" <[email protected]>
The mount option noacl and locallease aren't shown in
/proc/mountseven if they are mounted successfully. Now display them.Signed-off-by [email protected] <[email protected]>--- fs/cifs/cifsfs.c | 4 ++++ 1 file changed, 4 insertions(+)fs/cifs/cifsfs.c +2
-0@@ -503,6 +503,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)seq_puts (s,",unix" ); else seq_puts(s, ",nounix"); +if (tcon->local_lease) +seq_puts (s,",locallease" );if (cifs_sb->mnt_cifs_flags &CIFS_MOUNT_NO_DFS )seq_puts (s,",nodfs" );if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_POSIX_PATHS)fs/cifs/cifsfs.c +2
-0@@ -535,6 +537,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root)seq_puts (s,",dynperm" );if (root->d_sb->s_flags &SB_POSIXACL )seq_puts (s,",acl" ); +else +seq_puts (s,",noacl" );if (cifs_sb->mnt_cifs_flags &CIFS_MOUNT_MF_SYMLINKS )seq_puts (s,",mfsymlinks" );if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_FSCACHE)--
2.18.1