Skip to contentSkip to conversation

drm/bochs: use simple display pipe

PATCH In review Gerd Hoffmann 3 participants 5 messages Apr 10, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bochs: use simple display pipe

---
 drivers/gpu/drm/bochs/bochs.h     |   6 +-
 drivers/gpu/drm/bochs/bochs_kms.c | 178 +++++++++---------------------
 2 files changed, 53 insertions(+), 131 deletions(-)
drivers/gpu/drm/bochs/bochs.h +3 -3
index a7f6723bebdd..36f6ee725d13 100644
@@ -7,6 +7,7 @@
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_encoder.h>
 #include <drm/drm_fb_helper.h>
+#include <drm/drm_simple_kms_helper.h>
 
 #include <drm/drm_gem.h>
 
@@ -69,9 +70,8 @@ struct bochs_device {
 	struct edid *edid;
 
 	/* drm */
-	struct drm_device  *dev;
-	struct drm_crtc crtc;
-	struct drm_encoder encoder;
+	struct drm_device *dev;
+	struct drm_simple_display_pipe pipe;
 	struct drm_connector connector;
 
 	/* ttm */
drivers/gpu/drm/bochs/bochs_kms.c +50 -128

218 lines not on this page · raw message

Signature · 1 line
2.18.1
Acked-by on v1 1/1
#3 lore raw
In reply to Gerd Hoffmann

Hi Gerd.

drivers/gpu/drm/bochs/bochs.h struct bochs_device { · line 75

Quoted 13 lines

#include <drm/drm_gem.h>

drivers/gpu/drm/bochs/bochs.h +2 -3
@@ -69,9 +70,8 @@ struct bochs_device {
 	struct edid *edid;
 
 	/* drm */
-	struct drm_device  *dev;
-	struct drm_crtc crtc;
-	struct drm_encoder encoder;
+	struct drm_device *dev;
+	struct drm_simple_display_pipe pipe;
 	struct drm_connector connector;

Have you considered to embed drm_device in the bochs_device struct? This is the new way to do it.

This should likely be a follow-up patch...

Rest of the patch looked good.
Did not do a proper review but you can add my:

Sam

Acked-by on v1 1/1
#4 lore raw
In reply to Gerd Hoffmann

Hi Gerd.

drivers/gpu/drm/bochs/bochs.h struct bochs_device { · line 75

Quoted 13 lines

#include <drm/drm_gem.h>

drivers/gpu/drm/bochs/bochs.h +2 -3
@@ -69,9 +70,8 @@ struct bochs_device {
 	struct edid *edid;
 
 	/* drm */
-	struct drm_device  *dev;
-	struct drm_crtc crtc;
-	struct drm_encoder encoder;
+	struct drm_device *dev;
+	struct drm_simple_display_pipe pipe;
 	struct drm_connector connector;

Have you considered to embed drm_device in the bochs_device struct? This is the new way to do it.

This should likely be a follow-up patch...

Rest of the patch looked good.
Did not do a proper review but you can add my:

Sam