Skip to contentSkip to conversation

drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

PATCH Superseded Li Qiang 2 participants 2 messages Apr 10, 2019 – Apr 11, 2019

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Li Qiang

author
#0 lore raw

PATCH v2 1/1 drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this.

Spotted by Coverity: CID 27441

---
Changes since v1: fill ret before goto close_fd per Rosen's review

 drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2 -1
index da772d026..eff001b59 100644
@@ -244,7 +244,8 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id,
 	if (ret) {
 		IFPGA_RAWDEV_PMD_ERR("stat on bitstream file failed: %s\n",
 				file_name);
-		return -EINVAL;
+		ret = -EINVAL;
+		goto close_fd;
 	}
 	buffer_size = file_stat.st_size;
 	IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Li Qiang [mailto:[email protected]]
Sent: Wednesday, April 10, 2019 21:43
To: Xu, Rosen <[email protected]>; Zhang, Tianfei <[email protected]>
Cc: [email protected]; [email protected]; Li Qiang <[email protected]>
Subject: [PATCH v2] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

Quoted 2 lines

In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this.

It's a bug fix, so pls add 'Fix XXX'.

Quoted 1 line

Spotted by Coverity: CID 27441

It should be Coverity issue: 279441

Quoted 1 line

pls add:
Cc: [email protected]

Quoted 26 lines

---
Changes since v1: fill ret before goto close_fd per Rosen's review

 drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2 -1
index da772d026..eff001b59 100644
@@ -244,7 +244,8 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int
 port_id,
 	if (ret) {
 		IFPGA_RAWDEV_PMD_ERR("stat on bitstream file
 failed: %s\n",
 				file_name);
-		return -EINVAL;
+		ret = -EINVAL;
+		goto close_fd;
 	}
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +0 -1
 	buffer_size = file_stat.st_size;
 	IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
--

2.17.1