drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
PATCH v3 1/1 drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this.
Coverity issue: 279441
---
Change since v2: add proper tags in commit message
drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2 -1
@@ -244,7 +244,8 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id,if (ret) {IFPGA_RAWDEV_PMD_ERR ("stat on bitstream file failed: %s\n" , file_name); -return -EINVAL ; + ret = -EINVAL ; + goto close_fd; } buffer_size = file_stat.st_size;IFPGA_RAWDEV_PMD_INFO ("bitstream file size: %zu\n" , buffer_size);
Signature · 1 line
2.19.1.3.ge56e4f7
Quoted 43 lines
-----Original Message-----
From: Li Qiang [mailto:[email protected]]
Sent: Tuesday, April 16, 2019 13:05
To: Xu, Rosen <[email protected]>; Zhang, Tianfei <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Li Qiang <[email protected]>
Subject: [PATCH v3] drivers:ifpga_rawdev: fix fd leak inrte_fpga_do_prIn
rte_fpga_do_pr()function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this.Coverity issue: 279441
Fixes ef1e8ede3da59e("raw/ifpga: add Intel FPGA bus rawdev driver")Signed-off-by Li Qiang <[email protected]>---
Change since v2: add proper tags in commit messagedrivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/raw/ifpga_rawdev/ifpga_rawdev.c +2
-1@@ -244,7 +244,8 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id, if (ret) {IFPGA_RAWDEV_PMD_ERR ("stat on bitstream file failed: %s\n", file_name); -return -EINVAL ; + ret = -EINVAL ; + goto close_fd; }drivers/raw/ifpga_rawdev/ifpga_rawdev.c +0
-1buffer_size = file_stat.st_size;IFPGA_RAWDEV_PMD_INFO ("bitstream file size: %zu\n" , buffer_size); --
Quoted 2 lines
2.19.1.3.ge56e4f7
Thomas Monjalon
AppliedQuoted 10 lines
Quoted 8 lines
In
rte_fpga_do_pr()function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this.Coverity issue: 279441
Fixes ef1e8ede3da59e("raw/ifpga: add Intel FPGA bus rawdev driver")Signed-off-by Li Qiang <[email protected]>Acked-by Rosen Xu <[email protected]>
Applied, thanks