igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v2
v2 cover igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v2
i915_pm_lpsp patch, sending v2 version with an additional patch to add pm_lpsp igt subtests to CI fast feedback list.
Revision 1 Link: https://patchwork.freedesktop.org/series/58051/
Anshuman Gupta (2):
igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11. DO_NOT_MERGE add i915_pm_lpsp subtests to CI fast feedback list.
tests/i915/i915_pm_lpsp.c | 30 ++++++++++++++++++++++++++++-- tests/intel-ci/fast-feedback.testlist | 4 ++++ 2 files changed, 32 insertions(+), 2 deletions(-)
Signature · 6 lines
2.7.4 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH v2 1/2 igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11.
Enabling i915_pm_lpsp igt tests for all platforms till Gen11. Earlier these test were enabled only on haswell and broadwell platforms.
--- tests/i915/i915_pm_lpsp.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)
tests/i915/i915_pm_lpsp.c +28 -2
@@ -30,18 +30,43 @@#include <fcntl.h> #include <unistd.h> +#define HSW_PW_CTL_IDX_GLOBAL 15 +#define SKL_PW_CTL_IDX_PW_2 15 +#define ICL_PW_CTL_IDX_PW_3 2 + +#define HSW_PWR_WELL_CTL_REQ (pw_idx) (0x2 << ((pw_idx) * 2)) +#define HSW_PWR_WELL_CTL_STATE (pw_idx) (0x1 << ((pw_idx) * 2)) + +int no_lpsp_pw_idx;static bool supports_lpsp (uint32_t devid) { -return IS_HASWELL (devid) ||IS_BROADWELL (devid); +return IS_HASWELL (devid) ||IS_BROADWELL (devid) + ||AT_LEAST_GEN (devid,9 ); +} + +static bool get_no_lpsp_pw_idx (uint32_t devid) +{ +if (IS_HASWELL (devid) ||IS_BROADWELL (devid)) + no_lpsp_pw_idx =HSW_PW_CTL_IDX_GLOBAL ; +else if (IS_GEN (devid,11 )) + no_lpsp_pw_idx =ICL_PW_CTL_IDX_PW_3 ; +else if (AT_LEAST_GEN (devid,9 )) + no_lpsp_pw_idx =SKL_PW_CTL_IDX_PW_2 ; +else +return false; + +return true; }static bool lpsp_is_enabled (int drm_fd) {uint32_t val; +uint32_t mask =HSW_PWR_WELL_CTL_REQ (no_lpsp_pw_idx) | +HSW_PWR_WELL_CTL_STATE (no_lpsp_pw_idx); val =INREG (HSW_PWR_WELL_CTL2 ); -return !(val &HSW_PWR_WELL_STATE_ENABLED ); +return !((val & mask) == mask); }/* The LPSP mode is all about an enabled pipe, but we expect to also be in the
@@ -212,6 +237,7 @@ igt_mainintel_register_access_init (intel_get_pci_device (),0 , drm_fd); +igt_require (get_no_lpsp_pw_idx (devid));kmstest_set_vt_graphics_mode (); }
Signature · 6 lines
2.7.4 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH v2 2/2 DO_NOT_MERGE add i915_pm_lpsp subtests to CI fast feedback list.
In reply to Anshuman GuptaThis patch adds below i915_pm_lpsp subtests to CI fast feedback list in order to test these subtest on ICL
(which is affected platform).
Subtests:
screens-disabled
edp-native
edp-panel-fitter
non-edp
--- tests/intel-ci/fast-feedback.testlist | 4 ++++ 1 file changed, 4 insertions(+)
tests/intel-ci/fast-feedback.testlist +4 -0
@@ -227,6 +227,10 @@ igt@kms_psr@sprite_plane_onoff igt@kms_psr@primary_mmap_gtt igt@kms_setmode@basic-clone-single-crtc igt@i915_pm_backlight@basic-brightness +igt@i915_pm_lpsp@edp-native +igt@i915_pm_lpsp@edp-panel-fitter +igt@i915_pm_lpsp@non-edp +igt@i915_pm_lpsp@screens-disabled igt@i915_pm_rpm@basic-pci-d3-state igt@i915_pm_rpm@basic-rte igt@i915_pm_rps@basic-api
Signature · 6 lines
2.7.4 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v2
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v2
URL : https://patchwork.freedesktop.org/series/59048/
State : failure
== Summary ==
CI Bug Log - changes from IGT_4931 -> IGTPW_2797
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2797 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_2797, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59048/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2797:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_lpsp@non-edp:
- fi-bxt-j4205: NOTRUN -> FAIL
- fi-icl-y: NOTRUN -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2797 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +61
* igt@i915_pm_lpsp@edp-native:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +3
- fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] +3
- fi-kbl-x1275: NOTRUN -> SKIP [fdo#109271] +1
- fi-skl-lmem: NOTRUN -> SKIP [fdo#109271] +1
- fi-bwr-2160: NOTRUN -> SKIP [fdo#109271] +3
- fi-bdw-5557u: NOTRUN -> SKIP [fdo#109271] +1
- fi-skl-6770hq: NOTRUN -> SKIP [fdo#109271] +1
- fi-kbl-8809g: NOTRUN -> SKIP [fdo#109271] +2
- fi-kbl-guc: NOTRUN -> SKIP [fdo#109271] +2
- fi-hsw-4770: NOTRUN -> SKIP [fdo#109271] +1
- fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +1
- fi-skl-gvtdvm: NOTRUN -> SKIP [fdo#109271] +1
- fi-skl-6700k2: NOTRUN -> SKIP [fdo#109271] +1
- fi-skl-iommu: NOTRUN -> SKIP [fdo#109271] +1
- fi-cfl-guc: NOTRUN -> SKIP [fdo#109271] +1
- fi-cfl-8700k: NOTRUN -> SKIP [fdo#109271] +1
- fi-apl-guc: NOTRUN -> SKIP [fdo#109271] +1
- fi-cfl-8109u: NOTRUN -> SKIP [fdo#109271] +1
- fi-bxt-j4205: NOTRUN -> SKIP [fdo#109271] +1* igt@i915_pm_lpsp@edp-panel-fitter:
- fi-ilk-650: NOTRUN -> SKIP [fdo#109271] +3
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +3
- fi-bdw-gvtdvm: NOTRUN -> SKIP [fdo#109271] +1
- fi-hsw-peppy: NOTRUN -> FAIL [fdo#106602]* igt@i915_pm_lpsp@non-edp:
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] +3
- fi-ivb-3770: NOTRUN -> SKIP [fdo#109271] +3
- fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] +3
- fi-snb-2600: NOTRUN -> SKIP [fdo#109271] +3
- fi-kbl-r: NOTRUN -> SKIP [fdo#109271]
- fi-hsw-peppy: NOTRUN -> SKIP [fdo#109271]
- fi-whl-u: NOTRUN -> SKIP [fdo#109271]
- fi-skl-6600u: NOTRUN -> SKIP [fdo#109271] * igt@i915_pm_lpsp@screens-disabled:
- fi-elk-e7500: NOTRUN -> SKIP [fdo#109271] +3
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] +3
* igt@i915_selftest@live_uncore:
- fi-ivb-3770: PASS -> DMESG-FAIL [fdo#110210]
* igt@kms_busy@basic-flip-c:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_psr@primary_mmap_gtt:
- fi-skl-guc: NOTRUN -> SKIP [fdo#109271] +51
#### Possible fixes ####
* igt@gem_cpu_reloc@basic:
- {fi-icl-u3}: DMESG-WARN [fdo#107724] -> PASS
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#106602]: https://bugs.freedesktop.org/show_bug.cgi?id=106602
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210
[fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (45 -> 43)
------------------------------
Additional (2): fi-skl-guc fi-byt-clapper
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* IGT: IGT_4931 -> IGTPW_2797
CI_DRM_5877: 03f3a57c6df4ef469bd9f528bb9e0201ddd0ee14 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2797: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2797/
IGT_4931: 019f892e5d1a0a9643cb726c47ce2d99c14b444f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2797/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] ✗ Fi.CI.BAT: failure for igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v2
Hi Imre ,
Could you please review the i915_pm_lpsp series. "https://patchwork.freedesktop.org/series/59048/"
There is non-edp subtest igt failure for broxton. "https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2797/fi-bxt-j4205/igt@[email protected]"
This broxton machine has a DP1 connector and connected on Pipe A and to
DDI A. (https://intel-gfx-ci.01.org/hardware/fi-bxt-j4205/fi-bxt-j4205/i915_display_info.txt)
Current implementation of lpsp_is_enabled() is checking for state of power well 2 for gen9 and power well 3 for gen 11, these power well should be turned off in order to lpsp enabled.
But as above broxton machine has connected to port DDI A, that could be the reason power well 2 is not active and non-edp igt subtest get failed on this machine.
What should be the correct way to check lpsp_is_enabled(), could you please provide your suggestion.
Thanks ,
Anshuman Gupta.
Quoted 139 lines · Patchwork
== Series Details ==
Series: igt/i915/i915_pm_lpsp enable
pm_lpspfor platforms till Gen11 v2
URL : https://patchwork.freedesktop.org/series/59048/
State : failure== Summary ==
CI Bug Log - changes from
IGT_4931->IGTPW_2797
====================================================Summary
-------**FAILURE**
Serious unknown changes coming with
IGTPW_2797absolutely need to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
IGTPW_2797, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.External URL: https://patchwork.freedesktop.org/api/1.0/series/59048/revisions/1/mbox/Possible new issues
-------------------Here are the unknown changes that may have been introduced in
IGTPW_2797:### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_lpsp@non-edp:
- fi-bxt-j4205: NOTRUN -> FAIL
- fi-icl-y: NOTRUN -> SKIPKnown issues
------------Here are the changes found in
IGTPW_2797that come from known issues:### IGT changes ###
#### Issues hit ####
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +61* igt@i915_pm_lpsp@edp-native:
- fi-pnv-d510: NOTRUN -> SKIP [fdo#109271] +3 - fi-snb-2520m: NOTRUN -> SKIP [fdo#109271] +3 - fi-kbl-x1275: NOTRUN -> SKIP [fdo#109271] +1 - fi-skl-lmem: NOTRUN -> SKIP [fdo#109271] +1 - fi-bwr-2160: NOTRUN -> SKIP [fdo#109271] +3 - fi-bdw-5557u: NOTRUN -> SKIP [fdo#109271] +1 - fi-skl-6770hq: NOTRUN -> SKIP [fdo#109271] +1 - fi-kbl-8809g: NOTRUN -> SKIP [fdo#109271] +2 - fi-kbl-guc: NOTRUN -> SKIP [fdo#109271] +2 - fi-hsw-4770: NOTRUN -> SKIP [fdo#109271] +1 - fi-skl-6260u: NOTRUN -> SKIP [fdo#109271] +1 - fi-skl-gvtdvm: NOTRUN -> SKIP [fdo#109271] +1 - fi-skl-6700k2: NOTRUN -> SKIP [fdo#109271] +1 - fi-skl-iommu: NOTRUN -> SKIP [fdo#109271] +1 - fi-cfl-guc: NOTRUN -> SKIP [fdo#109271] +1 - fi-cfl-8700k: NOTRUN -> SKIP [fdo#109271] +1 - fi-apl-guc: NOTRUN -> SKIP [fdo#109271] +1 - fi-cfl-8109u: NOTRUN -> SKIP [fdo#109271] +1 - fi-bxt-j4205: NOTRUN -> SKIP [fdo#109271] +1* igt@i915_pm_lpsp@edp-panel-fitter:
- fi-ilk-650: NOTRUN -> SKIP [fdo#109271] +3 - fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +3 - fi-bdw-gvtdvm: NOTRUN -> SKIP [fdo#109271] +1 - fi-hsw-peppy: NOTRUN -> FAIL [fdo#106602]* igt@i915_pm_lpsp@non-edp:
- fi-byt-n2820: NOTRUN -> SKIP [fdo#109271] +3 - fi-ivb-3770: NOTRUN -> SKIP [fdo#109271] +3 - fi-byt-j1900: NOTRUN -> SKIP [fdo#109271] +3 - fi-snb-2600: NOTRUN -> SKIP [fdo#109271] +3 - fi-kbl-r: NOTRUN -> SKIP [fdo#109271] - fi-hsw-peppy: NOTRUN -> SKIP [fdo#109271] - fi-whl-u: NOTRUN -> SKIP [fdo#109271] - fi-skl-6600u: NOTRUN -> SKIP [fdo#109271]* igt@i915_pm_lpsp@screens-disabled:
- fi-elk-e7500: NOTRUN -> SKIP [fdo#109271] +3
- fi-bsw-kefka: NOTRUN -> SKIP [fdo#109271] +3* igt@i915_selftest@live_uncore:
- fi-ivb-3770: PASS -> DMESG-FAIL [fdo#110210]* igt@kms_busy@basic-flip-c:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103191] / [fdo#107362]* igt@kms_psr@primary_mmap_gtt:
- fi-skl-guc: NOTRUN -> SKIP [fdo#109271] +51#### Possible fixes ####
* igt@gem_cpu_reloc@basic: - {fi-icl-u3}: DMESG-WARN [fdo#107724] -> PASS * igt@i915_selftest@live_contexts: - fi-bdw-gvtdvm: DMESG-FAIL [fdo#110235 ] -> PASS {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#106602]: https://bugs.freedesktop.org/show_bug.cgi?id=106602 [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210 [fdo#110235 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110235Participating hosts (45 -> 43)
------------------------------Additional (2): fi-skl-guc fi-byt-clapper
Missing (4): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyanBuild changes
-------------* IGT:
IGT_4931->IGTPW_2797
Quoted 8 lines
CI_DRM_5877: 03f3a57c6df4ef469bd9f528bb9e0201ddd0ee14 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_2797: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2797/ IGT_4931: 019f892e5d1a0a9643cb726c47ce2d99c14b444f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2797/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] ✗ Fi.CI.BAT: failure for igt/i915/i915_pm_lpsp enable pm_lpsp for platforms till Gen11 v2
Quoted 15 lines · Anshuman
Hi Imre ,
Could you please review thei915_pm_lpspseries.
"https://patchwork.freedesktop.org/series/59048/"There is non-edp subtest igt failure for broxton. "https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2797/fi-bxt-j4205/igt@[email protected]"
This broxton machine has a DP1 connector and connected on Pipe A and to
DDI A. (https://intel-gfx-ci.01.org/hardware/fi-bxt-j4205/fi-bxt-j4205/i915_display_info.txt)Current implementation of
lpsp_is_enabled()is checking for state of power well 2 for gen9 and power well 3 for gen 11, these power well should be turned off in order to lpsp enabled.
Quoted 6 lines
But as above broxton machine has connected to port DDI A, that could be the reason power well 2 is not active and non-edp igt subtest get failed on this machine.
What should be the correct way to check
lpsp_is_enabled(), could you please provide your suggestion.
Power well#2 is not enabled when the test fails, which is expected for any outputs on DDI-A regardless of the output being eDP or not.
So the test is broken with its assumption that only eDP outputs will leave PW#2 disabled.
To fix that You need to determine if the enabled output (regardless whether it's DP/eDP or HDMI) is using pipe A/port A and expect PW#2 to be disabled if so. You can use i915_display_info to get at the port the output is using.
Note that audio could also use PW#2 but the driver doesn't enable it on port A ever (even if the display would support it).
There is also a PW#2 enable/disable sequence during/after the test exits it would be good to know what causes that (by instrumenting the PW#2 enabling in the driver).
--Imre
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev