package/tpm2-totp: blacklist Codesourcery ARM toolchain
PATCH 1/1 package/tpm2-totp: blacklist Codesourcery ARM toolchain
Fixes:
http://autobuild.buildroot.net/results/6c9bb17920749409e5a0c3388ccda411c6c7cfb4/
tpm2-totp uses _DEFAULT_SOURCE to make the htobe64() macro available, support for which was only added in glibc 2.20:
From glibc 2.20 NEWS:
* The _BSD_SOURCE and _SVID_SOURCE feature test macros are no longer supported; they now act the same as _DEFAULT_SOURCE (but generate a warning). Except for cases where _BSD_SOURCE enabled BSD interfaces that conflicted with POSIX (support for which was removed in 2.19), the interfaces those macros enabled remain available when compiling with _GNU_SOURCE defined, with _DEFAULT_SOURCE defined, or without any feature test macros defined.
This could be worked around by defining _BSD_SOURCE for this old toolchain (cannot be done unconditionally as it generated warnings for modern glibc versions), but given that platforms using this old toolchain are unlikely to have a TPM 2.0 and use it for TOTP, simply blacklist it instead.
--- package/tpm2-totp/Config.in | 2 ++ 1 file changed, 2 insertions(+)
package/tpm2-totp/Config.in +2 -0
@@ -1,6 +1,7 @@ config BR2_PACKAGE_TPM2_TOTP bool "tpm2-tools" depends on !BR2_STATIC_LIBS # tpm2-tss + depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM # glibc < 2.20 select BR2_PACKAGE_LIBQRENCODE select BR2_PACKAGE_TPM2_TSS help
@@ -19,3 +20,4 @@ config BR2_PACKAGE_TPM2_TOTP comment "tpm2-totp needs a toolchain w/ dynamic library" depends on BR2_STATIC_LIBS + depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM
Signature · 1 line
2.11.0
Thomas Petazzoni
AppliedPATCH 1/1 package/tpm2-totp: blacklist Codesourcery ARM toolchain
Quoted 23 lines · On Thu, 11 Apr 2019 12:59:06 +0200 Peter Korsgaard <[email protected]> wrote:
Fixes:
http://autobuild.buildroot.net/results/6c9bb17920749409e5a0c3388ccda411c6c7cfb4/tpm2-totp uses
_DEFAULT_SOURCEto make thehtobe64()macro available, support for which was only added in glibc 2.20:From glibc 2.20 NEWS:
* The
_BSD_SOURCEand_SVID_SOURCEfeature test macros are no longer supported; they now act the same as_DEFAULT_SOURCE(but generate a warning). Except for cases where_BSD_SOURCEenabled BSD interfaces that conflicted with POSIX (support for which was removed in 2.19), the interfaces those macros enabled remain available when compiling with_GNU_SOURCEdefined, with_DEFAULT_SOURCEdefined, or without any feature test macros defined.This could be worked around by defining
_BSD_SOURCEfor this old toolchain (cannot be done unconditionally as it generated warnings for modern glibc versions), but given that platforms using this old toolchain are unlikely to have a TPM 2.0 and use it for TOTP, simply blacklist it instead.
Quoted 4 lines
Signed-off-by Peter Korsgaard <[email protected]>--- package/tpm2-totp/Config.in | 2 ++ 1 file changed, 2 insertions(+)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com