imx: add lowlevel init for ARM64
Subsystems (4)
PATCH 1/1 imx: add lowlevel init for ARM64
Sometimes we met SERROR, but only to catch it when Linux boots up. Let's enable catching in U-Boot to catch it ealier and ease debug.
--- arch/arm/mach-imx/Makefile | 2 +- arch/arm/mach-imx/lowlevel.S | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 arch/arm/mach-imx/lowlevel.S
arch/arm/mach-imx/Makefile +1 -1
@@ -204,7 +204,7 @@ endif targets += $(addprefix ../../../,SPL spl/u-boot-spl.cfgout u-boot-dtb.cfgout u-boot.cfgout u-boot.uim spl/u-boot-nand-spl.imx) -obj-$(CONFIG_ARM64) += sip.o +obj-$(CONFIG_ARM64) += lowlevel.o sip.o obj-$(CONFIG_MX5) += mx5/ obj-$(CONFIG_MX6) += mx6/
arch/arm/mach-imx/lowlevel.S new file +22 -0
@@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2019 NXP + */ + +#include <linux/linkage.h> + +ENTRY(lowlevel_init) + mrs x0, CurrentEL + cmp x0, #8 + b.eq 1f + ret +1: + msr daifclr, #4 + + /* set HCR_EL2.AMO to catch SERROR */ + mrs x0, hcr_el2 + orr x0, x0, #0x20 + msr hcr_el2, x0 + isb + ret +ENDPROC(lowlevel_init)
Signature · 1 line
2.16.4
Quoted 3 lines
Sometimes we met SERROR, but only to catch it when Linux boots up. Let's enable catching in U-Boot to catch it ealier and ease debug.
Signed-off-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 imx: add lowlevel init for ARM64
In reply to Peng FanHi Peng and Stefano
Unfortunately, this seems to break Ethernet on Colibri iMX8X:
=> dhcp
"Error" handler, esr 0xbf000002
elr: 0000000080049664 lr : 000000008004964c (reloc)
elr: 00000000ffef6664 lr : 00000000ffef664c x0 : 000000005b040288 x1 : 0000000000000001 x2 : 00000000fd6c5ff4 x3 : 0000000000000020 x4 : 00000000fd6c5ff0 x5 : 0000000000000020 x6 : 00000000ffef079c x7 : 00000000fd6f1600 x8 : 0000000000000044 x9 : 0000000000000008
x10: 00000000fd6d1620 x11: 00000000fd6d3a10
x12: 0000000000000000 x13: 0000000000000200
x14: 00000000fd6c62cc x15: 0000000000000002
x16: 0000000000002080 x17: 0000000000000000
x18: 00000000fd6cada8 x19: 00000000fd6d1160
x20: 0000000000000200 x21: 000000005b040300
x22: 00000000fd6f1000 x23: 00000000fd6cfdf0
x24: 00000000ffff8000 x25: 0000000000000000
x26: 0000000000000000 x27: 0000000000000000
x28: 00000000fd6d15c0 x29: 00000000fd6c6030
Resetting CPU ...
resetting ...
Reverting commit 5955c6eeb453 ("imx: add lowlevel init for ARM64") makes it work again.
Unfortunately, I don't have a MEK in my home office but will check Ethernet operation there on Monday as well.
Anyway, does anybody know what exactly is going on?
Cheers
Marcel
Quoted 60 lines · Peng Fan
Sometimes we met SERROR, but only to catch it when Linux boots up. Let's enable catching in U-Boot to catch it ealier and ease debug.
Signed-off-by Peng Fan <[email protected]>--- arch/arm/mach-imx/Makefile | 2 +- arch/arm/mach-imx/lowlevel.S | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 arch/arm/mach-imx/lowlevel.Sarch/arm/mach-imx/Makefile +1
-1@@ -204,7 +204,7 @@ endif targets += $(addprefix ../../../,SPL spl/u-boot-spl.cfgout u-boot- dtb.cfgout u-boot.cfgout u-boot.uim spl/u-boot-nand-spl.imx) -obj-$(CONFIG_ARM64) += sip.o +obj-$(CONFIG_ARM64) += lowlevel.o sip.o obj-$(CONFIG_MX5) += mx5/obj-$(CONFIG_MX6) += mx6/
arch/arm/mach- renamed from arch/arm/mach-imx/lowlevel.S +0
-0
imx/lowlevel.S
new file mode 100644
index 0000000000..158fdb7d87arch/arm/mach-imx/lowlevel.S new file +22
-0@@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2019 NXP + */ + +#include <linux/linkage.h> + +ENTRY(lowlevel_init) + mrs x0, CurrentEL + cmp x0, #8 + b.eq 1f + ret +1: + msr daifclr, #4 + + /* set HCR_EL2.AMO to catch SERROR */ + mrs x0, hcr_el2 + orr x0, x0, #0x20 + msr hcr_el2, x0 + isb + ret +ENDPROC(lowlevel_init)Signature · 6 lines
2.16.4 _______________________________________________ U-Boot mailing list U-Boot at lists.denx.de https://lists.denx.de/listinfo/u-boot
PATCH 1/1 imx: add lowlevel init for ARM64
Hi Marcel,
Please apply this patch, Joe has not pick it up.
https://patchwork.ozlabs.org/patch/1085432/
Stefano,
Would you pick it up?
Quoted 30 lines
Subject: [REGRESSION] [PATCH] imx: add lowlevel init for ARM64
Hi Peng and Stefano
Unfortunately, this seems to break Ethernet on Colibri iMX8X:
=> dhcp
"Error" handler, esr0xbf000002
elr: 0000000080049664 lr :000000008004964c(reloc)
elr:00000000ffef6664lr :00000000ffef664cx0 :000000005b040288x1 : 0000000000000001 x2 :00000000fd6c5ff4x3 : 0000000000000020 x4 :00000000fd6c5ff0x5 : 0000000000000020 x6 :00000000ffef079cx7 :00000000fd6f1600x8 : 0000000000000044 x9 : 0000000000000008
x10:00000000fd6d1620x11:00000000fd6d3a10
x12: 0000000000000000 x13: 0000000000000200
x14:00000000fd6c62ccx15: 0000000000000002
x16: 0000000000002080 x17: 0000000000000000
x18:00000000fd6cada8x19:00000000fd6d1160
x20: 0000000000000200 x21:000000005b040300
x22:00000000fd6f1000x23:00000000fd6cfdf0
x24:00000000ffff8000x25: 0000000000000000
x26: 0000000000000000 x27: 0000000000000000
x28:00000000fd6d15c0x29:00000000fd6c6030Resetting CPU ...
resetting ...
Quoted 7 lines
Reverting commit
5955c6eeb453("imx: add lowlevel init for ARM64") makes it work again.Unfortunately, I don't have a MEK in my home office but will check Ethernet operation there on Monday as well.
Anyway, does anybody know what exactly is going on?
Regards,
Peng.
Quoted 74 lines
Cheers
Marcel
Quoted 54 lines · Peng Fan
Sometimes we met SERROR, but only to catch it when Linux boots up. Let's enable catching in U-Boot to catch it ealier and ease debug.
Signed-off-by Peng Fan <[email protected]>--- arch/arm/mach-imx/Makefile | 2 +- arch/arm/mach-imx/lowlevel.S | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644
arch/arm/mach-imx/lowlevel.Sarch/arm/mach-imx/Makefile +1
-1@@ -204,7 +204,7 @@ endif targets += $(addprefix ../../../,SPL spl/u-boot-spl.cfgout u-boot- dtb.cfgout u-boot.cfgout u-boot.uim spl/u-boot-nand-spl.imx) -obj-$(CONFIG_ARM64) += sip.o +obj-$(CONFIG_ARM64) += lowlevel.o sip.o obj-$(CONFIG_MX5) += mx5/obj-$(CONFIG_MX6) += mx6/
arch/arm/mach- renamed from arch/arm/mach-imx/lowlevel.S +0
-0
imx/lowlevel.Snew file mode 100644 index 0000000000..158fdb7d87arch/arm/mach-imx/lowlevel.S new file +22
-1@@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2019 NXP + */ + +#include <linux/linkage.h> + +ENTRY(lowlevel_init) + mrs x0, CurrentEL + cmp x0, #8 + b.eq 1f + ret +1: + msr daifclr, #4 + + /* set HCR_EL2.AMO to catch SERROR */ + mrs x0, hcr_el2 + orr x0, x0, #0x20 + msr hcr_el2, x0 + isb + ret +ENDPROC(lowlevel_init) --2.16.4
Quoted 5 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.denx.de%2Flistinfo%2Fu-boot&data=02%7C01%7Cpeng.fan%40nxp.co m%7C
Quoted 1 line
d671eca9f1cc4d06a7d008d6ca7661b1%7C686ea1d3bc2b4c6fa92cd99c5c30 1635%7C
Quoted 1 line
0%7C0%7C636919007134459412&sdata=R6xBpoVJHL7meQkRkBi1I8vg MgOTXlFEA
Quoted 1 line
QfMePrDdSc%3D&reserved=0
PATCH 1/1 imx: add lowlevel init for ARM64
Quoted 8 lines · Peng Fan
Hi Marcel,
Please apply this patch, Joe has not pick it up.
https://patchwork.ozlabs.org/patch/1085432/Stefano,
Would you pick it up?
It is acked by Joe, i assign the patch to me in patchwork and I pick it up.
Regards,
Stefano
Quoted 117 lines
Quoted 32 lines
Subject: [REGRESSION] [PATCH] imx: add lowlevel init for ARM64
Hi Peng and Stefano
Unfortunately, this seems to break Ethernet on Colibri iMX8X:
=> dhcp
"Error" handler, esr0xbf000002
elr: 0000000080049664 lr :000000008004964c(reloc)
elr:00000000ffef6664lr :00000000ffef664cx0 :000000005b040288x1 : 0000000000000001 x2 :00000000fd6c5ff4x3 : 0000000000000020 x4 :00000000fd6c5ff0x5 : 0000000000000020 x6 :00000000ffef079cx7 :00000000fd6f1600x8 : 0000000000000044 x9 : 0000000000000008
x10:00000000fd6d1620x11:00000000fd6d3a10
x12: 0000000000000000 x13: 0000000000000200
x14:00000000fd6c62ccx15: 0000000000000002
x16: 0000000000002080 x17: 0000000000000000
x18:00000000fd6cada8x19:00000000fd6d1160
x20: 0000000000000200 x21:000000005b040300
x22:00000000fd6f1000x23:00000000fd6cfdf0
x24:00000000ffff8000x25: 0000000000000000
x26: 0000000000000000 x27: 0000000000000000
x28:00000000fd6d15c0x29:00000000fd6c6030Resetting CPU ...
resetting ...
Quoted 7 lines
Reverting commit
5955c6eeb453("imx: add lowlevel init for ARM64") makes it work again.Unfortunately, I don't have a MEK in my home office but will check Ethernet operation there on Monday as well.
Anyway, does anybody know what exactly is going on?
Regards,
Peng.Quoted 74 lines
Cheers
Marcel
Quoted 54 lines · Peng Fan
Sometimes we met SERROR, but only to catch it when Linux boots up. Let's enable catching in U-Boot to catch it ealier and ease debug.
Signed-off-by Peng Fan <[email protected]>--- arch/arm/mach-imx/Makefile | 2 +- arch/arm/mach-imx/lowlevel.S | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644
arch/arm/mach-imx/lowlevel.Sarch/arm/mach-imx/Makefile +1
-1@@ -204,7 +204,7 @@ endif targets += $(addprefix ../../../,SPL spl/u-boot-spl.cfgout u-boot- dtb.cfgout u-boot.cfgout u-boot.uim spl/u-boot-nand-spl.imx) -obj-$(CONFIG_ARM64) += sip.o +obj-$(CONFIG_ARM64) += lowlevel.o sip.o obj-$(CONFIG_MX5) += mx5/obj-$(CONFIG_MX6) += mx6/
arch/arm/mach- renamed from arch/arm/mach-imx/lowlevel.S +0
-0
imx/lowlevel.Snew file mode 100644 index 0000000000..158fdb7d87arch/arm/mach-imx/lowlevel.S new file +22
-1@@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2019 NXP + */ + +#include <linux/linkage.h> + +ENTRY(lowlevel_init) + mrs x0, CurrentEL + cmp x0, #8 + b.eq 1f + ret +1: + msr daifclr, #4 + + /* set HCR_EL2.AMO to catch SERROR */ + mrs x0, hcr_el2 + orr x0, x0, #0x20 + msr hcr_el2, x0 + isb + ret +ENDPROC(lowlevel_init) --2.16.4
Quoted 5 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.denx.de%2Flistinfo%2Fu-boot&data=02%7C01%7Cpeng.fan%40nxp.co m%7C
Quoted 1 line
d671eca9f1cc4d06a7d008d6ca7661b1%7C686ea1d3bc2b4c6fa92cd99c5c30 1635%7C
Quoted 1 line
0%7C0%7C636919007134459412&sdata=R6xBpoVJHL7meQkRkBi1I8vg MgOTXlFEA
Quoted 1 line
QfMePrDdSc%3D&reserved=0
PATCH 1/1 imx: add lowlevel init for ARM64
Quoted 12 lines · Stefano Babic
Quoted 9 lines · Peng Fan
Hi Marcel,
Please apply this patch, Joe has not pick it up.
https://patchwork.ozlabs.org/patch/1085432/
Quoted 16 lines
Quoted 3 lines
Stefano,
Would you pick it up?
It is acked by Joe, i assign the patch to me in patchwork and I pick it up.
Regards,
StefanoQuoted 7 lines
Quoted 7 lines
Subject: [REGRESSION] [PATCH] imx: add lowlevel init for ARM64
Hi Peng and Stefano
Unfortunately, this seems to break Ethernet on Colibri iMX8X:
Has this been addressed?
Quoted 114 lines
Quoted 28 lines
Quoted 28 lines
=> dhcp
"Error" handler, esr0xbf000002
elr: 0000000080049664 lr :000000008004964c(reloc)
elr:00000000ffef6664lr :00000000ffef664cx0 :000000005b040288x1 : 0000000000000001 x2 :00000000fd6c5ff4x3 : 0000000000000020 x4 :00000000fd6c5ff0x5 : 0000000000000020 x6 :00000000ffef079cx7 :00000000fd6f1600x8 : 0000000000000044 x9 : 0000000000000008
x10:00000000fd6d1620x11:00000000fd6d3a10
x12: 0000000000000000 x13: 0000000000000200
x14:00000000fd6c62ccx15: 0000000000000002
x16: 0000000000002080 x17: 0000000000000000
x18:00000000fd6cada8x19:00000000fd6d1160
x20: 0000000000000200 x21:000000005b040300
x22:00000000fd6f1000x23:00000000fd6cfdf0
x24:00000000ffff8000x25: 0000000000000000
x26: 0000000000000000 x27: 0000000000000000
x28:00000000fd6d15c0x29:00000000fd6c6030Resetting CPU ...
resetting ...
Reverting commit
5955c6eeb453("imx: add lowlevel init for ARM64") makes it work again.Quoted 82 lines
Quoted 4 lines
Unfortunately, I don't have a MEK in my home office but will check Ethernet operation there on Monday as well.
Anyway, does anybody know what exactly is going on?
Regards,
Peng.Quoted 74 lines
Cheers
Marcel
Quoted 55 lines · Peng Fan
Sometimes we met SERROR, but only to catch it when Linux boots up. Let's enable catching in U-Boot to catch it ealier and ease debug.
Signed-off-by Peng Fan <[email protected]>---
arch/arm/mach-imx/Makefile| 2 +-arch/arm/mach-imx/lowlevel.S| 22 ++++++++++++++++++++++2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644
arch/arm/mach-imx/lowlevel.Sarch/arm/mach-imx/Makefile +0
-0@@ -204,7 +204,7 @@ endiftargets += $(addprefix ../../../,SPL spl/u-boot-spl.cfgout u-boot- dtb.cfgout u-boot.cfgout u-boot.uim spl/u-boot-nand-spl.imx)
arch/arm/mach-imx/Makefile +1
-1-obj-$(CONFIG_ARM64) += sip.o +obj-$(CONFIG_ARM64) += lowlevel.o sip.oobj-$(CONFIG_MX5) += mx5/
obj-$(CONFIG_MX6) += mx6/arch/arm/mach- renamed from arch/arm/mach-imx/lowlevel.S +0
-0
imx/lowlevel.Snew file mode 100644 index 0000000000..158fdb7d87arch/arm/mach-imx/lowlevel.S new file +22
-1@@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2019 NXP + */ + +#include <linux/linkage.h> + +ENTRY(lowlevel_init) + mrs x0, CurrentEL + cmp x0, #8 + b.eq 1f + ret +1: + msr daifclr, #4 + + /* set HCR_EL2.AMO to catch SERROR */ + mrs x0, hcr_el2 + orr x0, x0, #0x20 + msr hcr_el2, x0 + isb + ret +ENDPROC(lowlevel_init) --2.16.4
Quoted 5 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.denx.de%2Flistinfo%2Fu-boot&data=02%7C01%7Cpeng.fan%40nxp.co m%7C
Quoted 1 line
d671eca9f1cc4d06a7d008d6ca7661b1%7C686ea1d3bc2b4c6fa92cd99c5c30 1635%7C
Quoted 1 line
0%7C0%7C636919007134459412&sdata=R6xBpoVJHL7meQkRkBi1I8vg MgOTXlFEA
Quoted 1 line
QfMePrDdSc%3D&reserved=0
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
PATCH 1/1 imx: add lowlevel init for ARM64
Quoted 21 lines · Joe Hershberger
Quoted 21 lines · Stefano Babic
Quoted 12 lines · Peng Fan
Hi Marcel,
Please apply this patch, Joe has not pick it up.
https://patchwork.ozlabs.org/patch/1085432/Stefano,
Would you pick it up?
It is acked by Joe, i assign the patch to me in patchwork and I pick it up.
Regards,
StefanoQuoted 1 line
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Subject: [REGRESSION] [PATCH] imx: add lowlevel init for ARM64
Hi Peng and Stefano
Unfortunately, this seems to break Ethernet on Colibri iMX8X:
Has this been addressed?
Yes, sorry. The following patch as suggested by Peng does fix it:
https://patchwork.ozlabs.org/patch/1085432/
Thanks!
Quoted 119 lines
Quoted 119 lines
Quoted 28 lines
Quoted 28 lines
=> dhcp
"Error" handler, esr0xbf000002
elr: 0000000080049664 lr :000000008004964c(reloc)
elr:00000000ffef6664lr :00000000ffef664cx0 :000000005b040288x1 : 0000000000000001 x2 :00000000fd6c5ff4x3 : 0000000000000020 x4 :00000000fd6c5ff0x5 : 0000000000000020 x6 :00000000ffef079cx7 :00000000fd6f1600x8 : 0000000000000044 x9 : 0000000000000008
x10:00000000fd6d1620x11:00000000fd6d3a10
x12: 0000000000000000 x13: 0000000000000200
x14:00000000fd6c62ccx15: 0000000000000002
x16: 0000000000002080 x17: 0000000000000000
x18:00000000fd6cada8x19:00000000fd6d1160
x20: 0000000000000200 x21:000000005b040300
x22:00000000fd6f1000x23:00000000fd6cfdf0
x24:00000000ffff8000x25: 0000000000000000
x26: 0000000000000000 x27: 0000000000000000
x28:00000000fd6d15c0x29:00000000fd6c6030Resetting CPU ...
resetting ...
Reverting commit
5955c6eeb453("imx: add lowlevel init for ARM64") makes
it work again.Quoted 87 lines
Quoted 5 lines
Unfortunately, I don't have a MEK in my home office but will check Ethernet
operation there on Monday as well.Anyway, does anybody know what exactly is going on?
Regards,
Peng.Quoted 78 lines
Cheers
Marcel
Quoted 61 lines · Peng Fan
Sometimes we met SERROR, but only to catch it when Linux boots up.
Let's enable catching in U-Boot to catch it ealier and ease debug.Signed-off-by Peng Fan <[email protected]>---
arch/arm/mach-imx/Makefile| 2 +-arch/arm/mach-imx/lowlevel.S| 22 ++++++++++++++++++++++2 files changed, 23 insertions(+), 1 deletion(-) create mode100644
arch/arm/mach-imx/lowlevel.Sarch/arm/mach- renamed from arch/arm/mach-imx/Makefile +0
-0imx/Makefile
indexc3ed62aed6..37675d0558100644arch/arm/mach-imx/Makefile +0
-0@@ -204,7 +204,7 @@ endiftargets += $(addprefix ../../../,SPL spl/u-boot-spl.cfgout u- boot-
dtb.cfgout u-boot.cfgout u-boot.uim spl/u-boot-nand-spl.imx)arch/arm/mach-imx/Makefile +1
-1-obj-$(CONFIG_ARM64) += sip.o +obj-$(CONFIG_ARM64) += lowlevel.o sip.oobj-$(CONFIG_MX5) += mx5/
obj-$(CONFIG_MX6) += mx6/arch/arm/mach- renamed from arch/arm/mach-imx/lowlevel.S +0
-0
imx/lowlevel.Snew file mode 100644 index
0000000000..158fdb7d87arch/arm/mach-imx/lowlevel.S new file +22
-1@@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * Copyright 2019 NXP + */ + +#include <linux/linkage.h> + +ENTRY(lowlevel_init) + mrs x0, CurrentEL + cmp x0, #8 + b.eq 1f + ret +1: + msr daifclr, #4 + + /* set HCR_EL2.AMO to catch SERROR */ + mrs x0, hcr_el2 + orr x0, x0, #0x20 + msr hcr_el2, x0 + isb + ret +ENDPROC(lowlevel_init) --2.16.4
Quoted 5 lines
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.denx.de%2Flistinfo%2Fu- boot&data=02%7C01%7Cpeng.fan%40nxp.co
m%7C d671eca9f1cc4d06a7d008d6ca7661b1%7C686ea1d3bc2b4c6fa92cd99c5c30 1635%7C 0%7C0%7C636919007134459412&sdata=R6xBpoVJHL7meQkRkBi1I8vg MgOTXlFEAQuoted 1 line
QfMePrDdSc%3D&reserved=0
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot