Skip to contentSkip to conversation

kernel/module: Reschedule while waiting for modules to finish loading

PATCH Superseded Prarit Bhargava 3 participants 5 messages Apr 29, 2019 – Apr 30, 2019

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/module: Reschedule while waiting for modules to finish loading

Heiko, do you want a Signed-off-by or a Reported-by? Either one works for me.

P.

----8<----

On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while loading the s390_trng.ko module.

Add a reschedule point to the loop that waits for modules to complete loading.

Fixes linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
Cc Jessica Yu <[email protected]>
---
 kernel/module.c | 1 +
 1 file changed, 1 insertion(+)
kernel/module.c +1 -0
index 410eeb7e4f1d..48748cfec991 100644
@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod)
 					       finished_loading(mod->name));
 			if (err)
 				goto out_unlocked;
+			cond_resched();
 			goto again;
 		}
 		err = -EEXIST;
Signature · 1 line
2.18.1
#1 lore raw

+++ Prarit Bhargava [29/04/19 11:17 -0400]:

Quoted 4 lines

Heiko, do you want a Signed-off-by or a Reported-by? Either one works for me.

P.

I think you forgot to CC Heiko :)

Quoted 31 lines

----8<----

On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while loading the s390_trng.ko module.

Add a reschedule point to the loop that waits for modules to complete loading.

Fixes linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
Cc Jessica Yu <[email protected]>

---
kernel/module.c | 1 +

1 file changed, 1 insertion(+)
kernel/module.c +1 -0
index 410eeb7e4f1d..48748cfec991 100644
@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod)
 					       finished_loading(mod->name));
 			if (err)
 				goto out_unlocked;
+			cond_resched();
 			goto again;
 		}
 		err = -EEXIST;
Signature · 1 line
2.18.1
#2 lore raw
Quoted 7 lines · Jessica Yu

+++ Prarit Bhargava [29/04/19 11:17 -0400]:

Quoted 4 lines

Heiko, do you want a Signed-off-by or a Reported-by? Either one works for me.

P.

I think you forgot to CC Heiko :)

Indeed ;)

I'm fine with the Reported-by tag. Thank you!

Quoted 31 lines
Quoted 31 lines

----8<----

On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while loading the s390_trng.ko module.

Add a reschedule point to the loop that waits for modules to complete loading.

Fixes linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
Cc Jessica Yu <[email protected]>

---
kernel/module.c | 1 +

1 file changed, 1 insertion(+)
kernel/module.c +1 -0
index 410eeb7e4f1d..48748cfec991 100644
@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod)
 					       finished_loading(mod->name));
 			if (err)
 				goto out_unlocked;
+			cond_resched();
 			goto again;
 		}
 		err = -EEXIST;
Signature · 1 line
2.18.1
#3 lore raw
In reply to Jessica Yu
Quoted 7 lines · Jessica Yu

+++ Prarit Bhargava [29/04/19 11:17 -0400]:

Quoted 4 lines

Heiko, do you want a Signed-off-by or a Reported-by?  Either one works for me.

P.

I think you forgot to CC Heiko :)

#oops.

I forgot that git-send-email doesn't pick up "Reported-by".

P.

Quoted 33 lines
Quoted 33 lines

----8<----

On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while loading the s390_trng.ko module.

Add a reschedule point to the loop that waits for modules to complete loading.

Fixes linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for

modules that have finished loading")

---
kernel/module.c | 1 +

1 file changed, 1 insertion(+)
kernel/module.c +1 -0
index 410eeb7e4f1d..48748cfec991 100644
@@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod)
                            finished_loading(mod->name));
             if (err)
                 goto out_unlocked;
+            cond_resched();
             goto again;
         }
         err = -EEXIST;

--
2.18.1

#4 lore raw
In reply to Prarit Bhargava

+++ Prarit Bhargava [29/04/19 11:17 -0400]:

Quoted 10 lines

Heiko, do you want a Signed-off-by or a Reported-by? Either one works for me.

P.

----8<----

On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while loading the s390_trng.ko module.

Quoted 7 lines

Add a reschedule point to the loop that waits for modules to complete loading.

Fixes linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading")
Cc Jessica Yu <[email protected]>

Thanks for the fix! Applied to modules-next.

Jessica