Skip to contentSkip to conversation

netfilter: nf_flow_table: fix netdev refcnt leak

PATCH In review Taehee Yoo 1 participant 1 message Apr 29, 2019

Subsystems (2)
lore
Share & tools
lore

Taehee Yoo

author
#0 lore raw

PATCH v2 1/3 netfilter: nf_flow_table: fix netdev refcnt leak

flow_offload_alloc() calls nf_route() to get a dst_entry. Internally, nf_route() calls ip_route_output_key() that allocates a dst_entry and holds it.
So, a dst_entry should be released by dst_release() if nf_route() is successful.

Because of that problem, netns exit routine can not be finished and below message will be printed.

[  257.490952] unregister_netdevice: waiting for lo to become free. Usage count = 1
Fixes ac2a66665e23 ("netfilter: add generic flow table infrastructure")
---
 net/netfilter/nft_flow_offload.c | 1 +
 1 file changed, 1 insertion(+)
net/netfilter/nft_flow_offload.c +1 -0
index 6e6b9adf7d38..ff50bc1b144f 100644
@@ -113,6 +113,7 @@ static void nft_flow_offload_eval(const struct nft_expr *expr,
 	if (ret < 0)
 		goto err_flow_add;
 
+	dst_release(route.tuple[!dir].dst);
 	return;
 
 err_flow_add:
Signature · 1 line
2.17.1