netfilter: nf_flow_table: fix netdev refcnt leak
Subsystems (2)
PATCH v2 1/3 netfilter: nf_flow_table: fix netdev refcnt leak
flow_offload_alloc() calls nf_route() to get a dst_entry. Internally, nf_route() calls ip_route_output_key() that allocates a dst_entry and holds it.
So, a dst_entry should be released by dst_release() if nf_route() is successful.
Because of that problem, netns exit routine can not be finished and below message will be printed.
[ 257.490952] unregister_netdevice: waiting for lo to become free. Usage count = 1
Fixes ac2a66665e23 ("netfilter: add generic flow table infrastructure")
Signed-off-by Taehee Yoo <[email protected]>
--- net/netfilter/nft_flow_offload.c | 1 + 1 file changed, 1 insertion(+)
net/netfilter/nft_flow_offload.c +1 -0
@@ -113,6 +113,7 @@ static void nft_flow_offload_eval(const struct nft_expr *expr,if (ret <0 ) goto err_flow_add; +dst_release (route.tuple[!dir].dst);return ; err_flow_add:
Signature · 1 line
2.17.1