generic/532: do not break golden silence if attributes_mask is 0
PATCH 1/1 generic/532: do not break golden silence if attributes_mask is 0
If the filesystem does not support STATX_ATTR, like NFS, setting both attributes and attributes_mask to 0 seems the right thing to do. attributes_mask can be 0 only if attributes is also 0. This situation is covered by the "&" check in the next line.
Signed-off-by Murphy Zhou <[email protected]>
--- tests/generic/532 | 1 - 1 file changed, 1 deletion(-)
tests/generic/532 +0 -1
@@ -44,7 +44,6 @@ check_statx_attributes() echo "MASK:$mask:ATTRS:$attrs:" >> $seqres.full test -z "$mask" && _notrun "xfs_io statx command does not support attributes_mask" - test $(( mask )) -eq 0 && echo "attributes mask is zero" test $(( attrs & ~(mask) )) -ne 0 && echo "attributes $attrs do not appear in mask $mask" }
Signature · 1 line
2.21.0
Quoted 6 lines · Murphy Zhou
If the filesystem does not support
STATX_ATTR, like NFS, setting both attributes andattributes_maskto 0 seems the right thing to do.attributes_maskcan be 0 only if attributes is also 0. This situation is covered by the "&" check in the next line.Signed-off-by Murphy Zhou <[email protected]>
Seems fine to me.
Reviewed-by Darrick J. Wong <[email protected]>
--D
Quoted 19 lines
--- tests/generic/532 | 1 - 1 file changed, 1 deletion(-)tests/generic/532 +0
-1@@ -44,7 +44,6 @@ check_statx_attributes() echo "MASK:$mask:ATTRS:$attrs:" >> $seqres.full test -z "$mask" && _notrun "xfs_io statx command does not support attributes_mask" - test $(( mask )) -eq 0 && echo "attributes mask is zero" test $(( attrs & ~(mask) )) -ne 0 && echo "attributes $attrs do not appear in mask $mask" }Signature · 1 line
2.21.0