Skip to contentSkip to conversation

generic/532: do not break golden silence if attributes_mask is 0

PATCH In review Murphy Zhou 2 participants 2 messages May 8, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/532: do not break golden silence if attributes_mask is 0

If the filesystem does not support STATX_ATTR, like NFS, setting both attributes and attributes_mask to 0 seems the right thing to do. attributes_mask can be 0 only if attributes is also 0. This situation is covered by the "&" check in the next line.

---
 tests/generic/532 | 1 -
 1 file changed, 1 deletion(-)
tests/generic/532 +0 -1
index ac8b7a89..3f8afa4a 100755
@@ -44,7 +44,6 @@ check_statx_attributes()
 	echo "MASK:$mask:ATTRS:$attrs:" >> $seqres.full
 
 	test -z "$mask" && _notrun "xfs_io statx command does not support attributes_mask"
-	test $(( mask )) -eq 0 && echo "attributes mask is zero"
 	test $(( attrs & ~(mask) )) -ne 0 && echo "attributes $attrs do not appear in mask $mask"
 }
 
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Murphy Zhou

If the filesystem does not support STATX_ATTR, like NFS, setting both attributes and attributes_mask to 0 seems the right thing to do. attributes_mask can be 0 only if attributes is also 0. This situation is covered by the "&" check in the next line.

Seems fine to me.

--D

Quoted 19 lines
---
 tests/generic/532 | 1 -
 1 file changed, 1 deletion(-)
tests/generic/532 +0 -1
index ac8b7a89..3f8afa4a 100755
@@ -44,7 +44,6 @@ check_statx_attributes()
 	echo "MASK:$mask:ATTRS:$attrs:" >> $seqres.full
 
 	test -z "$mask" && _notrun "xfs_io statx command does not support attributes_mask"
-	test $(( mask )) -eq 0 && echo "attributes mask is zero"
 	test $(( attrs & ~(mask) )) -ne 0 && echo "attributes $attrs do not appear in mask $mask"
 }
 
Signature · 1 line
2.21.0