Skip to contentSkip to conversation

tests/Makefile: Remove unused test-obj-y variable

PATCH In review Thomas Huth 3 participants 3 messages May 8, 2019 – May 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tests/Makefile: Remove unused test-obj-y variable

I recently noticed that test-obj-y contains a file called tests/check-block-qtest.o which simply does not belong to any .c file and thus wondered why this is not causing any trouble. It is only used to add -Itests to the command line (which refers to the build directory). However, it is not needed because "-iquote $(@D)" already sets this up in rules.mak. Thus we can simply remove this variable.

---
v2: Fixed patch description with the information that Paolo provided.

 tests/Makefile.include | 19 -------------------
 1 file changed, 19 deletions(-)
tests/Makefile.include +0 -19
index 7c8b9c84b2..dfc4b7746f 100644
@@ -482,25 +482,6 @@ GENERATED_FILES += tests/test-qapi-types.h \
 	tests/test-qapi-events-sub-sub-module.h \
 	tests/test-qapi-introspect.h
 
-test-obj-y = tests/check-qnum.o tests/check-qstring.o tests/check-qdict.o \
-	tests/check-qlist.o tests/check-qnull.o tests/check-qobject.o \
-	tests/check-qjson.o tests/check-qlit.o \
-	tests/check-block-qtest.o \
-	tests/test-coroutine.o tests/test-string-output-visitor.o \
-	tests/test-string-input-visitor.o tests/test-qobject-output-visitor.o \
-	tests/test-clone-visitor.o \
-	tests/test-qobject-input-visitor.o \
-	tests/test-qmp-cmds.o tests/test-visitor-serialization.o \
-	tests/test-x86-cpuid.o tests/test-mul64.o tests/test-int128.o \
-	tests/test-opts-visitor.o tests/test-qmp-event.o \
-	tests/rcutorture.o tests/test-rcu-list.o \
-	tests/test-rcu-simpleq.o \
-	tests/test-rcu-tailq.o \
-	tests/test-qdist.o tests/test-shift128.o \
-	tests/test-qht.o tests/qht-bench.o tests/test-qht-par.o \
-	tests/atomic_add-bench.o tests/atomic64-bench.o
-
-$(test-obj-y): QEMU_INCLUDES += -Itests
 QEMU_CFLAGS += -I$(SRC_PATH)/tests
 
 
Signature · 1 line
2.21.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Thomas Huth

I recently noticed that test-obj-y contains a file called tests/check-block-qtest.o which simply does not belong to any .c file and thus wondered why this is not causing any trouble. It is only used to add -Itests to the command line (which refers to the build directory). However, it is not needed because "-iquote $(@D)" already sets this up in rules.mak. Thus we can simply remove this variable.

Reviewed-by on v2 1/1
#2 lore raw
In reply to Thomas Huth
Quoted 8 lines · Thomas Huth

I recently noticed that test-obj-y contains a file called tests/check-block-qtest.o which simply does not belong to any .c file and thus wondered why this is not causing any trouble. It is only used to add -Itests to the command line (which refers to the build directory). However, it is not needed because "-iquote $(@D)" already sets this up in rules.mak. Thus we can simply remove this variable.

Quoted 6 lines

---
v2: Fixed patch description with the information that Paolo provided.

 tests/Makefile.include | 19 -------------------
 1 file changed, 19 deletions(-)

Thanks,
Stefano