target/riscv: Only flush TLB if SATP.ASID changes
PATCH 1/1 target/riscv: Only flush TLB if SATP.ASID changes
There is an analogous change for ARM here:
https://patchwork.kernel.org/patch/10649857
Signed-off-by Jonathan Behrens <[email protected]>
--- target/riscv/csr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
target/riscv/csr.c +3 -1
@@ -732,7 +732,9 @@ static int write_satp(CPURISCVState *env, int csrno, target_ulong val)if (env->priv ==PRV_S &&get_field (env->mstatus,MSTATUS_TVM )) {return -1 ; }else { -tlb_flush (CPU (riscv_env_get_cpu (env))); +if ((val ^ env->satp) &SATP_ASID ) { +tlb_flush (CPU (riscv_env_get_cpu (env))); + } env->satp = val; } }
Signature · 1 line
2.20.1
Quoted 7 lines · Jonathan Behrens
There is an analogous change for ARM here:
https://patchwork.kernel.org/patch/10649857Signed-off-by Jonathan Behrens <[email protected]>--- target/riscv/csr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by Richard Henderson <[email protected]>
r~
Quoted 5 lines · Jonathan Behrens
There is an analogous change for ARM here:
https://patchwork.kernel.org/patch/10649857Signed-off-by Jonathan Behrens <[email protected]>
Reviewed-by Alistair Francis <[email protected]>
Alistair
Quoted 22 lines
--- target/riscv/csr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)target/riscv/csr.c +3
-2@@ -732,7 +732,9 @@ static int write_satp(CPURISCVState *env, int csrno, target_ulong val)if (env->priv ==PRV_S &&get_field (env->mstatus,MSTATUS_TVM )) {return -1 ; }else { -tlb_flush (CPU (riscv_env_get_cpu (env))); +if ((val ^ env->satp) &SATP_ASID ) { +tlb_flush (CPU (riscv_env_get_cpu (env))); + } env->satp = val; } } --2.20.1
Quoted 13 lines · On Wed, 08 May 2019 10:38:35 PDT (-0700), [email protected] wrote:
There is an analogous change for ARM here:
https://patchwork.kernel.org/patch/10649857Signed-off-by Jonathan Behrens <[email protected]>--- target/riscv/csr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)target/riscv/csr.c +0
-0
target/riscv/csr.c static int write_satp(CPURISCVState *env, int csrno, target_ulong val) · line 740
Quoted 10 lines
target/riscv/csr.c +3
-1@@ -732,7 +732,9 @@ static int write_satp(CPURISCVState *env, int csrno, target_ulong val)if (env->priv ==PRV_S &&get_field (env->mstatus,MSTATUS_TVM )) {return -1 ; }else { -tlb_flush (CPU (riscv_env_get_cpu (env))); +if ((val ^ env->satp) &SATP_ASID ) { +tlb_flush (CPU (riscv_env_get_cpu (env))); + } env->satp = val; } }
Thanks! I've taken this into my for-master branch, pending some testing I'll send it up.