arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C
PATCH v2 1/3 arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C
The CONFIG_POWER and CONFIG_POWER_I2C were introduced in include/configs/exynos5-common.h in commit 19bd3aaa5991 ("exynos5: fix build break by adding CONFIG_POWER") and then it propagated up to include/configs/arndale.h. However before that commit, there was no build break at all on Arndale and SMDK5250 boards. It seems the commit fixed nothing and just added unused defines.
In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus.
---
Not tested on Arndale board. Testing is welcomed.
Changes since v1:
1. Add Simon's tag.
2. Reorder patches - first remove CONFIG_POWER_I2C, then CONFIG_DM_I2C_COMPAT.
--- include/configs/arndale.h | 8 -------- 1 file changed, 8 deletions(-)
include/configs/arndale.h +0 -8
@@ -29,10 +29,6 @@#define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_STACK -/* PMIC */ -#define CONFIG_POWER -#define CONFIG_POWER_I2C -#define CONFIG_PREBOOT #define CONFIG_S5P_PA_SYSRAM 0x02020000
@@ -41,8 +37,4 @@/* The PERIPHBASE in the CBAR register is wrong on the Arndale, so override it */ #define CONFIG_ARM_GIC_BASE_ADDRESS 0x10480000 -/* Power */ -#define CONFIG_POWER -#define CONFIG_POWER_I2C -#endif /* __CONFIG_H */
Signature · 1 line
2.17.1
PATCH v2 2/3 arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT
The CONFIG_DM_I2C_COMPAT was introduced in include/configs/exynos5-common.h in commit 189d80166b31 ("exynos5:
enable dm i2c") and then it propagated up to configs/arndale_defconfig. However since beginning the Arndale board (Exynos5250) was not using I2C.
In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus. This setting can be thus safely removed to fix build warning:
This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.
---
Not tested on Arndale board. Testing is welcomed.
Changes since v1:
1. Add Simon's tag.
2. Reorder patches - first remove CONFIG_POWER_I2C, then CONFIG_DM_I2C_COMPAT.
--- configs/arndale_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/arndale_defconfig +0 -1
@@ -25,7 +25,6 @@ CONFIG_CMD_SOUND=y CONFIG_CMD_EXT4_WRITE=y CONFIG_DEFAULT_DEVICE_TREE="exynos5250-arndale" CONFIG_ENV_IS_IN_MMC=y -CONFIG_DM_I2C_COMPAT=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_MMC_DW=y CONFIG_MMC_SDHCI=y
Signature · 1 line
2.17.1
PATCH v2 2/3 arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT
Hi,
Quoted 35 lines · Krzysztof Kozlowski
The
CONFIG_DM_I2C_COMPATwas introduced ininclude/configs/exynos5-common.hin commit189d80166b31("exynos5:
enable dm i2c") and then it propagated up to configs/arndale_defconfig. However since beginning the Arndale board (Exynos5250) was not using I2C.In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus. This setting can be thus safely removed to fix build warning:
This board uses
CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Simon Glass <[email protected]>---
Not tested on Arndale board. Testing is welcomed.
Changes since v1:
1. Add Simon's tag.
2. Reorder patches - first removeCONFIG_POWER_I2C, thenCONFIG_DM_I2C_COMPAT.--- configs/arndale_defconfig | 1 - 1 file changed, 1 deletion(-)configs/arndale_defconfig +0
-0
configs/arndale_defconfig CONFIG_CMD_SOUND=y · line 30
Quoted 7 lines
configs/arndale_defconfig +0
-1@@ -25,7 +25,6 @@ CONFIG_CMD_SOUND=y CONFIG_CMD_EXT4_WRITE=y CONFIG_DEFAULT_DEVICE_TREE="exynos5250-arndale" CONFIG_ENV_IS_IN_MMC=y -CONFIG_DM_I2C_COMPAT=y CONFIG_SUPPORT_EMMC_BOOT=y CONFIG_MMC_DW=y CONFIG_MMC_SDHCI=y
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
PATCH v2 3/3 configs: arndale: Use appropriate driver for Asix AX88760
In reply to Krzysztof KozlowskiArndale board has an Asix AX88760 USB 2.0 Hub and Fast Ethernet combo. The appropriate driver for it is USB_ETHER_ASIX.
The mistake probably came from misinterpretation of commit e9954b867ce0 ("usb: eth: add ASIX AX88179 DRIVER") which was tested on RECS5250 COM module. This module indeed has Exynos5250 and some similarities with Arndale 5250 board but the USB/Ethernet chip used there is apparently different.
---
Not tested.
Changes since v1:
1. Add Lukasz's tag.
--- configs/arndale_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
configs/arndale_defconfig +1 -1
@@ -42,4 +42,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_HOST_ETHER=y -CONFIG_USB_ETHER_ASIX88179=y +CONFIG_USB_ETHER_ASIX=y
Signature · 1 line
2.17.1
PATCH v2 3/3 configs: arndale: Use appropriate driver for Asix AX88760
Hi,
Quoted 29 lines · Krzysztof Kozlowski
Arndale board has an Asix AX88760 USB 2.0 Hub and Fast Ethernet combo. The appropriate driver for it is
USB_ETHER_ASIX.The mistake probably came from misinterpretation of commit
e9954b867ce0("usb: eth: add ASIX AX88179 DRIVER") which was tested on RECS5250 COM module. This module indeed has Exynos5250 and some similarities with Arndale 5250 board but the USB/Ethernet chip used there is apparently different.Fixes f58ad98a621c ("usb: net: migrate USB Ethernet adapters to Kconfig")Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Lukasz Majewski <[email protected]>---
Not tested.
Changes since v1:
1. Add Lukasz's tag.--- configs/arndale_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configs/arndale_defconfig +0
-0
configs/arndale_defconfig CONFIG_USB_XHCI_HCD=y · line 45
Quoted 5 lines
configs/arndale_defconfig +1
-1@@ -42,4 +42,4 @@ CONFIG_USB_XHCI_HCD=y CONFIG_USB_XHCI_DWC3=y CONFIG_USB_EHCI_HCD=y CONFIG_USB_HOST_ETHER=y -CONFIG_USB_ETHER_ASIX88179=y +CONFIG_USB_ETHER_ASIX=y
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
PATCH v2 1/3 arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C
In reply to Krzysztof KozlowskiHi,
Quoted 42 lines · Krzysztof Kozlowski
The
CONFIG_POWERandCONFIG_POWER_I2Cwere introduced ininclude/configs/exynos5-common.hin commit19bd3aaa5991("exynos5: fix build break by addingCONFIG_POWER") and then it propagated up toinclude/configs/arndale.h. However before that commit, there was no build break at all on Arndale and SMDK5250 boards. It seems the commit fixed nothing and just added unused defines.In fact, the Arndale board is not configuring its PMIC (S5M8767) which uses I2C bus.
Signed-off-by Krzysztof Kozlowski <[email protected]>Reviewed-by Simon Glass <[email protected]>---
Not tested on Arndale board. Testing is welcomed.
Changes since v1:
1. Add Simon's tag.
2. Reorder patches - first removeCONFIG_POWER_I2C, thenCONFIG_DM_I2C_COMPAT.--- include/configs/arndale.h | 8 -------- 1 file changed, 8 deletions(-)include/configs/arndale.h +0
-4@@ -29,10 +29,6 @@#define CONFIG_SYS_INIT_SP_ADDR CONFIG_IRAM_STACK -/* PMIC */ -#define CONFIG_POWER -#define CONFIG_POWER_I2C -#define CONFIG_PREBOOT #define CONFIG_S5P_PA_SYSRAM 0x02020000
include/configs/arndale.h line 40
Quoted 8 lines
include/configs/arndale.h +0
-4@@ -41,8 +37,4 @@/* The PERIPHBASE in the CBAR register is wrong on the Arndale, so override it */ #define CONFIG_ARM_GIC_BASE_ADDRESS 0x10480000 -/* Power */ -#define CONFIG_POWER -#define CONFIG_POWER_I2C -#endif /* __CONFIG_H */
applied to u-boot-samsung.
Thanks,
Minkyu Kang.