drm/bridge: Remove duplicate header
Subsystems (3)
PATCH 1/1 drm/bridge: Remove duplicate header
Remove drm/drm_panel.h which is included more than once
--- drivers/gpu/drm/bridge/panel.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/bridge/panel.c +0 -1
@@ -15,7 +15,6 @@#include <drm/drm_crtc_helper.h> #include <drm/drm_encoder.h> #include <drm/drm_modeset_helper_vtables.h> -#include <drm/drm_panel.h> struct panel_bridge {struct drm_bridge bridge;
Signature · 1 line
2.7.4
Laurent Pinchart
reviewerHi Sabyasachi,
Thank you for the patch.
Quoted 12 lines · Sabyasachi Gupta
Remove
drm/drm_panel.hwhich is included more than onceSigned-off-by Sabyasachi Gupta <[email protected]>--- drivers/gpu/drm/bridge/panel.c | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/bridge/panel.c +0
-0
drivers/gpu/drm/bridge/panel.c line 18
Quoted 4 lines
drivers/gpu/drm/bridge/panel.c +0
-1@@ -15,7 +15,6 @@#include <drm/drm_crtc_helper.h> #include <drm/drm_encoder.h> #include <drm/drm_modeset_helper_vtables.h> -#include <drm/drm_panel.h>
Which tree is this against ? The patch applies on neither drm-next nor drm-misc-next.
While at it, could you you reorder the other header alphabetically to make this kind of issue easier to notice ?
Quoted 3 lines
drivers/gpu/drm/bridge/panel.c +0
-0struct panel_bridge {struct drm_bridge bridge;
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 13 lines · Laurent Pinchart
Hi Sabyasachi,
Thank you for the patch.
Quoted 7 lines · Sabyasachi Gupta
Remove
drm/drm_panel.hwhich is included more than onceSigned-off-by Sabyasachi Gupta <[email protected]>--- drivers/gpu/drm/bridge/panel.c | 1 - 1 file changed, 1 deletion(-)
Quoted 13 lines
drivers/gpu/drm/bridge/panel.c line 18
Quoted 9 lines
drivers/gpu/drm/bridge/panel.c +0
-1@@ -15,7 +15,6 @@#include <drm/drm_crtc_helper.h> #include <drm/drm_encoder.h> #include <drm/drm_modeset_helper_vtables.h> -#include <drm/drm_panel.h> Which tree is this against ? The patch applies on neither drm-next nor drm-misc-next.
It is against linux-next tree
Quoted 3 lines
While at it, could you you reorder the other header alphabetically to make this kind of issue easier to notice ?
It is already arranged in alphabetical order
Quoted 8 lines
drivers/gpu/drm/bridge/panel.c line 20
Quoted 3 lines
drivers/gpu/drm/bridge/panel.c +0
-0struct panel_bridge {struct drm_bridge bridge;--
Regards,Laurent Pinchart
Laurent Pinchart
reviewerHi Sabyasachi,
Quoted 23 lines · Sabyasachi Gupta
Quoted 8 lines · Laurent Pinchart
Quoted 7 lines · Sabyasachi Gupta
Remove
drm/drm_panel.hwhich is included more than onceSigned-off-by Sabyasachi Gupta <[email protected]>--- drivers/gpu/drm/bridge/panel.c | 1 - 1 file changed, 1 deletion(-)Quoted 13 lines
drivers/gpu/drm/bridge/panel.c line 18
Quoted 9 lines
drivers/gpu/drm/bridge/panel.c +0
-1@@ -15,7 +15,6 @@#include <drm/drm_crtc_helper.h> #include <drm/drm_encoder.h> #include <drm/drm_modeset_helper_vtables.h> -#include <drm/drm_panel.h> Which tree is this against ? The patch applies on neither drm-next nor drm-misc-next.
Quoted 1 line
It is against linux-next tree
You will likely have to rebase it on top of the drm-next or drm-next-misc branch.
Quoted 4 lines
Quoted 2 lines
While at it, could you you reorder the other header alphabetically to make this kind of issue easier to notice ?
It is already arranged in alphabetical order
There's an #include <drm/drm_panel.h> at the top of the list of includes. That's the one that is out of place.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/bridge/panel.c +0
-0struct panel_bridge {struct drm_bridge bridge;
Signature · 3 lines
Regards, Laurent Pinchart