Skip to contentSkip to conversation

drm/bridge: Remove duplicate header

PATCH Superseded Sabyasachi Gupta 2 participants 4 messages May 14, 2019 – May 16, 2019

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: Remove duplicate header

Remove drm/drm_panel.h which is included more than once

---
 drivers/gpu/drm/bridge/panel.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/bridge/panel.c +0 -1
index 7cbaba2..402b318 100644
@@ -15,7 +15,6 @@
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_encoder.h>
 #include <drm/drm_modeset_helper_vtables.h>
-#include <drm/drm_panel.h>
 
 struct panel_bridge {
 	struct drm_bridge bridge;
Signature · 1 line
2.7.4
#1 lore raw

Hi Sabyasachi,

Thank you for the patch.

Quoted 12 lines · Sabyasachi Gupta

Remove drm/drm_panel.h which is included more than once

---
 drivers/gpu/drm/bridge/panel.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/bridge/panel.c +0 -0
index 7cbaba2..402b318 100644

drivers/gpu/drm/bridge/panel.c line 18

Quoted 4 lines
drivers/gpu/drm/bridge/panel.c +0 -1
@@ -15,7 +15,6 @@
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_encoder.h>
 #include <drm/drm_modeset_helper_vtables.h>
-#include <drm/drm_panel.h>

Which tree is this against ? The patch applies on neither drm-next nor drm-misc-next.

While at it, could you you reorder the other header alphabetically to make this kind of issue easier to notice ?

Quoted 3 lines
drivers/gpu/drm/bridge/panel.c +0 -0
 struct panel_bridge {
 	struct drm_bridge bridge;
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw
Quoted 13 lines · Laurent Pinchart

Hi Sabyasachi,

Thank you for the patch.

Quoted 7 lines · Sabyasachi Gupta

Remove drm/drm_panel.h which is included more than once

---
 drivers/gpu/drm/bridge/panel.c | 1 -
 1 file changed, 1 deletion(-)
Quoted 13 lines

drivers/gpu/drm/bridge/panel.c line 18

Quoted 9 lines
drivers/gpu/drm/bridge/panel.c +0 -1
index 7cbaba2..402b318 100644
@@ -15,7 +15,6 @@
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_encoder.h>
 #include <drm/drm_modeset_helper_vtables.h>
-#include <drm/drm_panel.h>

Which tree is this against ? The patch applies on neither drm-next nor drm-misc-next.

It is against linux-next tree

Quoted 3 lines

While at it, could you you reorder the other header alphabetically to make this kind of issue easier to notice ?

It is already arranged in alphabetical order

Quoted 8 lines

drivers/gpu/drm/bridge/panel.c line 20

Quoted 3 lines
drivers/gpu/drm/bridge/panel.c +0 -0
 struct panel_bridge {
      struct drm_bridge bridge;

--
Regards,

Laurent Pinchart

#3 lore raw

Hi Sabyasachi,

Quoted 23 lines · Sabyasachi Gupta
Quoted 8 lines · Laurent Pinchart
Quoted 7 lines · Sabyasachi Gupta

Remove drm/drm_panel.h which is included more than once

---
 drivers/gpu/drm/bridge/panel.c | 1 -
 1 file changed, 1 deletion(-)
Quoted 13 lines

drivers/gpu/drm/bridge/panel.c line 18

Quoted 9 lines
drivers/gpu/drm/bridge/panel.c +0 -1
index 7cbaba2..402b318 100644
@@ -15,7 +15,6 @@
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_encoder.h>
 #include <drm/drm_modeset_helper_vtables.h>
-#include <drm/drm_panel.h>

Which tree is this against ? The patch applies on neither drm-next nor drm-misc-next.

Quoted 1 line

It is against linux-next tree

You will likely have to rebase it on top of the drm-next or drm-next-misc branch.

Quoted 4 lines
Quoted 2 lines

While at it, could you you reorder the other header alphabetically to make this kind of issue easier to notice ?

It is already arranged in alphabetical order

There's an #include <drm/drm_panel.h> at the top of the list of includes. That's the one that is out of place.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/bridge/panel.c +0 -0
 struct panel_bridge {
      struct drm_bridge bridge;
Signature · 3 lines
Regards,

Laurent Pinchart