package/brotli: fix build on microblaze with -02
PATCH 1/1 package/brotli: fix build on microblaze with -02
Fixes:
- http://autobuild.buildroot.org/results/4790c30b75cdec18f67cda9c6afcb6971ee27608
--- package/brotli/brotli.mk | 7 +++++++ 1 file changed, 7 insertions(+)
package/brotli/brotli.mk +7 -0
@@ -14,4 +14,11 @@ BROTLI_CONF_OPTS = \ -DBROTLI_DISABLE_TESTS=ON \ -DBROTLI_BUNDLED_MODE=OFF +# prevents from triggering GCC ICE +# A bug was reported to the gcc bug tracker: +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485 +ifeq ($(BR2_microblaze),y) +BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -O0" +endif + $(eval $(cmake-package))
Signature · 1 line
2.20.1
PATCH 1/1 package/brotli: fix build on microblaze with -02
Hi,
Quoted 4 lines · Fabrice Fontaine
Fixes:
- http://autobuild.buildroot.org/results/4790c30b75cdec18f67cda9c6afcb6971ee27608Signed-off-by Fabrice Fontaine <[email protected]>
Quoted 9 lines
--- package/brotli/brotli.mk | 7 +++++++ 1 file changed, 7 insertions(+)package/brotli/brotli.mk +0
-0
package/brotli/brotli.mk BROTLI_CONF_OPTS = \ · line 22
Quoted 9 lines
package/brotli/brotli.mk +6
-0@@ -14,4 +14,11 @@ BROTLI_CONF_OPTS = \ -DBROTLI_DISABLE_TESTS=ON \ -DBROTLI_BUNDLED_MODE=OFF +# prevents from triggering GCC ICE +# A bug was reported to the gcc bug tracker: +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485 +ifeq ($(BR2_microblaze),y) +BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -O0" +endif
This is not a great fix, but still better than not being able to build the package at all, so I think it's okay to merge it. ?\_(?)_/?
Quoted 4 lines
package/brotli/brotli.mk +0
-0$(eval $(cmake-package))Signature · 1 line
2.20.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190515/b4477b85/attachment.asc>
PATCH 1/1 package/brotli: fix build on microblaze with -02
Hello All, Arnout, Thomas,
Il 15/05/2019 11:27, Adrian Perez de Castro ha scritto:
Quoted 22 lines
Hi,
Quoted 4 lines · Fabrice Fontaine
Fixes:
- http://autobuild.buildroot.org/results/4790c30b75cdec18f67cda9c6afcb6971ee27608Signed-off-by Fabrice Fontaine <[email protected]>Reviewed-by Adrian Perez de Castro <[email protected]>Quoted 12 lines
--- package/brotli/brotli.mk | 7 +++++++ 1 file changed, 7 insertions(+)package/brotli/brotli.mk +0
-0@@ -14,4 +14,11 @@ BROTLI_CONF_OPTS = \ -DBROTLI_DISABLE_TESTS=ON \ -DBROTLI_BUNDLED_MODE=OFF
Quoted 9 lines
package/brotli/brotli.mk BROTLI_CONF_OPTS = \ · line 22
Quoted 6 lines
package/brotli/brotli.mk +6
-0+# prevents from triggering GCC ICE +# A bug was reported to the gcc bug tracker: +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485 +ifeq ($(BR2_microblaze),y) +BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -O0" +endifThis is not a great fix, but still better than not being able to build the package at all, so I think it's okay to merge it. ?\_(?)_/?
This is another package added to the list of Microblaze GCC6/7 bug 85180. List now is:
- atop
- flare-engine
- boost
- gst-ffmpeg
- glibmm
- qt5sensors
- (and this) brotli
I don't think this is the way to solve it. I mean, it would be ok for -O0, but at this point I'm going to make a patch that impose it at toolchain's Config.in, otherwise we need to wait every package to fail and patch it.
Another easier way is what Arnout suggested here:
http://lists.busybox.net/pipermail/buildroot/2019-May/250212.html
What I'm going to can check today is if there's a common fix for C and C++ compilation.
And it seems at the moment to be using -O0.
What about the 2 choices?
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
Quoted 9 lines
Quoted 9 lines
package/brotli/brotli.mk +0
-0$(eval $(cmake-package))Signature · 7 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 package/brotli: fix build on microblaze with -02
Hello,
Quoted 11 lines · On Wed, 15 May 2019 11:42:12 +0200 Giulio Benetti…
Quoted 9 lines
package/brotli/brotli.mk BROTLI_CONF_OPTS = \ · line 22
Quoted 6 lines
package/brotli/brotli.mk +6
-0+# prevents from triggering GCC ICE +# A bug was reported to the gcc bug tracker: +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485 +ifeq ($(BR2_microblaze),y) +BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -O0" +endifThis is not a great fix, but still better than not being able to build the package at all, so I think it's okay to merge it. ?\_(?)_/?
This is another package added to the list of Microblaze GCC6/7 bug 85180.
Be careful: we have two separate issues. Gcc bug 85180 and gcc bug 68485.
gcc bug 85180, which you were working on, causes the compiler to got in an infinite loop
gcc bug 68485, which this patch is about, causes the compiler to throw an ICE (Internal Compiler Error). I.e the compiler aborts, it does not enter in an infinite loop.
It would be interesting to see if bug 68485 stills exists with gcc 8.x or 9.x.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/brotli: fix build on microblaze with -02
Il 15/05/2019 11:50, Thomas Petazzoni ha scritto:
Quoted 17 lines
Hello,
Quoted 11 lines · On Wed, 15 May 2019 11:42:12 +0200 Giulio Benetti…
Quoted 9 lines
package/brotli/brotli.mk BROTLI_CONF_OPTS = \ · line 22
Quoted 6 lines
package/brotli/brotli.mk +6
-0+# prevents from triggering GCC ICE +# A bug was reported to the gcc bug tracker: +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485 +ifeq ($(BR2_microblaze),y) +BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -O0" +endifThis is not a great fix, but still better than not being able to build the package at all, so I think it's okay to merge it. ?\_(?)_/?
This is another package added to the list of Microblaze GCC6/7 bug 85180.
Quoted 8 lines
Be careful: we have two separate issues. Gcc bug 85180 and gcc bug 68485.
gcc bug 85180, which you were working on, causes the compiler to got in an infinite loop
gcc bug 68485, which this patch is about, causes the compiler to throw an ICE (Internal Compiler Error). I.e the compiler aborts, it does not enter in an infinite loop.
Right.
Quoted 2 lines
It would be interesting to see if bug 68485 stills exists with gcc 8.x or 9.x.
Then I'm going to test both 8.x and 9.x right now for both bugs.
It seems hard to find a fix for GCC < 8.x and Microblaze is a niche. So IMHO it seems a waste of time now with all these packages that fail.
Best regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH 1/1 package/brotli: fix build on microblaze with -02
Quoted 22 lines · Giulio Benetti
Il 15/05/2019 11:50, Thomas Petazzoni ha scritto:
Quoted 19 lines
Hello,
Quoted 11 lines · On Wed, 15 May 2019 11:42:12 +0200 Giulio Benetti…
Quoted 9 lines
package/brotli/brotli.mk BROTLI_CONF_OPTS = \ · line 22
Quoted 6 lines
package/brotli/brotli.mk +6
-0+# prevents from triggering GCC ICE +# A bug was reported to the gcc bug tracker: +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485 +ifeq ($(BR2_microblaze),y) +BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -O0" +endifThis is not a great fix, but still better than not being able to build the package at all, so I think it's okay to merge it. ?\_(?)_/?
This is another package added to the list of Microblaze GCC6/7 bug 85180.
Be careful: we have two separate issues. Gcc bug 85180 and gcc bug 68485.
Quoted 11 lines
Quoted 6 lines
gcc bug 85180, which you were working on, causes the compiler to got in an infinite loop
gcc bug 68485, which this patch is about, causes the compiler to throw an ICE (Internal Compiler Error). I.e the compiler aborts, it does not enter in an infinite loop.
Right.
Quoted 2 lines
It would be interesting to see if bug 68485 stills exists with gcc 8.x or 9.x.
IIUC it was actually introduced in GCC8.x, and we backported the patch that
broke it: 0892-microblaze-Revert.patch
So, my idea of requiring GCC8 for microblaze may not work out for all failures.
Regards,
Arnout
Quoted 7 lines
Then I'm going to test both 8.x and 9.x right now for both bugs.
It seems hard to find a fix for GCC < 8.x and Microblaze is a niche. So IMHO it seems a waste of time now with all these packages that fail.
Best regards
PATCH 1/1 package/brotli: fix build on microblaze with -02
In reply to Thomas PetazzoniHello
Il 15/05/2019 11:50, Thomas Petazzoni ha scritto:
Quoted 15 lines
Hello,
Quoted 10 lines · On Wed, 15 May 2019 11:42:12 +0200 Giulio Benetti…
Quoted 9 lines
package/brotli/brotli.mk BROTLI_CONF_OPTS = \ · line 22
Quoted 6 lines
package/brotli/brotli.mk +6
-0+# prevents from triggering GCC ICE +# A bug was reported to the gcc bug tracker: +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68485 +ifeq ($(BR2_microblaze),y) +BROTLI_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -O0" +endifThis is not a great fix, but still better than not being able to build the package at all, so I think it's okay to merge it. ?\_(?)_/?
Quoted 6 lines
Quoted 1 line
This is another package added to the list of Microblaze GCC6/7 bug 85180.
Be careful: we have two separate issues. Gcc bug 85180 and gcc bug 68485.
gcc bug 85180, which you were working on, causes the compiler to got in an infinite loop
Yes
Quoted 3 lines
gcc bug 68485, which this patch is about, causes the compiler to throw an ICE (Internal Compiler Error). I.e the compiler aborts, it does not enter in an infinite loop.
Right. Thank you.
Quoted 2 lines
It would be interesting to see if bug 68485 stills exists with gcc 8.x or 9.x.
Gcc bug 68485 still exists with gcc 8.x and 9.x
Need to add specific bug in toolchain Config.in and treat it package per package as discussed in IRC.
Kind regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642