Skip to contentSkip to conversation

imx: Cleanup i.MX6Q mccmon6 board configuration

PATCH New Lukasz Majewski 2 participants 7 messages May 16, 2019 – Jul 20, 2019

lore
Share & tools
lore
#0 lore raw

cover imx: Cleanup i.MX6Q mccmon6 board configuration

This patch series updates mccmon6 configuration to remove some "removal" warnings (i.e. disables the USB related code).

It also on purpose disables gigabig ethernet, as this board works on 10/100 Mib environments.

Patches applicable on top of master branch:
SHA1: 5b4b680cfe29a67171ccbe439c66374cb31faca3

Lukasz Majewski (3):
ARM: imx: cosmetic: Remove not needed comment from the mccmon6.h file
ARM: imx: config: Disable support for USB on MCCMON6
ARM: imx: Disable 1Gbps support on MCCMON6's KSZ9031 PHY

 configs/mccmon6_nor_defconfig | 2 --
 configs/mccmon6_sd_defconfig  | 2 --
 include/configs/mccmon6.h     | 8 +-------
 3 files changed, 1 insertion(+), 11 deletions(-)
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/3 ARM: imx: cosmetic: Remove not needed comment from the mccmon6.h file

This comment is a leftover from the Kconfig CONFIG_*MTD* move.

---

 include/configs/mccmon6.h | 2 --
 1 file changed, 2 deletions(-)
include/configs/mccmon6.h +0 -2
index a1774c027a..b97373512f 100644
@@ -65,8 +65,6 @@
 #define CONFIG_SYS_FLASH_BANKS_LIST	{ (CONFIG_SYS_FLASH_BASE) }
 #define CONFIG_SYS_FLASH_BANKS_SIZES	{ (32 * SZ_1M) }
 
-/* MTD support */
-
 /* USB Configs */
 #define CONFIG_USB_MAX_CONTROLLER_COUNT	2
 #define CONFIG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
Signature · 1 line
2.11.0
#2 lore raw

PATCH 1/3 ARM: imx: cosmetic: Remove not needed comment from the mccmon6.h file

Quoted 2 lines

This comment is a leftover from the Kconfig CONFIG_*MTD* move.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 2/3 ARM: imx: config: Disable support for USB on MCCMON6

In reply to Lukasz Majewski

The IMX6Q based MCCMON6 is not using USB for any purpose.

---

 configs/mccmon6_nor_defconfig | 2 --
 configs/mccmon6_sd_defconfig  | 2 --
 include/configs/mccmon6.h     | 5 -----
 3 files changed, 9 deletions(-)
configs/mccmon6_nor_defconfig +0 -2
index af2a106644..ddbcd69316 100644
@@ -20,7 +20,6 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
-CONFIG_CMD_USB=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_MTDPARTS=y
@@ -50,5 +49,4 @@ CONFIG_MII=y
 CONFIG_SPI=y
 CONFIG_MXC_SPI=y
 CONFIG_DM_THERMAL=y
-CONFIG_USB=y
 CONFIG_OF_LIBFDT=y
configs/mccmon6_sd_defconfig +0 -2
index aac433c13b..a018d804f8 100644
@@ -21,7 +21,6 @@ CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_SF=y
-CONFIG_CMD_USB=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_MTDPARTS=y
@@ -51,5 +50,4 @@ CONFIG_MII=y
 CONFIG_SPI=y
 CONFIG_MXC_SPI=y
 CONFIG_DM_THERMAL=y
-CONFIG_USB=y
 CONFIG_OF_LIBFDT=y
include/configs/mccmon6.h +0 -5
index b97373512f..231b2af87a 100644
@@ -65,11 +65,6 @@
 #define CONFIG_SYS_FLASH_BANKS_LIST	{ (CONFIG_SYS_FLASH_BASE) }
 #define CONFIG_SYS_FLASH_BANKS_SIZES	{ (32 * SZ_1M) }
 
-/* USB Configs */
-#define CONFIG_USB_MAX_CONTROLLER_COUNT	2
-#define CONFIG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CONFIG_MXC_USB_FLAGS		0
-
 /* Ethernet Configuration */
 #define CONFIG_FEC_MXC
 #define IMX_FEC_BASE			ENET_BASE_ADDR
Signature · 1 line
2.11.0
#4 lore raw

PATCH 2/3 ARM: imx: config: Disable support for USB on MCCMON6

Quoted 2 lines

The IMX6Q based MCCMON6 is not using USB for any purpose.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#5 lore raw

PATCH 3/3 ARM: imx: Disable 1Gbps support on MCCMON6's KSZ9031 PHY

In reply to Lukasz Majewski

mccmon6 works in 10/100 MiB Ethernet environment, so disabling 1GiB support improves robustness of the network after power up (as one don't need to wait for autoneg).

---

 include/configs/mccmon6.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/mccmon6.h +1 -0
index 231b2af87a..667dac7340 100644
@@ -78,6 +78,7 @@
 	"fdt_high=0xffffffff\0" \
 	"initrd_high=0xffffffff\0" \
 	"boot_os=yes\0" \
+	"disable_giga=yes\0" \
 	"download_kernel=" \
 		"tftpboot ${kernel_addr} ${kernel_file};" \
 		"tftpboot ${fdt_addr} ${fdtfile};\0" \
Signature · 1 line
2.11.0
#6 lore raw

PATCH 3/3 ARM: imx: Disable 1Gbps support on MCCMON6's KSZ9031 PHY

Quoted 4 lines

mccmon6 works in 10/100 MiB Ethernet environment, so disabling 1GiB support improves robustness of the network after power up (as one don't need to wait for autoneg).

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================