insane: add sanity checks to SRC_URI
PATCH v2 1/1 insane: add sanity checks to SRC_URI
The SRC_URI almost definitely shouldn't be using ${PN}, and GitHub */archive/* tarballs are dynamically generated so the checksums will change over time.
Detect both of these, and emit a QA warning if found.
--- meta/classes/insane.bbclass | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
meta/classes/insane.bbclass +12 -1
@@ -25,7 +25,7 @@ QA_SANE = "True" WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \ textrel already-stripped incompatible-license files-invalid \ installed-vs-shipped compile-host-path install-host-path \ - pn-overrides infodir build-deps \ + pn-overrides infodir build-deps src-uri-bad \ unknown-configure-option symlink-to-sysroot multilib \ invalid-packageconfig host-user-contaminated uppercase-pn patch-fuzz \ "
@@ -898,6 +898,17 @@ def package_qa_check_host_user(path, name, d, elf, messages): return False return True +QARECIPETEST[src-uri-bad] = "package_qa_check_src_uri" +def package_qa_check_src_uri(pn, d, messages): + import re + + if "${PN}" in d.getVar("SRC_URI", False): + package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn, d) + + pn = d.getVar("SRC_URI") + if re.search(r"github\.com/.+/.+/archive/.+", pn): + package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d) + # The PACKAGE FUNC to scan each package python do_package_qa () {
Signature · 1 line
2.20.1 (Apple Git-117)
Quoted 3 lines · Ross Burton
The
SRC_URIalmost definitely shouldn't be using ${PN}, and GitHub */archive/* tarballs are dynamically generated so the checksums will change over time.
...
It might be worth mentioning that this is for archive, not releases.
GitHub release tarballs are stable, and they are preferable to commit ids.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedCan we add an option to skip this with INSANE_SKIP?
It looks like QARECIPETEST doesn't use INSANE_SKIP or I don't see how.
Removing src-uri-bad from ERROR_QA/WARN_QA for some recipes works as well, is it worth adding INSANE_SKIP for consistency with other checks or not?
Quoted 56 lines · Ross Burton
The
SRC_URIalmost definitely shouldn't be using ${PN}, and GitHub */archive/*
tarballs are dynamically generated so the checksums will change over time.Detect both of these, and emit a QA warning if found.
Signed-off-by Ross Burton <[email protected]>--- meta/classes/insane.bbclass | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)meta/classes/insane.bbclass +1
-1@@ -25,7 +25,7 @@ QA_SANE = "True" WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \ textrel already-stripped incompatible-license files-invalid \ installed-vs-shipped compile-host-path install-host-path \ - pn-overrides infodir build-deps \ + pn-overrides infodir build-deps src-uri-bad \ unknown-configure-option symlink-to-sysroot multilib \ invalid-packageconfig host-user-contaminated uppercase-pnpatch-fuzz \ "meta/classes/insane.bbclass +0
-0@@ -898,6 +898,17 @@ def package_qa_check_host_user(path, name, d, elf,messages):
return False
return Truemeta/classes/insane.bbclass +6
-0+QARECIPETEST[src-uri-bad] = "package_qa_check_src_uri" +def package_qa_check_src_uri(pn, d, messages): + import re + + if "${PN}" in d.getVar("SRC_URI", False): + package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN notBPN" % pn, d)
meta/classes/insane.bbclass +4
-0+ + pn = d.getVar("SRC_URI") + if re.search(r"github\.com/.+/.+/archive/.+", pn): + package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstableGitHub archives" % pn, d)
+# The PACKAGE FUNC to scan each package
pythondo_package_qa() {
--
2.20.1 (Apple Git-117)--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 8 lines · Martin Jansa
Can we add an option to skip this with
INSANE_SKIP?It looks like QARECIPETEST doesn't use
INSANE_SKIPor I don't see how.Removing src-uri-bad from ERROR_QA/WARN_QA for some recipes works as well, is it worth adding
INSANE_SKIPfor consistency with other checks or not?
Ultimately I'd say that all these checks should work with INSANE_SKIP. I was just wondering about this issue myself for the chkconfig autobuilder warnings...
Cheers,
Richard
Quoted 3 lines · Richard Purdie
Ultimately I'd say that all these checks should work with
INSANE_SKIP. I was just wondering about this issue myself for the chkconfig autobuilder warnings...
chkconfig can be easily addressed by switching to git:// I think. Patch coming.
Alex