insane: add sanity checks to SRC_URI
PATCH 1/1 insane: add sanity checks to SRC_URI
The SRC_URI almost definitely shouldn't be using ${BPN}, and GitHub */archive/* tarballs are dynamically generated so the checksums will change over time.
Detect both of these, and emit a QA warning if found.
Signed-off-by Ross Burton <[email protected]>
--- meta/classes/insane.bbclass | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
meta/classes/insane.bbclass +12 -1
@@ -25,7 +25,7 @@ QA_SANE = "True" WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \ textrel already-stripped incompatible-license files-invalid \ installed-vs-shipped compile-host-path install-host-path \ - pn-overrides infodir build-deps \ + pn-overrides infodir build-deps src-uri-bad \ unknown-configure-option symlink-to-sysroot multilib \ invalid-packageconfig host-user-contaminated uppercase-pn patch-fuzz \ "
@@ -898,6 +898,17 @@ def package_qa_check_host_user(path, name, d, elf, messages): return False return True +QARECIPETEST[src-uri-bad] = "package_qa_check_src_uri" +def package_qa_check_src_uri(pn, d, messages): + import re + + if "${PN}" in d.getVar("SRC_URI", False): + package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn, d) + + pn = d.getVar("SRC_URI") + if re.search(r"github\.com/.+/.+/archive/.+", pn): + package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d) + # The PACKAGE FUNC to scan each package python do_package_qa () {
Signature · 1 line
2.20.1 (Apple Git-117)
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 3 lines · Jacob Kroon
Quoted 1 line · Ross Burton
The
SRC_URIalmost definitely shouldn't be using ${BPN}, and GitHub */archive/*"... shouldn't be using ${PN} ..." ?
Whoops! Fixed.
Ross