Skip to contentSkip to conversation

armv8: ls1028ardb: Add sd and emmc related environments

PATCH Superseded Yuantian Tang 2 participants 3 messages May 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 armv8: ls1028ardb: Add sd and emmc related environments

Add SD, EMMC and xspi environments to faciliate the boot.

---
v2:
- rebase to latest code

 include/configs/ls1028a_common.h | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)
include/configs/ls1028a_common.h +21 -3
index 0db86396e9..9531548184 100644
@@ -127,25 +127,43 @@
 			"${scripthdraddr} ${prefix}${boot_script_hdr} " \
 			"&& esbc_validate ${scripthdraddr};"    \
 		"source ${scriptaddr}\0"	  \
-	"sd_bootcmd=echo Trying load from SD ..;"	\
+		"xspi_bootcmd=echo Trying load from FlexSPI flash ...;" \
+		"sf probe 0:0 && sf read $load_addr " \
+		"$kernel_start $kernel_size ; env exists secureboot &&" \
+		"sf read $kernelheader_addr_r $kernelheader_start " \
+		"$kernelheader_size && esbc_validate ${kernelheader_addr_r}; "\
+		" bootm $load_addr#$board\0" \
+	"sd_bootcmd=echo Trying load from SD ...;" \
 		"mmcinfo; mmc read $load_addr "		\
 		"$kernel_addr_sd $kernel_size_sd && "	\
 		"env exists secureboot && mmc read $kernelheader_addr_r " \
 		"$kernelhdr_addr_sd $kernelhdr_size_sd "		\
 		" && esbc_validate ${kernelheader_addr_r};"	\
 		"bootm $load_addr#$board\0"		\
+		"xspi_hdploadcmd=echo Trying load HDP firmware from FlexSPI...;" \
+		"sf probe 0:0 && sf read $load_addr 0x940000 0x30000 " \
+		"&& hdp load $load_addr 0x2000\0"			\
+	"sd_hdploadcmd=echo Trying load HDP firmware from SD..;"        \
+		"mmcinfo;mmc read $load_addr 0x4a00 0x200 "             \
+		"&& hdp load $load_addr 0x2000\0"	\
 	"emmc_bootcmd=echo Trying load from EMMC ..;"	\
 		"mmcinfo; mmc dev 1; mmc read $load_addr "		\
 		"$kernel_addr_sd $kernel_size_sd && "	\
 		"env exists secureboot && mmc read $kernelheader_addr_r " \
 		"$kernelhdr_addr_sd $kernelhdr_size_sd "		\
 		" && esbc_validate ${kernelheader_addr_r};"	\
-		"bootm $load_addr#$board\0"
+		"bootm $load_addr#$board\0"			\
+	"emmc_hdploadcmd=echo Trying load HDP firmware from EMMC..;"      \
+		"mmc dev 1;mmcinfo;mmc read $load_addr 0x4a00 0x200 "	\
+		"&& hdp load $load_addr 0x2000\0"
 
 #undef CONFIG_BOOTCOMMAND
 
+#define XSPI_NOR_BOOTCOMMAND	\
+	"run qspi_hdploadcmd; run distro_bootcmd; run qspi_bootcmd; " \
+	"env exists secureboot && esbc_halt;;"
 #define SD_BOOTCOMMAND	\
-	"run distro_bootcmd;run sd_bootcmd; " \
+	"run sd_hdploadcmd; run distro_bootcmd;run sd_bootcmd; " \
 	"env exists secureboot && esbc_halt;"
 
 /* Monitor Command Prompt */
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 armv8: ls1028ardb: Add sd and emmc related environments

Quoted 38 lines

-----Original Message-----
From: Yuantian Tang <[email protected]>
Sent: Thursday, May 23, 2019 7:46 AM
To: Prabhakar Kushwaha <[email protected]>
Cc: u-boot at lists.denx.de; Andy Tang <[email protected]>
Subject: [PATCH v2] armv8: ls1028ardb: Add sd and emmc related environments

Add SD, EMMC and xspi environments to faciliate the boot.

---
v2:
- rebase to latest code

 include/configs/ls1028a_common.h | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)
include/configs/ls1028a_common.h +7 -1
index 0db86396e9..9531548184 100644
@@ -127,25 +127,43 @@
 			"${scripthdraddr} ${prefix}${boot_script_hdr} " \
 			"&& esbc_validate ${scripthdraddr};"    \
 		"source ${scriptaddr}\0"	  \
-	"sd_bootcmd=echo Trying load from SD ..;"	\
+		"xspi_bootcmd=echo Trying load from FlexSPI flash ...;" \
+		"sf probe 0:0 && sf read $load_addr " \
+		"$kernel_start $kernel_size ; env exists secureboot &&" \
+		"sf read $kernelheader_addr_r $kernelheader_start " \
+		"$kernelheader_size && esbc_validate ${kernelheader_addr_r};
 "\
+		" bootm $load_addr#$board\0" \
+	"sd_bootcmd=echo Trying load from SD ...;" \
 		"mmcinfo; mmc read $load_addr "		\
 		"$kernel_addr_sd $kernel_size_sd && "	\
 		"env exists secureboot && mmc read $kernelheader_addr_r " \

include/configs/ls1028a_common.h line 150

Quoted 10 lines
include/configs/ls1028a_common.h +6 -0
 		"$kernelhdr_addr_sd $kernelhdr_size_sd "		\
 		" && esbc_validate ${kernelheader_addr_r};"	\
 		"bootm $load_addr#$board\0"		\
+		"xspi_hdploadcmd=echo Trying load HDP firmware from
 FlexSPI...;" \
+		"sf probe 0:0 && sf read $load_addr 0x940000 0x30000 " \
+		"&& hdp load $load_addr 0x2000\0"			\
+	"sd_hdploadcmd=echo Trying load HDP firmware from SD..;"        \
+		"mmcinfo;mmc read $load_addr 0x4a00 0x200 "             \
+		"&& hdp load $load_addr 0x2000\0"	\

Hdp support is not part of upstream code -base

So can we remove hdp reference from this patch

--pk

author
#2 lore raw

PATCH v2 1/1 armv8: ls1028ardb: Add sd and emmc related environments

Hi Prabhakar,

Quoted 60 lines

-----Original Message-----
From: Prabhakar Kushwaha
Sent: 2019年5月23日 11:39
To: Andy Tang <[email protected]>
Cc: u-boot at lists.denx.de; Andy Tang <[email protected]>
Subject: RE: [PATCH v2] armv8: ls1028ardb: Add sd and emmc related environments

Quoted 6 lines

-----Original Message-----
From: Yuantian Tang <[email protected]>
Sent: Thursday, May 23, 2019 7:46 AM
To: Prabhakar Kushwaha <[email protected]>
Cc: u-boot at lists.denx.de; Andy Tang <[email protected]>
Subject: [PATCH v2] armv8: ls1028ardb: Add sd and emmc related

environments

Quoted 31 lines

Add SD, EMMC and xspi environments to faciliate the boot.

---
v2:
- rebase to latest code

 include/configs/ls1028a_common.h | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)
include/configs/ls1028a_common.h +7 -1
index 0db86396e9..9531548184 100644
@@ -127,25 +127,43 @@
 			"${scripthdraddr} ${prefix}${boot_script_hdr} " \
 			"&& esbc_validate ${scripthdraddr};"    \
 		"source ${scriptaddr}\0"	  \
-	"sd_bootcmd=echo Trying load from SD ..;"	\
+		"xspi_bootcmd=echo Trying load from FlexSPI flash ...;" \
+		"sf probe 0:0 && sf read $load_addr " \
+		"$kernel_start $kernel_size ; env exists secureboot &&" \
+		"sf read $kernelheader_addr_r $kernelheader_start " \
+		"$kernelheader_size && esbc_validate ${kernelheader_addr_r};
 "\
+		" bootm $load_addr#$board\0" \
+	"sd_bootcmd=echo Trying load from SD ...;" \
 		"mmcinfo; mmc read $load_addr "		\
 		"$kernel_addr_sd $kernel_size_sd && "	\
 		"env exists secureboot && mmc read $kernelheader_addr_r " \

include/configs/ls1028a_common.h line 150

Quoted 10 lines
include/configs/ls1028a_common.h +6 -0
 		"$kernelhdr_addr_sd $kernelhdr_size_sd "		\
 		" && esbc_validate ${kernelheader_addr_r};"	\
 		"bootm $load_addr#$board\0"		\
+		"xspi_hdploadcmd=echo Trying load HDP firmware from
 FlexSPI...;" \
+		"sf probe 0:0 && sf read $load_addr 0x940000 0x30000 " \
+		"&& hdp load $load_addr 0x2000\0"			\
+	"sd_hdploadcmd=echo Trying load HDP firmware from SD..;"        \
+		"mmcinfo;mmc read $load_addr 0x4a00 0x200 "             \
+		"&& hdp load $load_addr 0x2000\0"	\

Hdp support is not part of upstream code -base

Quoted 1 line

So can we remove hdp reference from this patch

Yeah, sure. I have not noticed that.

Thanks,
Andy

Quoted 2 lines

--pk