drm/sun4i: Allwinner A64 MIPI-DSI support
Subsystems (5)
v9 cover drm/sun4i: Allwinner A64 MIPI-DSI support
This is v9 version for Allwinner A64 MIPI-DSI support and here is the previous version set[1].
This depends on dsi host controller fixes which were supported in this series[2].
All these changes are tested in Allwinner A64 with 2, 4 lanes devices and whose pixel clocks are 27.5 MHz, 30MHz, 55MHz and 147MHz.
Changes for v9:
- moved dsi fixes in separate series on top of A33 [2]
- rebase on linux-next and on top of [2]
Changes for v8:
- rebased on drm-misc change along with linux-next
- reworked video start delay patch
- tested on 4 different dsi panels
- reworked commit messages
Changes for v7:
- moved vcc-dsi binding to required filed.
- drop quotes on fallback dphy bindings.
- drop min_rate clock pll-mipi patches.
- introduce dclk divider computation as like A64 BSP.
- add A64 DSI quark patches.
- fixed A64 DSI pipeline.
- add proper commit messages.
- collect Merlijn Wajer Tested-by credits.
Changes for v6:
- dropped unneeded changes, patches
- fixed all burst mode patches as per previous version comments
- rebase on master
- update proper commit message
- dropped unneeded comments
- order the patches that make review easy
Changes for v5:
- collect Rob, Acked-by
- droped "Fix VBP size calculation" patch
- updated vblk timing calculation.
- droped techstar, bananapi dsi panel drivers which may require bridge or other setup. it's under discussion.
Changes for v4:
- droppoed untested CCU_FEATURE_FIXED_POSTDIV check code in nkm min, max rate patches
- create two patches for "Add Allwinner A64 MIPI DSI support" one for has_mod_clk quirk and other one for A64 support
- use existing driver code construct for hblk computation
- dropped "Increase hfp packet overhead" patch [2], though BSP added this but we have no issues as of now.
(no issues on panel side w/o this change)
- create separate function for vblk computation
- enable vcc-dsi regulator in dsi_runtime_resume
- collect Rob, Acked-by
- update MAINTAINERS file for panel drivers
- cleanup commit messages
- fixed checkpatch warnings/errors
[1] https://patchwork.freedesktop.org/series/57834/
[2] https://patchwork.freedesktop.org/series/60847/
Jagan Teki (9):
dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible
dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback)
drm/sun4i: dsi: Add has_mod_clk quirk
drm/sun4i: dsi: Add Allwinner A64 MIPI DSI support
arm64: dts: allwinner: a64: Add MIPI DSI pipeline
arm64: dts: allwinner: a64-amarula-relic: Add Techstar TS8550B MIPI-DSI panel [DO NOT MERGE] arm64: dts: allwinner: bananapi-m64: Enable Bananapi S070WV20-CT16 DSI panel [DO NOT MERGE] arm64: dts: allwinner: a64-pine64-lts: Enable Feiyang FY07024DI26A30-D DSI panel [DO NOT MERGE] arm64: dts: allwinner: oceanic-5205-5inmfd: Enable Microtech MTF050FHDI-03 panel
.../bindings/display/sunxi/sun6i-dsi.txt | 2 + .../allwinner/sun50i-a64-amarula-relic.dts | 35 +++++++++++++ .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 31 ++++++++++++ .../sun50i-a64-oceanic-5205-5inmfd.dts | 49 +++++++++++++++++++ .../allwinner/sun50i-a64-sopine-baseboard.dts | 31 ++++++++++++ arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 38 ++++++++++++++ drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 45 ++++++++++++----- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 5 ++ 8 files changed, 225 insertions(+), 11 deletions(-)
Signature · 6 lines
2.18.0.321.gffc6fa0e3 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v9 1/9 dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible
The MIPI DSI controller in Allwinner A64 is similar to A33.
But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid to with separate compatible for A64 on the same driver.
--- Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +1 -0
@@ -12,6 +12,7 @@ The DSI Encoder generates the DSI signal from the TCON's. Required properties: - compatible: value must be one of: * allwinner,sun6i-a31-mipi-dsi + * allwinner,sun50i-a64-mipi-dsi - reg: base address and size of memory-mapped region - interrupts: interrupt associated to this IP - clocks: phandles to the clocks feeding the DSI encoder
Signature · 1 line
2.18.0.321.gffc6fa0e3
Re: [PATCH v9 1/9] dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible
Quoted 17 lines · Jagan Teki
The MIPI DSI controller in Allwinner A64 is similar to A33.
But unlike A33, A64 doesn't have
DSI_SCLKgating so it is valid to with separate compatible for A64 on the same driver.Reviewed-by Rob Herring <[email protected]>Tested-by Merlijn Wajer <[email protected]>--- Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +0
-0
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt The DSI Encoder generates the DSI signal from the TCON's. · line 18
Quoted 7 lines
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +1
-0@@ -12,6 +12,7 @@ The DSI Encoder generates the DSI signal from the TCON's. Required properties: - compatible: value must be one of: * allwinner,sun6i-a31-mipi-dsi + * allwinner,sun50i-a64-mipi-dsi - reg: base address and size of memory-mapped region - interrupts: interrupt associated to this IP - clocks: phandles to the clocks feeding the DSI encoder
We've switch to YAML now, and the compatible should be expressed that way now:
compatible:
enum:
- allwinner,sun6i-a31-mipi-dsi
- allwinner,sun50i-a64-mipi-dsi
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Re: [PATCH v9 1/9] dt-bindings: sun6i-dsi: Add A64 MIPI-DSI compatible
Quoted 14 lines · Maxime Ripard
Quoted 12 lines · Jagan Teki
The MIPI DSI controller in Allwinner A64 is similar to A33.
But unlike A33, A64 doesn't have
DSI_SCLKgating so it is valid to with separate compatible for A64 on the same driver.Signed-off-by Jagan Teki <[email protected]>Reviewed-by Rob Herring <[email protected]>Tested-by Merlijn Wajer <[email protected]>--- Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + 1 file changed, 1 insertion(+)
Quoted 15 lines
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt The DSI Encoder generates the DSI signal from the TCON's. · line 18
Quoted 12 lines
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +1
-0@@ -12,6 +12,7 @@ The DSI Encoder generates the DSI signal from the TCON's. Required properties: - compatible: value must be one of: * allwinner,sun6i-a31-mipi-dsi + * allwinner,sun50i-a64-mipi-dsi - reg: base address and size of memory-mapped region - interrupts: interrupt associated to this IP - clocks: phandles to the clocks feeding the DSI encoderWe've switch to YAML now, and the compatible should be expressed that way now:
Yes, I have seen it few days back will update on top of that, thanks!
PATCH v9 2/9 dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback)
In reply to Jagan TekiThe MIPI DSI PHY controller on Allwinner A64 is similar on the one on A31.
Add A64 compatible and append A31 compatible as fallback.
--- Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +1 -0
@@ -38,6 +38,7 @@ D-PHY Required properties: - compatible: value must be one of: * allwinner,sun6i-a31-mipi-dphy + * allwinner,sun50i-a64-mipi-dphy, allwinner,sun6i-a31-mipi-dphy - reg: base address and size of memory-mapped region - clocks: phandles to the clocks feeding the DSI encoder * bus: the DSI interface clock
Signature · 1 line
2.18.0.321.gffc6fa0e3
Re: [PATCH v9 2/9] dt-bindings: sun6i-dsi: Add A64 DPHY compatible (w/ A31 fallback)
Quoted 16 lines · Jagan Teki
The MIPI DSI PHY controller on Allwinner A64 is similar on the one on A31.
Add A64 compatible and append A31 compatible as fallback.
Reviewed-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +0
-0
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt D-PHY · line 44
Quoted 7 lines
Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt +1
-0@@ -38,6 +38,7 @@ D-PHY Required properties: - compatible: value must be one of: * allwinner,sun6i-a31-mipi-dphy + * allwinner,sun50i-a64-mipi-dphy, allwinner,sun6i-a31-mipi-dphy - reg: base address and size of memory-mapped region - clocks: phandles to the clocks feeding the DSI encoder * bus: the DSI interface clock
And this one should be:
compatible:
oneOf:
- const: allwinner,sun6i-a31-mipi-dphy
- items:
- const: allwinner,sun50i-a64-mipi-dphy
- const: allwinner,sun6i-a31-mipi-dphy
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
PATCH v9 3/9 drm/sun4i: dsi: Add has_mod_clk quirk
In reply to Jagan TekiAs per the user manual, look like mod clock is not mandatory for all Allwinner MIPI DSI controllers, it is connected to CLK_DSI_SCLK for A31 and not available in A64.
So add has_mod_clk quirk and process the clk accordingly.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 38 ++++++++++++++++++-------- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 5 ++++ 2 files changed, 32 insertions(+), 11 deletions(-)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +27 -11
@@ -10,6 +10,7 @@#include <linux/component.h> #include <linux/crc-ccitt.h> #include <linux/of_address.h> +#include <linux/of_device.h> #include <linux/pm_runtime.h> #include <linux/regmap.h> #include <linux/reset.h>
@@ -1154,6 +1155,7 @@ static int sun6i_dsi_probe(struct platform_device *pdev) dsi->dev = dev; dsi->host.ops = &sun6i_dsi_host_ops; dsi->host.dev = dev; + dsi->variant =of_device_get_match_data (dev); res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); base =devm_ioremap_resource (dev, res);
@@ -1181,17 +1183,20 @@ static int sun6i_dsi_probe(struct platform_device *pdev)return PTR_ERR (dsi->reset); } - dsi->mod_clk =devm_clk_get (dev,"mod" ); -if (IS_ERR (dsi->mod_clk)) { -dev_err (dev,"Couldn't get the DSI mod clock\n" ); -return PTR_ERR (dsi->mod_clk); +if (dsi->variant->has_mod_clk) { + dsi->mod_clk =devm_clk_get (dev,"mod" ); +if (IS_ERR (dsi->mod_clk)) { +dev_err (dev,"Couldn't get the DSI mod clock\n" ); +return PTR_ERR (dsi->mod_clk); + } }/* * In order to operate properly, that clock seems to be always * set to 297MHz. */ -clk_set_rate_exclusive (dsi->mod_clk,297000000 ); +if (dsi->variant->has_mod_clk) +clk_set_rate_exclusive (dsi->mod_clk,297000000 ); dsi->dphy =devm_phy_get (dev,"dphy" );if (IS_ERR (dsi->dphy)) {
@@ -1221,7 +1226,8 @@ static int sun6i_dsi_probe(struct platform_device *pdev) err_pm_disable:pm_runtime_disable (dev); err_unprotect_clk: -clk_rate_exclusive_put (dsi->mod_clk); +if (dsi->variant->has_mod_clk) +clk_rate_exclusive_put (dsi->mod_clk);return ret; }
@@ -1233,7 +1239,8 @@ static int sun6i_dsi_remove(struct platform_device *pdev)component_del (&pdev->dev, &sun6i_dsi_ops);mipi_dsi_host_unregister (&dsi->host);pm_runtime_disable (dev); -clk_rate_exclusive_put (dsi->mod_clk); +if (dsi->variant->has_mod_clk) +clk_rate_exclusive_put (dsi->mod_clk);return 0 ; }
@@ -1250,7 +1257,8 @@ static int __maybe_unused sun6i_dsi_runtime_resume(struct device *dev) }reset_control_deassert (dsi->reset); -clk_prepare_enable (dsi->mod_clk); +if (dsi->variant->has_mod_clk) +clk_prepare_enable (dsi->mod_clk);/* * Enable the DSI block.
@@ -1278,7 +1286,8 @@ static int __maybe_unused sun6i_dsi_runtime_suspend(struct device *dev) {struct sun6i_dsi *dsi =dev_get_drvdata (dev); -clk_disable_unprepare (dsi->mod_clk); +if (dsi->variant->has_mod_clk) +clk_disable_unprepare (dsi->mod_clk);reset_control_assert (dsi->reset);regulator_disable (dsi->regulator);
@@ -1291,9 +1300,16 @@ static const struct dev_pm_ops sun6i_dsi_pm_ops = { NULL) }; +static const struct sun6i_dsi_variant sun6i_a31_mipi_dsi = { + .has_mod_clk = true, +}; +static const struct of_device_id sun6i_dsi_of_table[] = { - { .compatible ="allwinner,sun6i-a31-mipi-dsi" }, - { } + { + .compatible ="allwinner,sun6i-a31-mipi-dsi" , + .data = &sun6i_a31_mipi_dsi, + }, + {/* sentinel */ } };MODULE_DEVICE_TABLE (of, sun6i_dsi_of_table);
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h +5 -0
@@ -15,6 +15,10 @@#include <linux/regulator/consumer.h> +struct sun6i_dsi_variant { +bool has_mod_clk; +}; +struct sun6i_dsi {struct drm_connector connector;struct drm_encoder encoder;
@@ -33,6 +37,7 @@ struct sun6i_dsi {struct mipi_dsi_device *device;struct drm_panel *panel;struct drm_bridge *bridge; +const struct sun6i_dsi_variant *variant; };static inline struct sun6i_dsi *host_to_sun6i_dsi (struct mipi_dsi_host *host)
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v9 4/9 drm/sun4i: dsi: Add Allwinner A64 MIPI DSI support
In reply to Jagan TekiThe MIPI DSI controller in Allwinner A64 is similar to A33.
But unlike A33, A64 doesn't have DSI_SCLK gating so add compatible for Allwinner A64 with uninitialized has_mod_clk driver.
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +7 -0
@@ -1304,11 +1304,18 @@ static const struct sun6i_dsi_variant sun6i_a31_mipi_dsi = { .has_mod_clk = true, }; +static const struct sun6i_dsi_variant sun50i_a64_mipi_dsi = { +}; +static const struct of_device_id sun6i_dsi_of_table[] = { { .compatible ="allwinner,sun6i-a31-mipi-dsi" , .data = &sun6i_a31_mipi_dsi, }, + { + .compatible ="allwinner,sun50i-a64-mipi-dsi" , + .data = &sun50i_a64_mipi_dsi, + }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, sun6i_dsi_of_table);
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v9 5/9 arm64: dts: allwinner: a64: Add MIPI DSI pipeline
In reply to Jagan TekiAdd MIPI DSI pipeline for Allwinner A64.
- dsi node, with A64 compatible since it doesn't support DSI_SCLK gating unlike A33
- dphy node, with A64 compatible with A33 fallback since DPHY on A64 and A33 is similar
- finally, attach the dsi_in to tcon0 for complete MIPI DSI
--- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +38 -0
@@ -382,6 +382,12 @@ #address-cells = <1>; #size-cells = <0>; reg = <1>; + + tcon0_out_dsi: endpoint@1 { + reg = <1>; + remote-endpoint = <&dsi_in_tcon0>; + allwinner,tcon-channel = <1>; + }; }; }; };
@@ -985,6 +991,38 @@ status = "disabled"; }; + dsi: dsi@1ca0000 { + compatible = "allwinner,sun50i-a64-mipi-dsi"; + reg = <0x01ca0000 0x1000>; + interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_MIPI_DSI>; + clock-names = "bus"; + resets = <&ccu RST_BUS_MIPI_DSI>; + phys = <&dphy>; + phy-names = "dphy"; + status = "disabled"; + #address-cells = <1>; + #size-cells = <0>; + + port { + dsi_in_tcon0: endpoint { + remote-endpoint = <&tcon0_out_dsi>; + }; + }; + }; + + dphy: d-phy@1ca1000 { + compatible = "allwinner,sun50i-a64-mipi-dphy", + "allwinner,sun6i-a31-mipi-dphy"; + reg = <0x01ca1000 0x1000>; + clocks = <&ccu CLK_BUS_MIPI_DSI>, + <&ccu CLK_DSI_DPHY>; + clock-names = "bus", "mod"; + resets = <&ccu RST_BUS_MIPI_DSI>; + status = "disabled"; + #phy-cells = <0>; + }; + hdmi: hdmi@1ee0000 { compatible = "allwinner,sun50i-a64-dw-hdmi", "allwinner,sun8i-a83t-dw-hdmi";
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v9 6/9 arm64: dts: allwinner: a64-amarula-relic: Add Techstar TS8550B MIPI-DSI panel
In reply to Jagan TekiAmarula A64-Relic board by default bound with Techstar TS8550B MIPI-DSI panel, add support for it.
DSI panel connected via board DSI port with,
- DLDO1 as VCC-DSI supply
- DLDO2 as VCC supply
- DLDO2 as IOVCC supply
- PD24 gpio for reset pin
- PD23 gpio for backlight enable pin
--- .../allwinner/sun50i-a64-amarula-relic.dts | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts +35 -0
@@ -9,6 +9,7 @@ #include "sun50i-a64.dtsi" #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/pwm/pwm.h> / { model = "Amarula A64-Relic";
@@ -18,6 +19,14 @@ serial0 = &uart0; }; + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&pwm 0 50000 PWM_POLARITY_INVERTED>; + brightness-levels = <1 2 4 8 16 32 64 128 255>; + default-brightness-level = <2>; + enable-gpios = <&pio 3 23 GPIO_ACTIVE_HIGH>; /* LCD-BL-EN: PD23 */ + }; + chosen { stdout-path = "serial0:115200n8"; };
@@ -80,6 +89,28 @@ }; }; +&de { + status = "okay"; +}; + +&dphy { + status = "okay"; +}; + +&dsi { + vcc-dsi-supply = <®_dldo1>; /* VCC-DSI */ + status = "okay"; + + panel@0 { + compatible = "techstar,ts8550b", "sitronix,st7701"; + reg = <0>; + VCC-supply = <®_dldo2>; /* VCC-MIPI */ + IOVCC-supply = <®_dldo2>; /* VCC-MIPI */ + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */ + backlight = <&backlight>; + }; +}; + &ehci0 { status = "okay"; };
@@ -151,6 +182,10 @@ status = "okay"; }; +&pwm { + status = "okay"; +}; + &r_rsb { status = "okay";
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v9 7/9 arm64: dts: allwinner: bananapi-m64: Enable Bananapi S070WV20-CT16 DSI panel
In reply to Jagan TekiThis patch add support for Bananapi S070WV20-CT16 DSI panel to BPI-M64 board.
DSI panel connected via board DSI port with,
- DLDO1 as VCC-DSI supply
- DCDC1 as VDD supply
- PD7 gpio for lcd enable pin
- PD6 gpio for lcd reset pin
- PD5 gpio for backlight enable pin
--- .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts +31 -0
@@ -45,6 +45,7 @@ #include "sun50i-a64.dtsi" #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/pwm/pwm.h> / { model = "BananaPi-M64";
@@ -56,6 +57,14 @@ serial1 = &uart1; }; + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; + brightness-levels = <1 2 4 8 16 32 64 128 255>; + default-brightness-level = <2>; + enable-gpios = <&pio 3 5 GPIO_ACTIVE_HIGH>; /* LCD-BL-EN: PD5 */ + }; + chosen { stdout-path = "serial0:115200n8"; };
@@ -116,6 +125,24 @@ status = "okay"; }; +&dphy { + status = "okay"; +}; + +&dsi { + vcc-dsi-supply = <®_dldo1>; /* VCC3V3-DSI */ + status = "okay"; + + panel@0 { + compatible = "bananapi,s070wv20-ct16-icn6211"; + reg = <0>; + enable-gpios = <&pio 3 7 GPIO_ACTIVE_HIGH>; /* LCD-PWR-EN: PD7 */ + reset-gpios = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD6 */ + vdd-supply = <®_dcdc1>; + backlight = <&backlight>; + }; +}; + &ehci0 { status = "okay"; };
@@ -206,6 +233,10 @@ status = "okay"; }; +&r_pwm { + status = "okay"; +}; + &r_rsb { status = "okay";
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v9 8/9 arm64: dts: allwinner: a64-pine64-lts: Enable Feiyang FY07024DI26A30-D DSI panel
In reply to Jagan TekiFeiyang FY07024DI26A30-D MIPI_DSI panel is desiged to attach with DSI connector on pine64 boards, enable the same for pine64 LTS.
DSI panel connected via board DSI port with,
- DLDO1 as VCC-DSI supply
- DC1SW as AVDD supply
- DLDO2 as DVDD supply
- PD24 gpio for reset pin
- PH10 gpio for backlight enable pin
--- .../allwinner/sun50i-a64-sopine-baseboard.dts | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +31 -0
@@ -46,6 +46,7 @@ /dts-v1/; #include "sun50i-a64-sopine.dtsi" +#include <dt-bindings/pwm/pwm.h> / { model = "SoPine with baseboard";
@@ -61,6 +62,14 @@ stdout-path = "serial0:115200n8"; }; + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; + brightness-levels = <1 2 4 8 16 32 64 128 255>; + default-brightness-level = <8>; + enable-gpios = <&pio 7 10 GPIO_ACTIVE_HIGH>; /* LCD-BL-EN: PH10 */ + }; + hdmi-connector { compatible = "hdmi-connector"; type = "a";
@@ -104,6 +113,24 @@ status = "okay"; }; +&dphy { + status = "okay"; +}; + +&dsi { + vcc-dsi-supply = <®_dldo1>; /* VCC-DSI */ + status = "okay"; + + panel@0 { + compatible = "feiyang,fy07024di26a30d"; + reg = <0>; + avdd-supply = <®_dc1sw>; /* VCC-LCD */ + dvdd-supply = <®_dldo2>; /* VCC-MIPI */ + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */ + backlight = <&backlight>; + }; +}; + &ehci0 { status = "okay"; };
@@ -184,6 +211,10 @@ vcc-hdmi-supply = <®_dldo1>; }; +&r_pwm { + status = "okay"; +}; + &sound { simple-audio-card,aux-devs = <&codec_analog>; simple-audio-card,widgets = "Microphone", "Microphone Jack",
Signature · 1 line
2.18.0.321.gffc6fa0e3
PATCH v9 9/9 arm64: dts: allwinner: oceanic-5205-5inmfd: Enable Microtech MTF050FHDI-03 panel
In reply to Jagan TekiMicrotech MTF050FHDI-03 is 1080x1920, 4-lane MIPI DSI LCD panel which has inbuilt NT35596 IC chip.
DSI panel connected to board via 39-pin FPC port with,
- DLDO1 as VCC-DSI supply
- DLDO2 as DVDD supply
- DC1SW as AVDD supply
- DC1SW as AVEE supply
- PD24 gpio for reset pin
- PH10 gpio for backlight enable pin
--- .../sun50i-a64-oceanic-5205-5inmfd.dts | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-oceanic-5205-5inmfd.dts +49 -0
@@ -8,6 +8,7 @@ /dts-v1/; #include "sun50i-a64-sopine.dtsi" +#include <dt-bindings/pwm/pwm.h> / { model = "Oceanic 5205 5inMFD";
@@ -22,6 +23,15 @@ stdout-path = "serial0:115200n8"; }; + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; + brightness-levels = <412 512>; + num-interpolated-steps = <100>; + default-brightness-level = <100>; + enable-gpios = <&pio 7 10 GPIO_ACTIVE_HIGH>; /* LCD-BL-EN: PH10 */ + }; + can_osc: can-osc { compatible = "fixed-clock"; #clock-cells = <0>;
@@ -40,6 +50,29 @@ }; }; +&de { + status = "okay"; +}; + +&dphy { + status = "okay"; +}; + +&dsi { + vcc-dsi-supply = <®_dldo1>; /* VCC-DSI */ + status = "okay"; + + panel@0 { + compatible = "microtech,mtf050fhdi-03", "novatek,nt35596"; + reg = <0>; + dvdd-supply = <®_dldo2>; /* VCC-MIPI */ + avdd-supply = <®_dc1sw>; /* AVDD_5V0 */ + avee-supply = <®_dc1sw>; /* AVEE_5V */ + reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD24 */ + backlight = <&backlight>; + }; +}; + &ehci0 { status = "okay"; };
@@ -81,10 +114,26 @@ status = "okay"; }; +&r_pwm { + status = "okay"; +}; + ®_dc1sw { regulator-name = "vcc-phy"; }; +®_dldo1 { + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-name = "vcc-dsi"; +}; + +®_dldo2 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-name = "vcc-mipi"; +}; + ®_ldo_io0 { regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>;
Signature · 1 line
2.18.0.321.gffc6fa0e3
Hi,
Quoted 9 lines · Jagan Teki
This is v9 version for Allwinner A64 MIPI-DSI support and here is the previous version set[1].
This depends on dsi host controller fixes which were supported in this series[2].
All these changes are tested in Allwinner A64 with 2, 4 lanes devices and whose pixel clocks are 27.5 MHz, 30MHz, 55MHz and 147MHz.
I wanted to apply this, but it wouldn't apply, can you send it without dependencies?
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Quoted 10 lines · Maxime Ripard
Hi,
Quoted 6 lines · Jagan Teki
This is v9 version for Allwinner A64 MIPI-DSI support and here is the previous version set[1].
This depends on dsi host controller fixes which were supported in this series[2].
Quoted 6 lines
Quoted 3 lines
All these changes are tested in Allwinner A64 with 2, 4 lanes devices and whose pixel clocks are 27.5 MHz, 30MHz, 55MHz and 147MHz.
I wanted to apply this, but it wouldn't apply, can you send it without dependencies?
I can do that no problem, but [2] has dsi and dclk divider fixes that would require A64 MIPI-DSI to work.