Skip to contentSkip to conversation

nvme-fc: Add message when creating new association

PATCH New James Smart 5 participants 5 messages May 29, 2019 – May 30, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 nvme-fc: Add message when creating new association

When looking at console messages to troubleshoot, there are one maybe two messages before creation of the controller is complete. However, a lot of io takes place to reach that point. It's unclear when things have started.

Add a message when the controller is attempting to create a new association. Thus we know what controller, between what host and remote port, and what NQN is being put into place for any subsequent success or failure messages.

Signed-off-by James Smart <jsmart2021 at gmail.com>

--
v2:
Moved message to create association so displayed at initial
creation as well as at each reconnect
Changed message to additionally print host port wwpn and target port
wwpn.

---
 drivers/nvme/host/fc.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/nvme/host/fc.c +6 -0
index c17c887f2148..bd1be8aa2d65 100644
@@ -2607,6 +2607,12 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
 	if (nvme_fc_ctlr_active_on_rport(ctrl))
 		return -ENOTUNIQ;
 
+	dev_info(ctrl->ctrl.device,
+		"NVME-FC{%d}: create association : host wwpn 0x%016llx "
+		" rport wwpn 0x%016llx: NQN \"%s\"\n",
+		ctrl->cnum, ctrl->lport->localport.port_name,
+		ctrl->rport->remoteport.port_name, ctrl->ctrl.opts->subsysnqn);
+
 	/*
 	 * Create the admin queue
 	 */
Signature · 1 line
2.13.7
#1 lore raw

PATCH v2 1/1 nvme-fc: Add message when creating new association

Looks good.

Reviewed-by Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
Quoted 40 lines · James Smart

When looking at console messages to troubleshoot, there are one maybe two messages before creation of the controller is complete. However, a lot of io takes place to reach that point. It's unclear when things have started.

Add a message when the controller is attempting to create a new association. Thus we know what controller, between what host and remote port, and what NQN is being put into place for any subsequent success or failure messages.

Signed-off-by James Smart <jsmart2021 at gmail.com>

--
v2:
Moved message to create association so displayed at initial
creation as well as at each reconnect
Changed message to additionally print host port wwpn and target port
wwpn.

---
  drivers/nvme/host/fc.c | 6 ++++++
  1 file changed, 6 insertions(+)
drivers/nvme/host/fc.c +6 -0
index c17c887f2148..bd1be8aa2d65 100644
@@ -2607,6 +2607,12 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
  	if (nvme_fc_ctlr_active_on_rport(ctrl))
  		return -ENOTUNIQ;
 
+	dev_info(ctrl->ctrl.device,
+		"NVME-FC{%d}: create association : host wwpn 0x%016llx "
+		" rport wwpn 0x%016llx: NQN \"%s\"\n",
+		ctrl->cnum, ctrl->lport->localport.port_name,
+		ctrl->rport->remoteport.port_name, ctrl->ctrl.opts->subsysnqn);
+
  	/*
  	 * Create the admin queue
  	 */
#2 lore raw

PATCH v2 1/1 nvme-fc: Add message when creating new association

In reply to James Smart
Quoted 30 lines · James Smart

When looking at console messages to troubleshoot, there are one maybe two messages before creation of the controller is complete. However, a lot of io takes place to reach that point. It's unclear when things have started.

Add a message when the controller is attempting to create a new association. Thus we know what controller, between what host and remote port, and what NQN is being put into place for any subsequent success or failure messages.

Signed-off-by James Smart <jsmart2021 at gmail.com>

--
v2:
Moved message to create association so displayed at initial
creation as well as at each reconnect
Changed message to additionally print host port wwpn and target port
wwpn.

---
 drivers/nvme/host/fc.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/nvme/host/fc.c +0 -0
index c17c887f2148..bd1be8aa2d65 100644
@@ -2607,6 +2607,12 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
 	if (nvme_fc_ctlr_active_on_rport(ctrl))
 		return -ENOTUNIQ;

drivers/nvme/host/fc.c nvme_fc_create_association(struct nvme_fc_ctrl *ctrl) · line 2618

Quoted 10 lines
drivers/nvme/host/fc.c +6 -0
 
+	dev_info(ctrl->ctrl.device,
+		"NVME-FC{%d}: create association : host wwpn 0x%016llx "
+		" rport wwpn 0x%016llx: NQN \"%s\"\n",
+		ctrl->cnum, ctrl->lport->localport.port_name,
+		ctrl->rport->remoteport.port_name, ctrl->ctrl.opts->subsysnqn);
+
 	/*
 	 * Create the admin queue
 	 */

Looks good. Thanks!

-- arun

#3 lore raw

PATCH v2 1/1 nvme-fc: Add message when creating new association

In reply to James Smart

Looks good.

Reviewed-by Giridhar Malavali <gmalavali at marvell.com>

?On 5/29/19, 3:25 PM, "Linux-nvme on behalf of James Smart" <[email protected] on behalf of [email protected]> wrote:

    When looking at console messages to troubleshoot, there are one
    maybe two messages before creation of the controller is complete.
    However, a lot of io takes place to reach that point. It's unclear
    when things have started.
    
    Add a message when the controller is attempting to create a new
    association. Thus we know what controller, between what host and
    remote port, and what NQN is being put into place for any
    subsequent success or failure messages.
    
    Signed-off-by: James Smart <jsmart2021 at gmail.com>
    
    --
    v2:
     Moved message to create association so displayed at initial
      creation as well as at each reconnect
     Changed message to additionally print host port wwpn and target port
      wwpn.
    ---
     drivers/nvme/host/fc.c | 6 ++++++
     1 file changed, 6 insertions(+)
    
    diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
    index c17c887f2148..bd1be8aa2d65 100644
    --- a/drivers/nvme/host/fc.c
    +++ b/drivers/nvme/host/fc.c
    @@ -2607,6 +2607,12 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
     	if (nvme_fc_ctlr_active_on_rport(ctrl))
     		return -ENOTUNIQ;
     
    +	dev_info(ctrl->ctrl.device,
    +		"NVME-FC{%d}: create association : host wwpn 0x%016llx "
    +		" rport wwpn 0x%016llx: NQN \"%s\"\n",
    +		ctrl->cnum, ctrl->lport->localport.port_name,
    +		ctrl->rport->remoteport.port_name, ctrl->ctrl.opts->subsysnqn);
    +
     	/*
     	 * Create the admin queue
     	 */
    -- 
    2.13.7
    
    
    _______________________________________________
    Linux-nvme mailing list
    Linux-nvme at lists.infradead.org
    http://lists.infradead.org/mailman/listinfo/linux-nvme